[http_request] Use a user provided default constructor for HttpRequestUpdate

2026-10-26 16:02:13 +00:00 · 2026-09-12 05:36:06 -05:00
2 changed files with 7 additions and 7 deletions
@@ -15,6 +15,9 @@ namespace esphome::http_request {

 class HttpRequestUpdate final : public update::UpdateEntity, public PollingComponent, public ota::OTAStateListener {
 public:
+  // User provided, not "= default": `new(p) HttpRequestUpdate()` would zero-fill .bss that is already zero.
+  HttpRequestUpdate() {}
+
  void setup() override;
  void update() override;

@@ -31,8 +34,8 @@ class HttpRequestUpdate final : public update::UpdateEntity, public PollingCompo
  void on_ota_state(ota::OTAState state, float progress, uint8_t error) override;

 protected:
-  HttpRequestComponent *request_parent_;
-  OtaHttpRequestComponent *ota_parent_;
+  HttpRequestComponent *request_parent_{nullptr};
+  OtaHttpRequestComponent *ota_parent_{nullptr};
  std::string source_url_;

  static void update_task(void *params);
@@ -24,9 +24,6 @@ enum MeasurementMode : uint8_t {

 class SCD4XComponent final : public PollingComponent, public sensirion_common::SensirionI2CDevice {
 public:
-  // User provided, not "= default": `new(p) SCD4XComponent()` would zero-fill .bss that is already zero.
-  SCD4XComponent() {}
-
  void setup() override;
  void dump_config() override;
  void update() override;
@@ -52,12 +49,12 @@ class SCD4XComponent final : public PollingComponent, public sensirion_common::S
  sensor::Sensor *temperature_sensor_{nullptr};
  sensor::Sensor *humidity_sensor_{nullptr};
  sensor::Sensor *ambient_pressure_source_{nullptr};  // used for compensation
-  float temperature_offset_{0};
+  float temperature_offset_;
  uint16_t altitude_compensation_{0};
  uint16_t ambient_pressure_{0};  // Per datasheet, valid values are 700 to 1200 hPa; 0 is a valid sentinel value
  bool initialized_{false};
  bool enable_asc_{false};
-  ErrorCode error_code_{};
+  ErrorCode error_code_;
  MeasurementMode measurement_mode_{PERIODIC};
 };