[http_request] Use a user provided default constructor for HttpRequestUpdate

2026-10-27 16:32:11 +00:00 · 2026-09-12 05:36:06 -05:00
2 changed files with 7 additions and 7 deletions
@@ -15,6 +15,9 @@ namespace esphome::http_request {

 class HttpRequestUpdate final : public update::UpdateEntity, public PollingComponent, public ota::OTAStateListener {
 public:
+  // User provided, not "= default": `new(p) HttpRequestUpdate()` would zero-fill .bss that is already zero.
+  HttpRequestUpdate() {}
+
  void setup() override;
  void update() override;

@@ -31,8 +34,8 @@ class HttpRequestUpdate final : public update::UpdateEntity, public PollingCompo
  void on_ota_state(ota::OTAState state, float progress, uint8_t error) override;

 protected:
-  HttpRequestComponent *request_parent_;
-  OtaHttpRequestComponent *ota_parent_;
+  HttpRequestComponent *request_parent_{nullptr};
+  OtaHttpRequestComponent *ota_parent_{nullptr};
  std::string source_url_;

  static void update_task(void *params);
@@ -29,9 +29,6 @@ enum class State : uint8_t {

 class Rtttl final : public Component {
 public:
-  // User provided, not "= default": `new(p) Rtttl()` would zero-fill .bss that is already zero.
-  Rtttl() {}
-
 #ifdef USE_OUTPUT
  void set_output(output::FloatOutput *output) { this->output_ = output; }
 #endif  // USE_OUTPUT
@@ -85,9 +82,9 @@ class Rtttl final : public Component {
  /// The duration of the current note in milliseconds.
  uint16_t note_duration_{0};
  /// The duration of a whole note in milliseconds.
-  uint16_t wholenote_duration_{0};
+  uint16_t wholenote_duration_;
  /// The time in milliseconds since microcontroller boot when the last note was started.
-  uint32_t last_note_start_time_{0};
+  uint32_t last_note_start_time_;
  /// The frequency of the current note in Hz.
  uint32_t output_freq_{0};
  /// The gain of the output.