[http_request] Use a user provided default constructor for HttpRequestUpdate

2026-10-27 16:32:11 +00:00 · 2026-09-12 05:36:06 -05:00
2 changed files with 5 additions and 5 deletions
@@ -23,9 +23,6 @@ enum OtaHttpRequestError : uint8_t {

 class OtaHttpRequestComponent final : public ota::OTAComponent, public Parented<HttpRequestComponent> {
 public:
-  // User provided, not "= default": `new(p) OtaHttpRequestComponent()` would zero-fill .bss that is already zero.
-  OtaHttpRequestComponent() {}
-
  void dump_config() override;
  float get_setup_priority() const override { return setup_priority::AFTER_WIFI; }

@@ -15,6 +15,9 @@ namespace esphome::http_request {

 class HttpRequestUpdate final : public update::UpdateEntity, public PollingComponent, public ota::OTAStateListener {
 public:
+  // User provided, not "= default": `new(p) HttpRequestUpdate()` would zero-fill .bss that is already zero.
+  HttpRequestUpdate() {}
+
  void setup() override;
  void update() override;

@@ -31,8 +34,8 @@ class HttpRequestUpdate final : public update::UpdateEntity, public PollingCompo
  void on_ota_state(ota::OTAState state, float progress, uint8_t error) override;

 protected:
-  HttpRequestComponent *request_parent_;
-  OtaHttpRequestComponent *ota_parent_;
+  HttpRequestComponent *request_parent_{nullptr};
+  OtaHttpRequestComponent *ota_parent_{nullptr};
  std::string source_url_;

  static void update_task(void *params);