mirror of
https://github.com/esphome/esphome.git
synced 2026-09-09 14:28:46 +00:00
Compare commits
45
Commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
455e1d6374 | ||
|
|
3af1d50bce | ||
|
|
842f354a05 | ||
|
|
af9b59d4bd | ||
|
|
55fc5a10de | ||
|
|
79927b918b | ||
|
|
1b070629bc | ||
|
|
c4e1360cdf | ||
|
|
7c774699d7 | ||
|
|
ea71a24a9b | ||
|
|
709a1e1eb6 | ||
|
|
822b701792 | ||
|
|
d2e4d2c46a | ||
|
|
adbbda4072 | ||
|
|
252bf6ea6a | ||
|
|
8ec9305688 | ||
|
|
490aca17e6 | ||
|
|
b77e2441d4 | ||
|
|
3b14f4dfc8 | ||
|
|
d34d3994e1 | ||
|
|
d58b37faa1 | ||
|
|
8966567be0 | ||
|
|
20c7dcb1dd | ||
|
|
688af60cbf | ||
|
|
9c00f13606 | ||
|
|
833dd0e812 | ||
|
|
8e1044e8ea | ||
|
|
e5200db6fd | ||
|
|
e3dd2f44a4 | ||
|
|
3ef7460fca | ||
|
|
ae187f81f2 | ||
|
|
84f78831f9 | ||
|
|
13dbbcaa32 | ||
|
|
b66822d9bd | ||
|
|
d1829c495d | ||
|
|
ce87bf9b17 | ||
|
|
51ea97deff | ||
|
|
ab800dc09d | ||
|
|
f65ab5629e | ||
|
|
b84532d254 | ||
|
|
6b11636491 | ||
|
|
2bb98f2d64 | ||
|
|
f3c786c784 | ||
|
|
2250430999 | ||
|
|
d1068d582f |
@@ -553,6 +553,7 @@ file does, and it is the authority when they disagree. The most useful starting
|
|||||||
4. **Lint:** Run `prek` to ensure code is compliant.
|
4. **Lint:** Run `prek` to ensure code is compliant.
|
||||||
5. **Commit:** Commit your changes. There is no strict format for commit messages.
|
5. **Commit:** Commit your changes. There is no strict format for commit messages.
|
||||||
6. **Pull Request:** Submit a PR against the `dev` branch. The Pull Request title must start with a `[tag]` prefix. For component work, use the component name (e.g., `[display] Fix bug`, `[abc123] Add new component`); for changes to shared/core code that isn't tied to a single component, use `[core]` (e.g., `[core] Add validator`). Update documentation, examples, and add `CODEOWNERS` entries as needed. Pull requests should always be made using the `.github/PULL_REQUEST_TEMPLATE.md` template - fill out all sections completely without removing any parts of the template.
|
6. **Pull Request:** Submit a PR against the `dev` branch. The Pull Request title must start with a `[tag]` prefix. For component work, use the component name (e.g., `[display] Fix bug`, `[abc123] Add new component`); for changes to shared/core code that isn't tied to a single component, use `[core]` (e.g., `[core] Add validator`). Update documentation, examples, and add `CODEOWNERS` entries as needed. Pull requests should always be made using the `.github/PULL_REQUEST_TEMPLATE.md` template - fill out all sections completely without removing any parts of the template.
|
||||||
|
7. **Comments:** When commenting on GitHub PRs or issues, don't tag contributors, especially bots. Avoid referring to list items (e.g. from reviews) with the form #nn - this will be interpreted by GitHub as a reference to issue or PR nn. Keep comments short and exclude irrelevant details, backstories, restatement of previous comments and anything that is already obvious to the reader.
|
||||||
|
|
||||||
* **Documentation Contributions:**
|
* **Documentation Contributions:**
|
||||||
* Documentation is hosted in the separate `esphome/esphome.io` repository.
|
* Documentation is hosted in the separate `esphome/esphome.io` repository.
|
||||||
|
|||||||
@@ -48,7 +48,7 @@ PROJECT_NAME = ESPHome
|
|||||||
# could be handy for archiving the generated documentation or if some version
|
# could be handy for archiving the generated documentation or if some version
|
||||||
# control system is used.
|
# control system is used.
|
||||||
|
|
||||||
PROJECT_NUMBER = 2026.9.0b3
|
PROJECT_NUMBER = 2026.10.0-dev
|
||||||
|
|
||||||
# Using the PROJECT_BRIEF tag one can provide an optional one line description
|
# Using the PROJECT_BRIEF tag one can provide an optional one line description
|
||||||
# for a project that appears at the top of each page and should give viewer a
|
# for a project that appears at the top of each page and should give viewer a
|
||||||
|
|||||||
+1
-1
@@ -22,7 +22,7 @@ RUN \
|
|||||||
-r /requirements.txt
|
-r /requirements.txt
|
||||||
|
|
||||||
# Install the ESPHome Device Builder dashboard.
|
# Install the ESPHome Device Builder dashboard.
|
||||||
RUN uv pip install --no-cache-dir esphome-device-builder==1.14.5
|
RUN uv pip install --no-cache-dir esphome-device-builder==1.14.4
|
||||||
|
|
||||||
RUN \
|
RUN \
|
||||||
platformio settings set enable_telemetry No \
|
platformio settings set enable_telemetry No \
|
||||||
|
|||||||
@@ -13,7 +13,7 @@ void Anova::dump_config() { LOG_CLIMATE("", "Anova BLE Cooker", this); }
|
|||||||
|
|
||||||
void Anova::setup() {
|
void Anova::setup() {
|
||||||
this->codec_ = make_unique<AnovaCodec>();
|
this->codec_ = make_unique<AnovaCodec>();
|
||||||
this->poll_step_ = PollStep::IDLE;
|
this->current_request_ = 0;
|
||||||
}
|
}
|
||||||
|
|
||||||
void Anova::loop() {
|
void Anova::loop() {
|
||||||
@@ -22,15 +22,6 @@ void Anova::loop() {
|
|||||||
this->disable_loop();
|
this->disable_loop();
|
||||||
}
|
}
|
||||||
|
|
||||||
void Anova::write_request_(AnovaPacket *pkt) {
|
|
||||||
auto status =
|
|
||||||
esp_ble_gattc_write_char(this->parent_->get_gattc_if(), this->parent_->get_conn_id(), this->char_handle_,
|
|
||||||
pkt->length, pkt->data, ESP_GATT_WRITE_TYPE_NO_RSP, ESP_GATT_AUTH_REQ_NONE);
|
|
||||||
if (status) {
|
|
||||||
ESP_LOGW(TAG, "[%s] esp_ble_gattc_write_char failed, status=%d", this->parent_->address_str(), status);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
void Anova::control(const ClimateCall &call) {
|
void Anova::control(const ClimateCall &call) {
|
||||||
auto mode_val = call.get_mode();
|
auto mode_val = call.get_mode();
|
||||||
if (mode_val.has_value()) {
|
if (mode_val.has_value()) {
|
||||||
@@ -47,11 +38,22 @@ void Anova::control(const ClimateCall &call) {
|
|||||||
ESP_LOGW(TAG, "Unsupported mode: %d", mode);
|
ESP_LOGW(TAG, "Unsupported mode: %d", mode);
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
this->write_request_(pkt);
|
auto status =
|
||||||
|
esp_ble_gattc_write_char(this->parent_->get_gattc_if(), this->parent_->get_conn_id(), this->char_handle_,
|
||||||
|
pkt->length, pkt->data, ESP_GATT_WRITE_TYPE_NO_RSP, ESP_GATT_AUTH_REQ_NONE);
|
||||||
|
if (status) {
|
||||||
|
ESP_LOGW(TAG, "[%s] esp_ble_gattc_write_char failed, status=%d", this->parent_->address_str(), status);
|
||||||
|
}
|
||||||
}
|
}
|
||||||
auto target_temp = call.get_target_temperature();
|
auto target_temp = call.get_target_temperature();
|
||||||
if (target_temp.has_value()) {
|
if (target_temp.has_value()) {
|
||||||
this->write_request_(this->codec_->get_set_target_temp_request(*target_temp));
|
auto *pkt = this->codec_->get_set_target_temp_request(*target_temp);
|
||||||
|
auto status =
|
||||||
|
esp_ble_gattc_write_char(this->parent_->get_gattc_if(), this->parent_->get_conn_id(), this->char_handle_,
|
||||||
|
pkt->length, pkt->data, ESP_GATT_WRITE_TYPE_NO_RSP, ESP_GATT_AUTH_REQ_NONE);
|
||||||
|
if (status) {
|
||||||
|
ESP_LOGW(TAG, "[%s] esp_ble_gattc_write_char failed, status=%d", this->parent_->address_str(), status);
|
||||||
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -60,7 +62,6 @@ void Anova::gattc_event_handler(esp_gattc_cb_event_t event, esp_gatt_if_t gattc_
|
|||||||
case ESP_GATTC_DISCONNECT_EVT: {
|
case ESP_GATTC_DISCONNECT_EVT: {
|
||||||
this->current_temperature = NAN;
|
this->current_temperature = NAN;
|
||||||
this->target_temperature = NAN;
|
this->target_temperature = NAN;
|
||||||
this->poll_step_ = PollStep::IDLE;
|
|
||||||
this->publish_state();
|
this->publish_state();
|
||||||
break;
|
break;
|
||||||
}
|
}
|
||||||
@@ -82,8 +83,8 @@ void Anova::gattc_event_handler(esp_gattc_cb_event_t event, esp_gatt_if_t gattc_
|
|||||||
}
|
}
|
||||||
case ESP_GATTC_REG_FOR_NOTIFY_EVT: {
|
case ESP_GATTC_REG_FOR_NOTIFY_EVT: {
|
||||||
this->node_state = espbt::ClientState::ESTABLISHED;
|
this->node_state = espbt::ClientState::ESTABLISHED;
|
||||||
this->poll_step_ = PollStep::IDLE;
|
this->current_request_ = 0;
|
||||||
this->update(); // begin the first poll cycle immediately
|
this->update();
|
||||||
break;
|
break;
|
||||||
}
|
}
|
||||||
case ESP_GATTC_NOTIFY_EVT: {
|
case ESP_GATTC_NOTIFY_EVT: {
|
||||||
@@ -100,30 +101,33 @@ void Anova::gattc_event_handler(esp_gattc_cb_event_t event, esp_gatt_if_t gattc_
|
|||||||
this->mode = this->codec_->running_ ? climate::CLIMATE_MODE_HEAT : climate::CLIMATE_MODE_OFF;
|
this->mode = this->codec_->running_ ? climate::CLIMATE_MODE_HEAT : climate::CLIMATE_MODE_OFF;
|
||||||
}
|
}
|
||||||
if (this->codec_->has_unit()) {
|
if (this->codec_->has_unit()) {
|
||||||
ESP_LOGD(TAG, "Anova units is %s", (this->codec_->unit_ == 'f') ? "fahrenheit" : "celsius");
|
this->fahrenheit_ = (this->codec_->unit_ == 'f');
|
||||||
|
ESP_LOGD(TAG, "Anova units is %s", this->fahrenheit_ ? "fahrenheit" : "celsius");
|
||||||
|
this->current_request_++;
|
||||||
}
|
}
|
||||||
this->publish_state();
|
this->publish_state();
|
||||||
|
|
||||||
// Advance the poll cycle to its next request based on the reply we got.
|
if (this->current_request_ > 1) {
|
||||||
switch (this->poll_step_) {
|
AnovaPacket *pkt = nullptr;
|
||||||
case PollStep::SET_UNIT:
|
switch (this->current_request_++) {
|
||||||
this->poll_step_ = PollStep::STATUS;
|
case 2:
|
||||||
this->write_request_(this->codec_->get_read_device_status_request());
|
pkt = this->codec_->get_read_target_temp_request();
|
||||||
break;
|
break;
|
||||||
case PollStep::STATUS:
|
case 3:
|
||||||
this->poll_step_ = PollStep::TARGET;
|
pkt = this->codec_->get_read_current_temp_request();
|
||||||
this->write_request_(this->codec_->get_read_target_temp_request());
|
break;
|
||||||
break;
|
default:
|
||||||
case PollStep::TARGET:
|
this->current_request_ = 1;
|
||||||
this->poll_step_ = PollStep::CURRENT;
|
break;
|
||||||
this->write_request_(this->codec_->get_read_current_temp_request());
|
}
|
||||||
break;
|
if (pkt != nullptr) {
|
||||||
case PollStep::CURRENT:
|
auto status =
|
||||||
this->poll_step_ = PollStep::IDLE; // full cycle complete
|
esp_ble_gattc_write_char(this->parent_->get_gattc_if(), this->parent_->get_conn_id(), this->char_handle_,
|
||||||
break;
|
pkt->length, pkt->data, ESP_GATT_WRITE_TYPE_NO_RSP, ESP_GATT_AUTH_REQ_NONE);
|
||||||
default:
|
if (status) {
|
||||||
// A reply to an ad-hoc control() write, outside a managed cycle.
|
ESP_LOGW(TAG, "[%s] esp_ble_gattc_write_char failed, status=%d", this->parent_->address_str(), status);
|
||||||
break;
|
}
|
||||||
|
}
|
||||||
}
|
}
|
||||||
break;
|
break;
|
||||||
}
|
}
|
||||||
@@ -132,26 +136,27 @@ void Anova::gattc_event_handler(esp_gattc_cb_event_t event, esp_gatt_if_t gattc_
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
void Anova::set_unit_of_measurement(const char *unit) { this->want_fahrenheit_ = !strncmp(unit, "f", 1); }
|
void Anova::set_unit_of_measurement(const char *unit) { this->fahrenheit_ = !strncmp(unit, "f", 1); }
|
||||||
|
|
||||||
void Anova::update() {
|
void Anova::update() {
|
||||||
if (this->node_state != espbt::ClientState::ESTABLISHED)
|
if (this->node_state != espbt::ClientState::ESTABLISHED)
|
||||||
return;
|
return;
|
||||||
if (this->poll_step_ != PollStep::IDLE) {
|
|
||||||
// The previous cycle never finished within a full polling interval -- a
|
if (this->current_request_ < 2) {
|
||||||
// reply was missed or a write failed. Restart the cycle rather than stall;
|
AnovaPacket *pkt;
|
||||||
// the polling interval itself acts as the timeout. A late reply from the
|
if (this->current_request_ == 0) {
|
||||||
// abandoned cycle is harmless: state decoding happens on every notify
|
pkt = this->codec_->get_set_unit_request(this->fahrenheit_ ? 'f' : 'c');
|
||||||
// regardless of step, and each notify sends at most one follow-up request.
|
} else {
|
||||||
ESP_LOGW(TAG, "[%s] Poll cycle incomplete (step %u); restarting cycle", this->parent_->address_str(),
|
pkt = this->codec_->get_read_device_status_request();
|
||||||
static_cast<uint8_t>(this->poll_step_));
|
}
|
||||||
|
auto status =
|
||||||
|
esp_ble_gattc_write_char(this->parent_->get_gattc_if(), this->parent_->get_conn_id(), this->char_handle_,
|
||||||
|
pkt->length, pkt->data, ESP_GATT_WRITE_TYPE_NO_RSP, ESP_GATT_AUTH_REQ_NONE);
|
||||||
|
if (status) {
|
||||||
|
ESP_LOGW(TAG, "[%s] esp_ble_gattc_write_char failed, status=%d", this->parent_->address_str(), status);
|
||||||
|
}
|
||||||
|
this->current_request_++;
|
||||||
}
|
}
|
||||||
// Re-assert the configured unit at the start of every poll cycle, then fall
|
|
||||||
// through the status/temperature reads via the notification handler. Always
|
|
||||||
// command the configured unit (want_fahrenheit_) -- never the last value the
|
|
||||||
// device reported, or a drift to 'c' would lock itself in.
|
|
||||||
this->poll_step_ = PollStep::SET_UNIT;
|
|
||||||
this->write_request_(this->codec_->get_set_unit_request(this->want_fahrenheit_ ? 'f' : 'c'));
|
|
||||||
}
|
}
|
||||||
|
|
||||||
} // namespace esphome::anova
|
} // namespace esphome::anova
|
||||||
|
|||||||
@@ -37,20 +37,11 @@ class Anova final : public climate::Climate, public esphome::ble_client::BLEClie
|
|||||||
void set_unit_of_measurement(const char *unit);
|
void set_unit_of_measurement(const char *unit);
|
||||||
|
|
||||||
protected:
|
protected:
|
||||||
// A poll cycle re-asserts the configured unit, then reads device state.
|
|
||||||
// Re-asserting every cycle prevents the cooker from silently reverting to
|
|
||||||
// its default (Celsius); previously the unit was only set once on
|
|
||||||
// connection, so a drift persisted (and corrupted the F/C interpretation of
|
|
||||||
// subsequent readings) until the BLE link was re-established.
|
|
||||||
enum class PollStep : uint8_t { SET_UNIT, STATUS, TARGET, CURRENT, IDLE };
|
|
||||||
|
|
||||||
void write_request_(AnovaPacket *pkt);
|
|
||||||
|
|
||||||
std::unique_ptr<AnovaCodec> codec_;
|
std::unique_ptr<AnovaCodec> codec_;
|
||||||
void control(const climate::ClimateCall &call) override;
|
void control(const climate::ClimateCall &call) override;
|
||||||
uint16_t char_handle_;
|
uint16_t char_handle_;
|
||||||
bool want_fahrenheit_{true}; // configured target unit; never overwritten by device replies
|
uint8_t current_request_;
|
||||||
PollStep poll_step_{PollStep::IDLE};
|
bool fahrenheit_;
|
||||||
};
|
};
|
||||||
|
|
||||||
} // namespace esphome::anova
|
} // namespace esphome::anova
|
||||||
|
|||||||
@@ -2255,7 +2255,12 @@ bool APIConnection::send_message_(uint32_t payload_size, uint16_t message_type,
|
|||||||
// Capacity reserved above, cannot fail
|
// Capacity reserved above, cannot fail
|
||||||
(void) shared_buf.resize(write_start + payload_size);
|
(void) shared_buf.resize(write_start + payload_size);
|
||||||
ProtoWriteBuffer buffer{&shared_buf, write_start};
|
ProtoWriteBuffer buffer{&shared_buf, write_start};
|
||||||
encode_fn(msg, buffer PROTO_ENCODE_DEBUG_INIT(&shared_buf));
|
uint8_t *end = encode_fn(msg, buffer PROTO_ENCODE_DEBUG_INIT(&shared_buf));
|
||||||
|
#ifdef ESPHOME_DEBUG_API
|
||||||
|
assert(end == shared_buf.data() + shared_buf.size());
|
||||||
|
#else
|
||||||
|
(void) end;
|
||||||
|
#endif
|
||||||
return this->send_buffer(ProtoWriteBuffer{&shared_buf}, message_type);
|
return this->send_buffer(ProtoWriteBuffer{&shared_buf}, message_type);
|
||||||
}
|
}
|
||||||
// encode_to_buffer is defined inline in api_connection.h (ESPHOME_ALWAYS_INLINE)
|
// encode_to_buffer is defined inline in api_connection.h (ESPHOME_ALWAYS_INLINE)
|
||||||
|
|||||||
@@ -345,11 +345,7 @@ class APIConnection final : public APIServerConnectionBase {
|
|||||||
/// Returns false as soon as the TCP buffer is full. Marked nodiscard so we
|
/// Returns false as soon as the TCP buffer is full. Marked nodiscard so we
|
||||||
/// have no silent failures: every caller must handle (or log) a refusal.
|
/// have no silent failures: every caller must handle (or log) a refusal.
|
||||||
template<typename T> [[nodiscard]] bool send_message(const T &msg) {
|
template<typename T> [[nodiscard]] bool send_message(const T &msg) {
|
||||||
if constexpr (T::ESTIMATED_SIZE == 0) {
|
return this->send_message_(T::calc_size_msg(&msg), T::MESSAGE_TYPE, &T::encode_msg, &msg);
|
||||||
return this->send_message_(0, T::MESSAGE_TYPE, &encode_msg_noop, &msg);
|
|
||||||
} else {
|
|
||||||
return this->send_message_(msg.calculate_size(), T::MESSAGE_TYPE, &proto_encode_msg<T>, &msg);
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
|
|
||||||
/// Clear the shared write buffer and reserve space for the first message.
|
/// Clear the shared write buffer and reserve space for the first message.
|
||||||
@@ -405,16 +401,6 @@ class APIConnection final : public APIServerConnectionBase {
|
|||||||
void process_state_subscriptions_();
|
void process_state_subscriptions_();
|
||||||
#endif
|
#endif
|
||||||
|
|
||||||
// Size thunk — converts void* back to concrete type for direct calculate_size() call
|
|
||||||
template<typename T> static uint32_t calc_size(const void *msg) {
|
|
||||||
return static_cast<const T *>(msg)->calculate_size();
|
|
||||||
}
|
|
||||||
|
|
||||||
// Shared no-op encode thunk for empty messages (ESTIMATED_SIZE == 0)
|
|
||||||
static uint8_t *encode_msg_noop(const void *, ProtoWriteBuffer &buf PROTO_ENCODE_DEBUG_PARAM) {
|
|
||||||
return buf.get_pos();
|
|
||||||
}
|
|
||||||
|
|
||||||
// Non-template buffer management for send_message
|
// Non-template buffer management for send_message
|
||||||
bool send_message_(uint32_t payload_size, uint16_t message_type, MessageEncodeFn encode_fn, const void *msg);
|
bool send_message_(uint32_t payload_size, uint16_t message_type, MessageEncodeFn encode_fn, const void *msg);
|
||||||
|
|
||||||
@@ -433,11 +419,7 @@ class APIConnection final : public APIServerConnectionBase {
|
|||||||
// Hot paths (state/info) go through fill_and_encode_entity_state/info instead.
|
// Hot paths (state/info) go through fill_and_encode_entity_state/info instead.
|
||||||
// batch_message_type_ is already set by dispatch_message_ before reaching here.
|
// batch_message_type_ is already set by dispatch_message_ before reaching here.
|
||||||
template<typename T> static uint16_t encode_message_to_buffer(T &msg, APIConnection *conn, uint32_t remaining_size) {
|
template<typename T> static uint16_t encode_message_to_buffer(T &msg, APIConnection *conn, uint32_t remaining_size) {
|
||||||
if constexpr (T::ESTIMATED_SIZE == 0) {
|
return encode_to_buffer_slow(T::calc_size_msg(&msg), &T::encode_msg, &msg, conn, remaining_size);
|
||||||
return encode_to_buffer_slow(0, &encode_msg_noop, &msg, conn, remaining_size);
|
|
||||||
} else {
|
|
||||||
return encode_to_buffer_slow(msg.calculate_size(), &proto_encode_msg<T>, &msg, conn, remaining_size);
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
|
|
||||||
// Non-template core — fills state fields and encodes
|
// Non-template core — fills state fields and encodes
|
||||||
@@ -449,7 +431,7 @@ class APIConnection final : public APIServerConnectionBase {
|
|||||||
template<typename T>
|
template<typename T>
|
||||||
static uint16_t fill_and_encode_entity_state(EntityBase *entity, T &msg, APIConnection *conn,
|
static uint16_t fill_and_encode_entity_state(EntityBase *entity, T &msg, APIConnection *conn,
|
||||||
uint32_t remaining_size) {
|
uint32_t remaining_size) {
|
||||||
return fill_and_encode_entity_state(entity, msg, &calc_size<T>, &proto_encode_msg<T>, conn, remaining_size);
|
return fill_and_encode_entity_state(entity, msg, &T::calc_size_msg, &T::encode_msg, conn, remaining_size);
|
||||||
}
|
}
|
||||||
|
|
||||||
// Non-template core — fills info fields, allocates buffers, and encodes
|
// Non-template core — fills info fields, allocates buffers, and encodes
|
||||||
@@ -461,7 +443,7 @@ class APIConnection final : public APIServerConnectionBase {
|
|||||||
template<typename T>
|
template<typename T>
|
||||||
static uint16_t fill_and_encode_entity_info(EntityBase *entity, T &msg, APIConnection *conn,
|
static uint16_t fill_and_encode_entity_info(EntityBase *entity, T &msg, APIConnection *conn,
|
||||||
uint32_t remaining_size) {
|
uint32_t remaining_size) {
|
||||||
return fill_and_encode_entity_info(entity, msg, &calc_size<T>, &proto_encode_msg<T>, conn, remaining_size);
|
return fill_and_encode_entity_info(entity, msg, &T::calc_size_msg, &T::encode_msg, conn, remaining_size);
|
||||||
}
|
}
|
||||||
|
|
||||||
// Non-template core — fills device_class, then delegates to fill_and_encode_entity_info
|
// Non-template core — fills device_class, then delegates to fill_and_encode_entity_info
|
||||||
@@ -475,8 +457,8 @@ class APIConnection final : public APIServerConnectionBase {
|
|||||||
static uint16_t fill_and_encode_entity_info_with_device_class(EntityBase *entity, T &msg,
|
static uint16_t fill_and_encode_entity_info_with_device_class(EntityBase *entity, T &msg,
|
||||||
StringRef &device_class_field, APIConnection *conn,
|
StringRef &device_class_field, APIConnection *conn,
|
||||||
uint32_t remaining_size) {
|
uint32_t remaining_size) {
|
||||||
return fill_and_encode_entity_info_with_device_class(entity, msg, device_class_field, &calc_size<T>,
|
return fill_and_encode_entity_info_with_device_class(entity, msg, device_class_field, &T::calc_size_msg,
|
||||||
&proto_encode_msg<T>, conn, remaining_size);
|
&T::encode_msg, conn, remaining_size);
|
||||||
}
|
}
|
||||||
|
|
||||||
#ifdef USE_VOICE_ASSISTANT
|
#ifdef USE_VOICE_ASSISTANT
|
||||||
|
|||||||
@@ -46,7 +46,13 @@ inline uint16_t ESPHOME_ALWAYS_INLINE APIConnection::encode_to_buffer(uint32_t c
|
|||||||
return 0;
|
return 0;
|
||||||
}
|
}
|
||||||
ProtoWriteBuffer buffer{&shared_buf, shared_buf.size() - calculated_size};
|
ProtoWriteBuffer buffer{&shared_buf, shared_buf.size() - calculated_size};
|
||||||
encode_fn(msg, buffer PROTO_ENCODE_DEBUG_INIT(&shared_buf));
|
uint8_t *end = encode_fn(msg, buffer PROTO_ENCODE_DEBUG_INIT(&shared_buf));
|
||||||
|
#ifdef ESPHOME_DEBUG_API
|
||||||
|
// A body that writes fewer bytes than calculate_size() promised would ship stale buffer bytes
|
||||||
|
assert(end == shared_buf.data() + shared_buf.size());
|
||||||
|
#else
|
||||||
|
(void) end;
|
||||||
|
#endif
|
||||||
|
|
||||||
return total_calculated_size;
|
return total_calculated_size;
|
||||||
}
|
}
|
||||||
|
|||||||
+1646
-1348
File diff suppressed because it is too large
Load Diff
+594
-198
File diff suppressed because it is too large
Load Diff
+198
-134
@@ -287,19 +287,31 @@ class ProtoWriteBuffer {
|
|||||||
uint8_t *pos_;
|
uint8_t *pos_;
|
||||||
};
|
};
|
||||||
|
|
||||||
|
// A four byte unaligned store is a memcpy call on ESP-IDF (-fno-builtin-memcpy) and on ARM cores without
|
||||||
|
// unaligned access (Cortex-M0+, ARM9), so those targets share one outlined byte store helper per fixed32
|
||||||
|
// field. Elsewhere the write inlines to a single store, or on ESP8266 to a few stores that measured
|
||||||
|
// faster than a call, so it stays inline.
|
||||||
|
#if defined(USE_ESP32) || (defined(__arm__) && !defined(__ARM_FEATURE_UNALIGNED))
|
||||||
|
#define PROTO_OUTLINE_FOR_SIZE __attribute__((noinline))
|
||||||
|
#define PROTO_FIXED32_BYTE_STORES true
|
||||||
|
#else
|
||||||
|
#define PROTO_OUTLINE_FOR_SIZE inline
|
||||||
|
#define PROTO_FIXED32_BYTE_STORES false
|
||||||
|
#endif
|
||||||
|
|
||||||
// Varint encoding thresholds — used by both proto_encode_* free functions and ProtoSize.
|
// Varint encoding thresholds — used by both proto_encode_* free functions and ProtoSize.
|
||||||
constexpr uint32_t VARINT_MAX_1_BYTE = 1 << 7; // 128
|
constexpr uint32_t VARINT_MAX_1_BYTE = 1 << 7; // 128
|
||||||
constexpr uint32_t VARINT_MAX_2_BYTE = 1 << 14; // 16384
|
constexpr uint32_t VARINT_MAX_2_BYTE = 1 << 14; // 16384
|
||||||
|
|
||||||
/// Static encode helpers for generated encode() functions.
|
/// Static encode helpers for the generated encode bodies. Each takes the write cursor by value and
|
||||||
/// Generated code hoists buffer.pos_ into a local uint8_t *__restrict__ pos,
|
/// returns it advanced, so outlined calls at -Os chain through the return register instead of a
|
||||||
/// then calls these methods which take pos by reference. No struct, no overhead.
|
/// stack slot. Helpers without a _force suffix skip fields holding the proto3 default.
|
||||||
/// For sub-messages, pos is synced back to buffer before the call and reloaded after.
|
|
||||||
class ProtoEncode {
|
class ProtoEncode {
|
||||||
public:
|
public:
|
||||||
/// Write a multi-byte varint directly through a pos pointer.
|
/// Write a multi-byte varint directly through a pos pointer.
|
||||||
template<typename T>
|
template<typename T>
|
||||||
static inline void encode_varint_raw_loop(uint8_t *__restrict__ &pos PROTO_ENCODE_DEBUG_PARAM, T value) {
|
[[nodiscard]] static inline uint8_t *encode_varint_raw_loop(uint8_t *__restrict__ pos PROTO_ENCODE_DEBUG_PARAM,
|
||||||
|
T value) {
|
||||||
do {
|
do {
|
||||||
PROTO_ENCODE_CHECK_BOUNDS(pos, 1);
|
PROTO_ENCODE_CHECK_BOUNDS(pos, 1);
|
||||||
*pos++ = static_cast<uint8_t>(value | 0x80);
|
*pos++ = static_cast<uint8_t>(value | 0x80);
|
||||||
@@ -307,48 +319,49 @@ class ProtoEncode {
|
|||||||
} while (value > 0x7F);
|
} while (value > 0x7F);
|
||||||
PROTO_ENCODE_CHECK_BOUNDS(pos, 1);
|
PROTO_ENCODE_CHECK_BOUNDS(pos, 1);
|
||||||
*pos++ = static_cast<uint8_t>(value);
|
*pos++ = static_cast<uint8_t>(value);
|
||||||
|
return pos;
|
||||||
}
|
}
|
||||||
static inline void ESPHOME_ALWAYS_INLINE encode_varint_raw(uint8_t *__restrict__ &pos PROTO_ENCODE_DEBUG_PARAM,
|
[[nodiscard]] static inline uint8_t *ESPHOME_ALWAYS_INLINE
|
||||||
uint32_t value) {
|
encode_varint_raw(uint8_t *__restrict__ pos PROTO_ENCODE_DEBUG_PARAM, uint32_t value) {
|
||||||
if (value < VARINT_MAX_1_BYTE) [[likely]] {
|
if (value < VARINT_MAX_1_BYTE) [[likely]] {
|
||||||
PROTO_ENCODE_CHECK_BOUNDS(pos, 1);
|
PROTO_ENCODE_CHECK_BOUNDS(pos, 1);
|
||||||
*pos++ = static_cast<uint8_t>(value);
|
*pos++ = static_cast<uint8_t>(value);
|
||||||
return;
|
return pos;
|
||||||
}
|
}
|
||||||
encode_varint_raw_loop(pos PROTO_ENCODE_DEBUG_ARG, value);
|
return encode_varint_raw_loop(pos PROTO_ENCODE_DEBUG_ARG, value);
|
||||||
}
|
}
|
||||||
/// Encode a varint that is expected to be 1-2 bytes (e.g. zigzag RSSI, small lengths).
|
/// Encode a varint that is expected to be 1-2 bytes (e.g. zigzag RSSI, small lengths).
|
||||||
static inline void ESPHOME_ALWAYS_INLINE encode_varint_raw_short(uint8_t *__restrict__ &pos PROTO_ENCODE_DEBUG_PARAM,
|
[[nodiscard]] static inline uint8_t *ESPHOME_ALWAYS_INLINE
|
||||||
uint32_t value) {
|
encode_varint_raw_short(uint8_t *__restrict__ pos PROTO_ENCODE_DEBUG_PARAM, uint32_t value) {
|
||||||
if (value < VARINT_MAX_1_BYTE) [[likely]] {
|
if (value < VARINT_MAX_1_BYTE) [[likely]] {
|
||||||
PROTO_ENCODE_CHECK_BOUNDS(pos, 1);
|
PROTO_ENCODE_CHECK_BOUNDS(pos, 1);
|
||||||
*pos++ = static_cast<uint8_t>(value);
|
*pos++ = static_cast<uint8_t>(value);
|
||||||
return;
|
return pos;
|
||||||
}
|
}
|
||||||
if (value < VARINT_MAX_2_BYTE) [[likely]] {
|
if (value < VARINT_MAX_2_BYTE) [[likely]] {
|
||||||
PROTO_ENCODE_CHECK_BOUNDS(pos, 2);
|
PROTO_ENCODE_CHECK_BOUNDS(pos, 2);
|
||||||
*pos++ = static_cast<uint8_t>(value | 0x80);
|
*pos++ = static_cast<uint8_t>(value | 0x80);
|
||||||
*pos++ = static_cast<uint8_t>(value >> 7);
|
*pos++ = static_cast<uint8_t>(value >> 7);
|
||||||
return;
|
return pos;
|
||||||
}
|
}
|
||||||
encode_varint_raw_loop(pos PROTO_ENCODE_DEBUG_ARG, value);
|
return encode_varint_raw_loop(pos PROTO_ENCODE_DEBUG_ARG, value);
|
||||||
}
|
}
|
||||||
static inline void ESPHOME_ALWAYS_INLINE encode_varint_raw_64(uint8_t *__restrict__ &pos PROTO_ENCODE_DEBUG_PARAM,
|
[[nodiscard]] static inline uint8_t *ESPHOME_ALWAYS_INLINE
|
||||||
uint64_t value) {
|
encode_varint_raw_64(uint8_t *__restrict__ pos PROTO_ENCODE_DEBUG_PARAM, uint64_t value) {
|
||||||
if (value < VARINT_MAX_1_BYTE) [[likely]] {
|
if (value < VARINT_MAX_1_BYTE) [[likely]] {
|
||||||
PROTO_ENCODE_CHECK_BOUNDS(pos, 1);
|
PROTO_ENCODE_CHECK_BOUNDS(pos, 1);
|
||||||
*pos++ = static_cast<uint8_t>(value);
|
*pos++ = static_cast<uint8_t>(value);
|
||||||
return;
|
return pos;
|
||||||
}
|
}
|
||||||
encode_varint_raw_loop(pos PROTO_ENCODE_DEBUG_ARG, value);
|
return encode_varint_raw_loop(pos PROTO_ENCODE_DEBUG_ARG, value);
|
||||||
}
|
}
|
||||||
/// Encode a 48-bit MAC address (stored in a uint64) as varint.
|
/// Encode a 48-bit MAC address (stored in a uint64) as varint.
|
||||||
/// Real MAC addresses occupy the full 48 bits (OUI in upper 24), so the
|
/// Real MAC addresses occupy the full 48 bits (OUI in upper 24), so the
|
||||||
/// fast path -- any non-zero bit in the top 6 of 48 -- emits exactly 7 bytes
|
/// fast path -- any non-zero bit in the top 6 of 48 -- emits exactly 7 bytes
|
||||||
/// with no per-byte branch. Falls back to the general loop otherwise.
|
/// with no per-byte branch. Falls back to the general loop otherwise.
|
||||||
/// Caller must guarantee value fits in 48 bits (checked in debug builds).
|
/// Caller must guarantee value fits in 48 bits (checked in debug builds).
|
||||||
static inline void ESPHOME_ALWAYS_INLINE encode_varint_raw_48bit(uint8_t *__restrict__ &pos PROTO_ENCODE_DEBUG_PARAM,
|
[[nodiscard]] static inline uint8_t *ESPHOME_ALWAYS_INLINE
|
||||||
uint64_t value) {
|
encode_varint_raw_48bit(uint8_t *__restrict__ pos PROTO_ENCODE_DEBUG_PARAM, uint64_t value) {
|
||||||
#ifdef ESPHOME_DEBUG_API
|
#ifdef ESPHOME_DEBUG_API
|
||||||
assert(value < (1ULL << (MAC_ADDRESS_SIZE * 8)) && "encode_varint_raw_48bit: value exceeds 48 bits");
|
assert(value < (1ULL << (MAC_ADDRESS_SIZE * 8)) && "encode_varint_raw_48bit: value exceeds 48 bits");
|
||||||
#endif
|
#endif
|
||||||
@@ -363,38 +376,39 @@ class ProtoEncode {
|
|||||||
pos[4] = static_cast<uint8_t>((value >> 28) | 0x80);
|
pos[4] = static_cast<uint8_t>((value >> 28) | 0x80);
|
||||||
pos[5] = static_cast<uint8_t>((value >> 35) | 0x80);
|
pos[5] = static_cast<uint8_t>((value >> 35) | 0x80);
|
||||||
pos[6] = static_cast<uint8_t>(value >> 42);
|
pos[6] = static_cast<uint8_t>(value >> 42);
|
||||||
pos += 7;
|
return pos + 7;
|
||||||
return;
|
|
||||||
}
|
}
|
||||||
encode_varint_raw_64(pos PROTO_ENCODE_DEBUG_ARG, value);
|
return encode_varint_raw_64(pos PROTO_ENCODE_DEBUG_ARG, value);
|
||||||
}
|
}
|
||||||
static inline void ESPHOME_ALWAYS_INLINE encode_field_raw(uint8_t *__restrict__ &pos PROTO_ENCODE_DEBUG_PARAM,
|
[[nodiscard]] static inline uint8_t *ESPHOME_ALWAYS_INLINE
|
||||||
uint32_t field_id, uint32_t type) {
|
encode_field_raw(uint8_t *__restrict__ pos PROTO_ENCODE_DEBUG_PARAM, uint32_t field_id, uint32_t type) {
|
||||||
encode_varint_raw(pos PROTO_ENCODE_DEBUG_ARG, (field_id << 3) | type);
|
return encode_varint_raw(pos PROTO_ENCODE_DEBUG_ARG, (field_id << 3) | type);
|
||||||
}
|
}
|
||||||
/// Write a single precomputed tag byte. Tag must be < 128.
|
/// Write a single precomputed tag byte. Tag must be < 128.
|
||||||
static inline void ESPHOME_ALWAYS_INLINE write_raw_byte(uint8_t *__restrict__ &pos PROTO_ENCODE_DEBUG_PARAM,
|
[[nodiscard]] static inline uint8_t *ESPHOME_ALWAYS_INLINE
|
||||||
uint8_t b) {
|
write_raw_byte(uint8_t *__restrict__ pos PROTO_ENCODE_DEBUG_PARAM, uint8_t b) {
|
||||||
PROTO_ENCODE_CHECK_BOUNDS(pos, 1);
|
PROTO_ENCODE_CHECK_BOUNDS(pos, 1);
|
||||||
*pos++ = b;
|
*pos++ = b;
|
||||||
|
return pos;
|
||||||
}
|
}
|
||||||
/// Reserve one byte for later backpatch (e.g., sub-message length).
|
/// Reserve one byte for later backpatch (e.g., sub-message length).
|
||||||
/// Advances pos past the reserved byte without writing a value.
|
/// Advances pos past the reserved byte without writing a value.
|
||||||
static inline void ESPHOME_ALWAYS_INLINE reserve_byte(uint8_t *__restrict__ &pos PROTO_ENCODE_DEBUG_PARAM) {
|
[[nodiscard]] static inline uint8_t *ESPHOME_ALWAYS_INLINE
|
||||||
|
reserve_byte(uint8_t *__restrict__ pos PROTO_ENCODE_DEBUG_PARAM) {
|
||||||
PROTO_ENCODE_CHECK_BOUNDS(pos, 1);
|
PROTO_ENCODE_CHECK_BOUNDS(pos, 1);
|
||||||
pos++;
|
return pos + 1;
|
||||||
}
|
}
|
||||||
/// Write raw bytes to the buffer (no tag, no length prefix).
|
/// Write raw bytes to the buffer (no tag, no length prefix).
|
||||||
static inline void ESPHOME_ALWAYS_INLINE encode_raw(uint8_t *__restrict__ &pos PROTO_ENCODE_DEBUG_PARAM,
|
[[nodiscard]] static inline uint8_t *ESPHOME_ALWAYS_INLINE
|
||||||
const void *data, size_t len) {
|
encode_raw(uint8_t *__restrict__ pos PROTO_ENCODE_DEBUG_PARAM, const void *data, size_t len) {
|
||||||
PROTO_ENCODE_CHECK_BOUNDS(pos, len);
|
PROTO_ENCODE_CHECK_BOUNDS(pos, len);
|
||||||
std::memcpy(pos, data, len);
|
std::memcpy(pos, data, len);
|
||||||
pos += len;
|
return pos + len;
|
||||||
}
|
}
|
||||||
/// Encode tag + 1-byte length + raw string data. For strings with max_data_length < 128.
|
/// Encode tag + 1-byte length + raw string data. For strings with max_data_length < 128.
|
||||||
/// Tag must be a single-byte varint (< 128). Always encodes (no zero check).
|
/// Tag must be a single-byte varint (< 128). Always encodes (no zero check).
|
||||||
static inline void encode_short_string_force(uint8_t *__restrict__ &pos PROTO_ENCODE_DEBUG_PARAM, uint8_t tag,
|
[[nodiscard]] static inline uint8_t *encode_short_string_force(uint8_t *__restrict__ pos PROTO_ENCODE_DEBUG_PARAM,
|
||||||
const StringRef &ref) {
|
uint8_t tag, const StringRef &ref) {
|
||||||
#ifdef ESPHOME_DEBUG_API
|
#ifdef ESPHOME_DEBUG_API
|
||||||
assert(ref.size() < 128 && "encode_short_string_force: string exceeds max_data_length < 128");
|
assert(ref.size() < 128 && "encode_short_string_force: string exceeds max_data_length < 128");
|
||||||
#endif
|
#endif
|
||||||
@@ -402,137 +416,191 @@ class ProtoEncode {
|
|||||||
pos[0] = tag;
|
pos[0] = tag;
|
||||||
pos[1] = static_cast<uint8_t>(ref.size());
|
pos[1] = static_cast<uint8_t>(ref.size());
|
||||||
std::memcpy(pos + 2, ref.c_str(), ref.size());
|
std::memcpy(pos + 2, ref.c_str(), ref.size());
|
||||||
pos += 2 + ref.size();
|
return pos + 2 + ref.size();
|
||||||
}
|
}
|
||||||
/// Write a precomputed tag byte + 32-bit value in one operation.
|
/// Write a precomputed tag byte + 32-bit value. Outlined on embedded: one copy beats inline stores per field.
|
||||||
static inline void ESPHOME_ALWAYS_INLINE write_tag_and_fixed32(uint8_t *__restrict__ &pos PROTO_ENCODE_DEBUG_PARAM,
|
[[nodiscard]] static PROTO_OUTLINE_FOR_SIZE uint8_t *write_tag_and_fixed32(
|
||||||
uint8_t tag, uint32_t value) {
|
uint8_t *__restrict__ pos PROTO_ENCODE_DEBUG_PARAM, uint8_t tag, uint32_t value) {
|
||||||
PROTO_ENCODE_CHECK_BOUNDS(pos, 5);
|
PROTO_ENCODE_CHECK_BOUNDS(pos, 5);
|
||||||
pos[0] = tag;
|
pos[0] = tag;
|
||||||
#if __BYTE_ORDER__ == __ORDER_LITTLE_ENDIAN__
|
write_fixed32_le(pos + 1, value);
|
||||||
std::memcpy(pos + 1, &value, 4);
|
return pos + 5;
|
||||||
#else
|
|
||||||
pos[1] = static_cast<uint8_t>(value & 0xFF);
|
|
||||||
pos[2] = static_cast<uint8_t>((value >> 8) & 0xFF);
|
|
||||||
pos[3] = static_cast<uint8_t>((value >> 16) & 0xFF);
|
|
||||||
pos[4] = static_cast<uint8_t>((value >> 24) & 0xFF);
|
|
||||||
#endif
|
|
||||||
pos += 5;
|
|
||||||
}
|
}
|
||||||
static inline void encode_string(uint8_t *__restrict__ &pos PROTO_ENCODE_DEBUG_PARAM, uint32_t field_id,
|
[[nodiscard]] static inline uint8_t *encode_string_force(uint8_t *__restrict__ pos PROTO_ENCODE_DEBUG_PARAM,
|
||||||
const char *string, size_t len, bool force = false) {
|
uint32_t field_id, const char *string, size_t len) {
|
||||||
if (len == 0 && !force)
|
pos = encode_field_raw(pos PROTO_ENCODE_DEBUG_ARG, field_id, 2); // type 2: Length-delimited string
|
||||||
return;
|
|
||||||
encode_field_raw(pos PROTO_ENCODE_DEBUG_ARG, field_id, 2); // type 2: Length-delimited string
|
|
||||||
// NOLINTNEXTLINE(readability-inconsistent-ifelse-braces) -- false positive on [[likely]] attribute
|
// NOLINTNEXTLINE(readability-inconsistent-ifelse-braces) -- false positive on [[likely]] attribute
|
||||||
if (len < VARINT_MAX_1_BYTE) [[likely]] {
|
if (len < VARINT_MAX_1_BYTE) [[likely]] {
|
||||||
PROTO_ENCODE_CHECK_BOUNDS(pos, 1 + len);
|
PROTO_ENCODE_CHECK_BOUNDS(pos, 1 + len);
|
||||||
*pos++ = static_cast<uint8_t>(len);
|
*pos++ = static_cast<uint8_t>(len);
|
||||||
} else {
|
} else {
|
||||||
encode_varint_raw_loop(pos PROTO_ENCODE_DEBUG_ARG, len);
|
pos = encode_varint_raw_loop(pos PROTO_ENCODE_DEBUG_ARG, len);
|
||||||
PROTO_ENCODE_CHECK_BOUNDS(pos, len);
|
PROTO_ENCODE_CHECK_BOUNDS(pos, len);
|
||||||
}
|
}
|
||||||
std::memcpy(pos, string, len);
|
std::memcpy(pos, string, len);
|
||||||
pos += len;
|
return pos + len;
|
||||||
}
|
}
|
||||||
static inline void encode_string(uint8_t *__restrict__ &pos PROTO_ENCODE_DEBUG_PARAM, uint32_t field_id,
|
[[nodiscard]] static inline uint8_t *encode_string(uint8_t *__restrict__ pos PROTO_ENCODE_DEBUG_PARAM,
|
||||||
const std::string &value, bool force = false) {
|
uint32_t field_id, const char *string, size_t len) {
|
||||||
encode_string(pos PROTO_ENCODE_DEBUG_ARG, field_id, value.data(), value.size(), force);
|
if (len == 0)
|
||||||
|
return pos;
|
||||||
|
return encode_string_force(pos PROTO_ENCODE_DEBUG_ARG, field_id, string, len);
|
||||||
}
|
}
|
||||||
static inline void encode_string(uint8_t *__restrict__ &pos PROTO_ENCODE_DEBUG_PARAM, uint32_t field_id,
|
[[nodiscard]] static inline uint8_t *encode_string_force(uint8_t *__restrict__ pos PROTO_ENCODE_DEBUG_PARAM,
|
||||||
const StringRef &ref, bool force = false) {
|
uint32_t field_id, const std::string &value) {
|
||||||
encode_string(pos PROTO_ENCODE_DEBUG_ARG, field_id, ref.c_str(), ref.size(), force);
|
return encode_string_force(pos PROTO_ENCODE_DEBUG_ARG, field_id, value.data(), value.size());
|
||||||
}
|
}
|
||||||
static inline void encode_bytes(uint8_t *__restrict__ &pos PROTO_ENCODE_DEBUG_PARAM, uint32_t field_id,
|
[[nodiscard]] static inline uint8_t *encode_string(uint8_t *__restrict__ pos PROTO_ENCODE_DEBUG_PARAM,
|
||||||
const uint8_t *data, size_t len, bool force = false) {
|
uint32_t field_id, const StringRef &ref) {
|
||||||
encode_string(pos PROTO_ENCODE_DEBUG_ARG, field_id, reinterpret_cast<const char *>(data), len, force);
|
return encode_string(pos PROTO_ENCODE_DEBUG_ARG, field_id, ref.c_str(), ref.size());
|
||||||
}
|
}
|
||||||
static inline void encode_uint32(uint8_t *__restrict__ &pos PROTO_ENCODE_DEBUG_PARAM, uint32_t field_id,
|
[[nodiscard]] static inline uint8_t *encode_string_force(uint8_t *__restrict__ pos PROTO_ENCODE_DEBUG_PARAM,
|
||||||
uint32_t value, bool force = false) {
|
uint32_t field_id, const StringRef &ref) {
|
||||||
if (value == 0 && !force)
|
return encode_string_force(pos PROTO_ENCODE_DEBUG_ARG, field_id, ref.c_str(), ref.size());
|
||||||
return;
|
|
||||||
encode_field_raw(pos PROTO_ENCODE_DEBUG_ARG, field_id, 0);
|
|
||||||
encode_varint_raw(pos PROTO_ENCODE_DEBUG_ARG, value);
|
|
||||||
}
|
}
|
||||||
static inline void encode_uint64(uint8_t *__restrict__ &pos PROTO_ENCODE_DEBUG_PARAM, uint32_t field_id,
|
[[nodiscard]] static inline uint8_t *encode_bytes(uint8_t *__restrict__ pos PROTO_ENCODE_DEBUG_PARAM,
|
||||||
uint64_t value, bool force = false) {
|
uint32_t field_id, const uint8_t *data, size_t len) {
|
||||||
if (value == 0 && !force)
|
return encode_string(pos PROTO_ENCODE_DEBUG_ARG, field_id, reinterpret_cast<const char *>(data), len);
|
||||||
return;
|
|
||||||
encode_field_raw(pos PROTO_ENCODE_DEBUG_ARG, field_id, 0);
|
|
||||||
encode_varint_raw_64(pos PROTO_ENCODE_DEBUG_ARG, value);
|
|
||||||
}
|
}
|
||||||
static inline void encode_bool(uint8_t *__restrict__ &pos PROTO_ENCODE_DEBUG_PARAM, uint32_t field_id, bool value,
|
[[nodiscard]] static inline uint8_t *encode_bytes_force(uint8_t *__restrict__ pos PROTO_ENCODE_DEBUG_PARAM,
|
||||||
bool force = false) {
|
uint32_t field_id, const uint8_t *data, size_t len) {
|
||||||
if (!value && !force)
|
return encode_string_force(pos PROTO_ENCODE_DEBUG_ARG, field_id, reinterpret_cast<const char *>(data), len);
|
||||||
return;
|
}
|
||||||
encode_field_raw(pos PROTO_ENCODE_DEBUG_ARG, field_id, 0);
|
[[nodiscard]] static inline uint8_t *encode_uint32_force(uint8_t *__restrict__ pos PROTO_ENCODE_DEBUG_PARAM,
|
||||||
|
uint32_t field_id, uint32_t value) {
|
||||||
|
pos = encode_field_raw(pos PROTO_ENCODE_DEBUG_ARG, field_id, 0);
|
||||||
|
return encode_varint_raw(pos PROTO_ENCODE_DEBUG_ARG, value);
|
||||||
|
}
|
||||||
|
[[nodiscard]] static inline uint8_t *encode_uint32(uint8_t *__restrict__ pos PROTO_ENCODE_DEBUG_PARAM,
|
||||||
|
uint32_t field_id, uint32_t value) {
|
||||||
|
if (value == 0)
|
||||||
|
return pos;
|
||||||
|
return encode_uint32_force(pos PROTO_ENCODE_DEBUG_ARG, field_id, value);
|
||||||
|
}
|
||||||
|
[[nodiscard]] static inline uint8_t *encode_uint64_force(uint8_t *__restrict__ pos PROTO_ENCODE_DEBUG_PARAM,
|
||||||
|
uint32_t field_id, uint64_t value) {
|
||||||
|
pos = encode_field_raw(pos PROTO_ENCODE_DEBUG_ARG, field_id, 0);
|
||||||
|
return encode_varint_raw_64(pos PROTO_ENCODE_DEBUG_ARG, value);
|
||||||
|
}
|
||||||
|
[[nodiscard]] static inline uint8_t *encode_uint64(uint8_t *__restrict__ pos PROTO_ENCODE_DEBUG_PARAM,
|
||||||
|
uint32_t field_id, uint64_t value) {
|
||||||
|
if (value == 0)
|
||||||
|
return pos;
|
||||||
|
return encode_uint64_force(pos PROTO_ENCODE_DEBUG_ARG, field_id, value);
|
||||||
|
}
|
||||||
|
[[nodiscard]] static inline uint8_t *encode_bool_force(uint8_t *__restrict__ pos PROTO_ENCODE_DEBUG_PARAM,
|
||||||
|
uint32_t field_id, bool value) {
|
||||||
|
pos = encode_field_raw(pos PROTO_ENCODE_DEBUG_ARG, field_id, 0);
|
||||||
PROTO_ENCODE_CHECK_BOUNDS(pos, 1);
|
PROTO_ENCODE_CHECK_BOUNDS(pos, 1);
|
||||||
*pos++ = value ? 0x01 : 0x00;
|
*pos++ = value ? 0x01 : 0x00;
|
||||||
|
return pos;
|
||||||
}
|
}
|
||||||
static inline void encode_fixed32(uint8_t *__restrict__ &pos PROTO_ENCODE_DEBUG_PARAM, uint32_t field_id,
|
[[nodiscard]] static inline uint8_t *encode_bool(uint8_t *__restrict__ pos PROTO_ENCODE_DEBUG_PARAM,
|
||||||
uint32_t value, bool force = false) {
|
uint32_t field_id, bool value) {
|
||||||
if (value == 0 && !force)
|
if (!value)
|
||||||
return;
|
return pos;
|
||||||
encode_field_raw(pos PROTO_ENCODE_DEBUG_ARG, field_id, 5);
|
return encode_bool_force(pos PROTO_ENCODE_DEBUG_ARG, field_id, value);
|
||||||
|
}
|
||||||
|
/// Tag + fixed32 for multi-byte tags; single-byte tags use write_tag_and_fixed32.
|
||||||
|
[[nodiscard]] static PROTO_OUTLINE_FOR_SIZE uint8_t *encode_fixed32_force(
|
||||||
|
uint8_t *__restrict__ pos PROTO_ENCODE_DEBUG_PARAM, uint32_t field_id, uint32_t value) {
|
||||||
|
pos = encode_field_raw(pos PROTO_ENCODE_DEBUG_ARG, field_id, 5);
|
||||||
PROTO_ENCODE_CHECK_BOUNDS(pos, 4);
|
PROTO_ENCODE_CHECK_BOUNDS(pos, 4);
|
||||||
#if __BYTE_ORDER__ == __ORDER_LITTLE_ENDIAN__
|
write_fixed32_le(pos, value);
|
||||||
std::memcpy(pos, &value, 4);
|
return pos + 4;
|
||||||
pos += 4;
|
}
|
||||||
#else
|
[[nodiscard]] static inline uint8_t *encode_fixed32(uint8_t *__restrict__ pos PROTO_ENCODE_DEBUG_PARAM,
|
||||||
*pos++ = (value >> 0) & 0xFF;
|
uint32_t field_id, uint32_t value) {
|
||||||
*pos++ = (value >> 8) & 0xFF;
|
if (value == 0)
|
||||||
*pos++ = (value >> 16) & 0xFF;
|
return pos;
|
||||||
*pos++ = (value >> 24) & 0xFF;
|
return encode_fixed32_force(pos PROTO_ENCODE_DEBUG_ARG, field_id, value);
|
||||||
#endif
|
|
||||||
}
|
}
|
||||||
// NOTE: Wire type 1 (64-bit fixed: double, fixed64, sfixed64) is intentionally
|
// NOTE: Wire type 1 (64-bit fixed: double, fixed64, sfixed64) is intentionally
|
||||||
// not supported to reduce overhead on embedded systems. All ESPHome devices are
|
// not supported to reduce overhead on embedded systems. All ESPHome devices are
|
||||||
// 32-bit microcontrollers where 64-bit operations are expensive. If 64-bit support
|
// 32-bit microcontrollers where 64-bit operations are expensive. If 64-bit support
|
||||||
// is needed in the future, the necessary encoding/decoding functions must be added.
|
// is needed in the future, the necessary encoding/decoding functions must be added.
|
||||||
static inline void encode_float(uint8_t *__restrict__ &pos PROTO_ENCODE_DEBUG_PARAM, uint32_t field_id, float value,
|
[[nodiscard]] static inline uint8_t *encode_float(uint8_t *__restrict__ pos PROTO_ENCODE_DEBUG_PARAM,
|
||||||
bool force = false) {
|
uint32_t field_id, float value) {
|
||||||
uint32_t raw = float_to_raw(value);
|
return encode_fixed32(pos PROTO_ENCODE_DEBUG_ARG, field_id, float_to_raw(value));
|
||||||
if (raw == 0 && !force)
|
|
||||||
return;
|
|
||||||
encode_fixed32(pos PROTO_ENCODE_DEBUG_ARG, field_id, raw);
|
|
||||||
}
|
}
|
||||||
static inline void encode_int32(uint8_t *__restrict__ &pos PROTO_ENCODE_DEBUG_PARAM, uint32_t field_id, int32_t value,
|
[[nodiscard]] static inline uint8_t *encode_float_force(uint8_t *__restrict__ pos PROTO_ENCODE_DEBUG_PARAM,
|
||||||
bool force = false) {
|
uint32_t field_id, float value) {
|
||||||
|
return encode_fixed32_force(pos PROTO_ENCODE_DEBUG_ARG, field_id, float_to_raw(value));
|
||||||
|
}
|
||||||
|
[[nodiscard]] static inline uint8_t *encode_int32_force(uint8_t *__restrict__ pos PROTO_ENCODE_DEBUG_PARAM,
|
||||||
|
uint32_t field_id, int32_t value) {
|
||||||
if (value < 0) {
|
if (value < 0) {
|
||||||
// negative int32 is always 10 byte long
|
// negative int32 is always 10 byte long
|
||||||
encode_uint64(pos PROTO_ENCODE_DEBUG_ARG, field_id, static_cast<uint64_t>(value), force);
|
return encode_uint64_force(pos PROTO_ENCODE_DEBUG_ARG, field_id, static_cast<uint64_t>(value));
|
||||||
return;
|
|
||||||
}
|
}
|
||||||
encode_uint32(pos PROTO_ENCODE_DEBUG_ARG, field_id, static_cast<uint32_t>(value), force);
|
return encode_uint32_force(pos PROTO_ENCODE_DEBUG_ARG, field_id, static_cast<uint32_t>(value));
|
||||||
}
|
}
|
||||||
static inline void encode_int64(uint8_t *__restrict__ &pos PROTO_ENCODE_DEBUG_PARAM, uint32_t field_id, int64_t value,
|
[[nodiscard]] static inline uint8_t *encode_int32(uint8_t *__restrict__ pos PROTO_ENCODE_DEBUG_PARAM,
|
||||||
bool force = false) {
|
uint32_t field_id, int32_t value) {
|
||||||
encode_uint64(pos PROTO_ENCODE_DEBUG_ARG, field_id, static_cast<uint64_t>(value), force);
|
if (value == 0)
|
||||||
|
return pos;
|
||||||
|
return encode_int32_force(pos PROTO_ENCODE_DEBUG_ARG, field_id, value);
|
||||||
}
|
}
|
||||||
static inline void encode_sint32(uint8_t *__restrict__ &pos PROTO_ENCODE_DEBUG_PARAM, uint32_t field_id,
|
[[nodiscard]] static inline uint8_t *encode_int64(uint8_t *__restrict__ pos PROTO_ENCODE_DEBUG_PARAM,
|
||||||
int32_t value, bool force = false) {
|
uint32_t field_id, int64_t value) {
|
||||||
encode_uint32(pos PROTO_ENCODE_DEBUG_ARG, field_id, encode_zigzag32(value), force);
|
return encode_uint64(pos PROTO_ENCODE_DEBUG_ARG, field_id, static_cast<uint64_t>(value));
|
||||||
}
|
}
|
||||||
static inline void encode_sint64(uint8_t *__restrict__ &pos PROTO_ENCODE_DEBUG_PARAM, uint32_t field_id,
|
[[nodiscard]] static inline uint8_t *encode_int64_force(uint8_t *__restrict__ pos PROTO_ENCODE_DEBUG_PARAM,
|
||||||
int64_t value, bool force = false) {
|
uint32_t field_id, int64_t value) {
|
||||||
encode_uint64(pos PROTO_ENCODE_DEBUG_ARG, field_id, encode_zigzag64(value), force);
|
return encode_uint64_force(pos PROTO_ENCODE_DEBUG_ARG, field_id, static_cast<uint64_t>(value));
|
||||||
}
|
}
|
||||||
/// Sub-message encoding: sync pos to buffer, delegate, get pos from return value.
|
[[nodiscard]] static inline uint8_t *encode_sint32(uint8_t *__restrict__ pos PROTO_ENCODE_DEBUG_PARAM,
|
||||||
|
uint32_t field_id, int32_t value) {
|
||||||
|
return encode_uint32(pos PROTO_ENCODE_DEBUG_ARG, field_id, encode_zigzag32(value));
|
||||||
|
}
|
||||||
|
[[nodiscard]] static inline uint8_t *encode_sint32_force(uint8_t *__restrict__ pos PROTO_ENCODE_DEBUG_PARAM,
|
||||||
|
uint32_t field_id, int32_t value) {
|
||||||
|
return encode_uint32_force(pos PROTO_ENCODE_DEBUG_ARG, field_id, encode_zigzag32(value));
|
||||||
|
}
|
||||||
|
[[nodiscard]] static inline uint8_t *encode_sint64(uint8_t *__restrict__ pos PROTO_ENCODE_DEBUG_PARAM,
|
||||||
|
uint32_t field_id, int64_t value) {
|
||||||
|
return encode_uint64(pos PROTO_ENCODE_DEBUG_ARG, field_id, encode_zigzag64(value));
|
||||||
|
}
|
||||||
|
[[nodiscard]] static inline uint8_t *encode_sint64_force(uint8_t *__restrict__ pos PROTO_ENCODE_DEBUG_PARAM,
|
||||||
|
uint32_t field_id, int64_t value) {
|
||||||
|
return encode_uint64_force(pos PROTO_ENCODE_DEBUG_ARG, field_id, encode_zigzag64(value));
|
||||||
|
}
|
||||||
|
/// Sub-message encoding: sync pos to buffer, delegate, read the cursor back.
|
||||||
template<typename T>
|
template<typename T>
|
||||||
static inline void encode_sub_message(uint8_t *__restrict__ &pos PROTO_ENCODE_DEBUG_PARAM, ProtoWriteBuffer &buffer,
|
[[nodiscard]] static inline uint8_t *encode_sub_message(uint8_t *__restrict__ pos PROTO_ENCODE_DEBUG_PARAM,
|
||||||
uint32_t field_id, const T &value) {
|
ProtoWriteBuffer &buffer, uint32_t field_id, const T &value) {
|
||||||
buffer.set_pos(pos);
|
buffer.set_pos(pos);
|
||||||
buffer.encode_sub_message(field_id, value);
|
buffer.encode_sub_message(field_id, value);
|
||||||
pos = buffer.get_pos();
|
return buffer.get_pos();
|
||||||
}
|
}
|
||||||
template<typename T>
|
template<typename T>
|
||||||
static inline void encode_optional_sub_message(uint8_t *__restrict__ &pos PROTO_ENCODE_DEBUG_PARAM,
|
[[nodiscard]] static inline uint8_t *encode_optional_sub_message(uint8_t *__restrict__ pos PROTO_ENCODE_DEBUG_PARAM,
|
||||||
ProtoWriteBuffer &buffer, uint32_t field_id, const T &value) {
|
ProtoWriteBuffer &buffer, uint32_t field_id,
|
||||||
|
const T &value) {
|
||||||
buffer.set_pos(pos);
|
buffer.set_pos(pos);
|
||||||
buffer.encode_optional_sub_message(field_id, value);
|
buffer.encode_optional_sub_message(field_id, value);
|
||||||
pos = buffer.get_pos();
|
return buffer.get_pos();
|
||||||
|
}
|
||||||
|
|
||||||
|
private:
|
||||||
|
/// Unaligned little endian store of four bytes: byte stores where the outlined helper lives (ESP-IDF, ARM
|
||||||
|
/// without unaligned access), otherwise a memcpy the compiler folds into one store. Callers bounds check
|
||||||
|
/// and advance the cursor themselves.
|
||||||
|
static inline void ESPHOME_ALWAYS_INLINE write_fixed32_le(uint8_t *__restrict__ pos, uint32_t value) {
|
||||||
|
if constexpr (PROTO_FIXED32_BYTE_STORES) {
|
||||||
|
// Spelled out so the outlined helper does not itself become a memcpy call
|
||||||
|
pos[0] = static_cast<uint8_t>(value);
|
||||||
|
pos[1] = static_cast<uint8_t>(value >> 8);
|
||||||
|
pos[2] = static_cast<uint8_t>(value >> 16);
|
||||||
|
pos[3] = static_cast<uint8_t>(value >> 24);
|
||||||
|
} else {
|
||||||
|
const uint32_t le = convert_little_endian(value);
|
||||||
|
__builtin_memcpy(pos, &le, 4);
|
||||||
|
}
|
||||||
}
|
}
|
||||||
};
|
};
|
||||||
|
#undef PROTO_OUTLINE_FOR_SIZE
|
||||||
|
#undef PROTO_FIXED32_BYTE_STORES
|
||||||
|
|
||||||
#ifdef HAS_PROTO_MESSAGE_DUMP
|
#ifdef HAS_PROTO_MESSAGE_DUMP
|
||||||
/**
|
/**
|
||||||
@@ -624,11 +692,12 @@ class DumpBuffer {
|
|||||||
|
|
||||||
class ProtoMessage {
|
class ProtoMessage {
|
||||||
public:
|
public:
|
||||||
// Non-virtual defaults for messages with no fields.
|
// Non-virtual defaults for messages with no fields; generated classes hide all four. The
|
||||||
// Concrete message classes hide these with their own implementations.
|
// static encode_msg/calc_size_msg take const void * so &T::encode_msg needs no thunk.
|
||||||
// All call sites use templates to preserve the concrete type, so virtual
|
static uint8_t *encode_msg(const void *self, ProtoWriteBuffer &buffer PROTO_ENCODE_DEBUG_PARAM) {
|
||||||
// dispatch is not needed. This eliminates per-message vtable entries for
|
return buffer.get_pos();
|
||||||
// encode/calculate_size, saving ~1.3 KB of flash across all message types.
|
}
|
||||||
|
static uint32_t calc_size_msg(const void *self) { return 0; }
|
||||||
uint8_t *encode(ProtoWriteBuffer &buffer PROTO_ENCODE_DEBUG_PARAM) const { return buffer.get_pos(); }
|
uint8_t *encode(ProtoWriteBuffer &buffer PROTO_ENCODE_DEBUG_PARAM) const { return buffer.get_pos(); }
|
||||||
uint32_t calculate_size() const { return 0; }
|
uint32_t calculate_size() const { return 0; }
|
||||||
#ifdef HAS_PROTO_MESSAGE_DUMP
|
#ifdef HAS_PROTO_MESSAGE_DUMP
|
||||||
@@ -876,19 +945,14 @@ class ProtoSize {
|
|||||||
|
|
||||||
// Implementation of methods that depend on ProtoSize being fully defined
|
// Implementation of methods that depend on ProtoSize being fully defined
|
||||||
|
|
||||||
// Encode thunk — converts void* back to concrete type for direct encode() call
|
|
||||||
template<typename T> uint8_t *proto_encode_msg(const void *msg, ProtoWriteBuffer &buf PROTO_ENCODE_DEBUG_PARAM) {
|
|
||||||
return static_cast<const T *>(msg)->encode(buf PROTO_ENCODE_DEBUG_ARG);
|
|
||||||
}
|
|
||||||
|
|
||||||
// Thin template wrapper; delegates to non-template core in proto.cpp.
|
// Thin template wrapper; delegates to non-template core in proto.cpp.
|
||||||
template<typename T> inline void ProtoWriteBuffer::encode_sub_message(uint32_t field_id, const T &value) {
|
template<typename T> inline void ProtoWriteBuffer::encode_sub_message(uint32_t field_id, const T &value) {
|
||||||
this->encode_sub_message(field_id, &value, &proto_encode_msg<T>);
|
this->encode_sub_message(field_id, &value, &T::encode_msg);
|
||||||
}
|
}
|
||||||
|
|
||||||
// Thin template wrapper; delegates to non-template core.
|
// Thin template wrapper; delegates to non-template core.
|
||||||
template<typename T> inline void ProtoWriteBuffer::encode_optional_sub_message(uint32_t field_id, const T &value) {
|
template<typename T> inline void ProtoWriteBuffer::encode_optional_sub_message(uint32_t field_id, const T &value) {
|
||||||
this->encode_optional_sub_message(field_id, value.calculate_size(), &value, &proto_encode_msg<T>);
|
this->encode_optional_sub_message(field_id, T::calc_size_msg(&value), &value, &T::encode_msg);
|
||||||
}
|
}
|
||||||
|
|
||||||
// Template decode_to_message - preserves concrete type so decode() resolves statically
|
// Template decode_to_message - preserves concrete type so decode() resolves statically
|
||||||
|
|||||||
@@ -9,10 +9,6 @@ namespace esphome::atm90e32 {
|
|||||||
|
|
||||||
static const char *const TAG = "atm90e32";
|
static const char *const TAG = "atm90e32";
|
||||||
|
|
||||||
static const LogString *offset_calibration_name(bool power_offsets) {
|
|
||||||
return power_offsets ? LOG_STR("Power offset") : LOG_STR("Offset");
|
|
||||||
}
|
|
||||||
|
|
||||||
static uint32_t pref_hash(const char *prefix, const char *name_space) {
|
static uint32_t pref_hash(const char *prefix, const char *name_space) {
|
||||||
auto hash = fnv1_hash(prefix);
|
auto hash = fnv1_hash(prefix);
|
||||||
return fnv1_hash_extend(hash, name_space);
|
return fnv1_hash_extend(hash, name_space);
|
||||||
@@ -207,12 +203,13 @@ void ATM90E32Component::setup() {
|
|||||||
|
|
||||||
// Initialize flash storage for power offset calibrations
|
// Initialize flash storage for power offset calibrations
|
||||||
uint32_t po_hash = pref_hash("_power_offset_calibration_", cs);
|
uint32_t po_hash = pref_hash("_power_offset_calibration_", cs);
|
||||||
this->power_offset_pref_ = global_preferences->make_preference<OffsetCalibration[3]>(po_hash, true);
|
this->power_offset_pref_ = global_preferences->make_preference<PowerOffsetCalibration[3]>(po_hash, true);
|
||||||
bool migrated_power_offset = false;
|
bool migrated_power_offset = false;
|
||||||
if (has_distinct_legacy_namespace) {
|
if (has_distinct_legacy_namespace) {
|
||||||
uint32_t legacy_po_hash = pref_hash("_power_offset_calibration_", legacy_cs);
|
uint32_t legacy_po_hash = pref_hash("_power_offset_calibration_", legacy_cs);
|
||||||
auto legacy_power_offset_pref = global_preferences->make_preference<OffsetCalibration[3]>(legacy_po_hash, true);
|
auto legacy_power_offset_pref =
|
||||||
OffsetCalibration power_offset_data[3]{};
|
global_preferences->make_preference<PowerOffsetCalibration[3]>(legacy_po_hash, true);
|
||||||
|
PowerOffsetCalibration power_offset_data[3]{};
|
||||||
int migration_status =
|
int migration_status =
|
||||||
migrate_legacy_pref_if_needed(this->power_offset_pref_, legacy_power_offset_pref, &power_offset_data);
|
migrate_legacy_pref_if_needed(this->power_offset_pref_, legacy_power_offset_pref, &power_offset_data);
|
||||||
migrated_power_offset = migration_status > 0;
|
migrated_power_offset = migration_status > 0;
|
||||||
@@ -227,20 +224,20 @@ void ATM90E32Component::setup() {
|
|||||||
global_preferences->sync();
|
global_preferences->sync();
|
||||||
}
|
}
|
||||||
|
|
||||||
this->restore_offset_calibrations_(OffsetCalibrationType::OFFSET_CALIBRATION_TYPE_VOLTAGE_CURRENT);
|
this->restore_offset_calibrations_();
|
||||||
this->restore_offset_calibrations_(OffsetCalibrationType::OFFSET_CALIBRATION_TYPE_POWER);
|
this->restore_power_offset_calibrations_();
|
||||||
} else {
|
} else {
|
||||||
ESP_LOGI(TAG, "[CALIBRATION][%s] Power & Voltage/Current offset calibration is disabled. Using config file values.",
|
ESP_LOGI(TAG, "[CALIBRATION][%s] Power & Voltage/Current offset calibration is disabled. Using config file values.",
|
||||||
cs);
|
cs);
|
||||||
for (uint8_t phase = 0; phase < 3; ++phase) {
|
for (uint8_t phase = 0; phase < 3; ++phase) {
|
||||||
this->write16_(this->voltage_offset_registers[phase],
|
this->write16_(this->voltage_offset_registers[phase],
|
||||||
static_cast<uint16_t>(this->offset_phase_[phase].first_offset));
|
static_cast<uint16_t>(this->offset_phase_[phase].voltage_offset_));
|
||||||
this->write16_(this->current_offset_registers[phase],
|
this->write16_(this->current_offset_registers[phase],
|
||||||
static_cast<uint16_t>(this->offset_phase_[phase].second_offset));
|
static_cast<uint16_t>(this->offset_phase_[phase].current_offset_));
|
||||||
this->write16_(this->power_offset_registers[phase],
|
this->write16_(this->power_offset_registers[phase],
|
||||||
static_cast<uint16_t>(this->power_offset_phase_[phase].first_offset));
|
static_cast<uint16_t>(this->power_offset_phase_[phase].active_power_offset));
|
||||||
this->write16_(this->reactive_power_offset_registers[phase],
|
this->write16_(this->reactive_power_offset_registers[phase],
|
||||||
static_cast<uint16_t>(this->power_offset_phase_[phase].second_offset));
|
static_cast<uint16_t>(this->power_offset_phase_[phase].reactive_power_offset));
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -320,8 +317,8 @@ void ATM90E32Component::log_calibration_status_() {
|
|||||||
cs);
|
cs);
|
||||||
for (uint8_t phase = 0; phase < 3; ++phase) {
|
for (uint8_t phase = 0; phase < 3; ++phase) {
|
||||||
ESP_LOGW(TAG, "[CALIBRATION][%s] | %c | %6d | %6d | %6d | %6d |", cs, 'A' + phase,
|
ESP_LOGW(TAG, "[CALIBRATION][%s] | %c | %6d | %6d | %6d | %6d |", cs, 'A' + phase,
|
||||||
this->config_offset_phase_[phase].first_offset, this->offset_phase_[phase].first_offset,
|
this->config_offset_phase_[phase].voltage_offset_, this->offset_phase_[phase].voltage_offset_,
|
||||||
this->config_offset_phase_[phase].second_offset, this->offset_phase_[phase].second_offset);
|
this->config_offset_phase_[phase].current_offset_, this->offset_phase_[phase].current_offset_);
|
||||||
}
|
}
|
||||||
ESP_LOGW(TAG,
|
ESP_LOGW(TAG,
|
||||||
"[CALIBRATION][%s] ===============================================================================", cs);
|
"[CALIBRATION][%s] ===============================================================================", cs);
|
||||||
@@ -338,8 +335,10 @@ void ATM90E32Component::log_calibration_status_() {
|
|||||||
cs);
|
cs);
|
||||||
for (uint8_t phase = 0; phase < 3; ++phase) {
|
for (uint8_t phase = 0; phase < 3; ++phase) {
|
||||||
ESP_LOGW(TAG, "[CALIBRATION][%s] | %c | %6d | %6d | %6d | %6d |", cs, 'A' + phase,
|
ESP_LOGW(TAG, "[CALIBRATION][%s] | %c | %6d | %6d | %6d | %6d |", cs, 'A' + phase,
|
||||||
this->config_power_offset_phase_[phase].first_offset, this->power_offset_phase_[phase].first_offset,
|
this->config_power_offset_phase_[phase].active_power_offset,
|
||||||
this->config_power_offset_phase_[phase].second_offset, this->power_offset_phase_[phase].second_offset);
|
this->power_offset_phase_[phase].active_power_offset,
|
||||||
|
this->config_power_offset_phase_[phase].reactive_power_offset,
|
||||||
|
this->power_offset_phase_[phase].reactive_power_offset);
|
||||||
}
|
}
|
||||||
ESP_LOGW(TAG,
|
ESP_LOGW(TAG,
|
||||||
"[CALIBRATION][%s] ===============================================================================", cs);
|
"[CALIBRATION][%s] ===============================================================================", cs);
|
||||||
@@ -373,7 +372,7 @@ void ATM90E32Component::log_calibration_status_() {
|
|||||||
ESP_LOGI(TAG, "[CALIBRATION][%s] --------------------------------------------------------------", cs);
|
ESP_LOGI(TAG, "[CALIBRATION][%s] --------------------------------------------------------------", cs);
|
||||||
for (uint8_t phase = 0; phase < 3; phase++) {
|
for (uint8_t phase = 0; phase < 3; phase++) {
|
||||||
ESP_LOGI(TAG, "[CALIBRATION][%s] | %c | %6d | %6d |", cs, 'A' + phase,
|
ESP_LOGI(TAG, "[CALIBRATION][%s] | %c | %6d | %6d |", cs, 'A' + phase,
|
||||||
this->offset_phase_[phase].first_offset, this->offset_phase_[phase].second_offset);
|
this->offset_phase_[phase].voltage_offset_, this->offset_phase_[phase].current_offset_);
|
||||||
}
|
}
|
||||||
ESP_LOGI(TAG, "[CALIBRATION][%s] ==============================================================\\n", cs);
|
ESP_LOGI(TAG, "[CALIBRATION][%s] ==============================================================\\n", cs);
|
||||||
}
|
}
|
||||||
@@ -386,7 +385,8 @@ void ATM90E32Component::log_calibration_status_() {
|
|||||||
ESP_LOGI(TAG, "[CALIBRATION][%s] ---------------------------------------------------------------------", cs);
|
ESP_LOGI(TAG, "[CALIBRATION][%s] ---------------------------------------------------------------------", cs);
|
||||||
for (uint8_t phase = 0; phase < 3; phase++) {
|
for (uint8_t phase = 0; phase < 3; phase++) {
|
||||||
ESP_LOGI(TAG, "[CALIBRATION][%s] | %c | %6d | %6d |", cs, 'A' + phase,
|
ESP_LOGI(TAG, "[CALIBRATION][%s] | %c | %6d | %6d |", cs, 'A' + phase,
|
||||||
this->power_offset_phase_[phase].first_offset, this->power_offset_phase_[phase].second_offset);
|
this->power_offset_phase_[phase].active_power_offset,
|
||||||
|
this->power_offset_phase_[phase].reactive_power_offset);
|
||||||
}
|
}
|
||||||
ESP_LOGI(TAG, "[CALIBRATION][%s] =====================================================================\n", cs);
|
ESP_LOGI(TAG, "[CALIBRATION][%s] =====================================================================\n", cs);
|
||||||
}
|
}
|
||||||
@@ -756,68 +756,36 @@ void ATM90E32Component::save_gain_calibration_to_memory_() {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
void ATM90E32Component::finish_offset_calibration_(const OffsetCalibration (&previous)[3], bool previous_restored,
|
void ATM90E32Component::save_offset_calibration_to_memory_() {
|
||||||
bool previous_using_saved, OffsetCalibrationType type) {
|
|
||||||
const bool power_offsets = type == OffsetCalibrationType::OFFSET_CALIBRATION_TYPE_POWER;
|
|
||||||
const char *cs = this->get_calibration_id_();
|
const char *cs = this->get_calibration_id_();
|
||||||
const LogString *name = offset_calibration_name(power_offsets);
|
bool success = this->offset_pref_.save(&this->offset_phase_);
|
||||||
OffsetCalibration(*offsets)[3] = power_offsets ? &this->power_offset_phase_ : &this->offset_phase_;
|
global_preferences->sync();
|
||||||
ESPPreferenceObject *preference = power_offsets ? &this->power_offset_pref_ : &this->offset_pref_;
|
if (success) {
|
||||||
bool *has_stored =
|
|
||||||
power_offsets ? &this->has_stored_power_offset_calibration_ : &this->has_stored_offset_calibration_;
|
|
||||||
bool *restored = power_offsets ? &this->restored_power_offset_calibration_ : &this->restored_offset_calibration_;
|
|
||||||
bool *mismatches = power_offsets ? this->power_offset_calibration_mismatch_ : this->offset_calibration_mismatch_;
|
|
||||||
|
|
||||||
const bool writes_verified = this->verify_offset_writes_(type);
|
|
||||||
bool saved = false;
|
|
||||||
bool synced = false;
|
|
||||||
if (writes_verified) {
|
|
||||||
saved = preference->save(offsets);
|
|
||||||
synced = global_preferences->sync();
|
|
||||||
}
|
|
||||||
|
|
||||||
if (writes_verified && saved && synced) {
|
|
||||||
this->using_saved_calibrations_ = true;
|
this->using_saved_calibrations_ = true;
|
||||||
*has_stored = true;
|
this->restored_offset_calibration_ = true;
|
||||||
*restored = true;
|
for (bool &phase : this->offset_calibration_mismatch_)
|
||||||
for (uint8_t phase = 0; phase < 3; phase++)
|
phase = false;
|
||||||
mismatches[phase] = false;
|
ESP_LOGI(TAG, "[CALIBRATION][%s] Offset calibration saved to memory.", cs);
|
||||||
ESP_LOGI(TAG, "[CALIBRATION][%s] %s calibration saved to memory. %s calibration completed and verified.", cs,
|
} else {
|
||||||
LOG_STR_ARG(name), LOG_STR_ARG(name));
|
this->using_saved_calibrations_ = false;
|
||||||
return;
|
ESP_LOGE(TAG, "[CALIBRATION][%s] Failed to save offset calibration to memory!", cs);
|
||||||
}
|
}
|
||||||
|
}
|
||||||
|
|
||||||
if (writes_verified) {
|
void ATM90E32Component::save_power_offset_calibration_to_memory_() {
|
||||||
ESP_LOGE(TAG, "[CALIBRATION][%s] Failed to save %s calibration to memory!", cs, LOG_STR_ARG(name));
|
const char *cs = this->get_calibration_id_();
|
||||||
|
bool success = this->power_offset_pref_.save(&this->power_offset_phase_);
|
||||||
|
global_preferences->sync();
|
||||||
|
if (success) {
|
||||||
|
this->using_saved_calibrations_ = true;
|
||||||
|
this->restored_power_offset_calibration_ = true;
|
||||||
|
for (bool &phase : this->power_offset_calibration_mismatch_)
|
||||||
|
phase = false;
|
||||||
|
ESP_LOGI(TAG, "[CALIBRATION][%s] Power offset calibration saved to memory.", cs);
|
||||||
|
} else {
|
||||||
|
this->using_saved_calibrations_ = false;
|
||||||
|
ESP_LOGE(TAG, "[CALIBRATION][%s] Failed to save power offset calibration to memory!", cs);
|
||||||
}
|
}
|
||||||
|
|
||||||
for (uint8_t phase = 0; phase < 3; phase++) {
|
|
||||||
this->write_offsets_to_registers_(phase, previous[phase].first_offset, previous[phase].second_offset, type);
|
|
||||||
}
|
|
||||||
const bool rollback_verified = this->verify_offset_writes_(type);
|
|
||||||
|
|
||||||
bool rollback_persisted = false;
|
|
||||||
if (writes_verified) {
|
|
||||||
OffsetCalibration rollback[3]{};
|
|
||||||
prepare_offset_rollback(previous, previous_restored, rollback);
|
|
||||||
const bool rollback_saved = preference->save(&rollback);
|
|
||||||
const bool rollback_synced = global_preferences->sync();
|
|
||||||
rollback_persisted = rollback_saved && rollback_synced;
|
|
||||||
if (!rollback_saved || !rollback_synced) {
|
|
||||||
ESP_LOGE(TAG, "[CALIBRATION][%s] Failed to persist restored %s calibration values!", cs, LOG_STR_ARG(name));
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
*restored = previous_restored;
|
|
||||||
if (rollback_persisted)
|
|
||||||
*has_stored = previous_restored;
|
|
||||||
this->using_saved_calibrations_ = previous_using_saved;
|
|
||||||
if (!rollback_verified) {
|
|
||||||
ESP_LOGE(TAG, "[CALIBRATION][%s] %s calibration failed; rollback readback verification failed.", cs,
|
|
||||||
LOG_STR_ARG(name));
|
|
||||||
return;
|
|
||||||
}
|
|
||||||
ESP_LOGE(TAG, "[CALIBRATION][%s] %s calibration failed; previous values restored.", cs, LOG_STR_ARG(name));
|
|
||||||
}
|
}
|
||||||
|
|
||||||
void ATM90E32Component::run_offset_calibrations() {
|
void ATM90E32Component::run_offset_calibrations() {
|
||||||
@@ -835,16 +803,11 @@ void ATM90E32Component::run_offset_calibrations() {
|
|||||||
ESP_LOGI(TAG, "[CALIBRATION][%s] | Phase | offset_voltage | offset_current |", cs);
|
ESP_LOGI(TAG, "[CALIBRATION][%s] | Phase | offset_voltage | offset_current |", cs);
|
||||||
ESP_LOGI(TAG, "[CALIBRATION][%s] ------------------------------------------------------------------", cs);
|
ESP_LOGI(TAG, "[CALIBRATION][%s] ------------------------------------------------------------------", cs);
|
||||||
|
|
||||||
OffsetCalibration previous_offsets[3] = {this->offset_phase_[0], this->offset_phase_[1], this->offset_phase_[2]};
|
|
||||||
const bool previous_restored = this->restored_offset_calibration_;
|
|
||||||
const bool previous_using_saved = this->using_saved_calibrations_;
|
|
||||||
|
|
||||||
for (uint8_t phase = 0; phase < 3; phase++) {
|
for (uint8_t phase = 0; phase < 3; phase++) {
|
||||||
int16_t voltage_offset = calibrate_offset(phase, true);
|
int16_t voltage_offset = calibrate_offset(phase, true);
|
||||||
int16_t current_offset = calibrate_offset(phase, false);
|
int16_t current_offset = calibrate_offset(phase, false);
|
||||||
|
|
||||||
this->write_offsets_to_registers_(phase, voltage_offset, current_offset,
|
this->write_offsets_to_registers_(phase, voltage_offset, current_offset);
|
||||||
OffsetCalibrationType::OFFSET_CALIBRATION_TYPE_VOLTAGE_CURRENT);
|
|
||||||
|
|
||||||
ESP_LOGI(TAG, "[CALIBRATION][%s] | %c | %6d | %6d |", cs, 'A' + phase, voltage_offset,
|
ESP_LOGI(TAG, "[CALIBRATION][%s] | %c | %6d | %6d |", cs, 'A' + phase, voltage_offset,
|
||||||
current_offset);
|
current_offset);
|
||||||
@@ -852,8 +815,7 @@ void ATM90E32Component::run_offset_calibrations() {
|
|||||||
|
|
||||||
ESP_LOGI(TAG, "[CALIBRATION][%s] ==================================================================\n", cs);
|
ESP_LOGI(TAG, "[CALIBRATION][%s] ==================================================================\n", cs);
|
||||||
|
|
||||||
this->finish_offset_calibration_(previous_offsets, previous_restored, previous_using_saved,
|
this->save_offset_calibration_to_memory_();
|
||||||
OffsetCalibrationType::OFFSET_CALIBRATION_TYPE_VOLTAGE_CURRENT);
|
|
||||||
}
|
}
|
||||||
|
|
||||||
void ATM90E32Component::run_power_offset_calibrations() {
|
void ATM90E32Component::run_power_offset_calibrations() {
|
||||||
@@ -872,25 +834,18 @@ void ATM90E32Component::run_power_offset_calibrations() {
|
|||||||
ESP_LOGI(TAG, "[CALIBRATION][%s] | Phase | offset_active_power | offset_reactive_power |", cs);
|
ESP_LOGI(TAG, "[CALIBRATION][%s] | Phase | offset_active_power | offset_reactive_power |", cs);
|
||||||
ESP_LOGI(TAG, "[CALIBRATION][%s] ---------------------------------------------------------------------", cs);
|
ESP_LOGI(TAG, "[CALIBRATION][%s] ---------------------------------------------------------------------", cs);
|
||||||
|
|
||||||
OffsetCalibration previous_offsets[3] = {this->power_offset_phase_[0], this->power_offset_phase_[1],
|
|
||||||
this->power_offset_phase_[2]};
|
|
||||||
const bool previous_restored = this->restored_power_offset_calibration_;
|
|
||||||
const bool previous_using_saved = this->using_saved_calibrations_;
|
|
||||||
|
|
||||||
for (uint8_t phase = 0; phase < 3; ++phase) {
|
for (uint8_t phase = 0; phase < 3; ++phase) {
|
||||||
int16_t active_offset = calibrate_power_offset(phase, false);
|
int16_t active_offset = calibrate_power_offset(phase, false);
|
||||||
int16_t reactive_offset = calibrate_power_offset(phase, true);
|
int16_t reactive_offset = calibrate_power_offset(phase, true);
|
||||||
|
|
||||||
this->write_offsets_to_registers_(phase, active_offset, reactive_offset,
|
this->write_power_offsets_to_registers_(phase, active_offset, reactive_offset);
|
||||||
OffsetCalibrationType::OFFSET_CALIBRATION_TYPE_POWER);
|
|
||||||
|
|
||||||
ESP_LOGI(TAG, "[CALIBRATION][%s] | %c | %6d | %6d |", cs, 'A' + phase, active_offset,
|
ESP_LOGI(TAG, "[CALIBRATION][%s] | %c | %6d | %6d |", cs, 'A' + phase, active_offset,
|
||||||
reactive_offset);
|
reactive_offset);
|
||||||
}
|
}
|
||||||
ESP_LOGI(TAG, "[CALIBRATION][%s] =====================================================================\n", cs);
|
ESP_LOGI(TAG, "[CALIBRATION][%s] =====================================================================\n", cs);
|
||||||
|
|
||||||
this->finish_offset_calibration_(previous_offsets, previous_restored, previous_using_saved,
|
this->save_power_offset_calibration_to_memory_();
|
||||||
OffsetCalibrationType::OFFSET_CALIBRATION_TYPE_POWER);
|
|
||||||
}
|
}
|
||||||
|
|
||||||
void ATM90E32Component::write_gains_to_registers_() {
|
void ATM90E32Component::write_gains_to_registers_() {
|
||||||
@@ -904,26 +859,35 @@ void ATM90E32Component::write_gains_to_registers_() {
|
|||||||
this->write16_(ATM90E32_REGISTER_CFGREGACCEN, 0x0000);
|
this->write16_(ATM90E32_REGISTER_CFGREGACCEN, 0x0000);
|
||||||
}
|
}
|
||||||
|
|
||||||
void ATM90E32Component::write_offsets_to_registers_(uint8_t phase, int16_t first_offset, int16_t second_offset,
|
void ATM90E32Component::write_offsets_to_registers_(uint8_t phase, int16_t voltage_offset, int16_t current_offset) {
|
||||||
OffsetCalibrationType type) {
|
// Save to runtime
|
||||||
const bool power_offsets = type == OffsetCalibrationType::OFFSET_CALIBRATION_TYPE_POWER;
|
this->offset_phase_[phase].voltage_offset_ = voltage_offset;
|
||||||
OffsetCalibration &offsets = power_offsets ? this->power_offset_phase_[phase] : this->offset_phase_[phase];
|
this->phase_[phase].voltage_offset_ = voltage_offset;
|
||||||
offsets.first_offset = first_offset;
|
|
||||||
offsets.second_offset = second_offset;
|
|
||||||
if (power_offsets) {
|
|
||||||
this->phase_[phase].active_power_offset_ = first_offset;
|
|
||||||
this->phase_[phase].reactive_power_offset_ = second_offset;
|
|
||||||
} else {
|
|
||||||
this->phase_[phase].voltage_offset_ = first_offset;
|
|
||||||
this->phase_[phase].current_offset_ = second_offset;
|
|
||||||
}
|
|
||||||
|
|
||||||
const uint16_t *first_registers = power_offsets ? this->power_offset_registers : this->voltage_offset_registers;
|
// Save to flash-storable struct
|
||||||
const uint16_t *second_registers =
|
this->offset_phase_[phase].current_offset_ = current_offset;
|
||||||
power_offsets ? this->reactive_power_offset_registers : this->current_offset_registers;
|
this->phase_[phase].current_offset_ = current_offset;
|
||||||
|
|
||||||
|
// Write to registers
|
||||||
this->write16_(ATM90E32_REGISTER_CFGREGACCEN, 0x55AA);
|
this->write16_(ATM90E32_REGISTER_CFGREGACCEN, 0x55AA);
|
||||||
this->write16_(first_registers[phase], static_cast<uint16_t>(first_offset));
|
this->write16_(voltage_offset_registers[phase], static_cast<uint16_t>(voltage_offset));
|
||||||
this->write16_(second_registers[phase], static_cast<uint16_t>(second_offset));
|
this->write16_(current_offset_registers[phase], static_cast<uint16_t>(current_offset));
|
||||||
|
this->write16_(ATM90E32_REGISTER_CFGREGACCEN, 0x0000);
|
||||||
|
}
|
||||||
|
|
||||||
|
void ATM90E32Component::write_power_offsets_to_registers_(uint8_t phase, int16_t p_offset, int16_t q_offset) {
|
||||||
|
// Save to runtime
|
||||||
|
this->phase_[phase].active_power_offset_ = p_offset;
|
||||||
|
this->phase_[phase].reactive_power_offset_ = q_offset;
|
||||||
|
|
||||||
|
// Save to flash-storable struct
|
||||||
|
this->power_offset_phase_[phase].active_power_offset = p_offset;
|
||||||
|
this->power_offset_phase_[phase].reactive_power_offset = q_offset;
|
||||||
|
|
||||||
|
// Write to registers
|
||||||
|
this->write16_(ATM90E32_REGISTER_CFGREGACCEN, 0x55AA);
|
||||||
|
this->write16_(this->power_offset_registers[phase], static_cast<uint16_t>(p_offset));
|
||||||
|
this->write16_(this->reactive_power_offset_registers[phase], static_cast<uint16_t>(q_offset));
|
||||||
this->write16_(ATM90E32_REGISTER_CFGREGACCEN, 0x0000);
|
this->write16_(ATM90E32_REGISTER_CFGREGACCEN, 0x0000);
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -983,78 +947,89 @@ void ATM90E32Component::restore_gain_calibrations_() {
|
|||||||
ESP_LOGW(TAG, "[CALIBRATION][%s] No stored gain calibrations found. Using config file values.", cs);
|
ESP_LOGW(TAG, "[CALIBRATION][%s] No stored gain calibrations found. Using config file values.", cs);
|
||||||
}
|
}
|
||||||
|
|
||||||
void ATM90E32Component::restore_offset_calibrations_(OffsetCalibrationType type) {
|
void ATM90E32Component::restore_offset_calibrations_() {
|
||||||
const bool power_offsets = type == OffsetCalibrationType::OFFSET_CALIBRATION_TYPE_POWER;
|
|
||||||
const char *cs = this->get_calibration_id_();
|
const char *cs = this->get_calibration_id_();
|
||||||
const LogString *name = power_offsets ? LOG_STR("power offset") : LOG_STR("offset");
|
|
||||||
OffsetCalibration(*offsets)[3] = power_offsets ? &this->power_offset_phase_ : &this->offset_phase_;
|
|
||||||
OffsetCalibration(*config_offsets)[3] =
|
|
||||||
power_offsets ? &this->config_power_offset_phase_ : &this->config_offset_phase_;
|
|
||||||
ESPPreferenceObject *preference = power_offsets ? &this->power_offset_pref_ : &this->offset_pref_;
|
|
||||||
bool *has_stored =
|
|
||||||
power_offsets ? &this->has_stored_power_offset_calibration_ : &this->has_stored_offset_calibration_;
|
|
||||||
bool *restored = power_offsets ? &this->restored_power_offset_calibration_ : &this->restored_offset_calibration_;
|
|
||||||
bool *mismatches = power_offsets ? this->power_offset_calibration_mismatch_ : this->offset_calibration_mismatch_;
|
|
||||||
const bool *has_first = power_offsets ? this->has_config_active_power_offset_ : this->has_config_voltage_offset_;
|
|
||||||
const bool *has_second = power_offsets ? this->has_config_reactive_power_offset_ : this->has_config_current_offset_;
|
|
||||||
|
|
||||||
for (uint8_t i = 0; i < 3; ++i)
|
for (uint8_t i = 0; i < 3; ++i)
|
||||||
(*config_offsets)[i] = (*offsets)[i];
|
this->config_offset_phase_[i] = this->offset_phase_[i];
|
||||||
|
|
||||||
|
bool have_data = this->offset_pref_.load(&this->offset_phase_);
|
||||||
|
|
||||||
const bool have_data = preference->load(offsets);
|
|
||||||
bool all_zero = true;
|
bool all_zero = true;
|
||||||
if (have_data) {
|
if (have_data) {
|
||||||
for (const auto &phase : *offsets) {
|
for (auto &phase : this->offset_phase_) {
|
||||||
if (phase.first_offset != 0 || phase.second_offset != 0) {
|
if (phase.voltage_offset_ != 0 || phase.current_offset_ != 0) {
|
||||||
all_zero = false;
|
all_zero = false;
|
||||||
break;
|
break;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
*has_stored = have_data && !all_zero;
|
if (have_data && !all_zero) {
|
||||||
*restored = false;
|
this->restored_offset_calibration_ = true;
|
||||||
|
for (uint8_t phase = 0; phase < 3; phase++) {
|
||||||
|
auto &offset = this->offset_phase_[phase];
|
||||||
|
bool mismatch = false;
|
||||||
|
if (this->has_config_voltage_offset_[phase] &&
|
||||||
|
offset.voltage_offset_ != this->config_offset_phase_[phase].voltage_offset_)
|
||||||
|
mismatch = true;
|
||||||
|
if (this->has_config_current_offset_[phase] &&
|
||||||
|
offset.current_offset_ != this->config_offset_phase_[phase].current_offset_)
|
||||||
|
mismatch = true;
|
||||||
|
if (mismatch)
|
||||||
|
this->offset_calibration_mismatch_[phase] = true;
|
||||||
|
}
|
||||||
|
} else {
|
||||||
|
for (uint8_t phase = 0; phase < 3; phase++)
|
||||||
|
this->offset_phase_[phase] = this->config_offset_phase_[phase];
|
||||||
|
ESP_LOGW(TAG, "[CALIBRATION][%s] No stored offset calibrations found. Using default values.", cs);
|
||||||
|
}
|
||||||
|
|
||||||
for (uint8_t phase = 0; phase < 3; phase++) {
|
for (uint8_t phase = 0; phase < 3; phase++) {
|
||||||
mismatches[phase] = false;
|
write_offsets_to_registers_(phase, this->offset_phase_[phase].voltage_offset_,
|
||||||
if (*has_stored) {
|
this->offset_phase_[phase].current_offset_);
|
||||||
mismatches[phase] =
|
}
|
||||||
(has_first[phase] && (*offsets)[phase].first_offset != (*config_offsets)[phase].first_offset) ||
|
}
|
||||||
(has_second[phase] && (*offsets)[phase].second_offset != (*config_offsets)[phase].second_offset);
|
|
||||||
|
void ATM90E32Component::restore_power_offset_calibrations_() {
|
||||||
|
const char *cs = this->get_calibration_id_();
|
||||||
|
for (uint8_t i = 0; i < 3; ++i)
|
||||||
|
this->config_power_offset_phase_[i] = this->power_offset_phase_[i];
|
||||||
|
|
||||||
|
bool have_data = this->power_offset_pref_.load(&this->power_offset_phase_);
|
||||||
|
|
||||||
|
bool all_zero = true;
|
||||||
|
if (have_data) {
|
||||||
|
for (auto &phase : this->power_offset_phase_) {
|
||||||
|
if (phase.active_power_offset != 0 || phase.reactive_power_offset != 0) {
|
||||||
|
all_zero = false;
|
||||||
|
break;
|
||||||
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
if (!*has_stored) {
|
if (have_data && !all_zero) {
|
||||||
for (uint8_t phase = 0; phase < 3; phase++)
|
this->restored_power_offset_calibration_ = true;
|
||||||
(*offsets)[phase] = (*config_offsets)[phase];
|
for (uint8_t phase = 0; phase < 3; ++phase) {
|
||||||
ESP_LOGW(TAG, "[CALIBRATION][%s] No stored %s calibrations found. Using default values.", cs, LOG_STR_ARG(name));
|
auto &offset = this->power_offset_phase_[phase];
|
||||||
}
|
bool mismatch = false;
|
||||||
|
if (this->has_config_active_power_offset_[phase] &&
|
||||||
for (uint8_t phase = 0; phase < 3; phase++) {
|
offset.active_power_offset != this->config_power_offset_phase_[phase].active_power_offset)
|
||||||
this->write_offsets_to_registers_(phase, (*offsets)[phase].first_offset, (*offsets)[phase].second_offset, type);
|
mismatch = true;
|
||||||
}
|
if (this->has_config_reactive_power_offset_[phase] &&
|
||||||
const bool initial_values_verified = this->verify_offset_writes_(type);
|
offset.reactive_power_offset != this->config_power_offset_phase_[phase].reactive_power_offset)
|
||||||
if (initial_values_verified) {
|
mismatch = true;
|
||||||
const auto state = resolve_offset_restore_state(*has_stored, true, false);
|
if (mismatch)
|
||||||
*restored = state.restored;
|
this->power_offset_calibration_mismatch_[phase] = true;
|
||||||
ESP_LOGI(TAG, "[CALIBRATION][%s] %s calibration values verified.", cs, LOG_STR_ARG(name));
|
}
|
||||||
return;
|
|
||||||
}
|
|
||||||
|
|
||||||
this->using_saved_calibrations_ = false;
|
|
||||||
for (uint8_t phase = 0; phase < 3; phase++)
|
|
||||||
mismatches[phase] = false;
|
|
||||||
for (uint8_t phase = 0; phase < 3; phase++) {
|
|
||||||
(*offsets)[phase] = (*config_offsets)[phase];
|
|
||||||
this->write_offsets_to_registers_(phase, (*offsets)[phase].first_offset, (*offsets)[phase].second_offset, type);
|
|
||||||
}
|
|
||||||
const auto state = resolve_offset_restore_state(*has_stored, false, this->verify_offset_writes_(type));
|
|
||||||
*restored = state.restored;
|
|
||||||
if (state.values_verified) {
|
|
||||||
ESP_LOGE(TAG, "[CALIBRATION][%s] %s calibration restore failed verification; config values verified.", cs,
|
|
||||||
LOG_STR_ARG(name));
|
|
||||||
} else {
|
} else {
|
||||||
ESP_LOGE(TAG, "[CALIBRATION][%s] %s calibration restore and config fallback both failed verification.", cs,
|
for (uint8_t phase = 0; phase < 3; ++phase)
|
||||||
LOG_STR_ARG(name));
|
this->power_offset_phase_[phase] = this->config_power_offset_phase_[phase];
|
||||||
|
ESP_LOGW(TAG, "[CALIBRATION][%s] No stored power offsets found. Using default values.", cs);
|
||||||
|
}
|
||||||
|
|
||||||
|
for (uint8_t phase = 0; phase < 3; ++phase) {
|
||||||
|
write_power_offsets_to_registers_(phase, this->power_offset_phase_[phase].active_power_offset,
|
||||||
|
this->power_offset_phase_[phase].reactive_power_offset);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -1109,14 +1084,14 @@ void ATM90E32Component::clear_gain_calibrations() {
|
|||||||
|
|
||||||
void ATM90E32Component::clear_offset_calibrations() {
|
void ATM90E32Component::clear_offset_calibrations() {
|
||||||
const char *cs = this->get_calibration_id_();
|
const char *cs = this->get_calibration_id_();
|
||||||
if (!this->has_stored_offset_calibration_) {
|
if (!this->restored_offset_calibration_) {
|
||||||
ESP_LOGI(TAG, "[CALIBRATION][%s] No stored offset calibrations to clear. Current values:", cs);
|
ESP_LOGI(TAG, "[CALIBRATION][%s] No stored offset calibrations to clear. Current values:", cs);
|
||||||
ESP_LOGI(TAG, "[CALIBRATION][%s] --------------------------------------------------------------", cs);
|
ESP_LOGI(TAG, "[CALIBRATION][%s] --------------------------------------------------------------", cs);
|
||||||
ESP_LOGI(TAG, "[CALIBRATION][%s] | Phase | offset_voltage | offset_current |", cs);
|
ESP_LOGI(TAG, "[CALIBRATION][%s] | Phase | offset_voltage | offset_current |", cs);
|
||||||
ESP_LOGI(TAG, "[CALIBRATION][%s] --------------------------------------------------------------", cs);
|
ESP_LOGI(TAG, "[CALIBRATION][%s] --------------------------------------------------------------", cs);
|
||||||
for (uint8_t phase = 0; phase < 3; phase++) {
|
for (uint8_t phase = 0; phase < 3; phase++) {
|
||||||
ESP_LOGI(TAG, "[CALIBRATION][%s] | %c | %6d | %6d |", cs, 'A' + phase,
|
ESP_LOGI(TAG, "[CALIBRATION][%s] | %c | %6d | %6d |", cs, 'A' + phase,
|
||||||
this->offset_phase_[phase].first_offset, this->offset_phase_[phase].second_offset);
|
this->offset_phase_[phase].voltage_offset_, this->offset_phase_[phase].current_offset_);
|
||||||
}
|
}
|
||||||
ESP_LOGI(TAG, "[CALIBRATION][%s] ==============================================================\n", cs);
|
ESP_LOGI(TAG, "[CALIBRATION][%s] ==============================================================\n", cs);
|
||||||
return;
|
return;
|
||||||
@@ -1129,11 +1104,10 @@ void ATM90E32Component::clear_offset_calibrations() {
|
|||||||
|
|
||||||
for (uint8_t phase = 0; phase < 3; phase++) {
|
for (uint8_t phase = 0; phase < 3; phase++) {
|
||||||
int16_t voltage_offset =
|
int16_t voltage_offset =
|
||||||
this->has_config_voltage_offset_[phase] ? this->config_offset_phase_[phase].first_offset : 0;
|
this->has_config_voltage_offset_[phase] ? this->config_offset_phase_[phase].voltage_offset_ : 0;
|
||||||
int16_t current_offset =
|
int16_t current_offset =
|
||||||
this->has_config_current_offset_[phase] ? this->config_offset_phase_[phase].second_offset : 0;
|
this->has_config_current_offset_[phase] ? this->config_offset_phase_[phase].current_offset_ : 0;
|
||||||
this->write_offsets_to_registers_(phase, voltage_offset, current_offset,
|
this->write_offsets_to_registers_(phase, voltage_offset, current_offset);
|
||||||
OffsetCalibrationType::OFFSET_CALIBRATION_TYPE_VOLTAGE_CURRENT);
|
|
||||||
ESP_LOGI(TAG, "[CALIBRATION][%s] | %c | %6d | %6d |", cs, 'A' + phase, voltage_offset,
|
ESP_LOGI(TAG, "[CALIBRATION][%s] | %c | %6d | %6d |", cs, 'A' + phase, voltage_offset,
|
||||||
current_offset);
|
current_offset);
|
||||||
}
|
}
|
||||||
@@ -1143,7 +1117,6 @@ void ATM90E32Component::clear_offset_calibrations() {
|
|||||||
this->offset_pref_.save(&zero_offsets); // Clear stored values in flash
|
this->offset_pref_.save(&zero_offsets); // Clear stored values in flash
|
||||||
global_preferences->sync();
|
global_preferences->sync();
|
||||||
|
|
||||||
this->has_stored_offset_calibration_ = false;
|
|
||||||
this->restored_offset_calibration_ = false;
|
this->restored_offset_calibration_ = false;
|
||||||
for (bool &phase : this->offset_calibration_mismatch_)
|
for (bool &phase : this->offset_calibration_mismatch_)
|
||||||
phase = false;
|
phase = false;
|
||||||
@@ -1153,14 +1126,15 @@ void ATM90E32Component::clear_offset_calibrations() {
|
|||||||
|
|
||||||
void ATM90E32Component::clear_power_offset_calibrations() {
|
void ATM90E32Component::clear_power_offset_calibrations() {
|
||||||
const char *cs = this->get_calibration_id_();
|
const char *cs = this->get_calibration_id_();
|
||||||
if (!this->has_stored_power_offset_calibration_) {
|
if (!this->restored_power_offset_calibration_) {
|
||||||
ESP_LOGI(TAG, "[CALIBRATION][%s] No stored power offsets to clear. Current values:", cs);
|
ESP_LOGI(TAG, "[CALIBRATION][%s] No stored power offsets to clear. Current values:", cs);
|
||||||
ESP_LOGI(TAG, "[CALIBRATION][%s] ---------------------------------------------------------------------", cs);
|
ESP_LOGI(TAG, "[CALIBRATION][%s] ---------------------------------------------------------------------", cs);
|
||||||
ESP_LOGI(TAG, "[CALIBRATION][%s] | Phase | offset_active_power | offset_reactive_power |", cs);
|
ESP_LOGI(TAG, "[CALIBRATION][%s] | Phase | offset_active_power | offset_reactive_power |", cs);
|
||||||
ESP_LOGI(TAG, "[CALIBRATION][%s] ---------------------------------------------------------------------", cs);
|
ESP_LOGI(TAG, "[CALIBRATION][%s] ---------------------------------------------------------------------", cs);
|
||||||
for (uint8_t phase = 0; phase < 3; phase++) {
|
for (uint8_t phase = 0; phase < 3; phase++) {
|
||||||
ESP_LOGI(TAG, "[CALIBRATION][%s] | %c | %6d | %6d |", cs, 'A' + phase,
|
ESP_LOGI(TAG, "[CALIBRATION][%s] | %c | %6d | %6d |", cs, 'A' + phase,
|
||||||
this->power_offset_phase_[phase].first_offset, this->power_offset_phase_[phase].second_offset);
|
this->power_offset_phase_[phase].active_power_offset,
|
||||||
|
this->power_offset_phase_[phase].reactive_power_offset);
|
||||||
}
|
}
|
||||||
ESP_LOGI(TAG, "[CALIBRATION][%s] =====================================================================\n", cs);
|
ESP_LOGI(TAG, "[CALIBRATION][%s] =====================================================================\n", cs);
|
||||||
return;
|
return;
|
||||||
@@ -1173,21 +1147,20 @@ void ATM90E32Component::clear_power_offset_calibrations() {
|
|||||||
|
|
||||||
for (uint8_t phase = 0; phase < 3; phase++) {
|
for (uint8_t phase = 0; phase < 3; phase++) {
|
||||||
int16_t active_offset =
|
int16_t active_offset =
|
||||||
this->has_config_active_power_offset_[phase] ? this->config_power_offset_phase_[phase].first_offset : 0;
|
this->has_config_active_power_offset_[phase] ? this->config_power_offset_phase_[phase].active_power_offset : 0;
|
||||||
int16_t reactive_offset =
|
int16_t reactive_offset = this->has_config_reactive_power_offset_[phase]
|
||||||
this->has_config_reactive_power_offset_[phase] ? this->config_power_offset_phase_[phase].second_offset : 0;
|
? this->config_power_offset_phase_[phase].reactive_power_offset
|
||||||
this->write_offsets_to_registers_(phase, active_offset, reactive_offset,
|
: 0;
|
||||||
OffsetCalibrationType::OFFSET_CALIBRATION_TYPE_POWER);
|
this->write_power_offsets_to_registers_(phase, active_offset, reactive_offset);
|
||||||
ESP_LOGI(TAG, "[CALIBRATION][%s] | %c | %6d | %6d |", cs, 'A' + phase, active_offset,
|
ESP_LOGI(TAG, "[CALIBRATION][%s] | %c | %6d | %6d |", cs, 'A' + phase, active_offset,
|
||||||
reactive_offset);
|
reactive_offset);
|
||||||
}
|
}
|
||||||
ESP_LOGI(TAG, "[CALIBRATION][%s] =====================================================================\n", cs);
|
ESP_LOGI(TAG, "[CALIBRATION][%s] =====================================================================\n", cs);
|
||||||
|
|
||||||
OffsetCalibration zero_power_offsets[3]{{0, 0}, {0, 0}, {0, 0}};
|
PowerOffsetCalibration zero_power_offsets[3]{{0, 0}, {0, 0}, {0, 0}};
|
||||||
this->power_offset_pref_.save(&zero_power_offsets);
|
this->power_offset_pref_.save(&zero_power_offsets);
|
||||||
global_preferences->sync();
|
global_preferences->sync();
|
||||||
|
|
||||||
this->has_stored_power_offset_calibration_ = false;
|
|
||||||
this->restored_power_offset_calibration_ = false;
|
this->restored_power_offset_calibration_ = false;
|
||||||
for (bool &phase : this->power_offset_calibration_mismatch_)
|
for (bool &phase : this->power_offset_calibration_mismatch_)
|
||||||
phase = false;
|
phase = false;
|
||||||
@@ -1242,31 +1215,6 @@ bool ATM90E32Component::verify_gain_writes_() {
|
|||||||
return success; // Return true if all writes were successful, false otherwise
|
return success; // Return true if all writes were successful, false otherwise
|
||||||
}
|
}
|
||||||
|
|
||||||
bool ATM90E32Component::verify_offset_writes_(OffsetCalibrationType type) {
|
|
||||||
const bool power_offsets = type == OffsetCalibrationType::OFFSET_CALIBRATION_TYPE_POWER;
|
|
||||||
const char *cs = this->get_calibration_id_();
|
|
||||||
const LogString *name = offset_calibration_name(power_offsets);
|
|
||||||
const LogString *first_name = power_offsets ? LOG_STR("active") : LOG_STR("voltage");
|
|
||||||
const LogString *second_name = power_offsets ? LOG_STR("reactive") : LOG_STR("current");
|
|
||||||
const OffsetCalibration *offsets = power_offsets ? this->power_offset_phase_ : this->offset_phase_;
|
|
||||||
const uint16_t *first_registers = power_offsets ? this->power_offset_registers : this->voltage_offset_registers;
|
|
||||||
const uint16_t *second_registers =
|
|
||||||
power_offsets ? this->reactive_power_offset_registers : this->current_offset_registers;
|
|
||||||
bool success = true;
|
|
||||||
for (uint8_t phase = 0; phase < 3; phase++) {
|
|
||||||
const uint16_t first = this->read16_(first_registers[phase]);
|
|
||||||
const uint16_t second = this->read16_(second_registers[phase]);
|
|
||||||
if (!offset_register_value_matches(first, offsets[phase].first_offset) ||
|
|
||||||
!offset_register_value_matches(second, offsets[phase].second_offset)) {
|
|
||||||
ESP_LOGE(TAG, "[CALIBRATION][%s] %s readback failed for Phase %s: %s %d/%d, %s %d/%d.", cs, LOG_STR_ARG(name),
|
|
||||||
phase_labels[phase], LOG_STR_ARG(first_name), static_cast<int16_t>(first), offsets[phase].first_offset,
|
|
||||||
LOG_STR_ARG(second_name), static_cast<int16_t>(second), offsets[phase].second_offset);
|
|
||||||
success = false;
|
|
||||||
}
|
|
||||||
}
|
|
||||||
return success;
|
|
||||||
}
|
|
||||||
|
|
||||||
#ifdef USE_TEXT_SENSOR
|
#ifdef USE_TEXT_SENSOR
|
||||||
void ATM90E32Component::check_phase_status() {
|
void ATM90E32Component::check_phase_status() {
|
||||||
uint16_t state0 = this->read16_(ATM90E32_REGISTER_EMMSTATE0);
|
uint16_t state0 = this->read16_(ATM90E32_REGISTER_EMMSTATE0);
|
||||||
|
|||||||
@@ -13,40 +13,6 @@
|
|||||||
|
|
||||||
namespace esphome::atm90e32 {
|
namespace esphome::atm90e32 {
|
||||||
|
|
||||||
inline bool offset_register_value_matches(uint16_t actual, int16_t expected) {
|
|
||||||
return actual == static_cast<uint16_t>(expected);
|
|
||||||
}
|
|
||||||
|
|
||||||
struct OffsetCalibration {
|
|
||||||
int16_t first_offset{0};
|
|
||||||
int16_t second_offset{0};
|
|
||||||
};
|
|
||||||
|
|
||||||
static_assert(sizeof(OffsetCalibration[3]) == 12, "Offset calibration preference layout must remain compatible");
|
|
||||||
|
|
||||||
enum class OffsetCalibrationType : uint8_t {
|
|
||||||
OFFSET_CALIBRATION_TYPE_VOLTAGE_CURRENT,
|
|
||||||
OFFSET_CALIBRATION_TYPE_POWER,
|
|
||||||
};
|
|
||||||
|
|
||||||
struct OffsetRestoreState {
|
|
||||||
bool restored;
|
|
||||||
bool values_verified;
|
|
||||||
};
|
|
||||||
|
|
||||||
inline OffsetRestoreState resolve_offset_restore_state(bool has_stored_values, bool initial_values_verified,
|
|
||||||
bool fallback_values_verified) {
|
|
||||||
if (initial_values_verified)
|
|
||||||
return {has_stored_values, true};
|
|
||||||
return {false, fallback_values_verified};
|
|
||||||
}
|
|
||||||
|
|
||||||
inline void prepare_offset_rollback(const OffsetCalibration (&previous)[3], bool had_stored_values,
|
|
||||||
OffsetCalibration (&rollback)[3]) {
|
|
||||||
for (uint8_t phase = 0; phase < 3; phase++)
|
|
||||||
rollback[phase] = had_stored_values ? previous[phase] : OffsetCalibration{};
|
|
||||||
}
|
|
||||||
|
|
||||||
class ATM90E32Component final : public PollingComponent,
|
class ATM90E32Component final : public PollingComponent,
|
||||||
public spi::SPIDevice<spi::BIT_ORDER_MSB_FIRST, spi::CLOCK_POLARITY_HIGH,
|
public spi::SPIDevice<spi::BIT_ORDER_MSB_FIRST, spi::CLOCK_POLARITY_HIGH,
|
||||||
spi::CLOCK_PHASE_TRAILING, spi::DATA_RATE_1MHZ> {
|
spi::CLOCK_PHASE_TRAILING, spi::DATA_RATE_1MHZ> {
|
||||||
@@ -105,19 +71,19 @@ class ATM90E32Component final : public PollingComponent,
|
|||||||
this->has_config_current_gain_[phase] = true;
|
this->has_config_current_gain_[phase] = true;
|
||||||
}
|
}
|
||||||
void set_voltage_offset(uint8_t phase, int16_t offset) {
|
void set_voltage_offset(uint8_t phase, int16_t offset) {
|
||||||
this->offset_phase_[phase].first_offset = offset;
|
this->offset_phase_[phase].voltage_offset_ = offset;
|
||||||
this->has_config_voltage_offset_[phase] = true;
|
this->has_config_voltage_offset_[phase] = true;
|
||||||
}
|
}
|
||||||
void set_current_offset(uint8_t phase, int16_t offset) {
|
void set_current_offset(uint8_t phase, int16_t offset) {
|
||||||
this->offset_phase_[phase].second_offset = offset;
|
this->offset_phase_[phase].current_offset_ = offset;
|
||||||
this->has_config_current_offset_[phase] = true;
|
this->has_config_current_offset_[phase] = true;
|
||||||
}
|
}
|
||||||
void set_active_power_offset(uint8_t phase, int16_t offset) {
|
void set_active_power_offset(uint8_t phase, int16_t offset) {
|
||||||
this->power_offset_phase_[phase].first_offset = offset;
|
this->power_offset_phase_[phase].active_power_offset = offset;
|
||||||
this->has_config_active_power_offset_[phase] = true;
|
this->has_config_active_power_offset_[phase] = true;
|
||||||
}
|
}
|
||||||
void set_reactive_power_offset(uint8_t phase, int16_t offset) {
|
void set_reactive_power_offset(uint8_t phase, int16_t offset) {
|
||||||
this->power_offset_phase_[phase].second_offset = offset;
|
this->power_offset_phase_[phase].reactive_power_offset = offset;
|
||||||
this->has_config_reactive_power_offset_[phase] = true;
|
this->has_config_reactive_power_offset_[phase] = true;
|
||||||
}
|
}
|
||||||
void set_freq_sensor(sensor::Sensor *freq_sensor) { freq_sensor_ = freq_sensor; }
|
void set_freq_sensor(sensor::Sensor *freq_sensor) { freq_sensor_ = freq_sensor; }
|
||||||
@@ -205,16 +171,16 @@ class ATM90E32Component final : public PollingComponent,
|
|||||||
float get_chip_temperature_();
|
float get_chip_temperature_();
|
||||||
bool get_publish_interval_flag_() { return publish_interval_flag_; };
|
bool get_publish_interval_flag_() { return publish_interval_flag_; };
|
||||||
void set_publish_interval_flag_(bool flag) { publish_interval_flag_ = flag; };
|
void set_publish_interval_flag_(bool flag) { publish_interval_flag_ = flag; };
|
||||||
void restore_offset_calibrations_(OffsetCalibrationType type);
|
void restore_offset_calibrations_();
|
||||||
|
void restore_power_offset_calibrations_();
|
||||||
void restore_gain_calibrations_();
|
void restore_gain_calibrations_();
|
||||||
|
void save_offset_calibration_to_memory_();
|
||||||
void save_gain_calibration_to_memory_();
|
void save_gain_calibration_to_memory_();
|
||||||
void finish_offset_calibration_(const OffsetCalibration (&previous)[3], bool previous_restored,
|
void save_power_offset_calibration_to_memory_();
|
||||||
bool previous_using_saved, OffsetCalibrationType type);
|
void write_offsets_to_registers_(uint8_t phase, int16_t voltage_offset, int16_t current_offset);
|
||||||
void write_offsets_to_registers_(uint8_t phase, int16_t first_offset, int16_t second_offset,
|
void write_power_offsets_to_registers_(uint8_t phase, int16_t p_offset, int16_t q_offset);
|
||||||
OffsetCalibrationType type);
|
|
||||||
void write_gains_to_registers_();
|
void write_gains_to_registers_();
|
||||||
bool verify_gain_writes_();
|
bool verify_gain_writes_();
|
||||||
bool verify_offset_writes_(OffsetCalibrationType type);
|
|
||||||
bool validate_spi_read_(uint16_t expected, const char *context = nullptr);
|
bool validate_spi_read_(uint16_t expected, const char *context = nullptr);
|
||||||
void log_calibration_status_();
|
void log_calibration_status_();
|
||||||
const char *get_calibration_id_();
|
const char *get_calibration_id_();
|
||||||
@@ -253,10 +219,19 @@ class ATM90E32Component final : public PollingComponent,
|
|||||||
uint32_t cumulative_reverse_active_energy_{0};
|
uint32_t cumulative_reverse_active_energy_{0};
|
||||||
} phase_[3];
|
} phase_[3];
|
||||||
|
|
||||||
OffsetCalibration offset_phase_[3];
|
struct OffsetCalibration {
|
||||||
|
int16_t voltage_offset_{0};
|
||||||
|
int16_t current_offset_{0};
|
||||||
|
} offset_phase_[3];
|
||||||
|
|
||||||
OffsetCalibration config_offset_phase_[3];
|
OffsetCalibration config_offset_phase_[3];
|
||||||
OffsetCalibration power_offset_phase_[3];
|
|
||||||
OffsetCalibration config_power_offset_phase_[3];
|
struct PowerOffsetCalibration {
|
||||||
|
int16_t active_power_offset{0};
|
||||||
|
int16_t reactive_power_offset{0};
|
||||||
|
} power_offset_phase_[3];
|
||||||
|
|
||||||
|
PowerOffsetCalibration config_power_offset_phase_[3];
|
||||||
|
|
||||||
struct GainCalibration {
|
struct GainCalibration {
|
||||||
uint16_t voltage_gain{1};
|
uint16_t voltage_gain{1};
|
||||||
@@ -290,8 +265,6 @@ class ATM90E32Component final : public PollingComponent,
|
|||||||
bool enable_offset_calibration_{false};
|
bool enable_offset_calibration_{false};
|
||||||
bool enable_gain_calibration_{false};
|
bool enable_gain_calibration_{false};
|
||||||
const char *instance_id_{nullptr};
|
const char *instance_id_{nullptr};
|
||||||
bool has_stored_offset_calibration_{false};
|
|
||||||
bool has_stored_power_offset_calibration_{false};
|
|
||||||
bool restored_offset_calibration_{false};
|
bool restored_offset_calibration_{false};
|
||||||
bool restored_power_offset_calibration_{false};
|
bool restored_power_offset_calibration_{false};
|
||||||
bool restored_gain_calibration_{false};
|
bool restored_gain_calibration_{false};
|
||||||
|
|||||||
@@ -313,10 +313,9 @@ FileDecoderState AudioDecoder::decode_mp3_() {
|
|||||||
this->output_transfer_buffer_->increase_buffer_length(
|
this->output_transfer_buffer_->increase_buffer_length(
|
||||||
this->audio_stream_info_.value().frames_to_bytes(samples_decoded));
|
this->audio_stream_info_.value().frames_to_bytes(samples_decoded));
|
||||||
}
|
}
|
||||||
} else if (result == micro_mp3::MP3_STREAM_INFO_READY || result == micro_mp3::MP3_STREAM_INFO_CHANGED) {
|
} else if (result == micro_mp3::MP3_STREAM_INFO_READY) {
|
||||||
// Header parsed: capture stream info and resize the output buffer to fit one full frame.
|
// First successful header parse: capture stream info and resize the output buffer to fit one full frame.
|
||||||
// microMP3 always outputs 16-bit PCM. MP3_STREAM_INFO_CHANGED is handled identically: despite its
|
// microMP3 always outputs 16-bit PCM.
|
||||||
// negative value it is documented as recoverable, so it must not reach the catch-all below.
|
|
||||||
this->audio_stream_info_ =
|
this->audio_stream_info_ =
|
||||||
audio::AudioStreamInfo(16, this->mp3_decoder_->get_channels(), this->mp3_decoder_->get_sample_rate());
|
audio::AudioStreamInfo(16, this->mp3_decoder_->get_channels(), this->mp3_decoder_->get_sample_rate());
|
||||||
this->free_buffer_required_ =
|
this->free_buffer_required_ =
|
||||||
|
|||||||
@@ -58,9 +58,6 @@ esp_err_t AudioReader::add_sink(const std::weak_ptr<ring_buffer::RingBuffer> &ou
|
|||||||
if (current_audio_file_ != nullptr) {
|
if (current_audio_file_ != nullptr) {
|
||||||
// A transfer buffer isn't ncessary for a local file
|
// A transfer buffer isn't ncessary for a local file
|
||||||
this->file_ring_buffer_ = output_ring_buffer.lock();
|
this->file_ring_buffer_ = output_ring_buffer.lock();
|
||||||
if (this->file_ring_buffer_ == nullptr) {
|
|
||||||
return ESP_ERR_INVALID_STATE;
|
|
||||||
}
|
|
||||||
return ESP_OK;
|
return ESP_OK;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@@ -51,14 +51,14 @@ void AudioTransferBuffer::increase_buffer_length(size_t bytes) { this->buffer_le
|
|||||||
|
|
||||||
void AudioTransferBuffer::clear_buffered_data() {
|
void AudioTransferBuffer::clear_buffered_data() {
|
||||||
this->buffer_length_ = 0;
|
this->buffer_length_ = 0;
|
||||||
if (this->ring_buffer_ != nullptr) {
|
if (this->ring_buffer_.use_count() > 0) {
|
||||||
this->ring_buffer_->reset();
|
this->ring_buffer_->reset();
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
void AudioSinkTransferBuffer::clear_buffered_data() {
|
void AudioSinkTransferBuffer::clear_buffered_data() {
|
||||||
this->buffer_length_ = 0;
|
this->buffer_length_ = 0;
|
||||||
if (this->ring_buffer_ != nullptr) {
|
if (this->ring_buffer_.use_count() > 0) {
|
||||||
this->ring_buffer_->reset();
|
this->ring_buffer_->reset();
|
||||||
}
|
}
|
||||||
#ifdef USE_SPEAKER
|
#ifdef USE_SPEAKER
|
||||||
@@ -69,7 +69,7 @@ void AudioSinkTransferBuffer::clear_buffered_data() {
|
|||||||
}
|
}
|
||||||
|
|
||||||
bool AudioTransferBuffer::has_buffered_data() const {
|
bool AudioTransferBuffer::has_buffered_data() const {
|
||||||
if (this->ring_buffer_ != nullptr) {
|
if (this->ring_buffer_.use_count() > 0) {
|
||||||
return ((this->ring_buffer_->available() > 0) || (this->available() > 0));
|
return ((this->ring_buffer_->available() > 0) || (this->available() > 0));
|
||||||
}
|
}
|
||||||
return (this->available() > 0);
|
return (this->available() > 0);
|
||||||
@@ -144,7 +144,7 @@ size_t AudioSourceTransferBuffer::transfer_data_from_source(TickType_t ticks_to_
|
|||||||
size_t bytes_to_read = AudioTransferBuffer::free();
|
size_t bytes_to_read = AudioTransferBuffer::free();
|
||||||
size_t bytes_read = 0;
|
size_t bytes_read = 0;
|
||||||
if (bytes_to_read > 0) {
|
if (bytes_to_read > 0) {
|
||||||
if (this->ring_buffer_ != nullptr) {
|
if (this->ring_buffer_.use_count() > 0) {
|
||||||
bytes_read = this->ring_buffer_->read((void *) this->get_buffer_end(), bytes_to_read, ticks_to_wait);
|
bytes_read = this->ring_buffer_->read((void *) this->get_buffer_end(), bytes_to_read, ticks_to_wait);
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -161,7 +161,7 @@ size_t AudioSinkTransferBuffer::transfer_data_to_sink(TickType_t ticks_to_wait,
|
|||||||
bytes_written = this->speaker_->play(this->data_start_, this->available(), ticks_to_wait);
|
bytes_written = this->speaker_->play(this->data_start_, this->available(), ticks_to_wait);
|
||||||
} else
|
} else
|
||||||
#endif
|
#endif
|
||||||
if (this->ring_buffer_ != nullptr) {
|
if (this->ring_buffer_.use_count() > 0) {
|
||||||
bytes_written =
|
bytes_written =
|
||||||
this->ring_buffer_->write_without_replacement((void *) this->data_start_, this->available(), ticks_to_wait);
|
this->ring_buffer_->write_without_replacement((void *) this->data_start_, this->available(), ticks_to_wait);
|
||||||
} else if (this->sink_callback_ != nullptr) {
|
} else if (this->sink_callback_ != nullptr) {
|
||||||
@@ -186,7 +186,7 @@ bool AudioSinkTransferBuffer::has_buffered_data() const {
|
|||||||
return (this->speaker_->has_buffered_data() || (this->available() > 0));
|
return (this->speaker_->has_buffered_data() || (this->available() > 0));
|
||||||
}
|
}
|
||||||
#endif
|
#endif
|
||||||
if (this->ring_buffer_ != nullptr) {
|
if (this->ring_buffer_.use_count() > 0) {
|
||||||
return ((this->ring_buffer_->available() > 0) || (this->available() > 0));
|
return ((this->ring_buffer_->available() > 0) || (this->available() > 0));
|
||||||
}
|
}
|
||||||
return (this->available() > 0);
|
return (this->available() > 0);
|
||||||
|
|||||||
@@ -22,23 +22,6 @@ class Automation {
|
|||||||
static const char *const TAG;
|
static const char *const TAG;
|
||||||
};
|
};
|
||||||
|
|
||||||
// Base for nodes that never read the parent's services.
|
|
||||||
// The parent releases its services only once every node reports Established, so a node that never
|
|
||||||
// reports it keeps that memory allocated for the life of the connection.
|
|
||||||
class BLEClientServicelessNode : public BLEClientNode {
|
|
||||||
public:
|
|
||||||
// Final so that Established is always reported on SEARCH_CMPL, before the derived node sees the event.
|
|
||||||
void gattc_event_handler(esp_gattc_cb_event_t event, esp_gatt_if_t gattc_if, esp_ble_gattc_cb_param_t *param) final {
|
|
||||||
if (event == ESP_GATTC_SEARCH_CMPL_EVT)
|
|
||||||
this->node_state = espbt::ClientState::ESTABLISHED;
|
|
||||||
this->on_gattc_event(event, gattc_if, param);
|
|
||||||
}
|
|
||||||
|
|
||||||
protected:
|
|
||||||
// Derived nodes handle GATT events here rather than by overriding the handler above.
|
|
||||||
virtual void on_gattc_event(esp_gattc_cb_event_t event, esp_gatt_if_t gattc_if, esp_ble_gattc_cb_param_t *param) {}
|
|
||||||
};
|
|
||||||
|
|
||||||
// implement on_connect automation.
|
// implement on_connect automation.
|
||||||
class BLEClientConnectTrigger final : public Trigger<>, public BLEClientNode {
|
class BLEClientConnectTrigger final : public Trigger<>, public BLEClientNode {
|
||||||
public:
|
public:
|
||||||
@@ -78,7 +61,7 @@ class BLEClientDisconnectTrigger final : public Trigger<>, public BLEClientNode
|
|||||||
}
|
}
|
||||||
};
|
};
|
||||||
|
|
||||||
class BLEClientPasskeyRequestTrigger final : public Trigger<>, public BLEClientServicelessNode {
|
class BLEClientPasskeyRequestTrigger final : public Trigger<>, public BLEClientNode {
|
||||||
public:
|
public:
|
||||||
explicit BLEClientPasskeyRequestTrigger(BLEClient *parent) { parent->register_ble_node(this); }
|
explicit BLEClientPasskeyRequestTrigger(BLEClient *parent) { parent->register_ble_node(this); }
|
||||||
void loop() override {}
|
void loop() override {}
|
||||||
@@ -88,7 +71,7 @@ class BLEClientPasskeyRequestTrigger final : public Trigger<>, public BLEClientS
|
|||||||
}
|
}
|
||||||
};
|
};
|
||||||
|
|
||||||
class BLEClientPasskeyNotificationTrigger final : public Trigger<uint32_t>, public BLEClientServicelessNode {
|
class BLEClientPasskeyNotificationTrigger final : public Trigger<uint32_t>, public BLEClientNode {
|
||||||
public:
|
public:
|
||||||
explicit BLEClientPasskeyNotificationTrigger(BLEClient *parent) { parent->register_ble_node(this); }
|
explicit BLEClientPasskeyNotificationTrigger(BLEClient *parent) { parent->register_ble_node(this); }
|
||||||
void loop() override {}
|
void loop() override {}
|
||||||
@@ -99,7 +82,7 @@ class BLEClientPasskeyNotificationTrigger final : public Trigger<uint32_t>, publ
|
|||||||
}
|
}
|
||||||
};
|
};
|
||||||
|
|
||||||
class BLEClientNumericComparisonRequestTrigger final : public Trigger<uint32_t>, public BLEClientServicelessNode {
|
class BLEClientNumericComparisonRequestTrigger final : public Trigger<uint32_t>, public BLEClientNode {
|
||||||
public:
|
public:
|
||||||
explicit BLEClientNumericComparisonRequestTrigger(BLEClient *parent) { parent->register_ble_node(this); }
|
explicit BLEClientNumericComparisonRequestTrigger(BLEClient *parent) { parent->register_ble_node(this); }
|
||||||
void loop() override {}
|
void loop() override {}
|
||||||
@@ -332,17 +315,19 @@ template<typename... Ts> class BLEClientRemoveBondAction final : public Action<T
|
|||||||
BLEClient *parent_{nullptr};
|
BLEClient *parent_{nullptr};
|
||||||
};
|
};
|
||||||
|
|
||||||
template<typename... Ts> class BLEClientConnectAction final : public Action<Ts...>, public BLEClientServicelessNode {
|
template<typename... Ts> class BLEClientConnectAction final : public Action<Ts...>, public BLEClientNode {
|
||||||
public:
|
public:
|
||||||
BLEClientConnectAction(BLEClient *ble_client) {
|
BLEClientConnectAction(BLEClient *ble_client) {
|
||||||
ble_client->register_ble_node(this);
|
ble_client->register_ble_node(this);
|
||||||
ble_client_ = ble_client;
|
ble_client_ = ble_client;
|
||||||
}
|
}
|
||||||
void on_gattc_event(esp_gattc_cb_event_t event, esp_gatt_if_t gattc_if, esp_ble_gattc_cb_param_t *param) override {
|
void gattc_event_handler(esp_gattc_cb_event_t event, esp_gatt_if_t gattc_if,
|
||||||
|
esp_ble_gattc_cb_param_t *param) override {
|
||||||
if (this->num_running_ == 0)
|
if (this->num_running_ == 0)
|
||||||
return;
|
return;
|
||||||
switch (event) {
|
switch (event) {
|
||||||
case ESP_GATTC_SEARCH_CMPL_EVT:
|
case ESP_GATTC_SEARCH_CMPL_EVT:
|
||||||
|
this->node_state = espbt::ClientState::ESTABLISHED;
|
||||||
this->parent()->run_later([this]() { this->play_next_tuple_(this->var_); });
|
this->parent()->run_later([this]() { this->play_next_tuple_(this->var_); });
|
||||||
break;
|
break;
|
||||||
// if the connection is closed, terminate the automation chain.
|
// if the connection is closed, terminate the automation chain.
|
||||||
@@ -379,13 +364,14 @@ template<typename... Ts> class BLEClientConnectAction final : public Action<Ts..
|
|||||||
std::tuple<Ts...> var_{};
|
std::tuple<Ts...> var_{};
|
||||||
};
|
};
|
||||||
|
|
||||||
template<typename... Ts> class BLEClientDisconnectAction final : public Action<Ts...>, public BLEClientServicelessNode {
|
template<typename... Ts> class BLEClientDisconnectAction final : public Action<Ts...>, public BLEClientNode {
|
||||||
public:
|
public:
|
||||||
BLEClientDisconnectAction(BLEClient *ble_client) {
|
BLEClientDisconnectAction(BLEClient *ble_client) {
|
||||||
ble_client->register_ble_node(this);
|
ble_client->register_ble_node(this);
|
||||||
ble_client_ = ble_client;
|
ble_client_ = ble_client;
|
||||||
}
|
}
|
||||||
void on_gattc_event(esp_gattc_cb_event_t event, esp_gatt_if_t gattc_if, esp_ble_gattc_cb_param_t *param) override {
|
void gattc_event_handler(esp_gattc_cb_event_t event, esp_gatt_if_t gattc_if,
|
||||||
|
esp_ble_gattc_cb_param_t *param) override {
|
||||||
if (this->num_running_ == 0)
|
if (this->num_running_ == 0)
|
||||||
return;
|
return;
|
||||||
switch (event) {
|
switch (event) {
|
||||||
|
|||||||
@@ -6,7 +6,6 @@ namespace esphome::dallas_temp {
|
|||||||
static const char *const TAG = "dallas.temp.sensor";
|
static const char *const TAG = "dallas.temp.sensor";
|
||||||
|
|
||||||
static const uint8_t DALLAS_MODEL_DS18S20 = 0x10;
|
static const uint8_t DALLAS_MODEL_DS18S20 = 0x10;
|
||||||
static const uint8_t DALLAS_MODEL_DS18B20 = 0x28;
|
|
||||||
static const uint8_t DALLAS_COMMAND_START_CONVERSION = 0x44;
|
static const uint8_t DALLAS_COMMAND_START_CONVERSION = 0x44;
|
||||||
static const uint8_t DALLAS_COMMAND_READ_SCRATCH_PAD = 0xBE;
|
static const uint8_t DALLAS_COMMAND_READ_SCRATCH_PAD = 0xBE;
|
||||||
static const uint8_t DALLAS_COMMAND_WRITE_SCRATCH_PAD = 0x4E;
|
static const uint8_t DALLAS_COMMAND_WRITE_SCRATCH_PAD = 0x4E;
|
||||||
@@ -155,14 +154,7 @@ float DallasTemperatureSensor::get_temp_c_() {
|
|||||||
default:
|
default:
|
||||||
break;
|
break;
|
||||||
}
|
}
|
||||||
// undocumented test for powerup measurement of 85
|
|
||||||
// https://github.com/cpetrich/counterfeit_DS18B20#solution-to-the-85-c-problem
|
|
||||||
if ((this->address_ & 0xff) == DALLAS_MODEL_DS18B20) {
|
|
||||||
if ((temp == 85 * 16) && (this->scratch_pad_[6] == 0xc)) {
|
|
||||||
ESP_LOGD(TAG, "dropping reading caused by sensor reset");
|
|
||||||
return NAN;
|
|
||||||
}
|
|
||||||
}
|
|
||||||
return temp / 16.0f;
|
return temp / 16.0f;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@@ -66,15 +66,11 @@ const char *DebugComponent::get_reset_reason_(std::span<char, RESET_REASON_BUFFE
|
|||||||
|
|
||||||
unsigned reason = esp_reset_reason();
|
unsigned reason = esp_reset_reason();
|
||||||
if (reason < sizeof(RESET_REASONS) / sizeof(RESET_REASONS[0])) {
|
if (reason < sizeof(RESET_REASONS) / sizeof(RESET_REASONS[0])) {
|
||||||
if (reason == ESP_RST_SW || reason == ESP_RST_WDT) {
|
if (reason == ESP_RST_SW) {
|
||||||
// On some ESP32-S3 configurations (e.g. SPIRAM with fetch-instructions/rodata),
|
|
||||||
// esp_restart() intermittently produces RTCWDT_RTC_RST (ESP_RST_WDT) instead of
|
|
||||||
// ESP_RST_SW. Check the stored reboot source for both reset reasons so a software
|
|
||||||
// reboot that ends up as WDT still reports the correct source.
|
|
||||||
auto pref = global_preferences->make_preference(REBOOT_MAX_LEN,
|
auto pref = global_preferences->make_preference(REBOOT_MAX_LEN,
|
||||||
fnv1_hash_extend(fnv1_hash(REBOOT_KEY), App.get_name().c_str()));
|
fnv1_hash_extend(fnv1_hash(REBOOT_KEY), App.get_name().c_str()));
|
||||||
char reboot_source[REBOOT_MAX_LEN]{};
|
char reboot_source[REBOOT_MAX_LEN]{};
|
||||||
if (pref.load(&reboot_source) && reboot_source[0] != '\0') {
|
if (pref.load(&reboot_source)) {
|
||||||
reboot_source[REBOOT_MAX_LEN - 1] = '\0';
|
reboot_source[REBOOT_MAX_LEN - 1] = '\0';
|
||||||
snprintf(buf, size, "Reboot request from %s", reboot_source);
|
snprintf(buf, size, "Reboot request from %s", reboot_source);
|
||||||
} else {
|
} else {
|
||||||
|
|||||||
@@ -41,10 +41,7 @@ const noise::NoiseContext &ESPHomeOTAComponent::noise_context_() const {
|
|||||||
#endif
|
#endif
|
||||||
static constexpr uint16_t OTA_BLOCK_SIZE = 8192;
|
static constexpr uint16_t OTA_BLOCK_SIZE = 8192;
|
||||||
static constexpr uint32_t OTA_SOCKET_TIMEOUT_HANDSHAKE = 20000; // milliseconds for initial handshake
|
static constexpr uint32_t OTA_SOCKET_TIMEOUT_HANDSHAKE = 20000; // milliseconds for initial handshake
|
||||||
// Milliseconds for data transfer. Covers the lwIP retransmit run seen in
|
static constexpr uint32_t OTA_SOCKET_TIMEOUT_DATA = 90000; // milliseconds for data transfer
|
||||||
// practice for a lost chunk ack (1.5 + 3 + 6 + 12 + 24 + 48 s); the CLI waits
|
|
||||||
// longer (espota2.DATA_PHASE_TIMEOUT) so the device is free before it retries
|
|
||||||
static constexpr uint32_t OTA_SOCKET_TIMEOUT_DATA = 105000;
|
|
||||||
|
|
||||||
// Single-instance pointer — multi-port configs are rejected in final_validate.
|
// Single-instance pointer — multi-port configs are rejected in final_validate.
|
||||||
// NOLINTNEXTLINE(cppcoreguidelines-avoid-non-const-global-variables)
|
// NOLINTNEXTLINE(cppcoreguidelines-avoid-non-const-global-variables)
|
||||||
|
|||||||
@@ -91,14 +91,7 @@ void I2SAudioSpeakerBase::loop() {
|
|||||||
this->speaker_task_handle_ = nullptr;
|
this->speaker_task_handle_ = nullptr;
|
||||||
|
|
||||||
this->stop_i2s_driver_();
|
this->stop_i2s_driver_();
|
||||||
// ALL_BITS includes COMMAND_START. Take the bits from the clear itself, not from the snapshot at
|
xEventGroupClearBits(this->event_group_, SpeakerEventGroupBits::ALL_BITS);
|
||||||
// the top of loop(): the audio source's task can raise a start at any point above, including
|
|
||||||
// during stop_i2s_driver_(), and nothing would ever re-issue it.
|
|
||||||
const EventBits_t bits_before_clear = xEventGroupClearBits(this->event_group_, SpeakerEventGroupBits::ALL_BITS);
|
|
||||||
if (bits_before_clear & SpeakerEventGroupBits::COMMAND_START) {
|
|
||||||
ESP_LOGD(TAG, "Start requested while stopping; keeping the request");
|
|
||||||
xEventGroupSetBits(this->event_group_, SpeakerEventGroupBits::COMMAND_START);
|
|
||||||
}
|
|
||||||
this->status_clear_error();
|
this->status_clear_error();
|
||||||
|
|
||||||
this->on_task_stopped();
|
this->on_task_stopped();
|
||||||
@@ -118,24 +111,21 @@ void I2SAudioSpeakerBase::loop() {
|
|||||||
break;
|
break;
|
||||||
}
|
}
|
||||||
|
|
||||||
// Still starting up or winding down from a previous run
|
|
||||||
if ((this->tx_handle_ != nullptr) || (this->speaker_task_handle_ != nullptr)) {
|
|
||||||
break;
|
|
||||||
}
|
|
||||||
|
|
||||||
if (this->start_i2s_driver(this->audio_stream_info_) != ESP_OK) {
|
if (this->start_i2s_driver(this->audio_stream_info_) != ESP_OK) {
|
||||||
ESP_LOGE(TAG, "Driver failed to start; retrying in 1 second");
|
ESP_LOGE(TAG, "Driver failed to start; retrying in 1 second");
|
||||||
this->status_momentary_error("driver-failure", 1000);
|
this->status_momentary_error("driver-failure", 1000);
|
||||||
break;
|
break;
|
||||||
}
|
}
|
||||||
|
|
||||||
xTaskCreate(I2SAudioSpeakerBase::speaker_task, "speaker_task", TASK_STACK_SIZE, (void *) this, TASK_PRIORITY,
|
|
||||||
&this->speaker_task_handle_);
|
|
||||||
|
|
||||||
if (this->speaker_task_handle_ == nullptr) {
|
if (this->speaker_task_handle_ == nullptr) {
|
||||||
ESP_LOGE(TAG, "Task failed to start, retrying in 1 second");
|
xTaskCreate(I2SAudioSpeakerBase::speaker_task, "speaker_task", TASK_STACK_SIZE, (void *) this, TASK_PRIORITY,
|
||||||
this->status_momentary_error("task-failure", 1000);
|
&this->speaker_task_handle_);
|
||||||
this->stop_i2s_driver_(); // Stops the driver to return the lock; will be reloaded in next attempt
|
|
||||||
|
if (this->speaker_task_handle_ == nullptr) {
|
||||||
|
ESP_LOGE(TAG, "Task failed to start, retrying in 1 second");
|
||||||
|
this->status_momentary_error("task-failure", 1000);
|
||||||
|
this->stop_i2s_driver_(); // Stops the driver to return the lock; will be reloaded in next attempt
|
||||||
|
}
|
||||||
}
|
}
|
||||||
break;
|
break;
|
||||||
case speaker::STATE_RUNNING: // Intentional fallthrough
|
case speaker::STATE_RUNNING: // Intentional fallthrough
|
||||||
@@ -221,8 +211,8 @@ size_t I2SAudioSpeakerBase::play(const uint8_t *data, size_t length, TickType_t
|
|||||||
}
|
}
|
||||||
|
|
||||||
bool I2SAudioSpeakerBase::has_buffered_data() const {
|
bool I2SAudioSpeakerBase::has_buffered_data() const {
|
||||||
std::shared_ptr<ring_buffer::RingBuffer> temp_ring_buffer = this->audio_ring_buffer_.lock();
|
if (this->audio_ring_buffer_.use_count() > 0) {
|
||||||
if (temp_ring_buffer != nullptr) {
|
std::shared_ptr<ring_buffer::RingBuffer> temp_ring_buffer = this->audio_ring_buffer_.lock();
|
||||||
return temp_ring_buffer->available() > 0;
|
return temp_ring_buffer->available() > 0;
|
||||||
}
|
}
|
||||||
return false;
|
return false;
|
||||||
|
|||||||
@@ -5,7 +5,6 @@
|
|||||||
#include <esp_log.h>
|
#include <esp_log.h>
|
||||||
|
|
||||||
#include <driver/uart.h>
|
#include <driver/uart.h>
|
||||||
#include <soc/soc_caps.h>
|
|
||||||
|
|
||||||
#ifdef USE_LOGGER_UART_SELECTION_USB_SERIAL_JTAG
|
#ifdef USE_LOGGER_UART_SELECTION_USB_SERIAL_JTAG
|
||||||
#include <driver/usb_serial_jtag.h>
|
#include <driver/usb_serial_jtag.h>
|
||||||
@@ -77,11 +76,7 @@ void init_uart(uart_port_t uart_num, uint32_t baud_rate, int tx_buffer_size) {
|
|||||||
uart_config.parity = UART_PARITY_DISABLE;
|
uart_config.parity = UART_PARITY_DISABLE;
|
||||||
uart_config.stop_bits = UART_STOP_BITS_1;
|
uart_config.stop_bits = UART_STOP_BITS_1;
|
||||||
uart_config.flow_ctrl = UART_HW_FLOWCTRL_DISABLE;
|
uart_config.flow_ctrl = UART_HW_FLOWCTRL_DISABLE;
|
||||||
#if SOC_UART_SUPPORT_XTAL_CLK
|
|
||||||
uart_config.source_clk = UART_SCLK_XTAL;
|
|
||||||
#else
|
|
||||||
uart_config.source_clk = UART_SCLK_DEFAULT;
|
uart_config.source_clk = UART_SCLK_DEFAULT;
|
||||||
#endif
|
|
||||||
uart_param_config(uart_num, &uart_config);
|
uart_param_config(uart_num, &uart_config);
|
||||||
// The logger only writes to UART, never reads, so use the minimum RX buffer.
|
// The logger only writes to UART, never reads, so use the minimum RX buffer.
|
||||||
// ESP-IDF requires rx_buffer_size > UART_HW_FIFO_LEN (128 bytes).
|
// ESP-IDF requires rx_buffer_size > UART_HW_FIFO_LEN (128 bytes).
|
||||||
|
|||||||
@@ -15,7 +15,6 @@ from ..defines import (
|
|||||||
from ..types import LvCompound, LvType
|
from ..types import LvCompound, LvType
|
||||||
from . import Widget, WidgetType, get_widgets
|
from . import Widget, WidgetType, get_widgets
|
||||||
from .buttonmatrix import CONF_BUTTONMATRIX
|
from .buttonmatrix import CONF_BUTTONMATRIX
|
||||||
from .label import CONF_LABEL
|
|
||||||
from .textarea import CONF_TEXTAREA, lv_textarea_t
|
from .textarea import CONF_TEXTAREA, lv_textarea_t
|
||||||
|
|
||||||
CONF_KEYBOARD = "keyboard"
|
CONF_KEYBOARD = "keyboard"
|
||||||
@@ -50,7 +49,7 @@ class KeyboardType(WidgetType):
|
|||||||
)
|
)
|
||||||
|
|
||||||
def get_uses(self):
|
def get_uses(self):
|
||||||
return CONF_KEYBOARD, CONF_TEXTAREA, CONF_BUTTONMATRIX, CONF_LABEL
|
return CONF_KEYBOARD, CONF_TEXTAREA, CONF_BUTTONMATRIX
|
||||||
|
|
||||||
async def to_code(self, w: Widget, config: dict):
|
async def to_code(self, w: Widget, config: dict):
|
||||||
add_lv_use("KEY_LISTENER")
|
add_lv_use("KEY_LISTENER")
|
||||||
|
|||||||
@@ -10,7 +10,6 @@ from ..types import lv_obj_t
|
|||||||
from . import Widget, WidgetType
|
from . import Widget, WidgetType
|
||||||
from .canvas import CONF_CANVAS
|
from .canvas import CONF_CANVAS
|
||||||
from .img import CONF_IMAGE
|
from .img import CONF_IMAGE
|
||||||
from .label import CONF_LABEL
|
|
||||||
|
|
||||||
CONF_QRCODE = "qrcode"
|
CONF_QRCODE = "qrcode"
|
||||||
CONF_DARK_COLOR = "dark_color"
|
CONF_DARK_COLOR = "dark_color"
|
||||||
@@ -42,7 +41,7 @@ class QrCodeType(WidgetType):
|
|||||||
)
|
)
|
||||||
|
|
||||||
def get_uses(self):
|
def get_uses(self):
|
||||||
return CONF_CANVAS, CONF_IMAGE, CONF_LABEL
|
return CONF_CANVAS, CONF_IMAGE
|
||||||
|
|
||||||
async def to_code(self, w: Widget, config):
|
async def to_code(self, w: Widget, config):
|
||||||
await w.set_property(
|
await w.set_property(
|
||||||
|
|||||||
@@ -28,7 +28,6 @@ from ..types import LV_EVENT, LvType, ObjUpdateAction, lv_obj_t, lv_obj_t_ptr
|
|||||||
from . import Widget, WidgetType, add_widgets, get_widgets, set_obj_properties
|
from . import Widget, WidgetType, add_widgets, get_widgets, set_obj_properties
|
||||||
from .button import button_spec
|
from .button import button_spec
|
||||||
from .buttonmatrix import CONF_BUTTONMATRIX, buttonmatrix_spec
|
from .buttonmatrix import CONF_BUTTONMATRIX, buttonmatrix_spec
|
||||||
from .label import CONF_LABEL
|
|
||||||
from .obj import obj_spec
|
from .obj import obj_spec
|
||||||
|
|
||||||
CONF_TABVIEW = "tabview"
|
CONF_TABVIEW = "tabview"
|
||||||
@@ -75,7 +74,7 @@ class TabviewType(WidgetType):
|
|||||||
)
|
)
|
||||||
|
|
||||||
def get_uses(self):
|
def get_uses(self):
|
||||||
return CONF_BUTTONMATRIX, TYPE_FLEX, CONF_BUTTON, CONF_LABEL
|
return CONF_BUTTONMATRIX, TYPE_FLEX, CONF_BUTTON
|
||||||
|
|
||||||
async def to_code(self, w: Widget, config: dict):
|
async def to_code(self, w: Widget, config: dict):
|
||||||
await w.set_property(
|
await w.set_property(
|
||||||
|
|||||||
@@ -129,7 +129,7 @@ void MicroWakeWord::setup() {
|
|||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
std::shared_ptr<ring_buffer::RingBuffer> temp_ring_buffer = this->ring_buffer_.lock();
|
std::shared_ptr<ring_buffer::RingBuffer> temp_ring_buffer = this->ring_buffer_.lock();
|
||||||
if (temp_ring_buffer != nullptr) {
|
if (this->ring_buffer_.use_count() > 1) {
|
||||||
// Producer-only write: never touches consumer state. If the buffer is full, ask the inference task
|
// Producer-only write: never touches consumer state. If the buffer is full, ask the inference task
|
||||||
// to drain it - reset() is a consumer operation and must run on the inference task's thread.
|
// to drain it - reset() is a consumer operation and must run on the inference task's thread.
|
||||||
// Disable partial writes so audio chunks are either fully accepted or rejected and handled below.
|
// Disable partial writes so audio chunks are either fully accepted or rejected and handled below.
|
||||||
@@ -446,9 +446,9 @@ void MicroWakeWord::loop() {
|
|||||||
xEventGroupClearBits(this->event_group_, EventGroupBits::TASK_STOPPING);
|
xEventGroupClearBits(this->event_group_, EventGroupBits::TASK_STOPPING);
|
||||||
}
|
}
|
||||||
|
|
||||||
// Retries on a subsequent loop if the task is still running on the other core
|
if ((event_group_bits & EventGroupBits::TASK_STOPPED)) {
|
||||||
if ((event_group_bits & EventGroupBits::TASK_STOPPED) && this->inference_task_.deallocate()) {
|
|
||||||
ESP_LOGD(TAG, "Inference task is finished, freeing task resources");
|
ESP_LOGD(TAG, "Inference task is finished, freeing task resources");
|
||||||
|
this->inference_task_.deallocate();
|
||||||
xEventGroupClearBits(this->event_group_, ALL_BITS);
|
xEventGroupClearBits(this->event_group_, ALL_BITS);
|
||||||
xQueueReset(this->detection_queue_);
|
xQueueReset(this->detection_queue_);
|
||||||
this->set_state_(State::STOPPED);
|
this->set_state_(State::STOPPED);
|
||||||
|
|||||||
@@ -48,7 +48,7 @@ class MicrophoneSource final {
|
|||||||
template<typename F> void add_data_callback(F &&data_callback) {
|
template<typename F> void add_data_callback(F &&data_callback) {
|
||||||
this->mic_->add_data_callback([this, data_callback](const std::vector<uint8_t> &data) {
|
this->mic_->add_data_callback([this, data_callback](const std::vector<uint8_t> &data) {
|
||||||
if (this->enabled_ || this->passive_) {
|
if (this->enabled_ || this->passive_) {
|
||||||
if (this->processed_samples_ == nullptr) {
|
if (this->processed_samples_.use_count() == 0) {
|
||||||
// Create vector if its unused
|
// Create vector if its unused
|
||||||
this->processed_samples_ = std::make_shared<std::vector<uint8_t>>();
|
this->processed_samples_ = std::make_shared<std::vector<uint8_t>>();
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -35,8 +35,8 @@ void MipiDsi::setup() {
|
|||||||
.bus_id = 0, // index from 0, specify the DSI host to use
|
.bus_id = 0, // index from 0, specify the DSI host to use
|
||||||
.num_data_lanes =
|
.num_data_lanes =
|
||||||
this->lanes_, // Number of data lanes to use, can't set a value that exceeds the chip's capability
|
this->lanes_, // Number of data lanes to use, can't set a value that exceeds the chip's capability
|
||||||
.phy_clk_src = MIPI_DSI_PHY_CLK_SRC_DEFAULT, // Clock source for the DPHY
|
// phy_clk_src left at 0 to enable runtime auto-select.
|
||||||
.lane_bit_rate_mbps = this->lane_bit_rate_, // Bit rate of the data lanes, in Mbps
|
.lane_bit_rate_mbps = this->lane_bit_rate_, // Bit rate of the data lanes, in Mbps
|
||||||
};
|
};
|
||||||
auto err = esp_lcd_new_dsi_bus(&bus_config, &this->bus_handle_);
|
auto err = esp_lcd_new_dsi_bus(&bus_config, &this->bus_handle_);
|
||||||
if (err != ESP_OK) {
|
if (err != ESP_OK) {
|
||||||
|
|||||||
@@ -218,7 +218,7 @@ size_t SourceSpeaker::play(const uint8_t *data, size_t length, TickType_t ticks_
|
|||||||
}
|
}
|
||||||
size_t bytes_written = 0;
|
size_t bytes_written = 0;
|
||||||
std::shared_ptr<ring_buffer::RingBuffer> temp_ring_buffer = this->ring_buffer_.lock();
|
std::shared_ptr<ring_buffer::RingBuffer> temp_ring_buffer = this->ring_buffer_.lock();
|
||||||
if (temp_ring_buffer != nullptr) {
|
if (temp_ring_buffer.use_count() > 0) {
|
||||||
// Only write to the ring buffer if the reference is valid
|
// Only write to the ring buffer if the reference is valid
|
||||||
bytes_written = temp_ring_buffer->write_without_replacement(data, length, ticks_to_wait);
|
bytes_written = temp_ring_buffer->write_without_replacement(data, length, ticks_to_wait);
|
||||||
if (bytes_written > 0) {
|
if (bytes_written > 0) {
|
||||||
@@ -250,14 +250,14 @@ esp_err_t SourceSpeaker::start_() {
|
|||||||
// avoids unnecessary single-frame splices.
|
// avoids unnecessary single-frame splices.
|
||||||
const size_t ring_buffer_size =
|
const size_t ring_buffer_size =
|
||||||
(this->audio_stream_info_.ms_to_bytes(this->buffer_duration_ms_) / bytes_per_frame) * bytes_per_frame;
|
(this->audio_stream_info_.ms_to_bytes(this->buffer_duration_ms_) / bytes_per_frame) * bytes_per_frame;
|
||||||
if (this->audio_source_ == nullptr) {
|
if (this->audio_source_.use_count() == 0) {
|
||||||
std::shared_ptr<ring_buffer::RingBuffer> temp_ring_buffer = this->ring_buffer_.lock();
|
std::shared_ptr<ring_buffer::RingBuffer> temp_ring_buffer = this->ring_buffer_.lock();
|
||||||
if (temp_ring_buffer == nullptr) {
|
if (!temp_ring_buffer) {
|
||||||
temp_ring_buffer = ring_buffer::RingBuffer::create(ring_buffer_size);
|
temp_ring_buffer = ring_buffer::RingBuffer::create(ring_buffer_size);
|
||||||
this->ring_buffer_ = temp_ring_buffer;
|
this->ring_buffer_ = temp_ring_buffer;
|
||||||
}
|
}
|
||||||
|
|
||||||
if (temp_ring_buffer == nullptr) {
|
if (!temp_ring_buffer) {
|
||||||
return ESP_ERR_NO_MEM;
|
return ESP_ERR_NO_MEM;
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -278,7 +278,7 @@ void SourceSpeaker::stop() { this->send_command_(SOURCE_SPEAKER_COMMAND_STOP); }
|
|||||||
void SourceSpeaker::finish() { this->send_command_(SOURCE_SPEAKER_COMMAND_FINISH); }
|
void SourceSpeaker::finish() { this->send_command_(SOURCE_SPEAKER_COMMAND_FINISH); }
|
||||||
|
|
||||||
bool SourceSpeaker::has_buffered_data() const {
|
bool SourceSpeaker::has_buffered_data() const {
|
||||||
return ((this->audio_source_ != nullptr) && this->audio_source_->has_buffered_data());
|
return ((this->audio_source_.use_count() > 0) && this->audio_source_->has_buffered_data());
|
||||||
}
|
}
|
||||||
|
|
||||||
void SourceSpeaker::set_mute_state(bool mute_state) {
|
void SourceSpeaker::set_mute_state(bool mute_state) {
|
||||||
@@ -382,8 +382,8 @@ void MixerSpeaker::loop() {
|
|||||||
ESP_LOGV(TAG, "Stopping");
|
ESP_LOGV(TAG, "Stopping");
|
||||||
xEventGroupClearBits(this->event_group_, MIXER_TASK_STATE_STOPPING);
|
xEventGroupClearBits(this->event_group_, MIXER_TASK_STATE_STOPPING);
|
||||||
}
|
}
|
||||||
// Retries on a subsequent loop if the task is still running on the other core
|
if (event_group_bits & MIXER_TASK_STATE_STOPPED) {
|
||||||
if ((event_group_bits & MIXER_TASK_STATE_STOPPED) && this->task_.deallocate()) {
|
this->task_.deallocate();
|
||||||
ESP_LOGD(TAG, "Stopped");
|
ESP_LOGD(TAG, "Stopped");
|
||||||
xEventGroupClearBits(this->event_group_, MIXER_TASK_ALL_BITS);
|
xEventGroupClearBits(this->event_group_, MIXER_TASK_ALL_BITS);
|
||||||
this->all_stopped_since_ms_ = 0;
|
this->all_stopped_since_ms_ = 0;
|
||||||
@@ -496,7 +496,7 @@ void MixerSpeaker::audio_mixer_task(void *params) {
|
|||||||
if (speaker->is_running() && !speaker->get_pause_state()) {
|
if (speaker->is_running() && !speaker->get_pause_state()) {
|
||||||
// Speaker is running and not paused, so it possibly can provide audio data
|
// Speaker is running and not paused, so it possibly can provide audio data
|
||||||
std::shared_ptr<audio::RingBufferAudioSource> audio_source = speaker->get_audio_source().lock();
|
std::shared_ptr<audio::RingBufferAudioSource> audio_source = speaker->get_audio_source().lock();
|
||||||
if (audio_source == nullptr) {
|
if (audio_source.use_count() == 0) {
|
||||||
// No audio source allocated, so skip processing this speaker
|
// No audio source allocated, so skip processing this speaker
|
||||||
continue;
|
continue;
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -67,9 +67,6 @@ void MQTTJSONLightComponent::send_discovery(JsonObject root, mqtt::SendDiscovery
|
|||||||
if (traits.supports_color_mode(ColorMode::RGB_COLD_WARM_WHITE))
|
if (traits.supports_color_mode(ColorMode::RGB_COLD_WARM_WHITE))
|
||||||
color_modes.add(ESPHOME_F("rgbww"));
|
color_modes.add(ESPHOME_F("rgbww"));
|
||||||
|
|
||||||
if (traits.supports_color_capability(ColorCapability::BRIGHTNESS))
|
|
||||||
root[ESPHOME_F("brightness")] = true;
|
|
||||||
|
|
||||||
if (traits.supports_color_mode(ColorMode::COLOR_TEMPERATURE) ||
|
if (traits.supports_color_mode(ColorMode::COLOR_TEMPERATURE) ||
|
||||||
traits.supports_color_mode(ColorMode::COLD_WARM_WHITE)) {
|
traits.supports_color_mode(ColorMode::COLD_WARM_WHITE)) {
|
||||||
root[MQTT_MIN_MIREDS] = traits.get_min_mireds();
|
root[MQTT_MIN_MIREDS] = traits.get_min_mireds();
|
||||||
|
|||||||
@@ -88,12 +88,12 @@ def encryption_schema(config: ConfigType | None) -> ConfigType:
|
|||||||
|
|
||||||
async def to_code(config: ConfigType) -> None:
|
async def to_code(config: ConfigType) -> None:
|
||||||
cg.add_define("USE_NOISE")
|
cg.add_define("USE_NOISE")
|
||||||
cg.add_library("esphome/noise-c", "0.1.26")
|
cg.add_library("esphome/noise-c", "0.1.24")
|
||||||
# noise-c depends on libsodium, but declaring it here too lets the
|
# noise-c depends on libsodium, but declaring it here too lets the
|
||||||
# library manager see the full set up front instead of discovering
|
# library manager see the full set up front instead of discovering
|
||||||
# libsodium only after noise-c has downloaded, so the two can download
|
# libsodium only after noise-c has downloaded, so the two can download
|
||||||
# in parallel. The version must match noise-c's library.json.
|
# in parallel. The version must match noise-c's library.json.
|
||||||
cg.add_library("esphome/libsodium", "1.10021.8")
|
cg.add_library("esphome/libsodium", "1.10021.6")
|
||||||
# Enable optimized memzero/memcmp in libsodium instead of volatile byte loops
|
# Enable optimized memzero/memcmp in libsodium instead of volatile byte loops
|
||||||
cg.add_build_flag("-DHAVE_WEAK_SYMBOLS=1")
|
cg.add_build_flag("-DHAVE_WEAK_SYMBOLS=1")
|
||||||
cg.add_build_flag("-DHAVE_INLINE_ASM=1")
|
cg.add_build_flag("-DHAVE_INLINE_ASM=1")
|
||||||
|
|||||||
@@ -153,8 +153,8 @@ void ResamplerSpeaker::loop() {
|
|||||||
ESP_LOGV(TAG, "Stopping");
|
ESP_LOGV(TAG, "Stopping");
|
||||||
xEventGroupClearBits(this->event_group_, ResamplingEventGroupBits::STATE_STOPPING);
|
xEventGroupClearBits(this->event_group_, ResamplingEventGroupBits::STATE_STOPPING);
|
||||||
}
|
}
|
||||||
// Retries on a subsequent loop if the task is still running on the other core
|
if (event_group_bits & ResamplingEventGroupBits::STATE_STOPPED) {
|
||||||
if ((event_group_bits & ResamplingEventGroupBits::STATE_STOPPED) && this->task_.deallocate()) {
|
this->task_.deallocate();
|
||||||
ESP_LOGD(TAG, "Stopped");
|
ESP_LOGD(TAG, "Stopped");
|
||||||
xEventGroupClearBits(this->event_group_, ResamplingEventGroupBits::ALL_BITS);
|
xEventGroupClearBits(this->event_group_, ResamplingEventGroupBits::ALL_BITS);
|
||||||
}
|
}
|
||||||
@@ -235,7 +235,7 @@ size_t ResamplerSpeaker::play(const uint8_t *data, size_t length, TickType_t tic
|
|||||||
bytes_written = this->output_speaker_->play(data, length, ticks_to_wait);
|
bytes_written = this->output_speaker_->play(data, length, ticks_to_wait);
|
||||||
} else {
|
} else {
|
||||||
std::shared_ptr<ring_buffer::RingBuffer> temp_ring_buffer = this->ring_buffer_.lock();
|
std::shared_ptr<ring_buffer::RingBuffer> temp_ring_buffer = this->ring_buffer_.lock();
|
||||||
if (temp_ring_buffer != nullptr) {
|
if (temp_ring_buffer) {
|
||||||
// Only write to the ring buffer if the reference is valid
|
// Only write to the ring buffer if the reference is valid
|
||||||
bytes_written = temp_ring_buffer->write_without_replacement(data, length, ticks_to_wait);
|
bytes_written = temp_ring_buffer->write_without_replacement(data, length, ticks_to_wait);
|
||||||
} else {
|
} else {
|
||||||
@@ -299,7 +299,7 @@ bool ResamplerSpeaker::has_buffered_data() const {
|
|||||||
bool has_ring_buffer_data = false;
|
bool has_ring_buffer_data = false;
|
||||||
if (this->requires_resampling_()) {
|
if (this->requires_resampling_()) {
|
||||||
std::shared_ptr<ring_buffer::RingBuffer> temp_ring_buffer = this->ring_buffer_.lock();
|
std::shared_ptr<ring_buffer::RingBuffer> temp_ring_buffer = this->ring_buffer_.lock();
|
||||||
if (temp_ring_buffer != nullptr) {
|
if (temp_ring_buffer) {
|
||||||
has_ring_buffer_data = (temp_ring_buffer->available() > 0);
|
has_ring_buffer_data = (temp_ring_buffer->available() > 0);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
@@ -342,7 +342,7 @@ void ResamplerSpeaker::resample_task(void *params) {
|
|||||||
std::shared_ptr<ring_buffer::RingBuffer> temp_ring_buffer = ring_buffer::RingBuffer::create(
|
std::shared_ptr<ring_buffer::RingBuffer> temp_ring_buffer = ring_buffer::RingBuffer::create(
|
||||||
this_resampler->audio_stream_info_.ms_to_bytes(this_resampler->buffer_duration_ms_));
|
this_resampler->audio_stream_info_.ms_to_bytes(this_resampler->buffer_duration_ms_));
|
||||||
|
|
||||||
if (temp_ring_buffer == nullptr) {
|
if (!temp_ring_buffer) {
|
||||||
err = ESP_ERR_NO_MEM;
|
err = ESP_ERR_NO_MEM;
|
||||||
} else {
|
} else {
|
||||||
this_resampler->ring_buffer_ = temp_ring_buffer;
|
this_resampler->ring_buffer_ = temp_ring_buffer;
|
||||||
|
|||||||
@@ -18,16 +18,6 @@ void RFBridgeComponent::ack_() {
|
|||||||
}
|
}
|
||||||
|
|
||||||
bool RFBridgeComponent::parse_bridge_byte_(uint8_t byte) {
|
bool RFBridgeComponent::parse_bridge_byte_(uint8_t byte) {
|
||||||
if (this->bucket_frame_candidate_ && byte == RF_CODE_START) {
|
|
||||||
// A queued next frame proves the trailing 0x55 really was the bucket
|
|
||||||
// frame's terminator: Portisch builds pulse entries from alternating
|
|
||||||
// signal edges, so the two level bits inside one pulse byte are always
|
|
||||||
// opposite — 0xAA (two high-level nibbles) cannot occur in pulse data.
|
|
||||||
// Finalize before this byte starts the new frame, so back-to-back
|
|
||||||
// deliveries are split even when loop() never observed a quiet gap
|
|
||||||
// between them.
|
|
||||||
this->finish_bucket_frame_();
|
|
||||||
}
|
|
||||||
size_t at = this->rx_buffer_.size();
|
size_t at = this->rx_buffer_.size();
|
||||||
this->rx_buffer_.push_back(byte);
|
this->rx_buffer_.push_back(byte);
|
||||||
const uint8_t *raw = &this->rx_buffer_[0];
|
const uint8_t *raw = &this->rx_buffer_[0];
|
||||||
@@ -94,21 +84,26 @@ bool RFBridgeComponent::parse_bridge_byte_(uint8_t byte) {
|
|||||||
break;
|
break;
|
||||||
}
|
}
|
||||||
case RF_CODE_RFIN_BUCKET: {
|
case RF_CODE_RFIN_BUCKET: {
|
||||||
if (at == 2) {
|
if (byte != RF_CODE_STOP) {
|
||||||
// The count byte: Portisch sends at most 7 buckets + sync, so 0 or
|
return true;
|
||||||
// >8 cannot be a genuine capture — reject before it can occupy the
|
|
||||||
// buffer for a full frame timeout.
|
|
||||||
return byte != 0 && byte <= B1_MAX_BUCKET_COUNT;
|
|
||||||
}
|
}
|
||||||
// 0x55 is legal DATA inside a B1 frame: bucket durations are sent
|
|
||||||
// with only their HIGH byte masked to 7 bits, so a duration such as
|
uint8_t buckets = raw[2] << 1;
|
||||||
// 0x0155 puts a raw 0x55 low byte inside the table — the first 0x55
|
std::string str;
|
||||||
// must therefore not end the capture. The header declares the table
|
char next_byte[3]; // 2 hex chars + null
|
||||||
// length (raw[2] pairs), so a 0x55 there is always data; one at or
|
|
||||||
// past the first pulse index is a terminator CANDIDATE, confirmed
|
for (uint32_t i = 0; i <= at; i++) {
|
||||||
// once the UART goes quiet (finish_bucket_frame_ in loop()).
|
buf_append_printf(next_byte, sizeof(next_byte), 0, "%02X", raw[i]);
|
||||||
this->bucket_frame_candidate_ = byte == RF_CODE_STOP && at >= 3 + static_cast<size_t>(raw[2]) * 2;
|
str += next_byte;
|
||||||
return true;
|
if ((i > 3) && buckets) {
|
||||||
|
buckets--;
|
||||||
|
}
|
||||||
|
if ((i < 3) || (buckets % 2) || (i == at - 1)) {
|
||||||
|
str += " ";
|
||||||
|
}
|
||||||
|
}
|
||||||
|
ESP_LOGI(TAG, "Received RFBridge Bucket: %s", str.c_str());
|
||||||
|
break;
|
||||||
}
|
}
|
||||||
default:
|
default:
|
||||||
ESP_LOGW(TAG, "Unknown action: 0x%02X", action);
|
ESP_LOGW(TAG, "Unknown action: 0x%02X", action);
|
||||||
@@ -124,47 +119,6 @@ bool RFBridgeComponent::parse_bridge_byte_(uint8_t byte) {
|
|||||||
return false;
|
return false;
|
||||||
}
|
}
|
||||||
|
|
||||||
void RFBridgeComponent::finish_bucket_frame_() {
|
|
||||||
if (this->rx_buffer_.size() < 4) {
|
|
||||||
// The candidate flag requires a header + non-empty bucket table, so
|
|
||||||
// this cannot happen while flag and buffer stay consistent; guard the
|
|
||||||
// raw[2] / size-1 reads against any future divergence anyway.
|
|
||||||
this->rx_buffer_.clear();
|
|
||||||
this->bucket_frame_candidate_ = false;
|
|
||||||
return;
|
|
||||||
}
|
|
||||||
const uint8_t *raw = this->rx_buffer_.data();
|
|
||||||
const size_t at = this->rx_buffer_.size() - 1;
|
|
||||||
|
|
||||||
uint8_t buckets = raw[2] << 1;
|
|
||||||
std::string str;
|
|
||||||
char next_byte[3]; // 2 hex chars + null
|
|
||||||
|
|
||||||
for (uint32_t i = 0; i <= at; i++) {
|
|
||||||
buf_append_printf(next_byte, sizeof(next_byte), 0, "%02X", raw[i]);
|
|
||||||
str += next_byte;
|
|
||||||
if ((i > 3) && buckets) {
|
|
||||||
buckets--;
|
|
||||||
}
|
|
||||||
if ((i < 3) || (buckets % 2) || (i == at - 1)) {
|
|
||||||
str += " ";
|
|
||||||
}
|
|
||||||
}
|
|
||||||
ESP_LOGI(TAG, "Received RFBridge Bucket: %s", str.c_str());
|
|
||||||
|
|
||||||
// Deliberately NOT ACKed: Portisch's B1 command handler leaves its
|
|
||||||
// last_sniffing_command at the previous mode (RF_CODE_RFIN), and its
|
|
||||||
// host-ACK handler re-arms sniffing from that stale value — so ACKing a
|
|
||||||
// bucket delivery silently reverts the radio to standard sniffing and
|
|
||||||
// ends bucket capture. Its delivery path is fire-and-forget and never
|
|
||||||
// waits for a host ACK. Stock Itead firmware never sends B1 frames, so
|
|
||||||
// suppressing this ACK cannot change stock-firmware behavior.
|
|
||||||
// https://github.com/esphome/esphome/issues/17682
|
|
||||||
|
|
||||||
this->rx_buffer_.clear();
|
|
||||||
this->bucket_frame_candidate_ = false;
|
|
||||||
}
|
|
||||||
|
|
||||||
void RFBridgeComponent::write_byte_str_(const std::string &codes) {
|
void RFBridgeComponent::write_byte_str_(const std::string &codes) {
|
||||||
uint8_t code;
|
uint8_t code;
|
||||||
int size = codes.length();
|
int size = codes.length();
|
||||||
@@ -176,31 +130,12 @@ void RFBridgeComponent::write_byte_str_(const std::string &codes) {
|
|||||||
|
|
||||||
void RFBridgeComponent::loop() {
|
void RFBridgeComponent::loop() {
|
||||||
const uint32_t now = App.get_loop_component_start_time();
|
const uint32_t now = App.get_loop_component_start_time();
|
||||||
size_t avail = this->available();
|
if (now - this->last_bridge_byte_ > 50) {
|
||||||
if (avail == 0 && this->bucket_frame_candidate_ && now - this->last_bridge_byte_ > BUCKET_CANDIDATE_QUIET_MS) {
|
|
||||||
// The trailing 0x55 was followed by UART quiet, so it really was the
|
|
||||||
// frame terminator and not an interior data byte.
|
|
||||||
this->finish_bucket_frame_();
|
|
||||||
this->last_bridge_byte_ = now;
|
|
||||||
}
|
|
||||||
const bool receiving_bucket = this->rx_buffer_.size() >= 2 && this->rx_buffer_[1] == RF_CODE_RFIN_BUCKET;
|
|
||||||
if (receiving_bucket) {
|
|
||||||
// Never declare an in-progress bucket frame dead while its continuation
|
|
||||||
// bytes are already queued: a stalled loop() otherwise discards a live
|
|
||||||
// frame that the UART buffer proves is still arriving.
|
|
||||||
if (avail == 0 && now - this->last_bridge_byte_ > BUCKET_FRAME_TIMEOUT_MS) {
|
|
||||||
ESP_LOGD(TAG, "Discarding incomplete RFBridge Bucket frame (%u bytes)",
|
|
||||||
static_cast<unsigned>(this->rx_buffer_.size()));
|
|
||||||
this->rx_buffer_.clear();
|
|
||||||
this->bucket_frame_candidate_ = false;
|
|
||||||
this->last_bridge_byte_ = now;
|
|
||||||
}
|
|
||||||
} else if (now - this->last_bridge_byte_ > 50) {
|
|
||||||
this->rx_buffer_.clear();
|
this->rx_buffer_.clear();
|
||||||
this->bucket_frame_candidate_ = false;
|
|
||||||
this->last_bridge_byte_ = now;
|
this->last_bridge_byte_ = now;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
size_t avail = this->available();
|
||||||
while (avail > 0) {
|
while (avail > 0) {
|
||||||
uint8_t buf[64];
|
uint8_t buf[64];
|
||||||
size_t to_read = std::min(avail, sizeof(buf));
|
size_t to_read = std::min(avail, sizeof(buf));
|
||||||
@@ -211,14 +146,12 @@ void RFBridgeComponent::loop() {
|
|||||||
for (size_t i = 0; i < to_read; i++) {
|
for (size_t i = 0; i < to_read; i++) {
|
||||||
if (this->rx_buffer_.size() > MAX_RX_BUFFER_SIZE) {
|
if (this->rx_buffer_.size() > MAX_RX_BUFFER_SIZE) {
|
||||||
this->rx_buffer_.clear();
|
this->rx_buffer_.clear();
|
||||||
this->bucket_frame_candidate_ = false;
|
|
||||||
}
|
}
|
||||||
if (this->parse_bridge_byte_(buf[i])) {
|
if (this->parse_bridge_byte_(buf[i])) {
|
||||||
ESP_LOGVV(TAG, "Parsed: 0x%02X", buf[i]);
|
ESP_LOGVV(TAG, "Parsed: 0x%02X", buf[i]);
|
||||||
this->last_bridge_byte_ = now;
|
this->last_bridge_byte_ = now;
|
||||||
} else {
|
} else {
|
||||||
this->rx_buffer_.clear();
|
this->rx_buffer_.clear();
|
||||||
this->bucket_frame_candidate_ = false;
|
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -30,17 +30,6 @@ static const uint8_t RF_CODE_BEEP = 0xC0;
|
|||||||
static const uint8_t RF_CODE_STOP = 0x55;
|
static const uint8_t RF_CODE_STOP = 0x55;
|
||||||
static const uint8_t RF_DEBOUNCE = 200;
|
static const uint8_t RF_DEBOUNCE = 200;
|
||||||
static const size_t MAX_RX_BUFFER_SIZE = 512;
|
static const size_t MAX_RX_BUFFER_SIZE = 512;
|
||||||
// ~10 byte times at 19200 baud: long enough to prove the UART went quiet
|
|
||||||
// after a possible bucket-frame terminator, short enough to finish well
|
|
||||||
// before the next radio capture can be delivered.
|
|
||||||
static const uint32_t BUCKET_CANDIDATE_QUIET_MS = 5;
|
|
||||||
// Portisch drains a B1 frame's header, bucket table, and pulse data as
|
|
||||||
// separate UART writes, so an in-progress bucket frame tolerates a longer
|
|
||||||
// inter-region gap than the generic 50 ms inter-byte timeout.
|
|
||||||
static const uint32_t BUCKET_FRAME_TIMEOUT_MS = 250;
|
|
||||||
// Portisch's uart_put_RF_buckets sends at most 7 buckets plus the sync
|
|
||||||
// bucket, so a B1 count byte above 8 (or 0) is malformed for any protocol.
|
|
||||||
static const uint8_t B1_MAX_BUCKET_COUNT = 8;
|
|
||||||
|
|
||||||
struct RFBridgeData {
|
struct RFBridgeData {
|
||||||
uint16_t sync;
|
uint16_t sync;
|
||||||
@@ -78,12 +67,10 @@ class RFBridgeComponent final : public uart::UARTDevice, public Component {
|
|||||||
void ack_();
|
void ack_();
|
||||||
void decode_();
|
void decode_();
|
||||||
bool parse_bridge_byte_(uint8_t byte);
|
bool parse_bridge_byte_(uint8_t byte);
|
||||||
void finish_bucket_frame_();
|
|
||||||
void write_byte_str_(const std::string &codes);
|
void write_byte_str_(const std::string &codes);
|
||||||
|
|
||||||
std::vector<uint8_t> rx_buffer_;
|
std::vector<uint8_t> rx_buffer_;
|
||||||
uint32_t last_bridge_byte_{0};
|
uint32_t last_bridge_byte_{0};
|
||||||
bool bucket_frame_candidate_{false};
|
|
||||||
|
|
||||||
CallbackManager<void(RFBridgeData)> data_callback_;
|
CallbackManager<void(RFBridgeData)> data_callback_;
|
||||||
CallbackManager<void(RFBridgeAdvancedData)> advanced_data_callback_;
|
CallbackManager<void(RFBridgeAdvancedData)> advanced_data_callback_;
|
||||||
|
|||||||
@@ -30,7 +30,6 @@ CONF_SENDSPIN_ID = "sendspin_id"
|
|||||||
CONF_INITIAL_STATIC_DELAY = "initial_static_delay"
|
CONF_INITIAL_STATIC_DELAY = "initial_static_delay"
|
||||||
CONF_FIXED_DELAY = "fixed_delay"
|
CONF_FIXED_DELAY = "fixed_delay"
|
||||||
CONF_DECODE_MEMORY = "decode_memory"
|
CONF_DECODE_MEMORY = "decode_memory"
|
||||||
CONF_CODECS = "codecs"
|
|
||||||
|
|
||||||
# Matches ARTWORK_MAX_SLOTS in sendspin-cpp.
|
# Matches ARTWORK_MAX_SLOTS in sendspin-cpp.
|
||||||
MAX_ARTWORK_SLOTS = 4
|
MAX_ARTWORK_SLOTS = 4
|
||||||
@@ -45,20 +44,6 @@ CODEC_FORMAT_OPUS = SendspinCodecFormat.enum("OPUS")
|
|||||||
CODEC_FORMAT_PCM = SendspinCodecFormat.enum("PCM")
|
CODEC_FORMAT_PCM = SendspinCodecFormat.enum("PCM")
|
||||||
CODEC_FORMAT_UNSUPPORTED = SendspinCodecFormat.enum("UNSUPPORTED")
|
CODEC_FORMAT_UNSUPPORTED = SendspinCodecFormat.enum("UNSUPPORTED")
|
||||||
|
|
||||||
CODEC_FLAC = "flac"
|
|
||||||
CODEC_OPUS = "opus"
|
|
||||||
CODEC_PCM = "pcm"
|
|
||||||
|
|
||||||
CODECS = {
|
|
||||||
CODEC_FLAC: CODEC_FORMAT_FLAC,
|
|
||||||
CODEC_OPUS: CODEC_FORMAT_OPUS,
|
|
||||||
CODEC_PCM: CODEC_FORMAT_PCM,
|
|
||||||
}
|
|
||||||
|
|
||||||
# Opus only supports 48 kHz audio, so it is left out of the default list at other rates.
|
|
||||||
DEFAULT_CODECS = [CODEC_FLAC, CODEC_OPUS, CODEC_PCM]
|
|
||||||
OPUS_SAMPLE_RATE = 48000
|
|
||||||
|
|
||||||
SendspinImageFormat = sendspin_library_ns.enum("SendspinImageFormat", is_class=True)
|
SendspinImageFormat = sendspin_library_ns.enum("SendspinImageFormat", is_class=True)
|
||||||
IMAGE_FORMAT_JPEG = SendspinImageFormat.enum("JPEG")
|
IMAGE_FORMAT_JPEG = SendspinImageFormat.enum("JPEG")
|
||||||
IMAGE_FORMAT_PNG = SendspinImageFormat.enum("PNG")
|
IMAGE_FORMAT_PNG = SendspinImageFormat.enum("PNG")
|
||||||
@@ -301,13 +286,16 @@ async def to_code(config: ConfigType) -> None:
|
|||||||
if data.player_support:
|
if data.player_support:
|
||||||
cg.add_define("USE_SENDSPIN_PLAYER", True)
|
cg.add_define("USE_SENDSPIN_PLAYER", True)
|
||||||
|
|
||||||
# Configures the player role. Each configured codec is advertised for 16 bits per sample
|
# Configures the player role. We always assume support for 16 bits per sample mono and stereo FLAC, Opus, and PCM at the configured sample rate
|
||||||
# mono and stereo at the configured sample rate. The order is a preference order, both for
|
# (with Opus only supported at 48 kHz since that's the only sample rate it supports). Users can configure the specific formats via the Sendspin server
|
||||||
# the codecs themselves and for stereo over mono.
|
|
||||||
player_cfg = data.player_config
|
player_cfg = data.player_config
|
||||||
sample_rate = player_cfg[CONF_SAMPLE_RATE]
|
sample_rate = player_cfg[CONF_SAMPLE_RATE]
|
||||||
|
|
||||||
codecs = player_cfg[CONF_CODECS]
|
# OPUS only supports 48 kHz audio
|
||||||
|
codecs = [CODEC_FORMAT_FLAC]
|
||||||
|
if sample_rate == 48000:
|
||||||
|
codecs.append(CODEC_FORMAT_OPUS)
|
||||||
|
codecs.append(CODEC_FORMAT_PCM)
|
||||||
|
|
||||||
def _audio_format(codec: MockObj, channels: int) -> cg.StructInitializer:
|
def _audio_format(codec: MockObj, channels: int) -> cg.StructInitializer:
|
||||||
return cg.StructInitializer(
|
return cg.StructInitializer(
|
||||||
|
|||||||
@@ -13,16 +13,11 @@ from esphome.cpp_generator import MockObj, TemplateArgsType
|
|||||||
from esphome.types import ConfigType
|
from esphome.types import ConfigType
|
||||||
|
|
||||||
from .. import (
|
from .. import (
|
||||||
CODEC_OPUS,
|
|
||||||
CODECS,
|
|
||||||
CONF_CODECS,
|
|
||||||
CONF_DECODE_MEMORY,
|
CONF_DECODE_MEMORY,
|
||||||
CONF_FIXED_DELAY,
|
CONF_FIXED_DELAY,
|
||||||
CONF_INITIAL_STATIC_DELAY,
|
CONF_INITIAL_STATIC_DELAY,
|
||||||
CONF_SENDSPIN_ID,
|
CONF_SENDSPIN_ID,
|
||||||
DEFAULT_CODECS,
|
|
||||||
MEMORY_LOCATIONS,
|
MEMORY_LOCATIONS,
|
||||||
OPUS_SAMPLE_RATE,
|
|
||||||
SendspinHub,
|
SendspinHub,
|
||||||
register_player_config,
|
register_player_config,
|
||||||
request_controller_support,
|
request_controller_support,
|
||||||
@@ -54,32 +49,10 @@ DisableStaticDelayAdjustmentAction = sendspin_ns.class_(
|
|||||||
)
|
)
|
||||||
|
|
||||||
|
|
||||||
def _resolve_codecs(config: ConfigType) -> ConfigType:
|
|
||||||
"""Validate the codec preference list, filling in the default when it is not set."""
|
|
||||||
sample_rate = config[CONF_SAMPLE_RATE]
|
|
||||||
if (codecs := config.get(CONF_CODECS)) is None:
|
|
||||||
config[CONF_CODECS] = [
|
|
||||||
codec
|
|
||||||
for codec in DEFAULT_CODECS
|
|
||||||
if codec != CODEC_OPUS or sample_rate == OPUS_SAMPLE_RATE
|
|
||||||
]
|
|
||||||
return config
|
|
||||||
|
|
||||||
if len(set(codecs)) != len(codecs):
|
|
||||||
raise cv.Invalid("Each codec may only be listed once", path=[CONF_CODECS])
|
|
||||||
if CODEC_OPUS in codecs and sample_rate != OPUS_SAMPLE_RATE:
|
|
||||||
raise cv.Invalid(
|
|
||||||
f"Codec '{CODEC_OPUS}' requires a {CONF_SAMPLE_RATE} of {OPUS_SAMPLE_RATE}",
|
|
||||||
path=[CONF_CODECS],
|
|
||||||
)
|
|
||||||
return config
|
|
||||||
|
|
||||||
|
|
||||||
def _register(config: ConfigType) -> ConfigType:
|
def _register(config: ConfigType) -> ConfigType:
|
||||||
request_controller_support()
|
request_controller_support()
|
||||||
register_player_config(
|
register_player_config(
|
||||||
{
|
{
|
||||||
CONF_CODECS: config[CONF_CODECS],
|
|
||||||
CONF_SAMPLE_RATE: config[CONF_SAMPLE_RATE],
|
CONF_SAMPLE_RATE: config[CONF_SAMPLE_RATE],
|
||||||
CONF_BUFFER_SIZE: config[CONF_BUFFER_SIZE],
|
CONF_BUFFER_SIZE: config[CONF_BUFFER_SIZE],
|
||||||
CONF_INITIAL_STATIC_DELAY: config[CONF_INITIAL_STATIC_DELAY],
|
CONF_INITIAL_STATIC_DELAY: config[CONF_INITIAL_STATIC_DELAY],
|
||||||
@@ -112,13 +85,9 @@ CONFIG_SCHEMA = cv.All(
|
|||||||
min=16000, max=96000
|
min=16000, max=96000
|
||||||
),
|
),
|
||||||
cv.Optional(CONF_DECODE_MEMORY): cv.one_of(*MEMORY_LOCATIONS, lower=True),
|
cv.Optional(CONF_DECODE_MEMORY): cv.one_of(*MEMORY_LOCATIONS, lower=True),
|
||||||
cv.Optional(CONF_CODECS): cv.All(
|
|
||||||
cv.ensure_list(cv.enum(CODECS, lower=True)), cv.Length(min=1)
|
|
||||||
),
|
|
||||||
}
|
}
|
||||||
),
|
),
|
||||||
cv.only_on_esp32,
|
cv.only_on_esp32,
|
||||||
_resolve_codecs,
|
|
||||||
_register,
|
_register,
|
||||||
)
|
)
|
||||||
|
|
||||||
|
|||||||
@@ -202,15 +202,8 @@ AudioPipelineState AudioPipeline::process_state() {
|
|||||||
if (!this->is_playing_) {
|
if (!this->is_playing_) {
|
||||||
// The tasks have been stopped for two ``process_state`` calls in a row, so delete the tasks
|
// The tasks have been stopped for two ``process_state`` calls in a row, so delete the tasks
|
||||||
if (this->read_task_.is_created() || this->decode_task_.is_created()) {
|
if (this->read_task_.is_created() || this->decode_task_.is_created()) {
|
||||||
// Both are attempted every time; a task that is still running on the other core is freed by a
|
this->read_task_.deallocate();
|
||||||
// subsequent call, and freeing an already freed task succeeds without doing anything
|
this->decode_task_.deallocate();
|
||||||
bool read_task_freed = this->read_task_.deallocate();
|
|
||||||
bool decode_task_freed = this->decode_task_.deallocate();
|
|
||||||
if (!read_task_freed || !decode_task_freed) {
|
|
||||||
// A task is still running on the other core, so keep the pipeline in its current state and try
|
|
||||||
// again on the next call
|
|
||||||
return AudioPipelineState::PLAYING;
|
|
||||||
}
|
|
||||||
if (this->hard_stop_) {
|
if (this->hard_stop_) {
|
||||||
// Stop command was sent, so immediately end the playback
|
// Stop command was sent, so immediately end the playback
|
||||||
this->speaker_->stop();
|
this->speaker_->stop();
|
||||||
@@ -322,17 +315,17 @@ void AudioPipeline::read_task(void *params) {
|
|||||||
if (err == ESP_OK) {
|
if (err == ESP_OK) {
|
||||||
size_t file_ring_buffer_size = this_pipeline->buffer_size_;
|
size_t file_ring_buffer_size = this_pipeline->buffer_size_;
|
||||||
|
|
||||||
std::shared_ptr<ring_buffer::RingBuffer> temp_ring_buffer = this_pipeline->raw_file_ring_buffer_.lock();
|
std::shared_ptr<ring_buffer::RingBuffer> temp_ring_buffer;
|
||||||
|
|
||||||
if (temp_ring_buffer == nullptr) {
|
if (!this_pipeline->raw_file_ring_buffer_.use_count()) {
|
||||||
temp_ring_buffer = ring_buffer::RingBuffer::create(file_ring_buffer_size);
|
temp_ring_buffer = ring_buffer::RingBuffer::create(file_ring_buffer_size);
|
||||||
this_pipeline->raw_file_ring_buffer_ = temp_ring_buffer;
|
this_pipeline->raw_file_ring_buffer_ = temp_ring_buffer;
|
||||||
}
|
}
|
||||||
|
|
||||||
if (temp_ring_buffer == nullptr) {
|
if (!this_pipeline->raw_file_ring_buffer_.use_count()) {
|
||||||
err = ESP_ERR_NO_MEM;
|
err = ESP_ERR_NO_MEM;
|
||||||
} else {
|
} else {
|
||||||
err = reader->add_sink(temp_ring_buffer);
|
reader->add_sink(this_pipeline->raw_file_ring_buffer_);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -403,9 +396,7 @@ void AudioPipeline::decode_task(void *params) {
|
|||||||
make_unique<audio::AudioDecoder>(this_pipeline->transfer_buffer_size_, this_pipeline->transfer_buffer_size_);
|
make_unique<audio::AudioDecoder>(this_pipeline->transfer_buffer_size_, this_pipeline->transfer_buffer_size_);
|
||||||
|
|
||||||
esp_err_t err = decoder->start(this_pipeline->current_audio_file_type_);
|
esp_err_t err = decoder->start(this_pipeline->current_audio_file_type_);
|
||||||
if (err == ESP_OK) {
|
decoder->add_source(this_pipeline->raw_file_ring_buffer_);
|
||||||
err = decoder->add_source(this_pipeline->raw_file_ring_buffer_);
|
|
||||||
}
|
|
||||||
|
|
||||||
if (err != ESP_OK) {
|
if (err != ESP_OK) {
|
||||||
// Send specific error message
|
// Send specific error message
|
||||||
|
|||||||
@@ -1,13 +1,10 @@
|
|||||||
#include "tuya.h"
|
#include "tuya.h"
|
||||||
|
#include "esphome/components/network/util.h"
|
||||||
#include "esphome/core/gpio.h"
|
#include "esphome/core/gpio.h"
|
||||||
#include "esphome/core/helpers.h"
|
#include "esphome/core/helpers.h"
|
||||||
#include "esphome/core/log.h"
|
#include "esphome/core/log.h"
|
||||||
#include "esphome/core/util.h"
|
#include "esphome/core/util.h"
|
||||||
|
|
||||||
#ifdef USE_NETWORK
|
|
||||||
#include "esphome/components/network/util.h"
|
|
||||||
#endif
|
|
||||||
|
|
||||||
#ifdef USE_WIFI
|
#ifdef USE_WIFI
|
||||||
#include "esphome/components/wifi/wifi_component.h"
|
#include "esphome/components/wifi/wifi_component.h"
|
||||||
#endif
|
#endif
|
||||||
@@ -25,14 +22,6 @@ static const int MAX_RETRIES = 5;
|
|||||||
// Max bytes to log for datapoint values (larger values are truncated)
|
// Max bytes to log for datapoint values (larger values are truncated)
|
||||||
static constexpr size_t MAX_DATAPOINT_LOG_BYTES = 16;
|
static constexpr size_t MAX_DATAPOINT_LOG_BYTES = 16;
|
||||||
|
|
||||||
static bool network_is_connected() {
|
|
||||||
#ifdef USE_NETWORK
|
|
||||||
return network::is_connected();
|
|
||||||
#else
|
|
||||||
return false;
|
|
||||||
#endif
|
|
||||||
}
|
|
||||||
|
|
||||||
void Tuya::setup() {
|
void Tuya::setup() {
|
||||||
this->set_interval("heartbeat", 15000, [this] { this->send_empty_command_(TuyaCommandType::HEARTBEAT); });
|
this->set_interval("heartbeat", 15000, [this] { this->send_empty_command_(TuyaCommandType::HEARTBEAT); });
|
||||||
if (this->status_pin_ != nullptr) {
|
if (this->status_pin_ != nullptr) {
|
||||||
@@ -565,14 +554,14 @@ void Tuya::send_empty_command_(TuyaCommandType command) {
|
|||||||
}
|
}
|
||||||
|
|
||||||
void Tuya::set_status_pin_() {
|
void Tuya::set_status_pin_() {
|
||||||
bool is_network_ready = network_is_connected() && remote_is_connected();
|
bool is_network_ready = network::is_connected() && remote_is_connected();
|
||||||
this->status_pin_->digital_write(is_network_ready);
|
this->status_pin_->digital_write(is_network_ready);
|
||||||
}
|
}
|
||||||
|
|
||||||
uint8_t Tuya::get_wifi_status_code_() {
|
uint8_t Tuya::get_wifi_status_code_() {
|
||||||
uint8_t status = 0x02;
|
uint8_t status = 0x02;
|
||||||
|
|
||||||
if (network_is_connected()) {
|
if (network::is_connected()) {
|
||||||
status = 0x03;
|
status = 0x03;
|
||||||
|
|
||||||
// Protocol version 3 also supports specifying when connected to "the cloud"
|
// Protocol version 3 also supports specifying when connected to "the cloud"
|
||||||
|
|||||||
@@ -1,4 +1,5 @@
|
|||||||
from typing import Any
|
from collections.abc import Callable
|
||||||
|
from typing import Any, NoReturn
|
||||||
|
|
||||||
from esphome import automation
|
from esphome import automation
|
||||||
from esphome.automation import Trigger
|
from esphome.automation import Trigger
|
||||||
@@ -47,10 +48,17 @@ UDP_SCHEMA = cv.Schema(
|
|||||||
)
|
)
|
||||||
|
|
||||||
|
|
||||||
|
def is_relocated(option: str) -> Callable[[Any], NoReturn]:
|
||||||
|
def validator(value: Any) -> NoReturn:
|
||||||
|
raise cv.Invalid(
|
||||||
|
f"The '{option}' option should now be configured in the 'packet_transport' component"
|
||||||
|
)
|
||||||
|
|
||||||
|
return validator
|
||||||
|
|
||||||
|
|
||||||
RELOCATED = {
|
RELOCATED = {
|
||||||
cv.Optional(x): cv.invalid(
|
cv.Optional(x): is_relocated(x)
|
||||||
f"The '{x}' option should now be configured in the 'packet_transport' component"
|
|
||||||
)
|
|
||||||
for x in (
|
for x in (
|
||||||
CONF_PROVIDERS,
|
CONF_PROVIDERS,
|
||||||
CONF_ENCRYPTION,
|
CONF_ENCRYPTION,
|
||||||
|
|||||||
@@ -66,13 +66,14 @@ from esphome.const import (
|
|||||||
)
|
)
|
||||||
from esphome.core import (
|
from esphome.core import (
|
||||||
CORE,
|
CORE,
|
||||||
|
ID,
|
||||||
CoroPriority,
|
CoroPriority,
|
||||||
EsphomeError,
|
EsphomeError,
|
||||||
HexInt,
|
HexInt,
|
||||||
coroutine_with_priority,
|
coroutine_with_priority,
|
||||||
)
|
)
|
||||||
import esphome.final_validate as fv
|
import esphome.final_validate as fv
|
||||||
from esphome.types import ConfigType
|
from esphome.types import ConfigType, TemplateArgsType
|
||||||
|
|
||||||
from . import wpa2_eap
|
from . import wpa2_eap
|
||||||
|
|
||||||
@@ -208,6 +209,7 @@ WiFiEnabledCondition = wifi_ns.class_("WiFiEnabledCondition", Condition)
|
|||||||
WiFiAPActiveCondition = wifi_ns.class_("WiFiAPActiveCondition", Condition)
|
WiFiAPActiveCondition = wifi_ns.class_("WiFiAPActiveCondition", Condition)
|
||||||
WiFiEnableAction = wifi_ns.class_("WiFiEnableAction", automation.Action)
|
WiFiEnableAction = wifi_ns.class_("WiFiEnableAction", automation.Action)
|
||||||
WiFiDisableAction = wifi_ns.class_("WiFiDisableAction", automation.Action)
|
WiFiDisableAction = wifi_ns.class_("WiFiDisableAction", automation.Action)
|
||||||
|
WiFiRoamAction = wifi_ns.class_("WiFiRoamAction", automation.Action)
|
||||||
WiFiConfigureAction = wifi_ns.class_(
|
WiFiConfigureAction = wifi_ns.class_(
|
||||||
"WiFiConfigureAction", automation.Action, cg.Component
|
"WiFiConfigureAction", automation.Action, cg.Component
|
||||||
)
|
)
|
||||||
@@ -820,6 +822,18 @@ async def wifi_disable_to_code(config, action_id, template_arg, args):
|
|||||||
return cg.new_Pvariable(action_id, template_arg)
|
return cg.new_Pvariable(action_id, template_arg)
|
||||||
|
|
||||||
|
|
||||||
|
@automation.register_action(
|
||||||
|
"wifi.roam", WiFiRoamAction, cv.Schema({}), synchronous=True
|
||||||
|
)
|
||||||
|
async def wifi_roam_to_code(
|
||||||
|
config: ConfigType,
|
||||||
|
action_id: ID,
|
||||||
|
template_arg: cg.TemplateArguments,
|
||||||
|
args: TemplateArgsType,
|
||||||
|
) -> cg.MockObj:
|
||||||
|
return cg.new_Pvariable(action_id, template_arg)
|
||||||
|
|
||||||
|
|
||||||
KEEP_SCAN_RESULTS_KEY = "wifi_keep_scan_results"
|
KEEP_SCAN_RESULTS_KEY = "wifi_keep_scan_results"
|
||||||
RUNTIME_POWER_SAVE_KEY = "wifi_runtime_power_save"
|
RUNTIME_POWER_SAVE_KEY = "wifi_runtime_power_save"
|
||||||
RUNTIME_ROAMING_SUPPRESSION_KEY = "wifi_runtime_roaming_suppression"
|
RUNTIME_ROAMING_SUPPRESSION_KEY = "wifi_runtime_roaming_suppression"
|
||||||
|
|||||||
@@ -31,6 +31,11 @@ template<typename... Ts> class WiFiDisableAction final : public Action<Ts...> {
|
|||||||
void play(const Ts &...x) override { global_wifi_component->disable(); }
|
void play(const Ts &...x) override { global_wifi_component->disable(); }
|
||||||
};
|
};
|
||||||
|
|
||||||
|
template<typename... Ts> class WiFiRoamAction final : public Action<Ts...> {
|
||||||
|
public:
|
||||||
|
void play(const Ts &...x) override { global_wifi_component->force_roam_check(); }
|
||||||
|
};
|
||||||
|
|
||||||
template<typename... Ts> class WiFiConfigureAction final : public Action<Ts...>, public Component {
|
template<typename... Ts> class WiFiConfigureAction final : public Action<Ts...>, public Component {
|
||||||
public:
|
public:
|
||||||
TEMPLATABLE_VALUE(std::string, ssid)
|
TEMPLATABLE_VALUE(std::string, ssid)
|
||||||
|
|||||||
@@ -846,17 +846,18 @@ void WiFiComponent::loop() {
|
|||||||
this->notify_connect_state_listeners_();
|
this->notify_connect_state_listeners_();
|
||||||
#endif
|
#endif
|
||||||
|
|
||||||
// Post-connect roaming: check for better AP
|
// Post-connect roaming: check for better AP. A scan may have been started by an
|
||||||
if (this->post_connect_roaming_) {
|
// explicit force_roam_check() even when post_connect_roaming_ is disabled, so the
|
||||||
if (this->is_roaming_scan_active()) {
|
// scan must always be consumed here to avoid leaving roaming_state_ stuck.
|
||||||
if (this->scan_done_) {
|
if (this->is_roaming_scan_active()) {
|
||||||
this->process_roaming_scan_();
|
if (this->scan_done_) {
|
||||||
}
|
this->process_roaming_scan_();
|
||||||
// else: scan in progress, wait
|
|
||||||
} else if (this->roaming_state_ == RoamingState::IDLE && this->roaming_attempts_ < ROAMING_MAX_ATTEMPTS &&
|
|
||||||
now - this->roaming_last_check_ >= ROAMING_CHECK_INTERVAL && !this->roaming_suppressed_()) {
|
|
||||||
this->check_roaming_(now);
|
|
||||||
}
|
}
|
||||||
|
// else: scan in progress, wait
|
||||||
|
} else if (this->post_connect_roaming_ && this->roaming_state_ == RoamingState::IDLE &&
|
||||||
|
this->roaming_attempts_ < ROAMING_MAX_ATTEMPTS &&
|
||||||
|
now - this->roaming_last_check_ >= ROAMING_CHECK_INTERVAL && !this->roaming_suppressed_()) {
|
||||||
|
this->check_roaming_(now);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
break;
|
break;
|
||||||
@@ -2463,6 +2464,17 @@ void WiFiComponent::notify_scan_results_listeners_() {
|
|||||||
}
|
}
|
||||||
#endif // USE_WIFI_SCAN_RESULTS_LISTENERS
|
#endif // USE_WIFI_SCAN_RESULTS_LISTENERS
|
||||||
|
|
||||||
|
void WiFiComponent::force_roam_check() {
|
||||||
|
if (!this->is_connected() || this->roaming_state_ != RoamingState::IDLE || this->roaming_suppressed_()) {
|
||||||
|
ESP_LOGD(TAG, "Roam check requested, but not able to check now");
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
// Reset the attempt counter so a prior run of failed roams doesn't block this explicit request
|
||||||
|
// Note that this re-arms automatic roaming if enabled.
|
||||||
|
this->roaming_attempts_ = 0;
|
||||||
|
this->check_roaming_(millis());
|
||||||
|
}
|
||||||
|
|
||||||
void WiFiComponent::check_roaming_(uint32_t now) {
|
void WiFiComponent::check_roaming_(uint32_t now) {
|
||||||
// Guard: not for hidden networks (may not appear in scan)
|
// Guard: not for hidden networks (may not appear in scan)
|
||||||
const WiFiAP *selected = this->get_selected_sta_();
|
const WiFiAP *selected = this->get_selected_sta_();
|
||||||
@@ -2484,7 +2496,11 @@ void WiFiComponent::check_roaming_(uint32_t now) {
|
|||||||
|
|
||||||
ESP_LOGD(TAG, "Roam scan (%d dBm, attempt %u/%u)", rssi, this->roaming_attempts_, ROAMING_MAX_ATTEMPTS);
|
ESP_LOGD(TAG, "Roam scan (%d dBm, attempt %u/%u)", rssi, this->roaming_attempts_, ROAMING_MAX_ATTEMPTS);
|
||||||
this->roaming_state_ = RoamingState::SCANNING;
|
this->roaming_state_ = RoamingState::SCANNING;
|
||||||
this->wifi_scan_start_(this->passive_scan_);
|
if (!this->wifi_scan_start_(this->passive_scan_)) {
|
||||||
|
// Scan failed to start (e.g. busy) - don't get stuck in SCANNING forever
|
||||||
|
ESP_LOGD(TAG, "Roam scan failed to start");
|
||||||
|
this->roaming_state_ = RoamingState::IDLE;
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
void WiFiComponent::process_roaming_scan_() {
|
void WiFiComponent::process_roaming_scan_() {
|
||||||
|
|||||||
@@ -565,6 +565,12 @@ class WiFiComponent final : public Component {
|
|||||||
void set_keep_scan_results(bool keep_scan_results) { this->keep_scan_results_ = keep_scan_results; }
|
void set_keep_scan_results(bool keep_scan_results) { this->keep_scan_results_ = keep_scan_results; }
|
||||||
void set_post_connect_roaming(bool enabled) { this->post_connect_roaming_ = enabled; }
|
void set_post_connect_roaming(bool enabled) { this->post_connect_roaming_ = enabled; }
|
||||||
|
|
||||||
|
/** Force an immediate post-connect roaming check, bypassing the periodic interval and the
|
||||||
|
* per-connection attempt limit. Does nothing (besides a debug log) if not connected, if a
|
||||||
|
* roam scan or connect is already in progress, or if roaming is currently suppressed.
|
||||||
|
*/
|
||||||
|
void force_roam_check();
|
||||||
|
|
||||||
#ifdef USE_WIFI_CONNECT_TRIGGER
|
#ifdef USE_WIFI_CONNECT_TRIGGER
|
||||||
Trigger<> *get_connect_trigger() { return &this->connect_trigger_; }
|
Trigger<> *get_connect_trigger() { return &this->connect_trigger_; }
|
||||||
#endif
|
#endif
|
||||||
|
|||||||
+1
-1
@@ -4,7 +4,7 @@ from enum import Enum
|
|||||||
|
|
||||||
from esphome.enum import StrEnum
|
from esphome.enum import StrEnum
|
||||||
|
|
||||||
__version__ = "2026.9.0b3"
|
__version__ = "2026.10.0-dev"
|
||||||
|
|
||||||
ALLOWED_NAME_CHARS = "abcdefghijklmnopqrstuvwxyz0123456789-_"
|
ALLOWED_NAME_CHARS = "abcdefghijklmnopqrstuvwxyz0123456789-_"
|
||||||
VALID_SUBSTITUTIONS_CHARACTERS = (
|
VALID_SUBSTITUTIONS_CHARACTERS = (
|
||||||
|
|||||||
@@ -40,31 +40,16 @@ bool StaticTask::create(TaskFunction_t fn, const char *name, uint32_t stack_size
|
|||||||
return true;
|
return true;
|
||||||
}
|
}
|
||||||
|
|
||||||
bool StaticTask::destroy() {
|
void StaticTask::destroy() {
|
||||||
if (this->handle_ == nullptr) {
|
if (this->handle_ != nullptr) {
|
||||||
return true;
|
TaskHandle_t handle = this->handle_;
|
||||||
|
this->handle_ = nullptr;
|
||||||
|
vTaskDelete(handle);
|
||||||
}
|
}
|
||||||
|
|
||||||
// Suspending takes the task off the ready and event lists, so nothing can schedule it again. It only asks
|
|
||||||
// the other core to yield though, so the task may still be running on it for a moment.
|
|
||||||
vTaskSuspend(this->handle_);
|
|
||||||
if (eTaskGetState(this->handle_) != eSuspended) {
|
|
||||||
// The task is still running on the other core and using its stack. Deleting it now would only put it on
|
|
||||||
// the termination list and return, so the caller has to try again once it has been swapped out.
|
|
||||||
return false;
|
|
||||||
}
|
|
||||||
|
|
||||||
// The task cannot run again, so the delete completes right away instead of being left to the idle task.
|
|
||||||
TaskHandle_t handle = this->handle_;
|
|
||||||
this->handle_ = nullptr;
|
|
||||||
vTaskDelete(handle);
|
|
||||||
return true;
|
|
||||||
}
|
}
|
||||||
|
|
||||||
bool StaticTask::deallocate() {
|
void StaticTask::deallocate() {
|
||||||
if (!this->destroy()) {
|
this->destroy();
|
||||||
return false;
|
|
||||||
}
|
|
||||||
if (this->stack_buffer_ != nullptr) {
|
if (this->stack_buffer_ != nullptr) {
|
||||||
RAMAllocator<StackType_t> allocator(this->use_psram_ ? RAMAllocator<StackType_t>::ALLOC_EXTERNAL
|
RAMAllocator<StackType_t> allocator(this->use_psram_ ? RAMAllocator<StackType_t>::ALLOC_EXTERNAL
|
||||||
: RAMAllocator<StackType_t>::ALLOC_INTERNAL);
|
: RAMAllocator<StackType_t>::ALLOC_INTERNAL);
|
||||||
@@ -72,7 +57,6 @@ bool StaticTask::deallocate() {
|
|||||||
this->stack_buffer_ = nullptr;
|
this->stack_buffer_ = nullptr;
|
||||||
this->stack_size_ = 0;
|
this->stack_size_ = 0;
|
||||||
}
|
}
|
||||||
return true;
|
|
||||||
}
|
}
|
||||||
|
|
||||||
} // namespace esphome
|
} // namespace esphome
|
||||||
|
|||||||
@@ -11,7 +11,6 @@ namespace esphome {
|
|||||||
|
|
||||||
/** Helper for FreeRTOS static task management.
|
/** Helper for FreeRTOS static task management.
|
||||||
* Bundles TaskHandle_t, StaticTask_t, and the stack buffer into one object with create/destroy methods.
|
* Bundles TaskHandle_t, StaticTask_t, and the stack buffer into one object with create/destroy methods.
|
||||||
* Call destroy() and deallocate() from another task: a task cannot free the stack it is still running on.
|
|
||||||
*/
|
*/
|
||||||
class StaticTask {
|
class StaticTask {
|
||||||
public:
|
public:
|
||||||
@@ -24,7 +23,7 @@ class StaticTask {
|
|||||||
/// @brief Allocate stack and create task.
|
/// @brief Allocate stack and create task.
|
||||||
/// @param fn Task function
|
/// @param fn Task function
|
||||||
/// @param name Task name (for debug)
|
/// @param name Task name (for debug)
|
||||||
/// @param stack_size Stack size in bytes (StackType_t is a byte on ESP-IDF)
|
/// @param stack_size Stack size in StackType_t words
|
||||||
/// @param param Parameter passed to task function
|
/// @param param Parameter passed to task function
|
||||||
/// @param priority FreeRTOS task priority
|
/// @param priority FreeRTOS task priority
|
||||||
/// @param use_psram If true, allocate stack in PSRAM; otherwise internal RAM
|
/// @param use_psram If true, allocate stack in PSRAM; otherwise internal RAM
|
||||||
@@ -32,17 +31,11 @@ class StaticTask {
|
|||||||
bool create(TaskFunction_t fn, const char *name, uint32_t stack_size, void *param, UBaseType_t priority,
|
bool create(TaskFunction_t fn, const char *name, uint32_t stack_size, void *param, UBaseType_t priority,
|
||||||
bool use_psram);
|
bool use_psram);
|
||||||
|
|
||||||
/// @brief Delete the task, keeping the stack buffer allocated for reuse by a subsequent create() call.
|
/// @brief Delete the task but keep the stack buffer allocated for reuse by a subsequent create() call.
|
||||||
/// The task must have finished its work and parked itself, either suspended or blocked indefinitely: it is
|
void destroy();
|
||||||
/// suspended here so that it cannot be scheduled again, and it is given no chance to clean up.
|
|
||||||
/// @return true if the task was deleted; false if it is still running on another core, in which case the
|
|
||||||
/// caller should try again later.
|
|
||||||
bool destroy();
|
|
||||||
|
|
||||||
/// @brief Delete the task (if created) and free the stack buffer.
|
/// @brief Delete the task (if running) and free the stack buffer.
|
||||||
/// @return true if the stack buffer was freed; false if the task is still running on another core, in
|
void deallocate();
|
||||||
/// which case the caller should try again later.
|
|
||||||
bool deallocate();
|
|
||||||
|
|
||||||
protected:
|
protected:
|
||||||
TaskHandle_t handle_{nullptr};
|
TaskHandle_t handle_{nullptr};
|
||||||
|
|||||||
+3
-6
@@ -96,10 +96,6 @@ UPLOAD_BUFFER_SIZE = UPLOAD_BLOCK_SIZE * 8
|
|||||||
# across the addresses on top of that.
|
# across the addresses on top of that.
|
||||||
EXTRA_UPLOAD_ATTEMPTS = 2
|
EXTRA_UPLOAD_ATTEMPTS = 2
|
||||||
UPLOAD_RETRY_DELAY = 5.0
|
UPLOAD_RETRY_DELAY = 5.0
|
||||||
# Data phase timeout; must stay longer than the device's OTA_SOCKET_TIMEOUT_DATA
|
|
||||||
# (105 s) so a stalled session is gone before a retry, and long enough for lwIP
|
|
||||||
# to get a lost chunk ack through after the retransmit run seen in practice
|
|
||||||
DATA_PHASE_TIMEOUT = 160.0
|
|
||||||
|
|
||||||
_LOGGER = logging.getLogger(__name__)
|
_LOGGER = logging.getLogger(__name__)
|
||||||
|
|
||||||
@@ -698,7 +694,8 @@ def perform_ota(
|
|||||||
|
|
||||||
_LOGGER.info("Handshake complete")
|
_LOGGER.info("Handshake complete")
|
||||||
|
|
||||||
sock.settimeout(DATA_PHASE_TIMEOUT)
|
# Timeout must match device-side OTA_SOCKET_TIMEOUT_DATA to prevent premature failures
|
||||||
|
sock.settimeout(90.0)
|
||||||
|
|
||||||
if extended_proto:
|
if extended_proto:
|
||||||
send_check(sock, ota_type, "ota type")
|
send_check(sock, ota_type, "ota type")
|
||||||
@@ -857,7 +854,7 @@ def run_ota_impl_(
|
|||||||
# clean up a half-open connection (its handshake watchdog runs at 20s);
|
# clean up a half-open connection (its handshake watchdog runs at 20s);
|
||||||
# moving on to the next address family stays immediate. Known limitation:
|
# moving on to the next address family stays immediate. Known limitation:
|
||||||
# a silent mid-transfer drop with no reset can wedge the device until its
|
# a silent mid-transfer drop with no reset can wedge the device until its
|
||||||
# 105s data timeout, which outlasts this budget; the retries target the
|
# 90s data timeout, which outlasts this budget; the retries target the
|
||||||
# common failures where the device resets or closes the link promptly.
|
# common failures where the device resets or closes the link promptly.
|
||||||
total_attempts = len(res) + EXTRA_UPLOAD_ATTEMPTS
|
total_attempts = len(res) + EXTRA_UPLOAD_ATTEMPTS
|
||||||
last_error = ""
|
last_error = ""
|
||||||
|
|||||||
@@ -616,15 +616,11 @@ def _make_registry_client() -> Any:
|
|||||||
elsewhere, not by the PlatformIO registry.
|
elsewhere, not by the PlatformIO registry.
|
||||||
"""
|
"""
|
||||||
from platformio.package.manager._registry import PackageManagerRegistryMixin
|
from platformio.package.manager._registry import PackageManagerRegistryMixin
|
||||||
from platformio.registry.client import RegistryClient
|
|
||||||
|
|
||||||
class _Registry(PackageManagerRegistryMixin):
|
class _Registry(PackageManagerRegistryMixin):
|
||||||
def __init__(self) -> None:
|
def __init__(self) -> None:
|
||||||
|
self._registry_client = None
|
||||||
self.pkg_type = "library"
|
self.pkg_type = "library"
|
||||||
self._registry_client = RegistryClient()
|
|
||||||
# The probe sleeps ~500 ms per lookup (see runner.patch_registry_private_packages);
|
|
||||||
# instance-level so the ESPHome process never patches PlatformIO's class
|
|
||||||
self._registry_client.allowed_private_packages = lambda: False
|
|
||||||
|
|
||||||
@staticmethod
|
@staticmethod
|
||||||
def is_system_compatible(value: Any, custom_system: Any = None) -> bool:
|
def is_system_compatible(value: Any, custom_system: Any = None) -> bool:
|
||||||
|
|||||||
@@ -951,10 +951,8 @@ def main(argv: list[str]) -> int:
|
|||||||
"""Subprocess entry point: ``prefetch <build_dir> <env_name>``."""
|
"""Subprocess entry point: ``prefetch <build_dir> <env_name>``."""
|
||||||
from esphome.core import CORE
|
from esphome.core import CORE
|
||||||
from esphome.log import setup_log
|
from esphome.log import setup_log
|
||||||
from esphome.platformio.runner import patch_registry_private_packages
|
|
||||||
|
|
||||||
signal.signal(signal.SIGTERM, _sigterm)
|
signal.signal(signal.SIGTERM, _sigterm)
|
||||||
patch_registry_private_packages()
|
|
||||||
raw_level = os.environ.get("ESPHOME_PREFETCH_LOG_LEVEL")
|
raw_level = os.environ.get("ESPHOME_PREFETCH_LOG_LEVEL")
|
||||||
try:
|
try:
|
||||||
level = int(raw_level) if raw_level is not None else logging.INFO
|
level = int(raw_level) if raw_level is not None else logging.INFO
|
||||||
|
|||||||
@@ -2,8 +2,7 @@
|
|||||||
|
|
||||||
Invoked via ``python -m esphome.platformio.runner`` instead of
|
Invoked via ``python -m esphome.platformio.runner`` instead of
|
||||||
``python -m platformio`` so that the patches (incremental rebuild
|
``python -m platformio`` so that the patches (incremental rebuild
|
||||||
preservation, download retries, skipping the private-package probe) apply
|
preservation, download retries) apply inside the subprocess. Running
|
||||||
inside the subprocess. Running
|
|
||||||
PlatformIO in a subprocess keeps its ``sys.path`` mutations and other
|
PlatformIO in a subprocess keeps its ``sys.path`` mutations and other
|
||||||
global state from leaking into the ESPHome process.
|
global state from leaking into the ESPHome process.
|
||||||
"""
|
"""
|
||||||
@@ -106,16 +105,6 @@ def patch_file_downloader() -> None:
|
|||||||
FileDownloader.__init__ = patched_init
|
FileDownloader.__init__ = patched_init
|
||||||
|
|
||||||
|
|
||||||
def patch_registry_private_packages() -> None:
|
|
||||||
"""Skip PlatformIO's private-package probe; it sleeps ~500 ms per lookup.
|
|
||||||
|
|
||||||
ESPHome never uses private packages, so the answer is always False.
|
|
||||||
"""
|
|
||||||
from platformio.registry.client import RegistryClient
|
|
||||||
|
|
||||||
RegistryClient.allowed_private_packages = staticmethod(lambda: False) # type: ignore[method-assign]
|
|
||||||
|
|
||||||
|
|
||||||
_IGNORE_LIB_WARNINGS = "(?:Hash|Update)"
|
_IGNORE_LIB_WARNINGS = "(?:Hash|Update)"
|
||||||
# Regex patterns matched against each line of PlatformIO output. Lines that
|
# Regex patterns matched against each line of PlatformIO output. Lines that
|
||||||
# match are dropped by RedirectText before they reach the parent process.
|
# match are dropped by RedirectText before they reach the parent process.
|
||||||
@@ -163,7 +152,6 @@ FILTER_PLATFORMIO_LINES = [
|
|||||||
def main() -> int:
|
def main() -> int:
|
||||||
patch_structhash()
|
patch_structhash()
|
||||||
patch_file_downloader()
|
patch_file_downloader()
|
||||||
patch_registry_private_packages()
|
|
||||||
|
|
||||||
# Wrap stdout/stderr with RedirectText before PlatformIO runs:
|
# Wrap stdout/stderr with RedirectText before PlatformIO runs:
|
||||||
#
|
#
|
||||||
|
|||||||
+3
-3
@@ -45,7 +45,7 @@ lib_deps_base =
|
|||||||
lib_deps =
|
lib_deps =
|
||||||
${common.lib_deps_base}
|
${common.lib_deps_base}
|
||||||
https://github.com/dudanov/MideaUART.git#eeea6c3e9b4474f067054592b435be1c4e466815 ; midea
|
https://github.com/dudanov/MideaUART.git#eeea6c3e9b4474f067054592b435be1c4e466815 ; midea
|
||||||
esphome/noise-c@0.1.26 ; noise (api, ota)
|
esphome/noise-c@0.1.24 ; noise (api, ota)
|
||||||
improv/Improv@1.2.7 ; improv_serial / esp32_improv
|
improv/Improv@1.2.7 ; improv_serial / esp32_improv
|
||||||
kikuchan98/pngle@1.1.0 ; online_image
|
kikuchan98/pngle@1.1.0 ; online_image
|
||||||
; Using the repository directly, otherwise ESP-IDF can't use the library
|
; Using the repository directly, otherwise ESP-IDF can't use the library
|
||||||
@@ -244,7 +244,7 @@ lib_deps =
|
|||||||
${common:idf-component-libs.lib_deps}
|
${common:idf-component-libs.lib_deps}
|
||||||
ESP32Async/ESPAsyncWebServer@3.9.6 ; web_server_base
|
ESP32Async/ESPAsyncWebServer@3.9.6 ; web_server_base
|
||||||
droscy/esp_wireguard@0.4.5 ; wireguard
|
droscy/esp_wireguard@0.4.5 ; wireguard
|
||||||
esphome/noise-c@0.1.26 ; noise (api, ota)
|
esphome/noise-c@0.1.24 ; noise (api, ota)
|
||||||
ESP32Async/AsyncTCP@3.4.5 ; async_tcp
|
ESP32Async/AsyncTCP@3.4.5 ; async_tcp
|
||||||
DNSServer ; captive_portal
|
DNSServer ; captive_portal
|
||||||
heman/AsyncMqttClient-esphome@2.0.0 ; mqtt
|
heman/AsyncMqttClient-esphome@2.0.0 ; mqtt
|
||||||
@@ -641,7 +641,7 @@ build_unflags =
|
|||||||
extends = common
|
extends = common
|
||||||
platform = platformio/native
|
platform = platformio/native
|
||||||
lib_deps =
|
lib_deps =
|
||||||
esphome/noise-c@0.1.26 ; used by noise (api, ota)
|
esphome/noise-c@0.1.24 ; used by noise (api, ota)
|
||||||
lvgl/lvgl@9.5.0 ; lvgl
|
lvgl/lvgl@9.5.0 ; lvgl
|
||||||
build_flags =
|
build_flags =
|
||||||
${common.build_flags}
|
${common.build_flags}
|
||||||
|
|||||||
+4
-4
@@ -14,7 +14,7 @@ esptool==5.3.1
|
|||||||
click==8.3.3
|
click==8.3.3
|
||||||
aioesphomeapi==46.3.0
|
aioesphomeapi==46.3.0
|
||||||
aiohappyeyeballs==2.7.1 # Happy Eyeballs for requests downloads; already pulled in by aioesphomeapi
|
aiohappyeyeballs==2.7.1 # Happy Eyeballs for requests downloads; already pulled in by aioesphomeapi
|
||||||
zeroconf==0.151.2
|
zeroconf==0.151.3
|
||||||
puremagic==2.2.0
|
puremagic==2.2.0
|
||||||
ruamel.yaml==0.19.1 # dashboard_import
|
ruamel.yaml==0.19.1 # dashboard_import
|
||||||
ruamel.yaml.clib==0.2.15 # dashboard_import
|
ruamel.yaml.clib==0.2.15 # dashboard_import
|
||||||
@@ -27,9 +27,9 @@ bleak==3.0.2
|
|||||||
smpclient==7.2.0
|
smpclient==7.2.0
|
||||||
requests==2.34.2
|
requests==2.34.2
|
||||||
py7zr==1.1.3
|
py7zr==1.1.3
|
||||||
platformdirs==4.11.5 # native esp-idf toolchain global cache dir
|
platformdirs==4.11.7 # native esp-idf toolchain global cache dir
|
||||||
ninja==1.13.0 # native esp8266 arduino toolchain build driver
|
ninja==1.13.2 # native esp8266 arduino toolchain build driver
|
||||||
filelock==3.32.4 # inter-process locks (PlatformIO cache heal, git clone cache); >=3.32 for FileLock(fallback_to_soft=...), older versions silently drop the kwarg
|
filelock==3.32.5 # inter-process locks (PlatformIO cache heal, git clone cache); >=3.32 for FileLock(fallback_to_soft=...), older versions silently drop the kwarg
|
||||||
|
|
||||||
# esp-idf >= 5.0 requires this
|
# esp-idf >= 5.0 requires this
|
||||||
pyparsing >= 3.3.2
|
pyparsing >= 3.3.2
|
||||||
|
|||||||
@@ -2,7 +2,7 @@ pylint==4.0.8
|
|||||||
flake8==7.3.0 # also change in .pre-commit-config.yaml when updating
|
flake8==7.3.0 # also change in .pre-commit-config.yaml when updating
|
||||||
ruff==0.16.5 # also change in .pre-commit-config.yaml when updating
|
ruff==0.16.5 # also change in .pre-commit-config.yaml when updating
|
||||||
pyupgrade==3.21.2 # also change in .pre-commit-config.yaml when updating
|
pyupgrade==3.21.2 # also change in .pre-commit-config.yaml when updating
|
||||||
prek==0.5.0 # also change in .github/workflows/ci.yml when updating
|
prek==0.5.1 # also change in .github/workflows/ci.yml when updating
|
||||||
|
|
||||||
# Unit tests
|
# Unit tests
|
||||||
pytest==9.1.1
|
pytest==9.1.1
|
||||||
|
|||||||
@@ -131,6 +131,12 @@ def force_str(force: bool) -> str:
|
|||||||
return str(force).lower()
|
return str(force).lower()
|
||||||
|
|
||||||
|
|
||||||
|
def _encode_call(func: str, *args: str, force: bool = False) -> str:
|
||||||
|
"""Emit one ProtoEncode call; every helper takes the cursor and returns it advanced."""
|
||||||
|
suffix = "_force" if force else ""
|
||||||
|
return f"pos = ProtoEncode::{func}{suffix}({', '.join(('pos', *args))});"
|
||||||
|
|
||||||
|
|
||||||
class TypeInfo(ABC):
|
class TypeInfo(ABC):
|
||||||
"""Base class for all type information."""
|
"""Base class for all type information."""
|
||||||
|
|
||||||
@@ -264,14 +270,16 @@ class TypeInfo(ABC):
|
|||||||
# write_raw_byte(tag) + raw encode instead of the full encode_* method,
|
# write_raw_byte(tag) + raw encode instead of the full encode_* method,
|
||||||
# eliminating the zero-check branch and encode_field_raw indirection.
|
# eliminating the zero-check branch and encode_field_raw indirection.
|
||||||
# {value} is replaced with the actual field expression.
|
# {value} is replaced with the actual field expression.
|
||||||
RAW_ENCODE_MAP: dict[str, str] = {
|
RAW_ENCODE_MAP: dict[str, tuple[str, str]] = {
|
||||||
"encode_uint32": "ProtoEncode::encode_varint_raw(pos, {value});",
|
"encode_uint32": ("encode_varint_raw", "{value}"),
|
||||||
"encode_uint64": "ProtoEncode::encode_varint_raw_64(pos, {value});",
|
"encode_uint64": ("encode_varint_raw_64", "{value}"),
|
||||||
"encode_sint32": "ProtoEncode::encode_varint_raw_short(pos, encode_zigzag32({value}));",
|
"encode_sint32": ("encode_varint_raw_short", "encode_zigzag32({value})"),
|
||||||
"encode_sint64": "ProtoEncode::encode_varint_raw_64(pos, encode_zigzag64({value}));",
|
"encode_sint64": ("encode_varint_raw_64", "encode_zigzag64({value})"),
|
||||||
"encode_int64": "ProtoEncode::encode_varint_raw_64(pos, static_cast<uint64_t>({value}));",
|
"encode_int64": ("encode_varint_raw_64", "static_cast<uint64_t>({value})"),
|
||||||
"encode_bool": "ProtoEncode::write_raw_byte(pos, {value} ? 0x01 : 0x00);",
|
"encode_bool": ("write_raw_byte", "{value} ? 0x01 : 0x00"),
|
||||||
}
|
}
|
||||||
|
# Fixed32 value expression for the shared tag+fixed32 writer; None for other wire types
|
||||||
|
fixed32_value_template: str | None = None
|
||||||
|
|
||||||
def _encode_with_precomputed_tag(self, value_expr: str) -> str | None:
|
def _encode_with_precomputed_tag(self, value_expr: str) -> str | None:
|
||||||
"""Try to emit a precomputed-tag encode for a field.
|
"""Try to emit a precomputed-tag encode for a field.
|
||||||
@@ -288,12 +296,17 @@ class TypeInfo(ABC):
|
|||||||
return None
|
return None
|
||||||
max_val = self.max_value
|
max_val = self.max_value
|
||||||
# Only use RAW_ENCODE_MAP for forced fields or fields with max_value
|
# Only use RAW_ENCODE_MAP for forced fields or fields with max_value
|
||||||
raw_expr = None
|
raw = None
|
||||||
if self.force or max_val is not None:
|
if self.force or max_val is not None:
|
||||||
raw_expr = self.RAW_ENCODE_MAP.get(self.encode_func)
|
raw = self.RAW_ENCODE_MAP.get(self.encode_func)
|
||||||
if raw_expr is None:
|
if raw is None:
|
||||||
return None
|
return None
|
||||||
body = f"ProtoEncode::write_raw_byte(pos, {tag});\n{raw_expr.format(value=value_expr)}"
|
func, arg = raw
|
||||||
|
body = (
|
||||||
|
_encode_call("write_raw_byte", str(tag))
|
||||||
|
+ "\n"
|
||||||
|
+ _encode_call(func, arg.format(value=value_expr))
|
||||||
|
)
|
||||||
if self.force:
|
if self.force:
|
||||||
return body
|
return body
|
||||||
# Non-forced with max_value: inline zero-check + raw encode
|
# Non-forced with max_value: inline zero-check + raw encode
|
||||||
@@ -314,23 +327,43 @@ class TypeInfo(ABC):
|
|||||||
return None
|
return None
|
||||||
# When max_len < 128, length varint is always 1 byte
|
# When max_len < 128, length varint is always 1 byte
|
||||||
len_encode = (
|
len_encode = (
|
||||||
f"ProtoEncode::write_raw_byte(pos, static_cast<uint8_t>({len_expr}));"
|
_encode_call("write_raw_byte", f"static_cast<uint8_t>({len_expr})")
|
||||||
if max_len is not None and max_len < 128
|
if max_len is not None and max_len < 128
|
||||||
else f"ProtoEncode::encode_varint_raw(pos, {len_expr});"
|
else _encode_call("encode_varint_raw", len_expr)
|
||||||
)
|
)
|
||||||
|
return "\n".join(
|
||||||
|
(
|
||||||
|
_encode_call("write_raw_byte", str(tag)),
|
||||||
|
len_encode,
|
||||||
|
_encode_call("encode_raw", data_expr, len_expr),
|
||||||
|
)
|
||||||
|
)
|
||||||
|
|
||||||
|
def _encode_fixed32_with_precomputed_tag(self, value_expr: str) -> str | None:
|
||||||
|
"""Single-byte tag fixed32 write, or None for multi-byte tags."""
|
||||||
|
tag = self.calculate_tag()
|
||||||
|
if tag >= 128:
|
||||||
|
return None
|
||||||
|
if self.force:
|
||||||
|
return _encode_call("write_tag_and_fixed32", str(tag), value_expr)
|
||||||
return (
|
return (
|
||||||
f"ProtoEncode::write_raw_byte(pos, {tag});\n"
|
f"if (uint32_t raw = {value_expr}; raw != 0) [[likely]] {{\n"
|
||||||
f"{len_encode}\n"
|
f" {_encode_call('write_tag_and_fixed32', str(tag), 'raw')}\n"
|
||||||
f"ProtoEncode::encode_raw(pos, {data_expr}, {len_expr});"
|
"}"
|
||||||
)
|
)
|
||||||
|
|
||||||
@property
|
@property
|
||||||
def encode_content(self) -> str:
|
def encode_content(self) -> str:
|
||||||
if result := self._encode_with_precomputed_tag(f"this->{self.field_name}"):
|
value = f"this->{self.field_name}"
|
||||||
|
if result := self._encode_with_precomputed_tag(value):
|
||||||
return result
|
return result
|
||||||
if self.force:
|
if self.fixed32_value_template is not None and (
|
||||||
return f"ProtoEncode::{self.encode_func}(pos, {self.number}, this->{self.field_name}, true);"
|
result := self._encode_fixed32_with_precomputed_tag(
|
||||||
return f"ProtoEncode::{self.encode_func}(pos, {self.number}, this->{self.field_name});"
|
self.fixed32_value_template.format(value=value)
|
||||||
|
)
|
||||||
|
):
|
||||||
|
return result
|
||||||
|
return _encode_call(self.encode_func, str(self.number), value, force=self.force)
|
||||||
|
|
||||||
encode_func = None
|
encode_func = None
|
||||||
|
|
||||||
@@ -635,6 +668,8 @@ class FloatType(FixedSizeTypeMixin, TypeInfo):
|
|||||||
encode_func = "encode_float"
|
encode_func = "encode_float"
|
||||||
wire_type = WireType.FIXED32 # Uses wire type 5
|
wire_type = WireType.FIXED32 # Uses wire type 5
|
||||||
|
|
||||||
|
fixed32_value_template = "float_to_raw({value})"
|
||||||
|
|
||||||
def dump(self, name: str) -> str:
|
def dump(self, name: str) -> str:
|
||||||
o = f'snprintf(buffer, sizeof(buffer), "%g", {name});\n'
|
o = f'snprintf(buffer, sizeof(buffer), "%g", {name});\n'
|
||||||
o += "out.append(buffer);"
|
o += "out.append(buffer);"
|
||||||
@@ -697,11 +732,11 @@ class UInt64Type(VarintTypeMixin, TypeInfo):
|
|||||||
return self._get_simple_size_calculation(name, force, "uint64")
|
return self._get_simple_size_calculation(name, force, "uint64")
|
||||||
|
|
||||||
@property
|
@property
|
||||||
def RAW_ENCODE_MAP(self) -> dict[str, str]: # noqa: N802
|
def RAW_ENCODE_MAP(self) -> dict[str, tuple[str, str]]: # noqa: N802
|
||||||
if self.mac_address:
|
if self.mac_address:
|
||||||
return {
|
return {
|
||||||
**TypeInfo.RAW_ENCODE_MAP,
|
**TypeInfo.RAW_ENCODE_MAP,
|
||||||
"encode_uint64": "ProtoEncode::encode_varint_raw_48bit(pos, {value});",
|
"encode_uint64": ("encode_varint_raw_48bit", "{value}"),
|
||||||
}
|
}
|
||||||
return TypeInfo.RAW_ENCODE_MAP
|
return TypeInfo.RAW_ENCODE_MAP
|
||||||
|
|
||||||
@@ -769,15 +804,7 @@ class Fixed32Type(FixedSizeTypeMixin, TypeInfo):
|
|||||||
o += "out.append(buffer);"
|
o += "out.append(buffer);"
|
||||||
return o
|
return o
|
||||||
|
|
||||||
@property
|
fixed32_value_template = "{value}"
|
||||||
def encode_content(self) -> str:
|
|
||||||
tag = self.calculate_tag()
|
|
||||||
if self.force and tag < 128:
|
|
||||||
# Emit combined tag+value write: precomputed tag + direct memcpy
|
|
||||||
return f"ProtoEncode::write_tag_and_fixed32(pos, {tag}, this->{self.field_name});"
|
|
||||||
if self.force:
|
|
||||||
return f"ProtoEncode::{self.encode_func}(pos, {self.number}, this->{self.field_name}, true);"
|
|
||||||
return f"ProtoEncode::{self.encode_func}(pos, {self.number}, this->{self.field_name});"
|
|
||||||
|
|
||||||
def get_size_calculation(self, name: str, force: bool = False) -> str:
|
def get_size_calculation(self, name: str, force: bool = False) -> str:
|
||||||
field_id_size = self.calculate_field_id_size()
|
field_id_size = self.calculate_field_id_size()
|
||||||
@@ -851,9 +878,12 @@ class StringType(TypeInfo):
|
|||||||
f"this->{self.field_name}_ref_.size()",
|
f"this->{self.field_name}_ref_.size()",
|
||||||
):
|
):
|
||||||
return result
|
return result
|
||||||
if self.force:
|
return _encode_call(
|
||||||
return f"ProtoEncode::encode_string(pos, {self.number}, this->{self.field_name}_ref_, true);"
|
"encode_string",
|
||||||
return f"ProtoEncode::encode_string(pos, {self.number}, this->{self.field_name}_ref_);"
|
str(self.number),
|
||||||
|
f"this->{self.field_name}_ref_",
|
||||||
|
force=self.force,
|
||||||
|
)
|
||||||
|
|
||||||
def dump(self, name):
|
def dump(self, name):
|
||||||
# If name is 'it', this is a repeated field element - always use string
|
# If name is 'it', this is a repeated field element - always use string
|
||||||
@@ -951,7 +981,9 @@ class MessageType(TypeInfo):
|
|||||||
@property
|
@property
|
||||||
def encode_content(self) -> str:
|
def encode_content(self) -> str:
|
||||||
# Sub-message encoding needs buffer for backpatch/sync
|
# Sub-message encoding needs buffer for backpatch/sync
|
||||||
return f"ProtoEncode::{self.encode_func}(pos, buffer, {self.number}, this->{self.field_name});"
|
return _encode_call(
|
||||||
|
self.encode_func, "buffer", str(self.number), f"this->{self.field_name}"
|
||||||
|
)
|
||||||
|
|
||||||
@property
|
@property
|
||||||
def decode_length(self) -> str:
|
def decode_length(self) -> str:
|
||||||
@@ -1058,9 +1090,13 @@ class BytesType(TypeInfo):
|
|||||||
f"this->{self.field_name}_ptr_", f"this->{self.field_name}_len_"
|
f"this->{self.field_name}_ptr_", f"this->{self.field_name}_len_"
|
||||||
):
|
):
|
||||||
return result
|
return result
|
||||||
if self.force:
|
return _encode_call(
|
||||||
return f"ProtoEncode::encode_bytes(pos, {self.number}, this->{self.field_name}_ptr_, this->{self.field_name}_len_, true);"
|
"encode_bytes",
|
||||||
return f"ProtoEncode::encode_bytes(pos, {self.number}, this->{self.field_name}_ptr_, this->{self.field_name}_len_);"
|
str(self.number),
|
||||||
|
f"this->{self.field_name}_ptr_",
|
||||||
|
f"this->{self.field_name}_len_",
|
||||||
|
force=self.force,
|
||||||
|
)
|
||||||
|
|
||||||
def dump(self, name: str) -> str:
|
def dump(self, name: str) -> str:
|
||||||
ptr_dump = f"format_hex_pretty(this->{self.field_name}_ptr_, this->{self.field_name}_len_)"
|
ptr_dump = f"format_hex_pretty(this->{self.field_name}_ptr_, this->{self.field_name}_len_)"
|
||||||
@@ -1170,9 +1206,13 @@ class PointerToBytesBufferType(PointerToBufferTypeBase):
|
|||||||
f"this->{self.field_name}", f"this->{self.field_name}_len"
|
f"this->{self.field_name}", f"this->{self.field_name}_len"
|
||||||
):
|
):
|
||||||
return result
|
return result
|
||||||
if self.force:
|
return _encode_call(
|
||||||
return f"ProtoEncode::encode_bytes(pos, {self.number}, this->{self.field_name}, this->{self.field_name}_len, true);"
|
"encode_bytes",
|
||||||
return f"ProtoEncode::encode_bytes(pos, {self.number}, this->{self.field_name}, this->{self.field_name}_len);"
|
str(self.number),
|
||||||
|
f"this->{self.field_name}",
|
||||||
|
f"this->{self.field_name}_len",
|
||||||
|
force=self.force,
|
||||||
|
)
|
||||||
|
|
||||||
@property
|
@property
|
||||||
def decode_length_content(self) -> str | None:
|
def decode_length_content(self) -> str | None:
|
||||||
@@ -1224,16 +1264,19 @@ class PointerToStringBufferType(PointerToBufferTypeBase):
|
|||||||
if max_len is not None and max_len < 128 and self.force:
|
if max_len is not None and max_len < 128 and self.force:
|
||||||
tag = self.calculate_tag()
|
tag = self.calculate_tag()
|
||||||
if tag < 128:
|
if tag < 128:
|
||||||
return f"ProtoEncode::encode_short_string_force(pos, {tag}, this->{self.field_name});"
|
return _encode_call(
|
||||||
|
"encode_short_string_force", str(tag), f"this->{self.field_name}"
|
||||||
|
)
|
||||||
if result := self._encode_bytes_with_precomputed_tag(
|
if result := self._encode_bytes_with_precomputed_tag(
|
||||||
f"this->{self.field_name}.c_str()",
|
f"this->{self.field_name}.c_str()",
|
||||||
f"this->{self.field_name}.size()",
|
f"this->{self.field_name}.size()",
|
||||||
):
|
):
|
||||||
return result
|
return result
|
||||||
if self.force:
|
return _encode_call(
|
||||||
return f"ProtoEncode::encode_string(pos, {self.number}, this->{self.field_name}, true);"
|
"encode_string",
|
||||||
return (
|
str(self.number),
|
||||||
f"ProtoEncode::encode_string(pos, {self.number}, this->{self.field_name});"
|
f"this->{self.field_name}",
|
||||||
|
force=self.force,
|
||||||
)
|
)
|
||||||
|
|
||||||
@property
|
@property
|
||||||
@@ -1421,9 +1464,13 @@ class FixedArrayBytesType(TypeInfo):
|
|||||||
f"this->{self.field_name}", f"this->{self.field_name}_len", max_len=max_len
|
f"this->{self.field_name}", f"this->{self.field_name}_len", max_len=max_len
|
||||||
):
|
):
|
||||||
return result
|
return result
|
||||||
if self.force:
|
return _encode_call(
|
||||||
return f"ProtoEncode::encode_bytes(pos, {self.number}, this->{self.field_name}, this->{self.field_name}_len, true);"
|
"encode_bytes",
|
||||||
return f"ProtoEncode::encode_bytes(pos, {self.number}, this->{self.field_name}, this->{self.field_name}_len);"
|
str(self.number),
|
||||||
|
f"this->{self.field_name}",
|
||||||
|
f"this->{self.field_name}_len",
|
||||||
|
force=self.force,
|
||||||
|
)
|
||||||
|
|
||||||
def dump(self, name: str) -> str:
|
def dump(self, name: str) -> str:
|
||||||
return f"out.append(format_hex_pretty({name}, {name}_len));"
|
return f"out.append(format_hex_pretty({name}, {name}_len));"
|
||||||
@@ -1520,9 +1567,9 @@ class EnumType(VarintTypeMixin, TypeInfo):
|
|||||||
@property
|
@property
|
||||||
def encode_content(self) -> str:
|
def encode_content(self) -> str:
|
||||||
value_expr = f"static_cast<uint32_t>(this->{self.field_name})"
|
value_expr = f"static_cast<uint32_t>(this->{self.field_name})"
|
||||||
if self.force:
|
return _encode_call(
|
||||||
return f"ProtoEncode::{self.encode_func}(pos, {self.number}, {value_expr}, true);"
|
self.encode_func, str(self.number), value_expr, force=self.force
|
||||||
return f"ProtoEncode::{self.encode_func}(pos, {self.number}, {value_expr});"
|
)
|
||||||
|
|
||||||
def dump(self, name: str) -> str:
|
def dump(self, name: str) -> str:
|
||||||
return f"out.append_p(proto_enum_to_string<{self.cpp_type}>({name}));"
|
return f"out.append_p(proto_enum_to_string<{self.cpp_type}>({name}));"
|
||||||
@@ -1701,9 +1748,9 @@ def _generate_inline_encode_block(
|
|||||||
|
|
||||||
lines = []
|
lines = []
|
||||||
lines.append(f"auto &sub_msg = {element};")
|
lines.append(f"auto &sub_msg = {element};")
|
||||||
lines.append(f"ProtoEncode::write_raw_byte(pos, {tag});")
|
lines.append(_encode_call("write_raw_byte", str(tag)))
|
||||||
lines.append("uint8_t *len_pos = pos;")
|
lines.append("uint8_t *len_pos = pos;")
|
||||||
lines.append("ProtoEncode::reserve_byte(pos);")
|
lines.append(_encode_call("reserve_byte"))
|
||||||
|
|
||||||
# Generate inline field encoding for each sub-message field
|
# Generate inline field encoding for each sub-message field
|
||||||
for field in sub_desc.field:
|
for field in sub_desc.field:
|
||||||
@@ -1775,17 +1822,22 @@ class FixedArrayRepeatedType(TypeInfo):
|
|||||||
def _encode_element(self, element: str) -> str:
|
def _encode_element(self, element: str) -> str:
|
||||||
"""Helper to generate encode statement for a single element."""
|
"""Helper to generate encode statement for a single element."""
|
||||||
if isinstance(self._ti, EnumType):
|
if isinstance(self._ti, EnumType):
|
||||||
return f"ProtoEncode::{self._ti.encode_func}(pos, {self.number}, static_cast<uint32_t>({element}), true);"
|
return _encode_call(
|
||||||
|
self._ti.encode_func,
|
||||||
|
str(self.number),
|
||||||
|
f"static_cast<uint32_t>({element})",
|
||||||
|
force=True,
|
||||||
|
)
|
||||||
# Repeated message elements use encode_sub_message (force=true is default)
|
# Repeated message elements use encode_sub_message (force=true is default)
|
||||||
if isinstance(self._ti, MessageType):
|
if isinstance(self._ti, MessageType):
|
||||||
if _is_inline_encode(self._ti.cpp_type):
|
if _is_inline_encode(self._ti.cpp_type):
|
||||||
return _generate_inline_encode_block(
|
return _generate_inline_encode_block(
|
||||||
self.number, self._ti.cpp_type, element
|
self.number, self._ti.cpp_type, element
|
||||||
)
|
)
|
||||||
return f"ProtoEncode::encode_sub_message(pos, buffer, {self.number}, {element});"
|
return _encode_call(
|
||||||
return (
|
"encode_sub_message", "buffer", str(self.number), element
|
||||||
f"ProtoEncode::{self._ti.encode_func}(pos, {self.number}, {element}, true);"
|
)
|
||||||
)
|
return _encode_call(self._ti.encode_func, str(self.number), element, force=True)
|
||||||
|
|
||||||
@property
|
@property
|
||||||
def cpp_type(self) -> str:
|
def cpp_type(self) -> str:
|
||||||
@@ -2137,13 +2189,18 @@ class RepeatedTypeInfo(TypeInfo):
|
|||||||
def _encode_element_call(self, element: str) -> str:
|
def _encode_element_call(self, element: str) -> str:
|
||||||
"""Helper to generate encode call for a single element."""
|
"""Helper to generate encode call for a single element."""
|
||||||
if isinstance(self._ti, EnumType):
|
if isinstance(self._ti, EnumType):
|
||||||
return f"ProtoEncode::{self._ti.encode_func}(pos, {self.number}, static_cast<uint32_t>({element}), true);"
|
return _encode_call(
|
||||||
|
self._ti.encode_func,
|
||||||
|
str(self.number),
|
||||||
|
f"static_cast<uint32_t>({element})",
|
||||||
|
force=True,
|
||||||
|
)
|
||||||
# Repeated message elements use encode_sub_message (force=true is default)
|
# Repeated message elements use encode_sub_message (force=true is default)
|
||||||
if isinstance(self._ti, MessageType):
|
if isinstance(self._ti, MessageType):
|
||||||
return f"ProtoEncode::encode_sub_message(pos, buffer, {self.number}, {element});"
|
return _encode_call(
|
||||||
return (
|
"encode_sub_message", "buffer", str(self.number), element
|
||||||
f"ProtoEncode::{self._ti.encode_func}(pos, {self.number}, {element}, true);"
|
)
|
||||||
)
|
return _encode_call(self._ti.encode_func, str(self.number), element, force=True)
|
||||||
|
|
||||||
@property
|
@property
|
||||||
def encode_content(self) -> str:
|
def encode_content(self) -> str:
|
||||||
@@ -2152,7 +2209,7 @@ class RepeatedTypeInfo(TypeInfo):
|
|||||||
# Special handling for const char* elements (when container_no_template contains "const char")
|
# Special handling for const char* elements (when container_no_template contains "const char")
|
||||||
if "const char" in self._container_no_template:
|
if "const char" in self._container_no_template:
|
||||||
o = f"for (const char *it : *this->{self.field_name}) {{\n"
|
o = f"for (const char *it : *this->{self.field_name}) {{\n"
|
||||||
o += f" ProtoEncode::{self._ti.encode_func}(pos, {self.number}, it, strlen(it), true);\n"
|
o += f" {_encode_call(self._ti.encode_func, str(self.number), 'it', 'strlen(it)', force=True)}\n"
|
||||||
else:
|
else:
|
||||||
o = f"for (const auto &it : *this->{self.field_name}) {{\n"
|
o = f"for (const auto &it : *this->{self.field_name}) {{\n"
|
||||||
o += f" {self._encode_element_call('it')}\n"
|
o += f" {self._encode_element_call('it')}\n"
|
||||||
@@ -2784,28 +2841,36 @@ def build_message_type(
|
|||||||
)
|
)
|
||||||
for line in encode
|
for line in encode
|
||||||
]
|
]
|
||||||
o = f"{speed_attr}uint8_t *{desc.name}::encode(ProtoWriteBuffer &buffer PROTO_ENCODE_DEBUG_PARAM) const {{\n"
|
o = f"{speed_attr}uint8_t *{desc.name}::encode_msg(const void *self, ProtoWriteBuffer &buffer PROTO_ENCODE_DEBUG_PARAM) {{\n"
|
||||||
|
o += f" const auto &msg = *static_cast<const {desc.name} *>(self);\n"
|
||||||
o += " uint8_t *__restrict__ pos = buffer.get_pos();\n"
|
o += " uint8_t *__restrict__ pos = buffer.get_pos();\n"
|
||||||
o += indent("\n".join(encode_debug)) + "\n"
|
o += indent("\n".join(encode_debug)).replace("this->", "msg.") + "\n"
|
||||||
o += " return pos;\n"
|
o += " return pos;\n"
|
||||||
o += "}\n"
|
o += "}\n"
|
||||||
cpp += o
|
cpp += o
|
||||||
prot = (
|
public_content.append(
|
||||||
"uint8_t *encode(ProtoWriteBuffer &buffer PROTO_ENCODE_DEBUG_PARAM) const;"
|
"static uint8_t *encode_msg(const void *self, ProtoWriteBuffer &buffer PROTO_ENCODE_DEBUG_PARAM);"
|
||||||
|
)
|
||||||
|
public_content.append(
|
||||||
|
"uint8_t *encode(ProtoWriteBuffer &buffer PROTO_ENCODE_DEBUG_PARAM) const {\n"
|
||||||
|
" return encode_msg(this, buffer PROTO_ENCODE_DEBUG_ARG);\n"
|
||||||
|
"}"
|
||||||
)
|
)
|
||||||
public_content.append(prot)
|
|
||||||
# If no fields to encode or message doesn't need encoding, the default implementation in ProtoMessage will be used
|
# If no fields to encode or message doesn't need encoding, the default implementation in ProtoMessage will be used
|
||||||
|
|
||||||
# Add calculate_size method only if this message needs encoding and has fields
|
# Add calculate_size method only if this message needs encoding and has fields
|
||||||
if needs_encode and size_calc and not is_inline_only:
|
if needs_encode and size_calc and not is_inline_only:
|
||||||
o = f"{speed_attr}uint32_t {desc.name}::calculate_size() const {{\n"
|
o = f"{speed_attr}uint32_t {desc.name}::calc_size_msg(const void *self) {{\n"
|
||||||
|
o += f" const auto &msg = *static_cast<const {desc.name} *>(self);\n"
|
||||||
o += " uint32_t size = 0;\n"
|
o += " uint32_t size = 0;\n"
|
||||||
o += indent("\n".join(size_calc)) + "\n"
|
o += indent("\n".join(size_calc)).replace("this->", "msg.") + "\n"
|
||||||
o += " return size;\n"
|
o += " return size;\n"
|
||||||
o += "}\n"
|
o += "}\n"
|
||||||
cpp += o
|
cpp += o
|
||||||
prot = "uint32_t calculate_size() const;"
|
public_content.append("static uint32_t calc_size_msg(const void *self);")
|
||||||
public_content.append(prot)
|
public_content.append(
|
||||||
|
"uint32_t calculate_size() const { return calc_size_msg(this); }"
|
||||||
|
)
|
||||||
# If no fields to calculate size for or message doesn't need encoding, the default implementation in ProtoMessage will be used
|
# If no fields to calculate size for or message doesn't need encoding, the default implementation in ProtoMessage will be used
|
||||||
|
|
||||||
# dump_to method declaration in header
|
# dump_to method declaration in header
|
||||||
|
|||||||
@@ -1,32 +0,0 @@
|
|||||||
esphome:
|
|
||||||
name: test-keyboard-no-label
|
|
||||||
|
|
||||||
esp32:
|
|
||||||
board: esp32dev
|
|
||||||
framework:
|
|
||||||
type: esp-idf
|
|
||||||
|
|
||||||
spi:
|
|
||||||
- id: spi_bus
|
|
||||||
clk_pin: GPIO18
|
|
||||||
mosi_pin: GPIO23
|
|
||||||
|
|
||||||
display:
|
|
||||||
- platform: mipi_spi
|
|
||||||
spi_id: spi_bus
|
|
||||||
model: st7789v
|
|
||||||
id: tft_display
|
|
||||||
dimensions:
|
|
||||||
width: 240
|
|
||||||
height: 320
|
|
||||||
cs_pin: GPIO22
|
|
||||||
dc_pin: GPIO21
|
|
||||||
auto_clear_enabled: false
|
|
||||||
invert_colors: false
|
|
||||||
update_interval: never
|
|
||||||
|
|
||||||
lvgl:
|
|
||||||
displays: tft_display
|
|
||||||
widgets:
|
|
||||||
- keyboard:
|
|
||||||
id: keyboard_widget
|
|
||||||
@@ -1,34 +0,0 @@
|
|||||||
esphome:
|
|
||||||
name: test-qrcode-no-label
|
|
||||||
|
|
||||||
esp32:
|
|
||||||
board: esp32dev
|
|
||||||
framework:
|
|
||||||
type: esp-idf
|
|
||||||
|
|
||||||
spi:
|
|
||||||
- id: spi_bus
|
|
||||||
clk_pin: GPIO18
|
|
||||||
mosi_pin: GPIO23
|
|
||||||
|
|
||||||
display:
|
|
||||||
- platform: mipi_spi
|
|
||||||
spi_id: spi_bus
|
|
||||||
model: st7789v
|
|
||||||
id: tft_display
|
|
||||||
dimensions:
|
|
||||||
width: 240
|
|
||||||
height: 320
|
|
||||||
cs_pin: GPIO22
|
|
||||||
dc_pin: GPIO21
|
|
||||||
auto_clear_enabled: false
|
|
||||||
invert_colors: false
|
|
||||||
update_interval: never
|
|
||||||
|
|
||||||
lvgl:
|
|
||||||
displays: tft_display
|
|
||||||
widgets:
|
|
||||||
- qrcode:
|
|
||||||
id: qr_widget
|
|
||||||
size: 100
|
|
||||||
text: "esphome.io"
|
|
||||||
@@ -1,35 +0,0 @@
|
|||||||
esphome:
|
|
||||||
name: test-tabview-no-label
|
|
||||||
|
|
||||||
esp32:
|
|
||||||
board: esp32dev
|
|
||||||
framework:
|
|
||||||
type: esp-idf
|
|
||||||
|
|
||||||
spi:
|
|
||||||
- id: spi_bus
|
|
||||||
clk_pin: GPIO18
|
|
||||||
mosi_pin: GPIO23
|
|
||||||
|
|
||||||
display:
|
|
||||||
- platform: mipi_spi
|
|
||||||
spi_id: spi_bus
|
|
||||||
model: st7789v
|
|
||||||
id: tft_display
|
|
||||||
dimensions:
|
|
||||||
width: 240
|
|
||||||
height: 320
|
|
||||||
cs_pin: GPIO22
|
|
||||||
dc_pin: GPIO21
|
|
||||||
auto_clear_enabled: false
|
|
||||||
invert_colors: false
|
|
||||||
update_interval: never
|
|
||||||
|
|
||||||
lvgl:
|
|
||||||
displays: tft_display
|
|
||||||
widgets:
|
|
||||||
- tabview:
|
|
||||||
id: tabview_widget
|
|
||||||
tabs:
|
|
||||||
- name: "Tab 1"
|
|
||||||
id: tab_1
|
|
||||||
@@ -1,32 +0,0 @@
|
|||||||
"""Widgets whose LVGL C implementation creates or references labels
|
|
||||||
internally (tab titles, key legends, the QR canvas fallback) must declare
|
|
||||||
the label dependency in ``get_uses()``. Otherwise a config that contains
|
|
||||||
no ``label`` widget of its own compiles LVGL without ``LV_USE_LABEL`` and
|
|
||||||
fails at C compile time with undefined ``lv_label_*`` symbols.
|
|
||||||
"""
|
|
||||||
|
|
||||||
from __future__ import annotations
|
|
||||||
|
|
||||||
from collections.abc import Callable
|
|
||||||
from pathlib import Path
|
|
||||||
|
|
||||||
import pytest
|
|
||||||
|
|
||||||
from esphome.components.lvgl import defines as df
|
|
||||||
|
|
||||||
|
|
||||||
@pytest.mark.parametrize(
|
|
||||||
"yaml_file",
|
|
||||||
[
|
|
||||||
"qrcode_no_label.yaml",
|
|
||||||
"keyboard_no_label.yaml",
|
|
||||||
"tabview_no_label.yaml",
|
|
||||||
],
|
|
||||||
)
|
|
||||||
def test_label_less_config_enables_lv_use_label(
|
|
||||||
generate_main: Callable[[str | Path], str],
|
|
||||||
component_config_path: Callable[[str], Path],
|
|
||||||
yaml_file: str,
|
|
||||||
) -> None:
|
|
||||||
generate_main(component_config_path(yaml_file))
|
|
||||||
assert "LV_USE_LABEL" in df.get_defines()
|
|
||||||
@@ -1,90 +0,0 @@
|
|||||||
"""Validation tests for the sendspin media_source platform.
|
|
||||||
|
|
||||||
These cover the codec preference list, whose rejection branches a compile test
|
|
||||||
cannot reach: a `test*.yaml` can only assert that a configuration is accepted.
|
|
||||||
"""
|
|
||||||
|
|
||||||
from typing import Any
|
|
||||||
|
|
||||||
import pytest
|
|
||||||
|
|
||||||
from esphome import config_validation as cv
|
|
||||||
from esphome.components.sendspin import CONF_CODECS, _get_data
|
|
||||||
from esphome.components.sendspin.media_source import CONFIG_SCHEMA
|
|
||||||
from esphome.const import PlatformFramework
|
|
||||||
from esphome.types import ConfigType
|
|
||||||
from tests.component_tests.types import SetCoreConfigCallable
|
|
||||||
|
|
||||||
|
|
||||||
def _media_source_config(**overrides: Any) -> ConfigType:
|
|
||||||
"""Build a minimal valid media source config, allowing field overrides."""
|
|
||||||
config: ConfigType = {
|
|
||||||
"id": "sendspin_media_source",
|
|
||||||
"sendspin_id": "sendspin_hub",
|
|
||||||
}
|
|
||||||
config.update(overrides)
|
|
||||||
return config
|
|
||||||
|
|
||||||
|
|
||||||
def test_default_codecs_at_48_khz(set_core_config: SetCoreConfigCallable) -> None:
|
|
||||||
"""Every codec is advertised when the sample rate suits all of them."""
|
|
||||||
set_core_config(PlatformFramework.ESP32_IDF)
|
|
||||||
|
|
||||||
config = CONFIG_SCHEMA(_media_source_config())
|
|
||||||
|
|
||||||
assert config[CONF_CODECS] == ["flac", "opus", "pcm"]
|
|
||||||
|
|
||||||
|
|
||||||
def test_default_codecs_drop_opus_at_other_rates(
|
|
||||||
set_core_config: SetCoreConfigCallable,
|
|
||||||
) -> None:
|
|
||||||
"""Opus only supports 48 kHz, so it leaves the default list at other rates."""
|
|
||||||
set_core_config(PlatformFramework.ESP32_IDF)
|
|
||||||
|
|
||||||
config = CONFIG_SCHEMA(_media_source_config(sample_rate=44100))
|
|
||||||
|
|
||||||
assert config[CONF_CODECS] == ["flac", "pcm"]
|
|
||||||
|
|
||||||
|
|
||||||
def test_configured_order_is_preserved(set_core_config: SetCoreConfigCallable) -> None:
|
|
||||||
"""The list is a preference order, so it reaches the player role as written."""
|
|
||||||
set_core_config(PlatformFramework.ESP32_IDF)
|
|
||||||
|
|
||||||
CONFIG_SCHEMA(_media_source_config(codecs=["pcm", "flac"]))
|
|
||||||
|
|
||||||
assert _get_data().player_config[CONF_CODECS] == ["pcm", "flac"]
|
|
||||||
|
|
||||||
|
|
||||||
def test_empty_codec_list_rejected(set_core_config: SetCoreConfigCallable) -> None:
|
|
||||||
"""A player with no codecs at all could never be given a stream."""
|
|
||||||
set_core_config(PlatformFramework.ESP32_IDF)
|
|
||||||
|
|
||||||
with pytest.raises(cv.Invalid, match="length of value must be at least 1"):
|
|
||||||
CONFIG_SCHEMA(_media_source_config(codecs=[]))
|
|
||||||
|
|
||||||
|
|
||||||
def test_duplicate_codec_rejected(set_core_config: SetCoreConfigCallable) -> None:
|
|
||||||
"""A repeated codec has no meaning in a preference order."""
|
|
||||||
set_core_config(PlatformFramework.ESP32_IDF)
|
|
||||||
|
|
||||||
with pytest.raises(cv.Invalid, match="may only be listed once"):
|
|
||||||
CONFIG_SCHEMA(_media_source_config(codecs=["flac", "flac"]))
|
|
||||||
|
|
||||||
|
|
||||||
def test_unknown_codec_rejected(set_core_config: SetCoreConfigCallable) -> None:
|
|
||||||
"""Only codecs the player role can decode are accepted."""
|
|
||||||
set_core_config(PlatformFramework.ESP32_IDF)
|
|
||||||
|
|
||||||
with pytest.raises(cv.Invalid, match="Unknown value"):
|
|
||||||
CONFIG_SCHEMA(_media_source_config(codecs=["mp3"]))
|
|
||||||
|
|
||||||
|
|
||||||
def test_opus_at_wrong_sample_rate_rejected(
|
|
||||||
set_core_config: SetCoreConfigCallable,
|
|
||||||
) -> None:
|
|
||||||
"""Asking for Opus at a rate it cannot handle fails rather than silently
|
|
||||||
dropping the stated preference."""
|
|
||||||
set_core_config(PlatformFramework.ESP32_IDF)
|
|
||||||
|
|
||||||
with pytest.raises(cv.Invalid, match="requires a sample_rate of 48000"):
|
|
||||||
CONFIG_SCHEMA(_media_source_config(codecs=["opus"], sample_rate=44100))
|
|
||||||
@@ -59,7 +59,7 @@ static void verify_mac(uint64_t mac, size_t expected_bytes) {
|
|||||||
#ifdef ESPHOME_DEBUG_API
|
#ifdef ESPHOME_DEBUG_API
|
||||||
uint8_t *proto_debug_end_ = api_buf.data() + api_buf.size();
|
uint8_t *proto_debug_end_ = api_buf.data() + api_buf.size();
|
||||||
#endif
|
#endif
|
||||||
ProtoEncode::encode_varint_raw_48bit(pos PROTO_ENCODE_DEBUG_ARG, mac);
|
pos = ProtoEncode::encode_varint_raw_48bit(pos PROTO_ENCODE_DEBUG_ARG, mac);
|
||||||
size_t new_len = pos - api_buf.data();
|
size_t new_len = pos - api_buf.data();
|
||||||
|
|
||||||
EXPECT_EQ(new_len, expected_bytes) << "mac=0x" << std::hex << mac << std::dec;
|
EXPECT_EQ(new_len, expected_bytes) << "mac=0x" << std::hex << mac << std::dec;
|
||||||
|
|||||||
@@ -1,5 +0,0 @@
|
|||||||
from tests.testing_helpers import ComponentManifestOverride
|
|
||||||
|
|
||||||
|
|
||||||
def override_manifest(manifest: ComponentManifestOverride) -> None:
|
|
||||||
manifest.dependencies = manifest.dependencies + ["sensor", "spi"]
|
|
||||||
@@ -1,62 +0,0 @@
|
|||||||
#include <gtest/gtest.h>
|
|
||||||
|
|
||||||
#include "esphome/components/atm90e32/atm90e32.h"
|
|
||||||
|
|
||||||
namespace esphome::atm90e32::testing {
|
|
||||||
|
|
||||||
TEST(ATM90E32OffsetRegisterVerification, AcceptsExactSignedReadback) {
|
|
||||||
EXPECT_TRUE(offset_register_value_matches(0x007B, 123));
|
|
||||||
EXPECT_TRUE(offset_register_value_matches(0xFF85, -123));
|
|
||||||
}
|
|
||||||
|
|
||||||
TEST(ATM90E32OffsetRegisterVerification, RejectsMismatchedReadback) {
|
|
||||||
EXPECT_FALSE(offset_register_value_matches(0x007C, 123));
|
|
||||||
EXPECT_FALSE(offset_register_value_matches(0xFF84, -123));
|
|
||||||
}
|
|
||||||
|
|
||||||
TEST(ATM90E32OffsetRestoreState, ReportsVerifiedStoredValuesAsRestored) {
|
|
||||||
const auto state = resolve_offset_restore_state(true, true, false);
|
|
||||||
|
|
||||||
EXPECT_TRUE(state.restored);
|
|
||||||
EXPECT_TRUE(state.values_verified);
|
|
||||||
}
|
|
||||||
|
|
||||||
TEST(ATM90E32OffsetRestoreState, ReportsVerifiedConfigFallbackAsNotRestored) {
|
|
||||||
const auto state = resolve_offset_restore_state(true, false, true);
|
|
||||||
|
|
||||||
EXPECT_FALSE(state.restored);
|
|
||||||
EXPECT_TRUE(state.values_verified);
|
|
||||||
}
|
|
||||||
|
|
||||||
TEST(ATM90E32OffsetRestoreState, ReportsFailedConfigFallbackAsUnverified) {
|
|
||||||
const auto state = resolve_offset_restore_state(true, false, false);
|
|
||||||
|
|
||||||
EXPECT_FALSE(state.restored);
|
|
||||||
EXPECT_FALSE(state.values_verified);
|
|
||||||
}
|
|
||||||
|
|
||||||
TEST(ATM90E32OffsetRestoreState, ReportsConfigWithoutStoredValuesAsNotRestored) {
|
|
||||||
const auto state = resolve_offset_restore_state(false, true, false);
|
|
||||||
|
|
||||||
EXPECT_FALSE(state.restored);
|
|
||||||
EXPECT_TRUE(state.values_verified);
|
|
||||||
}
|
|
||||||
|
|
||||||
TEST(ATM90E32OffsetPersistence, RollsBackStoredValuesOrZeroSentinel) {
|
|
||||||
const OffsetCalibration previous[3]{{1, -1}, {2, -2}, {3, -3}};
|
|
||||||
OffsetCalibration rollback[3]{};
|
|
||||||
|
|
||||||
prepare_offset_rollback(previous, true, rollback);
|
|
||||||
for (uint8_t phase = 0; phase < 3; phase++) {
|
|
||||||
EXPECT_EQ(rollback[phase].first_offset, previous[phase].first_offset);
|
|
||||||
EXPECT_EQ(rollback[phase].second_offset, previous[phase].second_offset);
|
|
||||||
}
|
|
||||||
|
|
||||||
prepare_offset_rollback(previous, false, rollback);
|
|
||||||
for (const auto &phase : rollback) {
|
|
||||||
EXPECT_EQ(phase.first_offset, 0);
|
|
||||||
EXPECT_EQ(phase.second_offset, 0);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
} // namespace esphome::atm90e32::testing
|
|
||||||
@@ -9,4 +9,3 @@ media_source:
|
|||||||
static_delay_adjustable: true
|
static_delay_adjustable: true
|
||||||
fixed_delay: 480us
|
fixed_delay: 480us
|
||||||
decode_memory: internal
|
decode_memory: internal
|
||||||
codecs: [pcm, opus, flac]
|
|
||||||
|
|||||||
@@ -1,29 +0,0 @@
|
|||||||
# Tuya without any network component (no wifi/ethernet/api), as used on
|
|
||||||
# serial-only or BLE-only Tuya MCU boards. Regression test for
|
|
||||||
# https://github.com/esphome/esphome/issues/18942
|
|
||||||
substitutions:
|
|
||||||
status_pin: P6
|
|
||||||
|
|
||||||
packages:
|
|
||||||
uart: !include ../../test_build_components/common/uart/bk72xx-ard.yaml
|
|
||||||
|
|
||||||
tuya:
|
|
||||||
status_pin: ${status_pin}
|
|
||||||
|
|
||||||
binary_sensor:
|
|
||||||
- platform: tuya
|
|
||||||
id: tuya_presence
|
|
||||||
sensor_datapoint: 101
|
|
||||||
|
|
||||||
sensor:
|
|
||||||
- platform: tuya
|
|
||||||
id: tuya_light_intensity
|
|
||||||
sensor_datapoint: 103
|
|
||||||
|
|
||||||
number:
|
|
||||||
- platform: tuya
|
|
||||||
id: tuya_far_detection
|
|
||||||
number_datapoint: 109
|
|
||||||
min_value: 0
|
|
||||||
max_value: 600
|
|
||||||
step: 1
|
|
||||||
@@ -14,6 +14,7 @@ esphome:
|
|||||||
condition: wifi.ap_active
|
condition: wifi.ap_active
|
||||||
then:
|
then:
|
||||||
- logger.log: "WiFi AP is active!"
|
- logger.log: "WiFi AP is active!"
|
||||||
|
- wifi.roam
|
||||||
|
|
||||||
wifi:
|
wifi:
|
||||||
networks:
|
networks:
|
||||||
|
|||||||
@@ -0,0 +1,11 @@
|
|||||||
|
esphome:
|
||||||
|
name: api-empty-message-test
|
||||||
|
host:
|
||||||
|
api:
|
||||||
|
logger:
|
||||||
|
level: DEBUG
|
||||||
|
|
||||||
|
switch:
|
||||||
|
- platform: template
|
||||||
|
name: "Empty Message Switch"
|
||||||
|
optimistic: true
|
||||||
@@ -0,0 +1,58 @@
|
|||||||
|
esphome:
|
||||||
|
name: api-encode-boundaries-test
|
||||||
|
# Top-level area fills DeviceInfoResponse.suggested_area (field 16, a two-byte tag)
|
||||||
|
area:
|
||||||
|
id: kitchen_area
|
||||||
|
name: Kitchen
|
||||||
|
on_boot:
|
||||||
|
- sensor.template.publish:
|
||||||
|
id: zero_then_value
|
||||||
|
state: 0.0
|
||||||
|
|
||||||
|
host:
|
||||||
|
api:
|
||||||
|
logger:
|
||||||
|
level: DEBUG
|
||||||
|
|
||||||
|
sensor:
|
||||||
|
- platform: template
|
||||||
|
name: "Zero Then Value"
|
||||||
|
id: zero_then_value
|
||||||
|
# Negative int32 takes the ten byte varint path
|
||||||
|
accuracy_decimals: -2
|
||||||
|
update_interval: never
|
||||||
|
|
||||||
|
text_sensor:
|
||||||
|
- platform: template
|
||||||
|
name: "Long Text"
|
||||||
|
id: long_text
|
||||||
|
update_interval: never
|
||||||
|
|
||||||
|
number:
|
||||||
|
- platform: template
|
||||||
|
name: "Negative Number"
|
||||||
|
optimistic: true
|
||||||
|
min_value: -1000
|
||||||
|
max_value: 1000
|
||||||
|
step: 0.5
|
||||||
|
initial_value: -123.5
|
||||||
|
|
||||||
|
select:
|
||||||
|
- platform: template
|
||||||
|
name: "Long Option Select"
|
||||||
|
optimistic: true
|
||||||
|
options:
|
||||||
|
- short
|
||||||
|
- "option-with-a-name-long-enough-that-its-length-prefix-needs-two-varint-bytes-when-the-list-entities-response-is-encoded-xxxxxxxxxx"
|
||||||
|
initial_option: short
|
||||||
|
|
||||||
|
button:
|
||||||
|
- platform: template
|
||||||
|
name: "Publish Values"
|
||||||
|
on_press:
|
||||||
|
- sensor.template.publish:
|
||||||
|
id: zero_then_value
|
||||||
|
state: 12.5
|
||||||
|
- text_sensor.template.publish:
|
||||||
|
id: long_text
|
||||||
|
state: !lambda return std::string(200, 'y');
|
||||||
@@ -57,6 +57,46 @@ async def wait_for_state(
|
|||||||
return await asyncio.wait_for(future, timeout=timeout)
|
return await asyncio.wait_for(future, timeout=timeout)
|
||||||
|
|
||||||
|
|
||||||
|
class StateWaiter:
|
||||||
|
"""Route one state subscription to any number of predicate waits."""
|
||||||
|
|
||||||
|
def __init__(self) -> None:
|
||||||
|
self._waiters: list[
|
||||||
|
tuple[Callable[[EntityState], bool], asyncio.Future[EntityState]]
|
||||||
|
] = []
|
||||||
|
|
||||||
|
def on_state(self, state: EntityState) -> None:
|
||||||
|
for predicate, future in self._waiters:
|
||||||
|
if future.done():
|
||||||
|
continue
|
||||||
|
try:
|
||||||
|
matched = predicate(state)
|
||||||
|
except Exception as exc: # noqa: BLE001 the wait re-raises it, the callback must not die
|
||||||
|
future.set_exception(exc)
|
||||||
|
continue
|
||||||
|
if matched:
|
||||||
|
future.set_result(state)
|
||||||
|
|
||||||
|
async def expect(
|
||||||
|
self,
|
||||||
|
predicate: Callable[[EntityState], bool],
|
||||||
|
timeout: float = 5.0,
|
||||||
|
label: str | None = None,
|
||||||
|
) -> EntityState:
|
||||||
|
"""Wait for the next state matching ``predicate``; states seen before this call do not count."""
|
||||||
|
entry = (predicate, asyncio.get_running_loop().create_future())
|
||||||
|
self._waiters.append(entry)
|
||||||
|
try:
|
||||||
|
async with asyncio.timeout(timeout):
|
||||||
|
return await entry[1]
|
||||||
|
except TimeoutError:
|
||||||
|
raise TimeoutError(
|
||||||
|
f"no state matched {label or predicate} within {timeout}s"
|
||||||
|
) from None
|
||||||
|
finally:
|
||||||
|
self._waiters.remove(entry)
|
||||||
|
|
||||||
|
|
||||||
def find_entity[T: EntityInfo](
|
def find_entity[T: EntityInfo](
|
||||||
entities: list[EntityInfo],
|
entities: list[EntityInfo],
|
||||||
object_id_substring: str,
|
object_id_substring: str,
|
||||||
|
|||||||
@@ -0,0 +1,37 @@
|
|||||||
|
"""Messages without fields go through the shared ProtoMessage entry points on both directions."""
|
||||||
|
|
||||||
|
from __future__ import annotations
|
||||||
|
|
||||||
|
from aioesphomeapi import api_pb2
|
||||||
|
import pytest
|
||||||
|
|
||||||
|
from .raw_api_client import MESSAGE_TYPE_OF, RawApiClient
|
||||||
|
from .types import RunCompiledFunction
|
||||||
|
|
||||||
|
|
||||||
|
@pytest.mark.asyncio
|
||||||
|
async def test_api_empty_message_roundtrip(
|
||||||
|
yaml_config: str,
|
||||||
|
run_compiled: RunCompiledFunction,
|
||||||
|
unused_tcp_port: int,
|
||||||
|
) -> None:
|
||||||
|
async with run_compiled(yaml_config), RawApiClient(unused_tcp_port) as client:
|
||||||
|
await client.connect()
|
||||||
|
|
||||||
|
# Field free request and reply on the plain send path
|
||||||
|
await client.send_message(api_pb2.PingRequest())
|
||||||
|
await client.read_until_frame(MESSAGE_TYPE_OF[api_pb2.PingResponse])
|
||||||
|
|
||||||
|
# Field free request answered by a message with fields, and a list that ends with
|
||||||
|
# the field free ListEntitiesDoneResponse through the batching path
|
||||||
|
await client.send_message(api_pb2.DeviceInfoRequest())
|
||||||
|
await client.read_until_frame(MESSAGE_TYPE_OF[api_pb2.DeviceInfoResponse])
|
||||||
|
await client.send_message(api_pb2.ListEntitiesRequest())
|
||||||
|
await client.read_until_frame(MESSAGE_TYPE_OF[api_pb2.ListEntitiesDoneResponse])
|
||||||
|
assert (
|
||||||
|
client.frame_counts[MESSAGE_TYPE_OF[api_pb2.ListEntitiesSwitchResponse]]
|
||||||
|
== 1
|
||||||
|
)
|
||||||
|
|
||||||
|
await client.send_message(api_pb2.DisconnectRequest())
|
||||||
|
await client.read_until_frame(MESSAGE_TYPE_OF[api_pb2.DisconnectResponse])
|
||||||
@@ -0,0 +1,78 @@
|
|||||||
|
"""Encode paths at their branch boundaries: zero skipped float, fixed32 state, negative int32,
|
||||||
|
length prefixes of two varint bytes and two byte field tags."""
|
||||||
|
|
||||||
|
from __future__ import annotations
|
||||||
|
|
||||||
|
import asyncio
|
||||||
|
|
||||||
|
from aioesphomeapi import (
|
||||||
|
NumberState,
|
||||||
|
SelectInfo,
|
||||||
|
SensorInfo,
|
||||||
|
SensorState,
|
||||||
|
TextSensorState,
|
||||||
|
)
|
||||||
|
import pytest
|
||||||
|
|
||||||
|
from .state_utils import InitialStateHelper, StateWaiter, require_entity
|
||||||
|
from .types import APIClientConnectedFactory, RunCompiledFunction
|
||||||
|
|
||||||
|
LONG_OPTION = (
|
||||||
|
"option-with-a-name-long-enough-that-its-length-prefix-needs-two-varint-bytes-"
|
||||||
|
"when-the-list-entities-response-is-encoded-xxxxxxxxxx"
|
||||||
|
)
|
||||||
|
|
||||||
|
|
||||||
|
@pytest.mark.asyncio
|
||||||
|
async def test_api_encode_boundaries(
|
||||||
|
yaml_config: str,
|
||||||
|
run_compiled: RunCompiledFunction,
|
||||||
|
api_client_connected: APIClientConnectedFactory,
|
||||||
|
) -> None:
|
||||||
|
async with run_compiled(yaml_config), api_client_connected() as client:
|
||||||
|
device_info, (entities, _) = await asyncio.gather(
|
||||||
|
client.device_info(), client.list_entities_services()
|
||||||
|
)
|
||||||
|
assert device_info.suggested_area == "Kitchen"
|
||||||
|
|
||||||
|
sensor = require_entity(entities, "zero_then_value", SensorInfo)
|
||||||
|
assert sensor.accuracy_decimals == -2
|
||||||
|
select = require_entity(entities, "long_option_select", SelectInfo)
|
||||||
|
assert len(LONG_OPTION) >= 128
|
||||||
|
assert select.options == ["short", LONG_OPTION]
|
||||||
|
text = require_entity(entities, "long_text")
|
||||||
|
number = require_entity(entities, "negative_number")
|
||||||
|
button = require_entity(entities, "publish_values")
|
||||||
|
|
||||||
|
initial = InitialStateHelper(entities)
|
||||||
|
waiter = StateWaiter()
|
||||||
|
client.subscribe_states(initial.on_state_wrapper(waiter.on_state))
|
||||||
|
await initial.wait_for_initial_states()
|
||||||
|
|
||||||
|
# A float of exactly zero is skipped on the wire and must still read as 0.0, not missing
|
||||||
|
first = initial.initial_states[sensor.key]
|
||||||
|
assert isinstance(first, SensorState)
|
||||||
|
assert first.state == 0.0 and not first.missing_state
|
||||||
|
first_number = initial.initial_states[number.key]
|
||||||
|
assert isinstance(first_number, NumberState)
|
||||||
|
assert first_number.state == -123.5
|
||||||
|
|
||||||
|
client.button_command(button.key)
|
||||||
|
await asyncio.gather(
|
||||||
|
waiter.expect(
|
||||||
|
lambda s: (
|
||||||
|
isinstance(s, SensorState)
|
||||||
|
and s.key == sensor.key
|
||||||
|
and s.state == 12.5
|
||||||
|
),
|
||||||
|
label="sensor 12.5",
|
||||||
|
),
|
||||||
|
waiter.expect(
|
||||||
|
lambda s: (
|
||||||
|
isinstance(s, TextSensorState)
|
||||||
|
and s.key == text.key
|
||||||
|
and s.state == "y" * 200
|
||||||
|
),
|
||||||
|
label="text 200 x y",
|
||||||
|
),
|
||||||
|
)
|
||||||
@@ -35,8 +35,8 @@ def _load_script():
|
|||||||
def test_spec_key_collapses_destinations() -> None:
|
def test_spec_key_collapses_destinations() -> None:
|
||||||
"""Two specs delivering one package share a directory and one key."""
|
"""Two specs delivering one package share a directory and one key."""
|
||||||
mod = _load_script()
|
mod = _load_script()
|
||||||
assert mod.spec_key("esphome/noise-c @ 0.1.26") == "noise-c"
|
assert mod.spec_key("esphome/noise-c @ 0.1.24") == "noise-c"
|
||||||
assert mod.spec_key("esphome/noise-c@0.1.26") == "noise-c"
|
assert mod.spec_key("esphome/noise-c@0.1.24") == "noise-c"
|
||||||
assert mod.spec_key("ESP32Async/AsyncTCP @ ^3.4.10") == mod.spec_key(
|
assert mod.spec_key("ESP32Async/AsyncTCP @ ^3.4.10") == mod.spec_key(
|
||||||
"esp32async/asynctcp @ 3.5.0"
|
"esp32async/asynctcp @ 3.5.0"
|
||||||
)
|
)
|
||||||
@@ -54,23 +54,23 @@ def test_parse_specs_and_cli_args(tmp_path: Path) -> None:
|
|||||||
"[env:a]\n"
|
"[env:a]\n"
|
||||||
"platform = fake/platform@1\n"
|
"platform = fake/platform@1\n"
|
||||||
"lib_deps =\n"
|
"lib_deps =\n"
|
||||||
" esphome/noise-c @ 0.1.26\n"
|
" esphome/noise-c @ 0.1.24\n"
|
||||||
" ${common.lib_deps}\n"
|
" ${common.lib_deps}\n"
|
||||||
" internal_lib\n"
|
" internal_lib\n"
|
||||||
"[env:b]\n"
|
"[env:b]\n"
|
||||||
"lib_deps =\n"
|
"lib_deps =\n"
|
||||||
" esphome/noise-c @ 0.1.26\n"
|
" esphome/noise-c @ 0.1.24\n"
|
||||||
)
|
)
|
||||||
mod = _load_script()
|
mod = _load_script()
|
||||||
args = Namespace(libraries=True, platforms=True, tools=False)
|
args = Namespace(libraries=True, platforms=True, tools=False)
|
||||||
libs, platforms, tools = mod.parse_specs(str(ini), args)
|
libs, platforms, tools = mod.parse_specs(str(ini), args)
|
||||||
# exact-string duplicates collapse; distinct version pins survive
|
# exact-string duplicates collapse; distinct version pins survive
|
||||||
assert libs == ["esphome/noise-c @ 0.1.26"]
|
assert libs == ["esphome/noise-c @ 0.1.24"]
|
||||||
assert platforms == ["fake/platform@1"]
|
assert platforms == ["fake/platform@1"]
|
||||||
assert tools == []
|
assert tools == []
|
||||||
assert mod.build_cli_args(libs, platforms, tools) == [
|
assert mod.build_cli_args(libs, platforms, tools) == [
|
||||||
"-l",
|
"-l",
|
||||||
"esphome/noise-c @ 0.1.26",
|
"esphome/noise-c @ 0.1.24",
|
||||||
"-p",
|
"-p",
|
||||||
"fake/platform@1",
|
"fake/platform@1",
|
||||||
]
|
]
|
||||||
@@ -162,13 +162,13 @@ def test_parallel_install_behavior(tmp_path: Path) -> None:
|
|||||||
mod.parallel_install(
|
mod.parallel_install(
|
||||||
cls,
|
cls,
|
||||||
[
|
[
|
||||||
"esphome/noise-c @ 0.1.26",
|
"esphome/noise-c @ 0.1.24",
|
||||||
"esphome/noise-c @ 0.1.26",
|
"esphome/noise-c @ 0.1.24",
|
||||||
"esphome/already @ 1.0",
|
"esphome/already @ 1.0",
|
||||||
"https://x/framework.tar.xz",
|
"https://x/framework.tar.xz",
|
||||||
],
|
],
|
||||||
)
|
)
|
||||||
assert cls.calls == ["esphome/noise-c @ 0.1.26"]
|
assert cls.calls == ["esphome/noise-c @ 0.1.24"]
|
||||||
assert cls.lock_events == ["lock", "unlock"]
|
assert cls.lock_events == ["lock", "unlock"]
|
||||||
|
|
||||||
|
|
||||||
@@ -205,7 +205,7 @@ def test_parallel_install_runs_dependency_waves(tmp_path: Path) -> None:
|
|||||||
mod = _load_script()
|
mod = _load_script()
|
||||||
cls = _reset_fake(str(tmp_path))
|
cls = _reset_fake(str(tmp_path))
|
||||||
cls.deps = {
|
cls.deps = {
|
||||||
"esphome/noise-c @ 0.1.26": [
|
"esphome/noise-c @ 0.1.24": [
|
||||||
{"owner": "esphome", "name": "libsodium", "version": "^1.0"},
|
{"owner": "esphome", "name": "libsodium", "version": "^1.0"},
|
||||||
{"name": "SPI"},
|
{"name": "SPI"},
|
||||||
],
|
],
|
||||||
@@ -213,12 +213,12 @@ def test_parallel_install_runs_dependency_waves(tmp_path: Path) -> None:
|
|||||||
{"owner": "esphome", "name": "libsodium", "version": "^1.0"},
|
{"owner": "esphome", "name": "libsodium", "version": "^1.0"},
|
||||||
],
|
],
|
||||||
}
|
}
|
||||||
mod.parallel_install(cls, ["esphome/noise-c @ 0.1.26", "esphome/wg @ 1.0"])
|
mod.parallel_install(cls, ["esphome/noise-c @ 0.1.24", "esphome/wg @ 1.0"])
|
||||||
assert len(cls.calls) == 3 # the shared dep installs exactly once
|
assert len(cls.calls) == 3 # the shared dep installs exactly once
|
||||||
assert {mod.spec_key(c) for c in cls.calls} == {"noise-c", "wg", "libsodium"}
|
assert {mod.spec_key(c) for c in cls.calls} == {"noise-c", "wg", "libsodium"}
|
||||||
# Wave-1 strings carry no compatibility; the dependency wave does
|
# Wave-1 strings carry no compatibility; the dependency wave does
|
||||||
compats = dict(cls.compat_calls)
|
compats = dict(cls.compat_calls)
|
||||||
assert compats["esphome/noise-c @ 0.1.26"] is None
|
assert compats["esphome/noise-c @ 0.1.24"] is None
|
||||||
dep_compat = next(v for k, v in cls.compat_calls if "libsodium" in k)
|
dep_compat = next(v for k, v in cls.compat_calls if "libsodium" in k)
|
||||||
assert dep_compat is not None # mirrors pio's install_dependency
|
assert dep_compat is not None # mirrors pio's install_dependency
|
||||||
|
|
||||||
@@ -229,11 +229,11 @@ def test_dependency_wave_excludes_url_specs(tmp_path: Path) -> None:
|
|||||||
mod = _load_script()
|
mod = _load_script()
|
||||||
cls = _reset_fake(str(tmp_path))
|
cls = _reset_fake(str(tmp_path))
|
||||||
cls.deps = {
|
cls.deps = {
|
||||||
"esphome/noise-c @ 0.1.26": [
|
"esphome/noise-c @ 0.1.24": [
|
||||||
{"name": "vendored", "version": "https://github.com/x/y.git"},
|
{"name": "vendored", "version": "https://github.com/x/y.git"},
|
||||||
],
|
],
|
||||||
}
|
}
|
||||||
mod.parallel_install(cls, ["esphome/noise-c @ 0.1.26"])
|
mod.parallel_install(cls, ["esphome/noise-c @ 0.1.24"])
|
||||||
assert {mod.spec_key(c) for c in cls.calls} == {"noise-c"}
|
assert {mod.spec_key(c) for c in cls.calls} == {"noise-c"}
|
||||||
|
|
||||||
|
|
||||||
@@ -348,13 +348,13 @@ def test_warm_store_still_walks_dependencies(tmp_path: Path) -> None:
|
|||||||
"""Already-installed top-level packages still feed the dependency
|
"""Already-installed top-level packages still feed the dependency
|
||||||
wave; a warm store can be missing a transitive dep."""
|
wave; a warm store can be missing a transitive dep."""
|
||||||
mod = _load_script()
|
mod = _load_script()
|
||||||
cls = _reset_fake(str(tmp_path), installed={"esphome/noise-c @ 0.1.26"})
|
cls = _reset_fake(str(tmp_path), installed={"esphome/noise-c @ 0.1.24"})
|
||||||
cls.deps = {
|
cls.deps = {
|
||||||
"esphome/noise-c @ 0.1.26": [
|
"esphome/noise-c @ 0.1.24": [
|
||||||
{"owner": "esphome", "name": "libsodium", "version": "^1.0"},
|
{"owner": "esphome", "name": "libsodium", "version": "^1.0"},
|
||||||
],
|
],
|
||||||
}
|
}
|
||||||
mod.parallel_install(cls, ["esphome/noise-c @ 0.1.26"])
|
mod.parallel_install(cls, ["esphome/noise-c @ 0.1.24"])
|
||||||
assert [mod.spec_key(c) for c in cls.calls] == ["libsodium"]
|
assert [mod.spec_key(c) for c in cls.calls] == ["libsodium"]
|
||||||
|
|
||||||
|
|
||||||
|
|||||||
@@ -194,17 +194,17 @@ def test_superseded_device_info_fields_still_declared_in_header() -> None:
|
|||||||
|
|
||||||
def test_superseded_device_info_fields_still_encoded_and_sized() -> None:
|
def test_superseded_device_info_fields_still_encoded_and_sized() -> None:
|
||||||
"""Each superseded field must still be touched by DeviceInfoResponse's
|
"""Each superseded field must still be touched by DeviceInfoResponse's
|
||||||
generated encode() and calculate_size(), i.e. it is still put on the wire.
|
generated encode_msg() and calc_size_msg(), i.e. it is still put on the wire.
|
||||||
"""
|
"""
|
||||||
encode_body = _extract_function_body(CPP_TEXT, "DeviceInfoResponse::encode")
|
encode_body = _extract_function_body(CPP_TEXT, "DeviceInfoResponse::encode_msg")
|
||||||
size_body = _extract_function_body(CPP_TEXT, "DeviceInfoResponse::calculate_size")
|
size_body = _extract_function_body(CPP_TEXT, "DeviceInfoResponse::calc_size_msg")
|
||||||
for field_name in SUPERSEDED_FIELDS:
|
for field_name in SUPERSEDED_FIELDS:
|
||||||
assert f"this->{field_name}" in encode_body, (
|
assert f"msg.{field_name}" in encode_body, (
|
||||||
f"DeviceInfoResponse::encode() no longer references {field_name}. "
|
f"DeviceInfoResponse::encode_msg() no longer references {field_name}. "
|
||||||
f"{DEPRECATED_FIELD_TRAP}"
|
f"{DEPRECATED_FIELD_TRAP}"
|
||||||
)
|
)
|
||||||
assert f"this->{field_name}" in size_body, (
|
assert f"msg.{field_name}" in size_body, (
|
||||||
f"DeviceInfoResponse::calculate_size() no longer references "
|
f"DeviceInfoResponse::calc_size_msg() no longer references "
|
||||||
f"{field_name}. {DEPRECATED_FIELD_TRAP}"
|
f"{field_name}. {DEPRECATED_FIELD_TRAP}"
|
||||||
)
|
)
|
||||||
|
|
||||||
@@ -380,3 +380,13 @@ def test_api_version_minor_is_at_least_15() -> None:
|
|||||||
"clients to see api_version >= 1.15 in HelloResponse before they will "
|
"clients to see api_version >= 1.15 in HelloResponse before they will "
|
||||||
"ever request it."
|
"ever request it."
|
||||||
)
|
)
|
||||||
|
|
||||||
|
|
||||||
|
def test_generated_encode_calls_keep_the_cursor() -> None:
|
||||||
|
"""No generated ProtoEncode call may drop the returned cursor."""
|
||||||
|
dropped = [
|
||||||
|
line
|
||||||
|
for line in CPP_TEXT.splitlines()
|
||||||
|
if "ProtoEncode::" in line and "pos = ProtoEncode::" not in line
|
||||||
|
]
|
||||||
|
assert not dropped, dropped[:5]
|
||||||
|
|||||||
@@ -15,9 +15,11 @@ import pytest
|
|||||||
|
|
||||||
sys.path.insert(0, str(Path(__file__).parents[4] / "script" / "api_protobuf"))
|
sys.path.insert(0, str(Path(__file__).parents[4] / "script" / "api_protobuf"))
|
||||||
|
|
||||||
|
import aioesphomeapi.api_options_pb2 as pb # noqa: E402
|
||||||
from api_protobuf import ( # noqa: E402
|
from api_protobuf import ( # noqa: E402
|
||||||
MAX_MESSAGE_ID,
|
MAX_MESSAGE_ID,
|
||||||
_make_ifdef_line,
|
_make_ifdef_line,
|
||||||
|
create_field_type_info,
|
||||||
get_varint64_ifdef,
|
get_varint64_ifdef,
|
||||||
validate_message_id,
|
validate_message_id,
|
||||||
)
|
)
|
||||||
@@ -43,7 +45,14 @@ UINT64 = descriptor_pb2.FieldDescriptorProto.TYPE_UINT64
|
|||||||
INT64 = descriptor_pb2.FieldDescriptorProto.TYPE_INT64
|
INT64 = descriptor_pb2.FieldDescriptorProto.TYPE_INT64
|
||||||
SINT64 = descriptor_pb2.FieldDescriptorProto.TYPE_SINT64
|
SINT64 = descriptor_pb2.FieldDescriptorProto.TYPE_SINT64
|
||||||
UINT32 = descriptor_pb2.FieldDescriptorProto.TYPE_UINT32
|
UINT32 = descriptor_pb2.FieldDescriptorProto.TYPE_UINT32
|
||||||
|
INT32 = descriptor_pb2.FieldDescriptorProto.TYPE_INT32
|
||||||
|
SINT32 = descriptor_pb2.FieldDescriptorProto.TYPE_SINT32
|
||||||
FIXED64 = descriptor_pb2.FieldDescriptorProto.TYPE_FIXED64
|
FIXED64 = descriptor_pb2.FieldDescriptorProto.TYPE_FIXED64
|
||||||
|
FIXED32 = descriptor_pb2.FieldDescriptorProto.TYPE_FIXED32
|
||||||
|
FLOAT = descriptor_pb2.FieldDescriptorProto.TYPE_FLOAT
|
||||||
|
BOOL = descriptor_pb2.FieldDescriptorProto.TYPE_BOOL
|
||||||
|
STRING = descriptor_pb2.FieldDescriptorProto.TYPE_STRING
|
||||||
|
BYTES = descriptor_pb2.FieldDescriptorProto.TYPE_BYTES
|
||||||
|
|
||||||
|
|
||||||
def test_no_varint64_fields() -> None:
|
def test_no_varint64_fields() -> None:
|
||||||
@@ -107,3 +116,69 @@ def test_message_id_at_maximum_is_accepted() -> None:
|
|||||||
def test_message_id_above_maximum_is_rejected() -> None:
|
def test_message_id_above_maximum_is_rejected() -> None:
|
||||||
with pytest.raises(ValueError, match="exceeds the plaintext"):
|
with pytest.raises(ValueError, match="exceeds the plaintext"):
|
||||||
validate_message_id(MAX_MESSAGE_ID + 1, "TooBigMessage")
|
validate_message_id(MAX_MESSAGE_ID + 1, "TooBigMessage")
|
||||||
|
|
||||||
|
|
||||||
|
def _field(
|
||||||
|
field_type: int, number: int = 1, *, force: bool = False, repeated: bool = False
|
||||||
|
) -> descriptor_pb2.FieldDescriptorProto:
|
||||||
|
field = descriptor_pb2.FieldDescriptorProto(
|
||||||
|
name="value", number=number, type=field_type
|
||||||
|
)
|
||||||
|
if repeated:
|
||||||
|
field.label = descriptor_pb2.FieldDescriptorProto.LABEL_REPEATED
|
||||||
|
if force:
|
||||||
|
field.options.Extensions[pb.force] = True
|
||||||
|
return field
|
||||||
|
|
||||||
|
|
||||||
|
def _encode_field(
|
||||||
|
field_type: int, number: int = 1, force: bool = False, repeated: bool = False
|
||||||
|
) -> str:
|
||||||
|
"""Return the encode statement the generator emits for one encode-only field."""
|
||||||
|
field = _field(field_type, number, force=force, repeated=repeated)
|
||||||
|
return create_field_type_info(
|
||||||
|
field, needs_decode=False, needs_encode=True
|
||||||
|
).encode_content
|
||||||
|
|
||||||
|
|
||||||
|
SCALAR_TYPES = [
|
||||||
|
BOOL,
|
||||||
|
UINT32,
|
||||||
|
INT32,
|
||||||
|
UINT64,
|
||||||
|
INT64,
|
||||||
|
SINT32,
|
||||||
|
FLOAT,
|
||||||
|
FIXED32,
|
||||||
|
STRING,
|
||||||
|
BYTES,
|
||||||
|
]
|
||||||
|
|
||||||
|
|
||||||
|
@pytest.mark.parametrize("field_type", SCALAR_TYPES)
|
||||||
|
def test_forced_fields_use_the_force_overload_or_raw_writes(field_type: int) -> None:
|
||||||
|
content = _encode_field(field_type, force=True)
|
||||||
|
assert (
|
||||||
|
"_force(" in content
|
||||||
|
or "write_raw_byte(" in content
|
||||||
|
or "write_tag_and_fixed32(" in content
|
||||||
|
), content
|
||||||
|
|
||||||
|
|
||||||
|
@pytest.mark.parametrize("field_type", [FLOAT, FIXED32])
|
||||||
|
def test_single_byte_tag_fixed32_shares_the_outlined_writer(field_type: int) -> None:
|
||||||
|
unconditional = _encode_field(field_type, force=True)
|
||||||
|
assert unconditional.count("write_tag_and_fixed32(pos, 13,") == 1, unconditional
|
||||||
|
guarded = _encode_field(field_type, force=False)
|
||||||
|
assert guarded.startswith("if ("), guarded
|
||||||
|
assert "[[likely]]" in guarded
|
||||||
|
assert "write_tag_and_fixed32(pos, 13," in guarded
|
||||||
|
|
||||||
|
|
||||||
|
@pytest.mark.parametrize("field_type", [FLOAT, FIXED32])
|
||||||
|
def test_multi_byte_tag_fixed32_falls_back_to_the_generic_helper(
|
||||||
|
field_type: int,
|
||||||
|
) -> None:
|
||||||
|
content = _encode_field(field_type, number=16)
|
||||||
|
assert "write_tag_and_fixed32" not in content, content
|
||||||
|
assert content.startswith("pos = ProtoEncode::encode_"), content
|
||||||
|
|||||||
@@ -1,37 +0,0 @@
|
|||||||
"""Tests for the udp component configuration schema."""
|
|
||||||
|
|
||||||
from __future__ import annotations
|
|
||||||
|
|
||||||
import pytest
|
|
||||||
|
|
||||||
from esphome.components import udp
|
|
||||||
from esphome.components.packet_transport import (
|
|
||||||
CONF_BINARY_SENSORS,
|
|
||||||
CONF_ENCRYPTION,
|
|
||||||
CONF_PING_PONG_ENABLE,
|
|
||||||
CONF_PROVIDERS,
|
|
||||||
CONF_ROLLING_CODE_ENABLE,
|
|
||||||
CONF_SENSORS,
|
|
||||||
)
|
|
||||||
import esphome.config_validation as cv
|
|
||||||
|
|
||||||
|
|
||||||
@pytest.mark.parametrize(
|
|
||||||
"option",
|
|
||||||
[
|
|
||||||
CONF_PROVIDERS,
|
|
||||||
CONF_ENCRYPTION,
|
|
||||||
CONF_PING_PONG_ENABLE,
|
|
||||||
CONF_ROLLING_CODE_ENABLE,
|
|
||||||
CONF_SENSORS,
|
|
||||||
CONF_BINARY_SENSORS,
|
|
||||||
],
|
|
||||||
)
|
|
||||||
def test_relocated_option_rejected(option: str) -> None:
|
|
||||||
"""Options that moved to packet_transport raise a pointing error."""
|
|
||||||
with pytest.raises(cv.Invalid) as exc_info:
|
|
||||||
udp.CONFIG_SCHEMA({option: True})
|
|
||||||
assert (
|
|
||||||
f"The '{option}' option should now be configured in the 'packet_transport' component"
|
|
||||||
in str(exc_info.value)
|
|
||||||
)
|
|
||||||
@@ -416,9 +416,6 @@ def test_perform_ota_no_auth(
|
|||||||
"Update took 14.00 seconds (prepare 2.00, upload 5.00, commit 7.00)"
|
"Update took 14.00 seconds (prepare 2.00, upload 5.00, commit 7.00)"
|
||||||
in caplog.text
|
in caplog.text
|
||||||
)
|
)
|
||||||
# The data phase timeout must outlast the device's 105 s data timeout
|
|
||||||
mock_socket.settimeout.assert_any_call(espota2.DATA_PHASE_TIMEOUT)
|
|
||||||
assert espota2.DATA_PHASE_TIMEOUT > 105.0
|
|
||||||
|
|
||||||
|
|
||||||
@pytest.mark.usefixtures("mock_time")
|
@pytest.mark.usefixtures("mock_time")
|
||||||
|
|||||||
@@ -7,7 +7,6 @@ exercised in their own test modules)."""
|
|||||||
import json
|
import json
|
||||||
import logging
|
import logging
|
||||||
from pathlib import Path
|
from pathlib import Path
|
||||||
from unittest.mock import Mock
|
|
||||||
|
|
||||||
import pytest
|
import pytest
|
||||||
|
|
||||||
@@ -229,24 +228,6 @@ def test_resolve_registry_version_raises_without_pkg_file(monkeypatch):
|
|||||||
_resolve_registry_version("owner", "pkg", set())
|
_resolve_registry_version("owner", "pkg", set())
|
||||||
|
|
||||||
|
|
||||||
def test_make_registry_client_skips_private_package_probe(monkeypatch):
|
|
||||||
"""Our client answers the probe locally without patching PlatformIO's class."""
|
|
||||||
from platformio.account.client import AccountClient
|
|
||||||
from platformio.registry.client import RegistryClient
|
|
||||||
|
|
||||||
pio_probe = RegistryClient.__dict__["allowed_private_packages"]
|
|
||||||
monkeypatch.setattr(
|
|
||||||
AccountClient,
|
|
||||||
"get_account_info",
|
|
||||||
Mock(side_effect=AssertionError("account probe must not run")),
|
|
||||||
)
|
|
||||||
|
|
||||||
client = lib._make_registry_client().get_registry_client_instance()
|
|
||||||
|
|
||||||
assert client.allowed_private_packages() is False
|
|
||||||
assert RegistryClient.__dict__["allowed_private_packages"] is pio_probe
|
|
||||||
|
|
||||||
|
|
||||||
def _patch_registry_resolve(monkeypatch: pytest.MonkeyPatch) -> None:
|
def _patch_registry_resolve(monkeypatch: pytest.MonkeyPatch) -> None:
|
||||||
"""Stub the registry lookup so tests never touch the network."""
|
"""Stub the registry lookup so tests never touch the network."""
|
||||||
monkeypatch.setattr(
|
monkeypatch.setattr(
|
||||||
|
|||||||
@@ -1225,20 +1225,6 @@ def test_main_runs_prefetch(tmp_path: Path) -> None:
|
|||||||
mock_prefetch.assert_called_once_with(tmp_path, "testenv")
|
mock_prefetch.assert_called_once_with(tmp_path, "testenv")
|
||||||
|
|
||||||
|
|
||||||
def test_main_skips_private_package_probe_before_prefetch(tmp_path: Path) -> None:
|
|
||||||
"""The registry probe patch is applied before any package manager runs."""
|
|
||||||
order: list[str] = []
|
|
||||||
with (
|
|
||||||
patch.object(pf, "_prefetch", side_effect=lambda *_: order.append("prefetch")),
|
|
||||||
patch(
|
|
||||||
"esphome.platformio.runner.patch_registry_private_packages",
|
|
||||||
side_effect=lambda: order.append("patch"),
|
|
||||||
),
|
|
||||||
):
|
|
||||||
assert pf.main([str(tmp_path), "testenv"]) == 0
|
|
||||||
assert order == ["patch", "prefetch"]
|
|
||||||
|
|
||||||
|
|
||||||
def test_main_bad_argv_is_a_distinct_exit(
|
def test_main_bad_argv_is_a_distinct_exit(
|
||||||
caplog: pytest.LogCaptureFixture,
|
caplog: pytest.LogCaptureFixture,
|
||||||
) -> None:
|
) -> None:
|
||||||
@@ -1663,7 +1649,7 @@ def test_preinstall_runs_dependency_waves(tmp_path: Path) -> None:
|
|||||||
{"name": "SPI"},
|
{"name": "SPI"},
|
||||||
]
|
]
|
||||||
m.dependency_to_spec.side_effect = lambda dep: _FakeSpec(name=dep["name"])
|
m.dependency_to_spec.side_effect = lambda dep: _FakeSpec(name=dep["name"])
|
||||||
pf._preinstall(m, [("noise-c@0.1.26", _FakeSpec(name="noise-c"))])
|
pf._preinstall(m, [("noise-c@0.1.24", _FakeSpec(name="noise-c"))])
|
||||||
assert installed == ["noise-c", "libsodium"] # dep deduped, SPI left out
|
assert installed == ["noise-c", "libsodium"] # dep deduped, SPI left out
|
||||||
# The dep wave carries its compatibility so _install searches qualified
|
# The dep wave carries its compatibility so _install searches qualified
|
||||||
dep_call = m._install.call_args_list[-1]
|
dep_call = m._install.call_args_list[-1]
|
||||||
@@ -1683,7 +1669,7 @@ def test_preinstall_dependency_wave_skips_seen_names(tmp_path: Path) -> None:
|
|||||||
m._install.side_effect = lambda spec, skip_dependencies, compatibility=None: (
|
m._install.side_effect = lambda spec, skip_dependencies, compatibility=None: (
|
||||||
installed.append(getattr(spec, "name", str(spec)))
|
installed.append(getattr(spec, "name", str(spec)))
|
||||||
)
|
)
|
||||||
pf._preinstall(m, [("noise-c@0.1.26", _FakeSpec(name="noise-c"))])
|
pf._preinstall(m, [("noise-c@0.1.24", _FakeSpec(name="noise-c"))])
|
||||||
assert installed == ["noise-c"]
|
assert installed == ["noise-c"]
|
||||||
|
|
||||||
|
|
||||||
|
|||||||
@@ -6,9 +6,7 @@ from collections.abc import Callable
|
|||||||
import io
|
import io
|
||||||
import sys
|
import sys
|
||||||
from types import ModuleType
|
from types import ModuleType
|
||||||
from unittest.mock import Mock
|
|
||||||
|
|
||||||
from platformio.registry.client import RegistryClient
|
|
||||||
import pytest
|
import pytest
|
||||||
|
|
||||||
from esphome.platformio import runner
|
from esphome.platformio import runner
|
||||||
@@ -32,7 +30,6 @@ def _prepare_main(
|
|||||||
monkeypatch.setattr(sys, "stderr", stream)
|
monkeypatch.setattr(sys, "stderr", stream)
|
||||||
monkeypatch.setattr(runner, "patch_structhash", lambda: None)
|
monkeypatch.setattr(runner, "patch_structhash", lambda: None)
|
||||||
monkeypatch.setattr(runner, "patch_file_downloader", lambda: None)
|
monkeypatch.setattr(runner, "patch_file_downloader", lambda: None)
|
||||||
monkeypatch.setattr(runner, "patch_registry_private_packages", lambda: None)
|
|
||||||
|
|
||||||
platformio = ModuleType("platformio")
|
platformio = ModuleType("platformio")
|
||||||
platformio_main = ModuleType("platformio.__main__")
|
platformio_main = ModuleType("platformio.__main__")
|
||||||
@@ -94,40 +91,3 @@ def test_main_still_filters_a_drained_partial_line(
|
|||||||
|
|
||||||
assert runner.main() == 0
|
assert runner.main() == 0
|
||||||
assert buf.getvalue() == b""
|
assert buf.getvalue() == b""
|
||||||
|
|
||||||
|
|
||||||
def test_main_applies_registry_private_packages_patch(
|
|
||||||
monkeypatch: pytest.MonkeyPatch,
|
|
||||||
) -> None:
|
|
||||||
"""The probe is patched before PlatformIO runs."""
|
|
||||||
order: list[str] = []
|
|
||||||
_prepare_main(monkeypatch, lambda: order.append("pio") or 0)
|
|
||||||
monkeypatch.setattr(
|
|
||||||
runner, "patch_registry_private_packages", lambda: order.append("patch")
|
|
||||||
)
|
|
||||||
|
|
||||||
assert runner.main() == 0
|
|
||||||
assert order == ["patch", "pio"]
|
|
||||||
|
|
||||||
|
|
||||||
# Snapshot PlatformIO's own probe at import, before any test can patch it
|
|
||||||
_PIO_PROBE = RegistryClient.__dict__["allowed_private_packages"]
|
|
||||||
|
|
||||||
|
|
||||||
def test_patch_registry_private_packages_skips_account_probe(
|
|
||||||
monkeypatch: pytest.MonkeyPatch,
|
|
||||||
) -> None:
|
|
||||||
"""Answers False without touching the account client."""
|
|
||||||
from platformio.account.client import AccountClient
|
|
||||||
|
|
||||||
monkeypatch.setattr(RegistryClient, "allowed_private_packages", _PIO_PROBE)
|
|
||||||
monkeypatch.setattr(
|
|
||||||
AccountClient,
|
|
||||||
"get_account_info",
|
|
||||||
Mock(side_effect=AssertionError("account probe must not run")),
|
|
||||||
)
|
|
||||||
|
|
||||||
runner.patch_registry_private_packages()
|
|
||||||
|
|
||||||
assert RegistryClient.allowed_private_packages() is False
|
|
||||||
assert RegistryClient().allowed_private_packages() is False
|
|
||||||
|
|||||||
Reference in New Issue
Block a user