github/esphome
2
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2026-09-11 23:37:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

[api] Tighten the ProtoMessage default entry point comment

Browse Source
This commit is contained in:
J. Nick Koston
2026-09-07 15:57:12 +02:00
parent 79927b918b
commit 55fc5a10de
1 changed files with 5 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
esphome/components/api/proto.h
+5 -11
View File
@@ -692,17 +692,11 @@ class DumpBuffer {
class ProtoMessage {
public:
// Non-virtual defaults for messages with no fields.
// Concrete message classes hide these with their own implementations.
// All call sites use templates to preserve the concrete type, so virtual
// dispatch is not needed. This eliminates per-message vtable entries for
// encode/calculate_size, saving ~1.3 KB of flash across all message types.
//
// encode_msg/calc_size_msg are the type-erased entry points: generated messages define them as
// static functions over const void *, so &T::encode_msg is passed directly where a function
// pointer is needed and no per-type thunk exists. Generated classes also define encode() and
// calculate_size() as inline forwarders to their statics; the four defaults here are independent
// no-ops for messages without fields.
// Non-virtual defaults for messages with no fields; generated message classes hide all four.
// encode_msg/calc_size_msg are the type-erased entry points (static over const void *), so
// &T::encode_msg is a MessageEncodeFn with no per-type thunk; encode()/calculate_size() serve
// direct callers and forward to the statics in generated classes. No virtual dispatch: every
// call site knows the concrete type, which keeps these out of the per-message vtables.
static uint8_t *encode_msg(const void *self, ProtoWriteBuffer &buffer PROTO_ENCODE_DEBUG_PARAM) {
return buffer.get_pos();
}