Make the 4-byte alignment of the directly read flash tables explicit

.github/workflows/ci.yml

@@ -81,8 +81,8 @@ jobs:
       - name: Install apt packages (cached)
         uses: awalsh128/cache-apt-pkgs-action@553a35bb8ebd9fcabcb1c9451aa4c98e1b4ca8a9 # v1.6.3
         with:
-          packages: libsdl2-dev libmbedtls-dev ccache
-          version: 1.2
+          packages: libsdl2-dev ccache
+          version: 1.1
 
   determine-jobs:
     name: Determine which jobs to run
@@ -415,8 +415,8 @@ jobs:
         timeout-minutes: 10
         uses: awalsh128/cache-apt-pkgs-action@553a35bb8ebd9fcabcb1c9451aa4c98e1b4ca8a9 # v1.6.3
         with:
-          packages: libsdl2-dev libmbedtls-dev ccache
-          version: 1.2
+          packages: libsdl2-dev ccache
+          version: 1.1
       - name: Set up Python 3.13
         id: python
         uses: actions/setup-python@5fda3b95a4ea91299a34e894583c3862153e4b97 # v7.0.0
@@ -680,7 +680,7 @@ jobs:
         include:
           - id: clang-tidy
             name: Run script/clang-tidy for ESP8266
-            options: --environment esp8266-arduino-tidy --grep USE_ESP8266 --grep USE_SOCKET_IMPL_LWIP_TCP --grep USE_SHD_FIRMWARE_DATA
+            options: --environment esp8266-arduino-tidy --grep USE_ESP8266
             pio_cache_key: tidyesp8266
           - id: clang-tidy
             name: Run script/clang-tidy for ESP32 Arduino
@@ -693,16 +693,12 @@ jobs:
             ignore_errors: false
           - id: clang-tidy
             name: Run script/clang-tidy for RP2
-            options: --environment rp2-tidy --grep USE_RP2 --grep USE_BLE_SCAN_RESPONSE_MERGER
+            options: --environment rp2-tidy --grep USE_RP2
             pio_cache_key: tidyrp2
-          - id: clang-tidy
-            name: Run script/clang-tidy for host
-            options: --environment host-tidy --grep USE_HOST
-            pio_cache_key: tidyhost
           - id: clang-tidy
             name: Run script/clang-tidy for LibreTiny
             environments: bk72xx-tidy ln882h-tidy rtl87xxb-tidy rtl87xxc-tidy
-            options: --grep USE_LIBRETINY --grep USE_BK72XX --grep USE_RTL87XX --grep USE_LN882X --grep USE_LN882H_BLE --grep USE_SOCKET_IMPL_LWIP_SOCKETS
+            options: --grep USE_LIBRETINY --grep USE_BK72XX --grep USE_RTL87XX --grep USE_LN882X
             pio_cache_key: tidylibretiny
 
     steps:
@@ -711,16 +707,6 @@ jobs:
         with:
           # Need history for HEAD~1 to work for checking changed files
           fetch-depth: 2
-      - name: Install apt packages (cached)
-        if: matrix.pio_cache_key == 'tidyhost'
-        # libsdl2-dev is needed by the sdl component on the host, libmbedtls-dev
-        # by dsmr and dlms_meter. Packages and version must match seed-apt-cache
-        # exactly.
-        timeout-minutes: 10
-        uses: awalsh128/cache-apt-pkgs-action@553a35bb8ebd9fcabcb1c9451aa4c98e1b4ca8a9 # v1.6.3
-        with:
-          packages: libsdl2-dev libmbedtls-dev ccache
-          version: 1.2
 
       - name: Restore Python
         id: restore-python
@@ -1003,14 +989,14 @@ jobs:
           - id: clang-tidy
             name: Run script/clang-tidy for ESP32 S3
             # yamllint disable-line rule:line-length
-            options: --environment esp32s3-idf-tidy --grep SOC_TEMP_SENSOR_SUPPORTED --grep USE_ESP32_VARIANT_ESP32S3 --grep USE_LOGGER_USB_CDC --grep SOC_I2S_SUPPORTS_TDM
+            options: --environment esp32s3-idf-tidy --grep SOC_TEMP_SENSOR_SUPPORTED --grep USE_ESP32_VARIANT_ESP32S3 --grep USE_LOGGER_USB_CDC
             tidy_environment: esp32s3-idf-tidy
           - id: clang-tidy
             name: Run script/clang-tidy for ESP32 P4
             # P4 has no native Wi-Fi/BLE; those run over the hosted co-processor,
             # so their code paths differ -- lint them under the P4 build too.
             # yamllint disable-line rule:line-length
-            options: --environment esp32p4-idf-tidy --grep USE_ESP32_VARIANT_ESP32P4 --grep CONFIG_IDF_TARGET_ESP32P4 --grep USE_ESP32_HOSTED --grep USE_WIFI --grep USE_BLE
+            options: --environment esp32p4-idf-tidy --grep USE_ESP32_VARIANT_ESP32P4 --grep USE_ESP32_HOSTED --grep USE_WIFI --grep USE_BLE
             tidy_environment: esp32p4-idf-tidy
           - id: clang-tidy
             name: Run script/clang-tidy for ESP32 C6
@@ -1116,8 +1102,8 @@ jobs:
         timeout-minutes: 10
         uses: awalsh128/cache-apt-pkgs-action@553a35bb8ebd9fcabcb1c9451aa4c98e1b4ca8a9 # v1.6.3
         with:
-          packages: libsdl2-dev libmbedtls-dev ccache
-          version: 1.2
+          packages: libsdl2-dev ccache
+          version: 1.1
 
       - name: Check out code from GitHub
         uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1

CODEOWNERS

@@ -183,7 +183,6 @@ esphome/components/es7243e/* @kbx81
 esphome/components/es8156/* @kbx81
 esphome/components/es8311/* @kahrendt @kroimon
 esphome/components/es8388/* @P4uLT
-esphome/components/es9038q2m_katana/* @GioMez
 esphome/components/esp32/* @esphome/core
 esphome/components/esp32_ble/* @bdraco @jesserockz @Rapsssito
 esphome/components/esp32_ble_client/* @bdraco @jesserockz
@@ -220,7 +219,6 @@ esphome/components/friedrich/* @rwrozelle
 esphome/components/fs3000/* @kahrendt
 esphome/components/ft5x06/* @clydebarrow
 esphome/components/ft63x6/* @gpambrozio
-esphome/components/fusb302b/* @remcom
 esphome/components/gcja5/* @gcormier
 esphome/components/gdk101/* @Szewcson
 esphome/components/gl_r01_i2c/* @pkejval
@@ -242,7 +240,6 @@ esphome/components/gt911/* @clydebarrow @jesserockz
 esphome/components/haier/* @paveldn
 esphome/components/haier/binary_sensor/* @paveldn
 esphome/components/haier/button/* @paveldn
-esphome/components/haier/select/* @paveldn
 esphome/components/haier/sensor/* @paveldn
 esphome/components/haier/switch/* @paveldn
 esphome/components/haier/text_sensor/* @paveldn
@@ -388,7 +385,6 @@ esphome/components/microphone/* @jesserockz @kahrendt
 esphome/components/mics_4514/* @jesserockz
 esphome/components/midea/* @dudanov
 esphome/components/midea_ir/* @dudanov
-esphome/components/midea_portasplit/* @Fexiven
 esphome/components/mipi_dsi/* @clydebarrow
 esphome/components/mipi_rgb/* @clydebarrow
 esphome/components/mipi_spi/* @clydebarrow

esphome/components/api/__init__.py

@@ -251,6 +251,9 @@ def _validate_supports_response(value: Any) -> str:
     return cv.enum(SUPPORTS_RESPONSE_OPTIONS, lower=True)(value)
 
 
+# ESP8266 copies every string of an action into a stack buffer sized by codegen; keep it small
+ESP8266_ACTION_STRINGS_MAX_TOTAL = 384
+
 VARIABLE_SCHEMA = cv.Schema(
     {
         cv.Required(CONF_TYPE): cv.one_of(*SERVICE_ARG_NATIVE_TYPES, lower=True),
@@ -481,6 +484,29 @@ def _action_strings(conf: ConfigType, has_metadata: bool) -> list[str | None]:
     return strings
 
 
+def _action_strings_size(strings: list[str | None]) -> int:
+    """Bytes needed to copy every string out of flash, each with its terminator."""
+    return sum(
+        len(string.encode("utf-8")) + 1 for string in strings if string is not None
+    )
+
+
+def _validate_esp8266_action_strings(config: ConfigType) -> ConfigType:
+    if not CORE.is_esp8266:
+        return config
+    actions = config.get(CONF_ACTIONS, [])
+    has_metadata = _has_action_metadata(actions)
+    for conf in actions:
+        size = _action_strings_size(_action_strings(conf, has_metadata))
+        if size > ESP8266_ACTION_STRINGS_MAX_TOTAL:
+            raise cv.Invalid(
+                f"Action '{conf[CONF_ACTION]}' has {size} bytes of name, variable name, "
+                f"description and example text; ESP8266 allows at most "
+                f"{ESP8266_ACTION_STRINGS_MAX_TOTAL} bytes per action"
+            )
+    return config
+
+
 def _validate_outgoing_host_ipv6(config: ConfigType) -> ConfigType:
     """An IPv6 host can never be parsed, so never dialed, without IPv6."""
     if (
@@ -505,6 +531,7 @@ def _validate_wizard(config: ConfigType) -> ConfigType:
 
 
 FINAL_VALIDATE_SCHEMA = cv.All(
+    _validate_esp8266_action_strings,
     _validate_outgoing_host_ipv6,
     _validate_wizard,
 )
@@ -560,6 +587,7 @@ async def to_code(config: ConfigType) -> None:
     if config[CONF_HOMEASSISTANT_STATES]:
         cg.add_define("USE_API_HOMEASSISTANT_STATES")
 
+    scratch_size = 0
     if actions:
         # Metadata is compiled in for every action once any action declares it, because the
         # string table layout is fixed by the define rather than per action
@@ -611,6 +639,8 @@ async def to_code(config: ConfigType) -> None:
                 func_args.append((native, name))
             strings = _action_strings(conf, has_metadata)
             table = _add_action_strings(index, strings)
+            if CORE.is_esp8266:
+                scratch_size = max(scratch_size, _action_strings_size(strings))
             # Template args: supports_response mode, then user service arg types
             templ = cg.TemplateArguments(supports_response, *service_template_args)
             # Key is hashed here because the name is not readable at runtime on ESP8266
@@ -637,6 +667,9 @@ async def to_code(config: ConfigType) -> None:
                 cg.add(auto.add_action(unregister_action))
         # Register all services at once - single allocation, no reallocations
         cg.add(var.initialize_user_services(triggers))
+    if CORE.is_esp8266 and has_user_actions:
+        # Stack buffer that list-entities copies PROGMEM strings into, sized for the largest action
+        cg.add_define("API_USER_ACTION_STRINGS_SCRATCH_SIZE", max(scratch_size, 1))
 
     if (wizard_config := config.get(wizard.CONF_WIZARD)) is not None:
         await wizard.to_code(wizard_config)

esphome/components/api/api.proto

@@ -403,9 +403,6 @@ message WizardCapabilities {
 message SendspinCapabilities {
   // Bitmask of the Sendspin features this device supports
   uint32 feature_flags = 1;
-  // The Sendspin client_id: base64url of the client's static public key, 43 characters.
-  // Empty until the Sendspin client has started once since boot.
-  string client_id = 2 [(max_data_length) = 43];
 }
 
 message DeviceCapabilitiesResponse {
@@ -1029,8 +1026,8 @@ message SubscribeHomeassistantServicesRequest {
 }
 
 message HomeassistantServiceMap {
-  string key = 1 [(progmem) = true];
-  string value = 2 [(progmem) = true];
+  string key = 1;
+  string value = 2;
 }
 
 message HomeassistantActionRequest {
@@ -1039,7 +1036,7 @@ message HomeassistantActionRequest {
   option (no_delay) = true;
   option (ifdef) = "USE_API_HOMEASSISTANT_SERVICES";
 
-  string service = 1 [(progmem) = true];
+  string service = 1;
   repeated HomeassistantServiceMap data = 2 [(fixed_vector) = true];
   repeated HomeassistantServiceMap data_template = 3 [(fixed_vector) = true];
   repeated HomeassistantServiceMap variables = 4 [(fixed_vector) = true];
@@ -1160,21 +1157,21 @@ enum SupportsResponseType {
 }
 message ListEntitiesServicesArgument {
   option (ifdef) = "USE_API_USER_DEFINED_ACTIONS";
-  string name = 1 [(progmem) = true];
+  string name = 1;
   ServiceArgType type = 2;
-  string description = 3 [(field_ifdef) = "USE_API_USER_DEFINED_ACTION_METADATA", (progmem) = true];
-  string example = 4 [(field_ifdef) = "USE_API_USER_DEFINED_ACTION_METADATA", (progmem) = true];
+  string description = 3 [(field_ifdef) = "USE_API_USER_DEFINED_ACTION_METADATA"];
+  string example = 4 [(field_ifdef) = "USE_API_USER_DEFINED_ACTION_METADATA"];
 }
 message ListEntitiesServicesResponse {
   option (id) = 41;
   option (source) = SOURCE_SERVER;
   option (ifdef) = "USE_API_USER_DEFINED_ACTIONS";
 
-  string name = 1 [(progmem) = true];
+  string name = 1;
   fixed32 key = 2 [(force) = true];
   repeated ListEntitiesServicesArgument args = 3 [(fixed_vector) = true];
   SupportsResponseType supports_response = 4;
-  string description = 5 [(field_ifdef) = "USE_API_USER_DEFINED_ACTION_METADATA", (progmem) = true];
+  string description = 5 [(field_ifdef) = "USE_API_USER_DEFINED_ACTION_METADATA"];
 }
 message ExecuteServiceArgument {
   option (ifdef) = "USE_API_USER_DEFINED_ACTIONS";
@@ -3046,15 +3043,12 @@ enum SerialProxyIdentityFlag {
                                              // IDs below are empty
 }
 
-// The descriptor fields of a USB device as seen by the host stack, and the port's index
-// among those a vendor driver exposes on the interface
+// The descriptor fields of a USB device as seen by the host stack
 message UsbDeviceDescriptor {
   uint32 vendor_id = 1;
   uint32 product_id = 2;
   uint32 bcd_device = 3;
-  uint32 interface_number = 4;  // bInterfaceNumber the port is bound through
-  uint32 interface_class = 5;   // bInterfaceClass of that interface
-  uint32 port_number = 6;
+  uint32 interface_number = 4;   // bInterfaceNumber the host driver binds to
 }
 
 // The identity of the device behind a port. Identifies one physical device among others of

esphome/components/api/api_connection.cpp

@@ -1,7 +1,4 @@
 #include "api_connection.h"
-#if defined(USE_LOGGER) && defined(USE_CRASH_HANDLER)
-#include "esphome/components/logger/logger.h"
-#endif
 #ifdef USE_API
 #include "api_connection_buffer.h"  // for the APIServer-dependent APIConnection inlines
 #ifdef USE_API_NOISE
@@ -454,15 +451,6 @@ bool APIConnection::send_disconnect_response_() {
   DisconnectResponse resp;
   return this->send_message(resp);
 }
-void APIConnection::on_subscribe_logs_request(const SubscribeLogsRequest &msg) {
-  this->flags_.log_subscription = msg.level;
-  if (msg.dump_config)
-    App.schedule_dump_config();
-#if defined(USE_LOGGER) && defined(USE_CRASH_HANDLER)
-  logger::log_crash_to_client();
-#endif
-}
-
 void APIConnection::on_disconnect_response() {
   // Don't close socket here, let APIServer::loop() do it
   // so getpeername() still works for the disconnect trigger
@@ -2131,7 +2119,6 @@ bool APIConnection::send_device_capabilities_response_() {
 #endif
 #if defined(USE_SENDSPIN) && defined(USE_ESP_IDF)
   resp.sendspin.feature_flags = sendspin_::global_sendspin_hub->get_feature_flags();
-  resp.sendspin.client_id = sendspin_::global_sendspin_hub->get_client_id();
 #endif
   return this->send_message(resp);
 }

esphome/components/api/api_connection.h

@@ -15,6 +15,15 @@
 #include "subscribe_state.h"
 #include "esphome/core/application.h"
 #include "esphome/core/component.h"
+#ifdef USE_ESP32_CRASH_HANDLER
+#include "esphome/components/esp32/crash_handler.h"
+#endif
+#ifdef USE_RP2_CRASH_HANDLER
+#include "esphome/components/rp2/crash_handler.h"
+#endif
+#ifdef USE_ESP8266_CRASH_HANDLER
+#include "esphome/components/esp8266/crash_handler.h"
+#endif
 #include "esphome/core/entity_base.h"
 #include "esphome/core/log.h"
 #include "esphome/core/string_ref.h"
@@ -289,7 +298,21 @@ class APIConnection final : public APIServerConnectionBase {
       this->begin_iterator_(ActiveIterator::INITIAL_STATE);
     }
   }
-  void on_subscribe_logs_request(const SubscribeLogsRequest &msg);
+  void on_subscribe_logs_request(const SubscribeLogsRequest &msg) {
+    this->flags_.log_subscription = msg.level;
+    if (msg.dump_config)
+      App.schedule_dump_config();
+#ifdef USE_ESP32_CRASH_HANDLER
+    esp32::crash_handler_log();
+    esp32::crash_handler_clear();
+#endif
+#ifdef USE_RP2_CRASH_HANDLER
+    rp2::crash_handler_log();
+#endif
+#ifdef USE_ESP8266_CRASH_HANDLER
+    esp8266::crash_handler_log();
+#endif
+  }
 #ifdef USE_API_HOMEASSISTANT_SERVICES
   void on_subscribe_homeassistant_services_request() { this->flags_.service_call_subscription = true; }
 #endif

esphome/components/api/api_options.proto

@@ -123,7 +123,7 @@ extend google.protobuf.FieldOptions {
     // from an absent one (e.g. a UTC ParsedTimezone, which is all zeros).
     optional bool track_presence = 50020 [default=false];
 
-    // progmem: The string field, or pointer_to_buffer bytes field, points into flash (PROGMEM).
+    // progmem: The pointer_to_buffer bytes field points into flash (PROGMEM).
     // The generated encode and dump copy it with progmem_memcpy, as ESP8266
     // cannot read flash with ordinary loads.
     optional bool progmem = 50021 [default=false];

esphome/components/api/api_pb2.cpp

@@ -310,14 +310,12 @@ uint32_t WizardCapabilities::calc_size_msg(const void *self) {
 uint8_t *SendspinCapabilities::encode_msg(const void *self, uint8_t *__restrict__ pos PROTO_ENCODE_DEBUG_PARAM) {
   const auto &msg = *static_cast<const SendspinCapabilities *>(self);
   pos = ProtoEncode::encode_uint32(pos PROTO_ENCODE_DEBUG_ARG, 1, msg.feature_flags);
-  pos = ProtoEncode::encode_string(pos PROTO_ENCODE_DEBUG_ARG, 2, msg.client_id);
   return pos;
 }
 uint32_t SendspinCapabilities::calc_size_msg(const void *self) {
   const auto &msg = *static_cast<const SendspinCapabilities *>(self);
   uint32_t size = 0;
   size += ProtoSize::calc_uint32(1, msg.feature_flags);
-  size += !msg.client_id.empty() ? 2 + msg.client_id.size() : 0;
   return size;
 }
 #endif
@@ -1142,8 +1140,8 @@ uint32_t NoiseEncryptionSetKeyResponse::calc_size_msg(const void *self) {
 #ifdef USE_API_HOMEASSISTANT_SERVICES
 uint8_t *HomeassistantServiceMap::encode_msg(const void *self, uint8_t *__restrict__ pos PROTO_ENCODE_DEBUG_PARAM) {
   const auto &msg = *static_cast<const HomeassistantServiceMap *>(self);
-  pos = ProtoEncode::encode_progmem_string(pos PROTO_ENCODE_DEBUG_ARG, 1, msg.key);
-  pos = ProtoEncode::encode_progmem_string(pos PROTO_ENCODE_DEBUG_ARG, 2, msg.value);
+  pos = ProtoEncode::encode_string(pos PROTO_ENCODE_DEBUG_ARG, 1, msg.key);
+  pos = ProtoEncode::encode_string(pos PROTO_ENCODE_DEBUG_ARG, 2, msg.value);
   return pos;
 }
 uint32_t HomeassistantServiceMap::calc_size_msg(const void *self) {
@@ -1155,7 +1153,7 @@ uint32_t HomeassistantServiceMap::calc_size_msg(const void *self) {
 }
 uint8_t *HomeassistantActionRequest::encode_msg(const void *self, uint8_t *__restrict__ pos PROTO_ENCODE_DEBUG_PARAM) {
   const auto &msg = *static_cast<const HomeassistantActionRequest *>(self);
-  pos = ProtoEncode::encode_progmem_string(pos PROTO_ENCODE_DEBUG_ARG, 1, msg.service);
+  pos = ProtoEncode::encode_string(pos PROTO_ENCODE_DEBUG_ARG, 1, msg.service);
   for (auto &it : msg.data) {
     pos = ProtoEncode::encode_sub_message(pos PROTO_ENCODE_DEBUG_ARG, 2, it);
   }
@@ -1326,13 +1324,13 @@ void GetTimeResponse::decode_field(void *self, uint32_t tag, const uint8_t *data
 uint8_t *ListEntitiesServicesArgument::encode_msg(const void *self,
                                                   uint8_t *__restrict__ pos PROTO_ENCODE_DEBUG_PARAM) {
   const auto &msg = *static_cast<const ListEntitiesServicesArgument *>(self);
-  pos = ProtoEncode::encode_progmem_string(pos PROTO_ENCODE_DEBUG_ARG, 1, msg.name);
+  pos = ProtoEncode::encode_string(pos PROTO_ENCODE_DEBUG_ARG, 1, msg.name);
   pos = ProtoEncode::encode_uint32(pos PROTO_ENCODE_DEBUG_ARG, 2, static_cast<uint32_t>(msg.type));
 #ifdef USE_API_USER_DEFINED_ACTION_METADATA
-  pos = ProtoEncode::encode_progmem_string(pos PROTO_ENCODE_DEBUG_ARG, 3, msg.description);
+  pos = ProtoEncode::encode_string(pos PROTO_ENCODE_DEBUG_ARG, 3, msg.description);
 #endif
 #ifdef USE_API_USER_DEFINED_ACTION_METADATA
-  pos = ProtoEncode::encode_progmem_string(pos PROTO_ENCODE_DEBUG_ARG, 4, msg.example);
+  pos = ProtoEncode::encode_string(pos PROTO_ENCODE_DEBUG_ARG, 4, msg.example);
 #endif
   return pos;
 }
@@ -1352,14 +1350,14 @@ uint32_t ListEntitiesServicesArgument::calc_size_msg(const void *self) {
 uint8_t *ListEntitiesServicesResponse::encode_msg(const void *self,
                                                   uint8_t *__restrict__ pos PROTO_ENCODE_DEBUG_PARAM) {
   const auto &msg = *static_cast<const ListEntitiesServicesResponse *>(self);
-  pos = ProtoEncode::encode_progmem_string(pos PROTO_ENCODE_DEBUG_ARG, 1, msg.name);
+  pos = ProtoEncode::encode_string(pos PROTO_ENCODE_DEBUG_ARG, 1, msg.name);
   pos = ProtoEncode::write_tag_and_fixed32(pos PROTO_ENCODE_DEBUG_ARG, 21, msg.key);
   for (auto &it : msg.args) {
     pos = ProtoEncode::encode_sub_message(pos PROTO_ENCODE_DEBUG_ARG, 3, it);
   }
   pos = ProtoEncode::encode_uint32(pos PROTO_ENCODE_DEBUG_ARG, 4, static_cast<uint32_t>(msg.supports_response));
 #ifdef USE_API_USER_DEFINED_ACTION_METADATA
-  pos = ProtoEncode::encode_progmem_string(pos PROTO_ENCODE_DEBUG_ARG, 5, msg.description);
+  pos = ProtoEncode::encode_string(pos PROTO_ENCODE_DEBUG_ARG, 5, msg.description);
 #endif
   return pos;
 }
@@ -4177,8 +4175,6 @@ uint8_t *UsbDeviceDescriptor::encode_msg(const void *self, uint8_t *__restrict__
   pos = ProtoEncode::encode_uint32(pos PROTO_ENCODE_DEBUG_ARG, 2, msg.product_id);
   pos = ProtoEncode::encode_uint32(pos PROTO_ENCODE_DEBUG_ARG, 3, msg.bcd_device);
   pos = ProtoEncode::encode_uint32(pos PROTO_ENCODE_DEBUG_ARG, 4, msg.interface_number);
-  pos = ProtoEncode::encode_uint32(pos PROTO_ENCODE_DEBUG_ARG, 5, msg.interface_class);
-  pos = ProtoEncode::encode_uint32(pos PROTO_ENCODE_DEBUG_ARG, 6, msg.port_number);
   return pos;
 }
 uint32_t UsbDeviceDescriptor::calc_size_msg(const void *self) {
@@ -4188,8 +4184,6 @@ uint32_t UsbDeviceDescriptor::calc_size_msg(const void *self) {
   size += ProtoSize::calc_uint32(1, msg.product_id);
   size += ProtoSize::calc_uint32(1, msg.bcd_device);
   size += ProtoSize::calc_uint32(1, msg.interface_number);
-  size += ProtoSize::calc_uint32(1, msg.interface_class);
-  size += ProtoSize::calc_uint32(1, msg.port_number);
   return size;
 }
 uint8_t *SerialProxyIdentity::encode_msg(const void *self, uint8_t *__restrict__ pos PROTO_ENCODE_DEBUG_PARAM) {

esphome/components/api/api_pb2.h

@@ -750,7 +750,6 @@ class WizardCapabilities final : public ProtoMessage {
 class SendspinCapabilities final : public ProtoMessage {
  public:
   uint32_t feature_flags{0};
-  StringRef client_id{nullptr, 0};  // null until set, encode only
   static uint8_t *encode_msg(const void *self, uint8_t *pos PROTO_ENCODE_DEBUG_PARAM);
   uint8_t *encode(ProtoWriteBuffer &buffer PROTO_ENCODE_DEBUG_PARAM) const {
     return encode_msg(this, buffer.get_pos() PROTO_ENCODE_DEBUG_ARG);
@@ -1389,8 +1388,8 @@ class NoiseEncryptionSetKeyResponse final : public ProtoMessage {
 #ifdef USE_API_HOMEASSISTANT_SERVICES
 class HomeassistantServiceMap final : public ProtoMessage {
  public:
-  ProgmemStringRef key{};
-  ProgmemStringRef value{};
+  StringRef key{nullptr, 0};    // null until set, encode only
+  StringRef value{nullptr, 0};  // null until set, encode only
   static uint8_t *encode_msg(const void *self, uint8_t *pos PROTO_ENCODE_DEBUG_PARAM);
   uint8_t *encode(ProtoWriteBuffer &buffer PROTO_ENCODE_DEBUG_PARAM) const {
     return encode_msg(this, buffer.get_pos() PROTO_ENCODE_DEBUG_ARG);
@@ -1410,7 +1409,7 @@ class HomeassistantActionRequest final : public ProtoMessage {
 #ifdef HAS_PROTO_MESSAGE_DUMP
   const LogString *message_name() const override { return LOG_STR("homeassistant_action_request"); }
 #endif
-  ProgmemStringRef service{};
+  StringRef service{nullptr, 0};  // null until set, encode only
   FixedVector<HomeassistantServiceMap> data{};
   FixedVector<HomeassistantServiceMap> data_template{};
   FixedVector<HomeassistantServiceMap> variables{};
@@ -1577,13 +1576,13 @@ class GetTimeResponse final : public ProtoDecodableMessage {
 #ifdef USE_API_USER_DEFINED_ACTIONS
 class ListEntitiesServicesArgument final : public ProtoMessage {
  public:
-  ProgmemStringRef name{};
+  StringRef name{nullptr, 0};  // null until set, encode only
   enums::ServiceArgType type{};
 #ifdef USE_API_USER_DEFINED_ACTION_METADATA
-  ProgmemStringRef description{};
+  StringRef description{nullptr, 0};  // null until set, encode only
 #endif
 #ifdef USE_API_USER_DEFINED_ACTION_METADATA
-  ProgmemStringRef example{};
+  StringRef example{nullptr, 0};  // null until set, encode only
 #endif
   static uint8_t *encode_msg(const void *self, uint8_t *pos PROTO_ENCODE_DEBUG_PARAM);
   uint8_t *encode(ProtoWriteBuffer &buffer PROTO_ENCODE_DEBUG_PARAM) const {
@@ -1604,12 +1603,12 @@ class ListEntitiesServicesResponse final : public ProtoMessage {
 #ifdef HAS_PROTO_MESSAGE_DUMP
   const LogString *message_name() const override { return LOG_STR("list_entities_services_response"); }
 #endif
-  ProgmemStringRef name{};
+  StringRef name{nullptr, 0};  // null until set, encode only
   uint32_t key{0};
   FixedVector<ListEntitiesServicesArgument> args{};
   enums::SupportsResponseType supports_response{};
 #ifdef USE_API_USER_DEFINED_ACTION_METADATA
-  ProgmemStringRef description{};
+  StringRef description{nullptr, 0};  // null until set, encode only
 #endif
   static uint8_t *encode_msg(const void *self, uint8_t *pos PROTO_ENCODE_DEBUG_PARAM);
   uint8_t *encode(ProtoWriteBuffer &buffer PROTO_ENCODE_DEBUG_PARAM) const {
@@ -4084,8 +4083,6 @@ class UsbDeviceDescriptor final : public ProtoMessage {
   uint32_t product_id{0};
   uint32_t bcd_device{0};
   uint32_t interface_number{0};
-  uint32_t interface_class{0};
-  uint32_t port_number{0};
   static uint8_t *encode_msg(const void *self, uint8_t *pos PROTO_ENCODE_DEBUG_PARAM);
   uint8_t *encode(ProtoWriteBuffer &buffer PROTO_ENCODE_DEBUG_PARAM) const {
     return encode_msg(this, buffer.get_pos() PROTO_ENCODE_DEBUG_ARG);

esphome/components/api/api_pb2_dump.cpp

@@ -12,9 +12,8 @@ namespace esphome::api {
 
 #ifdef USE_ESP8266
 // Out-of-line to avoid inlining strlen_P/memcpy_P at every call site
-void DumpBuffer::append_p_esp8266(const char *str) { this->append_p_esp8266(str, strlen_P(str)); }
-
-void DumpBuffer::append_p_esp8266(const char *str, size_t len) {
+void DumpBuffer::append_p_esp8266(const char *str) {
+  size_t len = strlen_P(str);
   size_t space = CAPACITY - 1 - pos_;
   if (len > space)
     len = space;
@@ -135,13 +134,6 @@ static void dump_progmem_bytes_field(DumpBuffer &out, const char *field_name, co
   progmem_memcpy(data_buf, data, len);
   dump_bytes_field(out, field_name, data_buf, len, indent);
 }
-
-// Helper for string fields in flash
-static void dump_progmem_string_field(DumpBuffer &out, const char *field_name, const ProgmemStringRef &value,
-                                      int indent = 2) {
-  append_field_prefix(out, field_name, indent);
-  out.append("'").append_p(value.progmem_ptr(), value.size()).append("'\n");
-}
 #pragma GCC diagnostic pop
 
 template<> const char *proto_enum_to_string<enums::DisconnectReason>(enums::DisconnectReason value) {
@@ -1127,7 +1119,6 @@ const char *WizardCapabilities::dump_to(DumpBuffer &out) const {
 const char *SendspinCapabilities::dump_to(DumpBuffer &out) const {
   MessageDumpHelper helper(out, ESPHOME_PSTR("SendspinCapabilities"));
   dump_field(out, ESPHOME_PSTR("feature_flags"), this->feature_flags);
-  dump_field(out, ESPHOME_PSTR("client_id"), this->client_id);
   return out.c_str();
 }
 #endif
@@ -1520,13 +1511,13 @@ const char *NoiseEncryptionSetKeyResponse::dump_to(DumpBuffer &out) const {
 #ifdef USE_API_HOMEASSISTANT_SERVICES
 const char *HomeassistantServiceMap::dump_to(DumpBuffer &out) const {
   MessageDumpHelper helper(out, ESPHOME_PSTR("HomeassistantServiceMap"));
-  dump_progmem_string_field(out, ESPHOME_PSTR("key"), this->key);
-  dump_progmem_string_field(out, ESPHOME_PSTR("value"), this->value);
+  dump_field(out, ESPHOME_PSTR("key"), this->key);
+  dump_field(out, ESPHOME_PSTR("value"), this->value);
   return out.c_str();
 }
 const char *HomeassistantActionRequest::dump_to(DumpBuffer &out) const {
   MessageDumpHelper helper(out, ESPHOME_PSTR("HomeassistantActionRequest"));
-  dump_progmem_string_field(out, ESPHOME_PSTR("service"), this->service);
+  dump_field(out, ESPHOME_PSTR("service"), this->service);
   for (const auto &it : this->data) {
     out.append(4, ' ').append_p(ESPHOME_PSTR("data")).append(": ");
     it.dump_to(out);
@@ -1621,19 +1612,19 @@ const char *GetTimeResponse::dump_to(DumpBuffer &out) const {
 #ifdef USE_API_USER_DEFINED_ACTIONS
 const char *ListEntitiesServicesArgument::dump_to(DumpBuffer &out) const {
   MessageDumpHelper helper(out, ESPHOME_PSTR("ListEntitiesServicesArgument"));
-  dump_progmem_string_field(out, ESPHOME_PSTR("name"), this->name);
+  dump_field(out, ESPHOME_PSTR("name"), this->name);
   dump_field(out, ESPHOME_PSTR("type"), static_cast<enums::ServiceArgType>(this->type));
 #ifdef USE_API_USER_DEFINED_ACTION_METADATA
-  dump_progmem_string_field(out, ESPHOME_PSTR("description"), this->description);
+  dump_field(out, ESPHOME_PSTR("description"), this->description);
 #endif
 #ifdef USE_API_USER_DEFINED_ACTION_METADATA
-  dump_progmem_string_field(out, ESPHOME_PSTR("example"), this->example);
+  dump_field(out, ESPHOME_PSTR("example"), this->example);
 #endif
   return out.c_str();
 }
 const char *ListEntitiesServicesResponse::dump_to(DumpBuffer &out) const {
   MessageDumpHelper helper(out, ESPHOME_PSTR("ListEntitiesServicesResponse"));
-  dump_progmem_string_field(out, ESPHOME_PSTR("name"), this->name);
+  dump_field(out, ESPHOME_PSTR("name"), this->name);
   dump_field(out, ESPHOME_PSTR("key"), this->key);
   for (const auto &it : this->args) {
     out.append(4, ' ').append_p(ESPHOME_PSTR("args")).append(": ");
@@ -1642,7 +1633,7 @@ const char *ListEntitiesServicesResponse::dump_to(DumpBuffer &out) const {
   }
   dump_field(out, ESPHOME_PSTR("supports_response"), static_cast<enums::SupportsResponseType>(this->supports_response));
 #ifdef USE_API_USER_DEFINED_ACTION_METADATA
-  dump_progmem_string_field(out, ESPHOME_PSTR("description"), this->description);
+  dump_field(out, ESPHOME_PSTR("description"), this->description);
 #endif
   return out.c_str();
 }
@@ -2951,8 +2942,6 @@ const char *UsbDeviceDescriptor::dump_to(DumpBuffer &out) const {
   dump_field(out, ESPHOME_PSTR("product_id"), this->product_id);
   dump_field(out, ESPHOME_PSTR("bcd_device"), this->bcd_device);
   dump_field(out, ESPHOME_PSTR("interface_number"), this->interface_number);
-  dump_field(out, ESPHOME_PSTR("interface_class"), this->interface_class);
-  dump_field(out, ESPHOME_PSTR("port_number"), this->port_number);
   return out.c_str();
 }
 const char *SerialProxyIdentity::dump_to(DumpBuffer &out) const {

esphome/components/api/api_server.cpp

@@ -547,7 +547,7 @@ void APIServer::send_homeassistant_action(const HomeassistantActionRequest &call
     // arrive before the subscription and are lost - warn instead of failing silently.
     ESP_LOGW(TAG, "Home Assistant %s '%.*s' dropped; %s",
              call.is_event ? LOG_STR_LITERAL("event") : LOG_STR_LITERAL("action"),
-             static_cast<int>(call.service.size()), call.service.empty() ? "" : call.service.progmem_ptr(),
+             static_cast<int>(call.service.size()), call.service.empty() ? "" : call.service.c_str(),
              this->is_connected() ? LOG_STR_LITERAL("client has not subscribed to actions (yet)")
                                   : LOG_STR_LITERAL("no client connected"));
   }

esphome/components/api/custom_api_device.h

@@ -247,7 +247,7 @@ class CustomAPIDevice {
    */
   void call_homeassistant_service(const std::string &service_name) {
     HomeassistantActionRequest resp;
-    resp.service = ProgmemStringRef(StringRef(service_name));
+    resp.service = StringRef(service_name);
     global_api_server->send_homeassistant_action(resp);
   }
 
@@ -267,12 +267,12 @@ class CustomAPIDevice {
    */
   void call_homeassistant_service(const std::string &service_name, const std::map<std::string, std::string> &data) {
     HomeassistantActionRequest resp;
-    resp.service = ProgmemStringRef(StringRef(service_name));
+    resp.service = StringRef(service_name);
     resp.data.init(data.size());
     for (auto &it : data) {
       auto &kv = resp.data.emplace_back();
-      kv.key = ProgmemStringRef(StringRef(it.first));
-      kv.value = ProgmemStringRef(StringRef(it.second));  // data map lives until send completes
+      kv.key = StringRef(it.first);
+      kv.value = StringRef(it.second);  // data map lives until send completes
     }
     global_api_server->send_homeassistant_action(resp);
   }
@@ -289,7 +289,7 @@ class CustomAPIDevice {
    */
   void fire_homeassistant_event(const std::string &event_name) {
     HomeassistantActionRequest resp;
-    resp.service = ProgmemStringRef(StringRef(event_name));
+    resp.service = StringRef(event_name);
     resp.is_event = true;
     global_api_server->send_homeassistant_action(resp);
   }
@@ -309,13 +309,13 @@ class CustomAPIDevice {
    */
   void fire_homeassistant_event(const std::string &service_name, const std::map<std::string, std::string> &data) {
     HomeassistantActionRequest resp;
-    resp.service = ProgmemStringRef(StringRef(service_name));
+    resp.service = StringRef(service_name);
     resp.is_event = true;
     resp.data.init(data.size());
     for (auto &it : data) {
       auto &kv = resp.data.emplace_back();
-      kv.key = ProgmemStringRef(StringRef(it.first));
-      kv.value = ProgmemStringRef(StringRef(it.second));  // data map lives until send completes
+      kv.key = StringRef(it.first);
+      kv.value = StringRef(it.second);  // data map lives until send completes
     }
     global_api_server->send_homeassistant_action(resp);
   }

esphome/components/api/homeassistant_service.h

@@ -116,18 +116,42 @@ template<typename... Ts> class HomeAssistantServiceCallAction final : public Act
     const Field *fields = this->fields_;
     const size_t total = 1 + this->data_count_ + this->data_template_count_ + this->variables_count_;
 
-    // Lambda results must live until the send; the constant strings are encoded from flash where they are
+    // Lambda results, and on ESP8266 the RAM copies of the flash strings, must live until the send
     size_t lambda_count = 0;
-    for (size_t i = 0; i < total; i++)
+#ifdef USE_ESP8266
+    size_t flash_len = 0;
+#endif
+    for (size_t i = 0; i < total; i++) {
       lambda_count += fields[i].fn != nullptr;
+#ifdef USE_ESP8266
+      if (fields[i].fn == nullptr)
+        flash_len += ESPHOME_strlen_P(fields[i].value);
+      if (fields[i].key != nullptr)
+        flash_len += ESPHOME_strlen_P(fields[i].key);
+#endif
+    }
     FixedVector<std::string> results;
     results.init(lambda_count);
-    auto string_ref = [](const char *str) { return ProgmemStringRef(str, ESPHOME_strlen_P(str)); };
+#ifdef USE_ESP8266
+    SmallBufferWithHeapFallback<128, char> flash_copy(flash_len);
+    char *cursor = flash_copy.get();
+#endif
+    auto string_ref = [&](const char *str) {
+#ifdef USE_ESP8266
+      size_t len = ESPHOME_strlen_P(str);
+      memcpy_P(cursor, str, len);
+      StringRef ref(cursor, len);
+      cursor += len;
+      return ref;
+#else
+      return StringRef(str);
+#endif
+    };
     auto value_ref = [&](const Field &field) {
       if (field.fn == nullptr)
         return string_ref(field.value);
       results.push_back(field.fn(x...));
-      return ProgmemStringRef(StringRef(results.back()));
+      return StringRef(results.back());
     };
     auto fill = [&](FixedVector<HomeassistantServiceMap> &dest, uint8_t count) {
       dest.init(count);

esphome/components/api/list_entities.cpp

@@ -99,7 +99,8 @@ ListEntitiesIterator::ListEntitiesIterator(APIConnection *client) : client_(clie
 static constexpr uint8_t SERVICE_YIELD_INTERVAL = 3;
 
 bool ListEntitiesIterator::on_service(UserServiceDescriptor *service) {
-  auto resp = service->encode_list_service_response();
+  UserActionScratch scratch;
+  auto resp = service->encode_list_service_response(scratch);
   if (!this->client_->send_message(resp))
     return false;
   // at_ is this service's index

esphome/components/api/proto.h

@@ -418,18 +418,6 @@ class ProtoEncode {
     std::memcpy(pos + 2, ref.c_str(), ref.size());
     return pos + 2 + ref.size();
   }
-  /// encode_short_string_force for a string that may be in flash (PROGMEM).
-  [[nodiscard]] static inline uint8_t *encode_short_progmem_string_force(
-      uint8_t *__restrict__ pos PROTO_ENCODE_DEBUG_PARAM, uint8_t tag, const ProgmemStringRef &ref) {
-#ifdef ESPHOME_DEBUG_API
-    assert(ref.size() < 128 && "encode_short_progmem_string_force: string exceeds max_data_length < 128");
-#endif
-    PROTO_ENCODE_CHECK_BOUNDS(pos, 2 + ref.size());
-    pos[0] = tag;
-    pos[1] = static_cast<uint8_t>(ref.size());
-    progmem_memcpy(pos + 2, ref.progmem_ptr(), ref.size());
-    return pos + 2 + ref.size();
-  }
   /// Write a precomputed tag byte + 32-bit value. Outlined on embedded: one copy beats inline stores per field.
   [[nodiscard]] static PROTO_OUTLINE_FOR_SIZE uint8_t *write_tag_and_fixed32(
       uint8_t *__restrict__ pos PROTO_ENCODE_DEBUG_PARAM, uint8_t tag, uint32_t value) {
@@ -493,17 +481,6 @@ class ProtoEncode {
     progmem_memcpy(pos, data, len);
     return pos + len;
   }
-  /// encode_progmem_bytes for a string field that may be in flash.
-  [[nodiscard]] static inline uint8_t *encode_progmem_string(uint8_t *__restrict__ pos PROTO_ENCODE_DEBUG_PARAM,
-                                                             uint32_t field_id, const ProgmemStringRef &ref) {
-    return encode_progmem_bytes(pos PROTO_ENCODE_DEBUG_ARG, field_id,
-                                reinterpret_cast<const uint8_t *>(ref.progmem_ptr()), ref.size());
-  }
-  [[nodiscard]] static inline uint8_t *encode_progmem_string_force(uint8_t *__restrict__ pos PROTO_ENCODE_DEBUG_PARAM,
-                                                                   uint32_t field_id, const ProgmemStringRef &ref) {
-    return encode_progmem_bytes_force(pos PROTO_ENCODE_DEBUG_ARG, field_id,
-                                      reinterpret_cast<const uint8_t *>(ref.progmem_ptr()), ref.size());
-  }
   [[nodiscard]] static inline uint8_t *encode_uint32_force(uint8_t *__restrict__ pos PROTO_ENCODE_DEBUG_PARAM,
                                                            uint32_t field_id, uint32_t value) {
     pos = encode_field_raw(pos PROTO_ENCODE_DEBUG_ARG, field_id, 0);
@@ -703,20 +680,9 @@ class DumpBuffer {
     return *this;
   }
 
-  /// Append len bytes of a PROGMEM string
-  DumpBuffer &append_p(const char *str, size_t len) {
-#ifdef USE_ESP8266
-    append_p_esp8266(str, len);
-#else
-    append_impl_(str, len);
-#endif
-    return *this;
-  }
-
 #ifdef USE_ESP8266
   /// Out-of-line ESP8266 PROGMEM append to avoid inlining strlen_P/memcpy_P at every call site
   void append_p_esp8266(const char *str);
-  void append_p_esp8266(const char *str, size_t len);
 #endif
 
   const char *c_str() const { return buf_; }

esphome/components/api/user_services.cpp

@@ -1,36 +1,47 @@
 #include "user_services.h"
 #include "esphome/core/hal.h"
 #include "esphome/core/log.h"
-#include "esphome/core/progmem.h"
 #include "esphome/core/string_ref.h"
 
 namespace esphome::api {
 
-ProgmemStringRef UserServiceStatic::str_(size_t idx) const {
+StringRef UserServiceStatic::str_(size_t idx, std::span<char> &scratch) const {
   const char *s = progmem_read_ptr(&this->strings_[idx]);
   if (s == nullptr)
     return {};
-  return ProgmemStringRef(s, ESPHOME_strlen_P(s));
+#ifdef USE_ESP8266
+  // Codegen sizes the scratch buffer for the largest service; the bound only guards other callers
+  if (scratch.empty())
+    return {};
+  size_t len = strnlen_P(s, scratch.size() - 1);
+  progmem_memcpy(scratch.data(), s, len);
+  scratch[len] = '\0';
+  StringRef ref(scratch.data(), len);
+  scratch = scratch.subspan(len + 1);
+  return ref;
+#else
+  return StringRef(s);
+#endif
 }
 
 ListEntitiesServicesResponse UserServiceStatic::encode_list_service_response_(
-    std::span<const enums::ServiceArgType> arg_types) const {
+    std::span<const enums::ServiceArgType> arg_types, std::span<char> scratch) const {
   ListEntitiesServicesResponse msg;
-  msg.name = this->str_(0);
+  msg.name = this->str_(0, scratch);
   msg.key = this->key_;
   msg.supports_response = this->supports_response_;
 #ifdef USE_API_USER_DEFINED_ACTION_METADATA
-  msg.description = this->str_(1);
+  msg.description = this->str_(1, scratch);
 #endif
   msg.args.init(arg_types.size());
   for (size_t i = 0; i < arg_types.size(); i++) {
     size_t base = USER_ACTION_HEADER_STRINGS + i * USER_ACTION_ARG_STRINGS;
     auto &arg = msg.args.emplace_back();
     arg.type = arg_types[i];
-    arg.name = this->str_(base);
+    arg.name = this->str_(base, scratch);
 #ifdef USE_API_USER_DEFINED_ACTION_METADATA
-    arg.description = this->str_(base + 1);
-    arg.example = this->str_(base + 2);
+    arg.description = this->str_(base + 1, scratch);
+    arg.example = this->str_(base + 2, scratch);
 #endif
   }
   return msg;

esphome/components/api/user_services.h

@@ -20,8 +20,9 @@ class APIServer;
 
 class UserServiceDescriptor {
  public:
-  /// Build the list-entities message; its strings may point into flash (PROGMEM).
-  virtual ListEntitiesServicesResponse encode_list_service_response() = 0;
+  /// Build the list-entities message. On ESP8266 the strings live in PROGMEM and are copied into
+  /// `scratch`, so the returned message is only valid while `scratch` is; other platforms ignore it.
+  virtual ListEntitiesServicesResponse encode_list_service_response(std::span<char> scratch) = 0;
 
   virtual bool execute_service(const ExecuteServiceRequest &req) = 0;
 #ifdef USE_API_USER_DEFINED_ACTION_RESPONSES
@@ -36,6 +37,13 @@ template<typename T> T get_execute_arg_value(const ExecuteServiceArgument &arg);
 
 template<typename T> enums::ServiceArgType to_service_arg_type();
 
+// Scratch buffer list-entities hands to encode_list_service_response(); only ESP8266 copies into it
+#ifdef USE_ESP8266
+using UserActionScratch = std::array<char, API_USER_ACTION_STRINGS_SCRATCH_SIZE>;
+#else
+using UserActionScratch = std::array<char, 0>;
+#endif
+
 // Non-template base for YAML-defined services so the list-entities encoder is compiled once.
 // All strings live in one PROGMEM pointer table emitted by codegen (see _action_strings in
 // __init__.py), so each service costs a single pointer of RAM. Layout: the action name, then
@@ -55,9 +63,12 @@ class UserServiceStatic : public UserServiceDescriptor {
       : strings_(strings), key_(key), supports_response_(supports_response) {}
 
  protected:
-  ListEntitiesServicesResponse encode_list_service_response_(std::span<const enums::ServiceArgType> arg_types) const;
-  /// Table entry `idx` as it sits in flash; nullptr gives an empty string.
-  ProgmemStringRef str_(size_t idx) const;
+  ListEntitiesServicesResponse encode_list_service_response_(std::span<const enums::ServiceArgType> arg_types,
+                                                             std::span<char> scratch) const;
+  /// Reference table entry `idx`; nullptr gives an empty StringRef.
+  /// On ESP8266 the bytes are copied out of PROGMEM into `scratch` with a terminator, and the span
+  /// is advanced past the copy.
+  StringRef str_(size_t idx, std::span<char> &scratch) const;
 
   const char *const *strings_;  // PROGMEM pointer table, read with progmem_read_ptr()
   uint32_t key_;
@@ -68,9 +79,9 @@ template<typename... Ts> class UserServiceBase : public UserServiceStatic {
  public:
   using UserServiceStatic::UserServiceStatic;
 
-  ListEntitiesServicesResponse encode_list_service_response() override {
+  ListEntitiesServicesResponse encode_list_service_response(std::span<char> scratch) override {
     std::array<enums::ServiceArgType, sizeof...(Ts)> arg_types = {to_service_arg_type<Ts>()...};
-    return this->encode_list_service_response_(arg_types);
+    return this->encode_list_service_response_(arg_types, scratch);
   }
 
   bool execute_service(const ExecuteServiceRequest &req) override {
@@ -114,9 +125,9 @@ template<typename... Ts> class UserServiceDynamic : public UserServiceDescriptor
     this->key_ = fnv1_hash(this->name_.c_str());
   }
 
-  ListEntitiesServicesResponse encode_list_service_response() override {
+  ListEntitiesServicesResponse encode_list_service_response(std::span<char> /*scratch*/) override {
     ListEntitiesServicesResponse msg;
-    msg.name = ProgmemStringRef(StringRef(this->name_));
+    msg.name = StringRef(this->name_);
     msg.key = this->key_;
     msg.supports_response = enums::SUPPORTS_RESPONSE_NONE;  // Dynamic services don't support responses yet
     std::array<enums::ServiceArgType, sizeof...(Ts)> arg_types = {to_service_arg_type<Ts>()...};
@@ -124,7 +135,7 @@ template<typename... Ts> class UserServiceDynamic : public UserServiceDescriptor
     for (size_t i = 0; i < sizeof...(Ts); i++) {
       auto &arg = msg.args.emplace_back();
       arg.type = arg_types[i];
-      arg.name = ProgmemStringRef(StringRef(this->arg_names_[i]));
+      arg.name = StringRef(this->arg_names_[i]);
     }
     return msg;
   }

esphome/components/audio/__init__.py

@@ -338,7 +338,7 @@ async def to_code(config: ConfigType) -> None:
     # HTTPS streams verify the server against the root certificate bundle
     require_certificate_bundle()
 
-    add_idf_component(name="esphome/esp-audio-libs", ref="4.1.0")
+    add_idf_component(name="esphome/esp-audio-libs", ref="4.0.1")
 
     data = _get_data()
 

esphome/components/bluetooth_connection/bluetooth_connection_bluedroid.cpp

@@ -382,7 +382,7 @@ void BluedroidGattClient::set_disconnecting_() {
 
 esp_err_t BluedroidGattClient::update_conn_params_(uint16_t min_interval, uint16_t max_interval, uint16_t latency,
                                                    uint16_t timeout, const char *param_type) {
-  esp_ble_conn_update_params_t conn_params = {};
+  esp_ble_conn_update_params_t conn_params = {{0}};
   memcpy(conn_params.bda, this->remote_bda_, sizeof(esp_bd_addr_t));
   conn_params.min_int = min_interval;
   conn_params.max_int = max_interval;

esphome/components/bm8563/bm8563.cpp

@@ -100,8 +100,7 @@ void BM8563::get_date_(ESPTime &time) {
   this->read_register(DATE_FIRST_REG, buf, sizeof(buf));
 
   time.day_of_month = this->bcd2_to_byte_(buf[0] & 0x3f);
-  // The chip counts weekdays 0-6 from Sunday (not BCD), ESPTime counts 1-7
-  time.day_of_week = (buf[1] & 0x07) + 1;
+  time.day_of_week = this->bcd2_to_byte_(buf[1] & 0x07);
   time.month = this->bcd2_to_byte_(buf[2] & 0x1f);
 
   uint8_t year_byte = this->bcd2_to_byte_(buf[3] & 0xff);
@@ -116,7 +115,7 @@ void BM8563::get_date_(ESPTime &time) {
 void BM8563::set_date_(const ESPTime &time) {
   uint8_t buf[4] = {
       this->byte_to_bcd2_(time.day_of_month),
-      static_cast<uint8_t>(time.day_of_week - 1),
+      this->byte_to_bcd2_(time.day_of_week),
       this->byte_to_bcd2_(time.month),
       this->byte_to_bcd2_(time.year % 100),
   };

esphome/components/cse7766/cse7766.cpp

@@ -8,9 +8,6 @@ namespace esphome::cse7766 {
 
 ESPHOME_LOG_TAG(TAG, "cse7766");
 
-// The chip only sends the time since the last pulse once a cycle is longer than 1 s (in us)
-static constexpr uint32_t MIN_HELD_POWER_CYCLE = 1000000;
-
 void CSE7766Component::loop() {
   const uint32_t now = App.get_loop_component_start_time();
   if (now - this->last_transmission_ >= 500) {
@@ -157,33 +154,18 @@ void CSE7766Component::parse_data_() {
   if (power_cycle_exceeds_range) {
     // Datasheet: power cycle exceeding range means active power is 0
     have_power = true;
-    this->last_power_cycle_ = 0;
     if (this->power_sensor_ != nullptr) {
       this->power_sensor_->publish_state(0.0f);
     }
   } else if (have_power) {
     power = power_coeff / float(power_cycle);
-    this->last_power_cycle_ = power_cycle;
     if (this->power_sensor_ != nullptr) {
       this->power_sensor_->publish_state(power);
     }
-  } else if (this->last_power_cycle_ > MIN_HELD_POWER_CYCLE && power_cycle <= 2 * this->last_power_cycle_) {
-    // No new measurement in this frame. With cycles over 1 s the register holds the last
-    // cycle or the time elapsed since the last pulse. While that time is within twice the
-    // last cycle, the next pulse is not overdue, so the last measurement still applies.
-    // Shorter cycles never get here in normal operation and keep the previous behaviour.
-    have_power = true;
-    power = power_coeff / float(this->last_power_cycle_);
-    if (this->power_sensor_ != nullptr) {
-      this->power_sensor_->publish_state(power);
-    }
-  } else {
-    // The next pulse is overdue: the load has dropped, report 0 W. A load that drops to less
-    // than half also reads 0 W here until its first new pulse arrives.
-    this->last_power_cycle_ = 0;
-    if (this->power_sensor_ != nullptr) {
-      this->power_sensor_->publish_state(0.0f);
-    }
+  } else if (this->power_sensor_ != nullptr) {
+    // No valid power measurement from chip - publish 0W to avoid stale readings
+    // This typically happens when current is below the measurable threshold (~50mA)
+    this->power_sensor_->publish_state(0.0f);
   }
 
   float current = 0.0f;

esphome/components/cse7766/cse7766.h

@@ -36,7 +36,6 @@ class CSE7766Component final : public Component, public uart::UARTDevice {
 
   uint8_t raw_data_[CSE7766_RAW_DATA_SIZE];
   uint8_t raw_data_index_{0};
-  uint16_t cf_pulses_last_{0};
   uint32_t last_transmission_{0};
   sensor::Sensor *voltage_sensor_{nullptr};
   sensor::Sensor *current_sensor_{nullptr};
@@ -46,8 +45,7 @@ class CSE7766Component final : public Component, public uart::UARTDevice {
   sensor::Sensor *reactive_power_sensor_{nullptr};
   sensor::Sensor *power_factor_sensor_{nullptr};
   uint32_t cf_pulses_total_{0};
-  // Power cycle of the last frame that carried a new power measurement, 0 if none
-  uint32_t last_power_cycle_{0};
+  uint16_t cf_pulses_last_{0};
 };
 
 }  // namespace esphome::cse7766

esphome/components/display/__init__.py

@@ -250,42 +250,6 @@ def add_metadata(
     )
 
 
-KEY_EXTERNAL_WRITERS = "external_writers"
-
-
-def _get_external_writer_list() -> list[tuple[ID, str]]:
-    """Get the raw external writer list. Each entry is (display id, owner)."""
-    return CORE.data.setdefault(DOMAIN, {}).setdefault(KEY_EXTERNAL_WRITERS, [])
-
-
-def register_external_writer(display_id: ID, owner: str) -> None:
-    """Declare that ``owner`` draws into the display from outside its lambda or pages.
-
-    Call from the owner's CONFIG_SCHEMA. The ID may still be unresolved; the ID pass
-    resolves it in place before final validation.
-    """
-    _get_external_writer_list().append((display_id, owner))
-
-
-def get_external_writers(display_id: ID) -> list[str]:
-    """Get the owners registered for a display. Only valid once IDs are resolved."""
-    return [
-        owner
-        for id_, owner in _get_external_writer_list()
-        if id_.id is not None and id_.id == display_id.id
-    ]
-
-
-def has_external_writer(display_id: ID) -> bool:
-    """Tell a driver's final validation that something else draws into the display.
-
-    LVGL anywhere in the config also counts, as the drivers assumed before.
-    """
-    from esphome.components.lvgl import DOMAIN as LVGL_DOMAIN
-
-    return LVGL_DOMAIN in full_config.get() or bool(get_external_writers(display_id))
-
-
 async def register_display(var, config):
     await cg.register_component(var, config)
     await setup_display_core_(var, config)

esphome/components/ecocomfort2/ecocomfort2_fan.cpp

@@ -118,8 +118,13 @@ void Ecocomfort2Fan::on_status() {
 
   int new_speed = this->speed;
   uint8_t base_speed = raw_speed & SPEED_MASK;
-  if (base_speed >= SPEED_SLEEP && base_speed <= SPEED_VEL3)
+  if (raw_speed & FLAG_BOOST) {
+    new_speed = SPEED_COUNT;
+  } else if (raw_speed & FLAG_NIGHT) {
+    new_speed = SPEED_SLEEP;
+  } else if (base_speed >= SPEED_SLEEP && base_speed <= SPEED_VEL3) {
     new_speed = base_speed;
+  }
   const Preset *preset = find_preset(mode, (raw_speed & FLAG_AUTO) != 0);
   const char *new_preset = preset != nullptr ? preset->name : nullptr;
   bool same_preset = new_preset == nullptr ? !this->has_preset_mode() : this->get_preset_mode().c_str() == new_preset;

esphome/components/ecocomfort2/ecocomfort2_hub.cpp

@@ -205,10 +205,6 @@ void Ecocomfort2Hub::publish_unknown_() {
       sensor->publish_state(NAN);
   }
 #endif
-#ifdef USE_BINARY_SENSOR
-  if (this->boost_binary_sensor_ != nullptr)
-    this->boost_binary_sensor_->invalidate_state();
-#endif
 }
 
 // C_OPER: mode byte, speed/flags byte
@@ -220,6 +216,10 @@ void Ecocomfort2Hub::on_oper_(const uint8_t *data, uint16_t len) {
   this->mode_ = data[0];
   this->speed_ = data[1];
   ESP_LOGD(TAG, "[%s] C_OPER: mode=0x%02x, speed=0x%02x", this->parent_->address_str(), this->mode_, this->speed_);
+#ifdef USE_BINARY_SENSOR
+  if (this->boost_binary_sensor_ != nullptr)
+    this->boost_binary_sensor_->publish_state((this->speed_ & FLAG_BOOST) != 0);
+#endif
 #ifdef ECOCOMFORT2_CHILD_COUNT
   for (auto *child : this->children_) {
     child->on_status();
@@ -227,9 +227,7 @@ void Ecocomfort2Hub::on_oper_(const uint8_t *data, uint16_t len) {
 #endif
 }
 
-// C_STATE: bytes 0-1 the mode and speed the unit runs; byte 1 also has the boost flag (0x40) and the advanced
-// control step (0x20). Byte 2 the air flow direction, bytes 3-4 temperature and 5-6 humidity in hundredths,
-// 7-8 VOC in ppb
+// C_STATE: bytes 3-4 temperature and 5-6 humidity in hundredths, 7-8 VOC in ppb, byte 2 the air flow direction
 void Ecocomfort2Hub::on_state_(const uint8_t *data, uint16_t len) {
   if (len < 9) {
     ESP_LOGW(TAG, "[%s] C_STATE too short: %u bytes", this->parent_->address_str(), len);
@@ -238,12 +236,8 @@ void Ecocomfort2Hub::on_state_(const uint8_t *data, uint16_t len) {
   const float temperature = static_cast<int16_t>(encode_uint16(data[3], data[4])) / 100.0f;
   const float humidity = encode_uint16(data[5], data[6]) / 100.0f;
   const uint16_t voc = encode_uint16(data[7], data[8]);
-  ESP_LOGD(TAG, "[%s] C_STATE: mode=0x%02x, speed=0x%02x, %.2f °C, %.2f %%, %u ppb, direction=%u",
-           this->parent_->address_str(), data[0], data[1], temperature, humidity, voc, data[2]);
-#ifdef USE_BINARY_SENSOR
-  if (this->boost_binary_sensor_ != nullptr)
-    this->boost_binary_sensor_->publish_state((data[1] & FLAG_BOOST) != 0);
-#endif
+  ESP_LOGD(TAG, "[%s] C_STATE: %.2f °C, %.2f %%, %u ppb, direction=%u", this->parent_->address_str(), temperature,
+           humidity, voc, data[2]);
 #ifdef USE_SENSOR
   if (this->temperature_sensor_ != nullptr)
     this->temperature_sensor_->publish_state(temperature);
@@ -273,7 +267,7 @@ void Ecocomfort2Hub::on_info_(const uint8_t *data, uint16_t len) {
 }
 
 #ifdef USE_TIME
-// C_CLOCK: two-digit year, month, day, weekday with Monday as 0, hour, minute, second, automatic DST flag
+// C_CLOCK: hour, minute, second, weekday with Monday as 0, day, month, year as two bytes
 void Ecocomfort2Hub::sync_clock_() {
   if (!this->is_ready() || this->char_handle_clock_ == 0)
     return;
@@ -282,11 +276,15 @@ void Ecocomfort2Hub::sync_clock_() {
     return;
   // ESPTime counts Sunday=1 .. Saturday=7, the unit Monday=0 .. Sunday=6
   const uint8_t weekday = (now.day_of_week + 5) % 7;
-  // The time source already applies DST and every sync rewrites the clock, so the unit must not shift it again
-  uint8_t data[8]{
-      static_cast<uint8_t>(now.year % 100), now.month, now.day_of_month, weekday, now.hour, now.minute, now.second, 0};
-  ESP_LOGD(TAG, "[%s] Syncing clock to %04u-%02u-%02u %02u:%02u:%02u", this->parent_->address_str(), now.year,
-           now.month, now.day_of_month, now.hour, now.minute, now.second);
+  uint8_t data[8]{now.hour,
+                  now.minute,
+                  now.second,
+                  weekday,
+                  now.day_of_month,
+                  now.month,
+                  static_cast<uint8_t>(now.year >> 8),
+                  static_cast<uint8_t>(now.year)};
+  ESP_LOGD(TAG, "[%s] Syncing clock to %02u:%02u:%02u", this->parent_->address_str(), now.hour, now.minute, now.second);
   auto status =
       esp_ble_gattc_write_char(this->parent_->get_gattc_if(), this->parent_->get_conn_id(), this->char_handle_clock_,
                                sizeof(data), data, ESP_GATT_WRITE_TYPE_NO_RSP, ESP_GATT_AUTH_REQ_NONE);

esphome/components/ecocomfort2/ecocomfort2_hub.h

@@ -32,8 +32,7 @@ static constexpr uint8_t OPER_OUT = 0x02;
 static constexpr uint8_t OPER_IN_OUT = 0x03;
 static constexpr uint8_t OPER_SENSOR_OR_AUTO = 0x04;
 
-// Speed byte: speed in the low nibble, flags in the high nibble.
-// C_OPER carries FLAG_AUTO; the unit reports FLAG_BOOST in byte 1 of C_STATE.
+// C_OPER byte 1: speed in the low nibble, flags in the high nibble
 static constexpr uint8_t SPEED_OFF = 0x00;
 static constexpr uint8_t SPEED_SLEEP = 0x01;
 static constexpr uint8_t SPEED_VEL1 = 0x02;
@@ -42,6 +41,7 @@ static constexpr uint8_t SPEED_VEL3 = 0x04;
 static constexpr uint8_t SPEED_MASK = 0x0F;
 static constexpr uint8_t FLAG_AUTO = 0x10;
 static constexpr uint8_t FLAG_BOOST = 0x40;
+static constexpr uint8_t FLAG_NIGHT = 0x80;
 
 /** Hub component for Ecocomfort 2.0 VMC via BLE. */
 class Ecocomfort2Hub : public esphome::ble_client::BLEClientNode, public PollingComponent {

esphome/components/epaper_spi/display.py

@@ -40,6 +40,7 @@ from esphome.const import (
     CONF_WIDTH,
 )
 from esphome.cpp_generator import RawExpression
+from esphome.final_validate import full_config
 
 from . import models
 
@@ -197,11 +198,15 @@ def _final_validate(config) -> None:
         "epaper_spi", require_miso=False, require_mosi=True
     )(config)
 
+    global_config = full_config.get()
+    from esphome.components.lvgl import DOMAIN as LVGL_DOMAIN
+
     if CONF_LAMBDA not in config and CONF_PAGES not in config:
-        if display.has_external_writer(config[CONF_ID]):
+        if LVGL_DOMAIN in global_config:
             if CONF_UPDATE_INTERVAL not in config:
                 config[CONF_UPDATE_INTERVAL] = update_interval("never")
         else:
+            # If no drawing methods are configured, and LVGL is not enabled, show a test card
             config[CONF_SHOW_TEST_CARD] = True
     elif CONF_UPDATE_INTERVAL not in config:
         config[CONF_UPDATE_INTERVAL] = update_interval("1min")

esphome/components/es9038q2m_katana/__init__.py

@@ -1,3 +0,0 @@
-CODEOWNERS = ["@GioMez"]
-DEPENDENCIES = ["i2c"]
-DOMAIN = "es9038q2m_katana"

esphome/components/es9038q2m_katana/audio_dac.py

@@ -1,92 +0,0 @@
-import esphome.codegen as cg
-from esphome.components import audio_dac, i2c
-import esphome.config_validation as cv
-from esphome.const import CONF_BITS_PER_SAMPLE, CONF_ID, CONF_SAMPLE_RATE
-from esphome.types import ConfigType
-
-CONF_DEEMPHASIS = "deemphasis"
-CONF_DOP = "dop"
-CONF_FILTER_SHAPE = "filter_shape"
-
-# Fields of the Katana format register: channel layout, word length and rate code.
-FORMAT_STEREO = 0x80
-BITS_PER_SAMPLE_CODES = {16: 0x10, 24: 0x20, 32: 0x30}
-SAMPLE_RATE_CODES = {
-    44100: 0x04,
-    48000: 0x05,
-    88200: 0x06,
-    96000: 0x07,
-    176400: 0x08,
-    192000: 0x09,
-    352800: 0x0A,
-    384000: 0x0B,
-}
-
-es9038q2m_katana_ns = cg.esphome_ns.namespace("es9038q2m_katana")
-ES9038Q2MKatana = es9038q2m_katana_ns.class_(
-    "ES9038Q2MKatana",
-    audio_dac.AudioDac,
-    cg.Component,
-    i2c.I2CDevice,
-)
-
-FilterShape = es9038q2m_katana_ns.enum("FilterShape")
-FILTER_SHAPES = {
-    "linear_phase_fast": FilterShape.FILTER_SHAPE_LINEAR_PHASE_FAST,
-    "linear_phase_slow": FilterShape.FILTER_SHAPE_LINEAR_PHASE_SLOW,
-    "minimum_phase_fast": FilterShape.FILTER_SHAPE_MIN_PHASE_FAST,
-    "minimum_phase_slow": FilterShape.FILTER_SHAPE_MIN_PHASE_SLOW,
-    "apodizing": FilterShape.FILTER_SHAPE_APODIZING,
-    "hybrid": FilterShape.FILTER_SHAPE_HYBRID,
-    "brick_wall": FilterShape.FILTER_SHAPE_BRICK_WALL,
-}
-
-DeemphasisMode = es9038q2m_katana_ns.enum("DeemphasisMode")
-DEEMPHASIS_MODES = {
-    "bypass": DeemphasisMode.DEEMPHASIS_BYPASS,
-    "32khz": DeemphasisMode.DEEMPHASIS_32KHZ,
-    "44_1khz": DeemphasisMode.DEEMPHASIS_44_1KHZ,
-    "48khz": DeemphasisMode.DEEMPHASIS_48KHZ,
-}
-
-CONFIG_SCHEMA = (
-    cv.Schema(
-        {
-            cv.GenerateID(): cv.declare_id(ES9038Q2MKatana),
-            cv.Optional(CONF_FILTER_SHAPE, default="apodizing"): cv.enum(
-                FILTER_SHAPES, lower=True
-            ),
-            cv.Optional(CONF_BITS_PER_SAMPLE, default="16bit"): cv.All(
-                cv.float_with_unit("bits", "bit"),
-                cv.one_of(*BITS_PER_SAMPLE_CODES, int=True),
-            ),
-            cv.Optional(CONF_SAMPLE_RATE, default=48000): cv.one_of(
-                *SAMPLE_RATE_CODES, int=True
-            ),
-            cv.Optional(CONF_DEEMPHASIS, default="bypass"): cv.enum(
-                DEEMPHASIS_MODES, lower=True
-            ),
-            # Only switches the control logic; the source must already send DoP frames.
-            cv.Optional(CONF_DOP, default=False): cv.boolean,
-        }
-    )
-    .extend(cv.COMPONENT_SCHEMA)
-    .extend(i2c.i2c_device_schema(0x30))
-)
-
-
-async def to_code(config: ConfigType) -> None:
-    var = cg.new_Pvariable(config[CONF_ID])
-    await cg.register_component(var, config)
-    await i2c.register_i2c_device(var, config)
-
-    cg.add(var.set_filter_shape(config[CONF_FILTER_SHAPE]))
-    cg.add(
-        var.set_format(
-            FORMAT_STEREO
-            | BITS_PER_SAMPLE_CODES[config[CONF_BITS_PER_SAMPLE]]
-            | SAMPLE_RATE_CODES[config[CONF_SAMPLE_RATE]]
-        )
-    )
-    cg.add(var.set_deemphasis_mode(config[CONF_DEEMPHASIS]))
-    cg.add(var.set_dop_enabled(config[CONF_DOP]))

esphome/components/es9038q2m_katana/es9038q2m_katana.cpp

@@ -1,176 +0,0 @@
-#include "es9038q2m_katana.h"
-
-#include "esphome/core/hal.h"
-#include "esphome/core/log.h"
-
-#include <cmath>
-
-namespace esphome::es9038q2m_katana {
-
-ESPHOME_LOG_TAG(TAG, "es9038q2m_katana");
-
-namespace {
-
-constexpr uint8_t KATANA_CHIP_ID = 0x30;
-
-constexpr uint8_t KATANA_REG_CHIP_ID = 0x00;
-constexpr uint8_t KATANA_REG_RESET = 0x01;
-constexpr uint8_t KATANA_REG_VOLUME_1 = 0x02;
-constexpr uint8_t KATANA_REG_VOLUME_2 = 0x03;
-constexpr uint8_t KATANA_REG_MUTE = 0x04;
-constexpr uint8_t KATANA_REG_DSP_PROGRAM = 0x05;
-constexpr uint8_t KATANA_REG_DEEMPHASIS = 0x06;
-constexpr uint8_t KATANA_REG_DOP = 0x07;
-constexpr uint8_t KATANA_REG_FORMAT = 0x08;
-constexpr uint8_t KATANA_REG_COMMAND = 0x09;
-constexpr uint8_t KATANA_REG_MUTE_STREAM = 0x0A;
-
-constexpr float KATANA_VOLUME_MIDPOINT = 0.5f;
-constexpr float KATANA_VOLUME_MIDPOINT_STEPS = 50.0f;  // -25 dB at 50% volume.
-// Cubic amplitude gain: -20 * log10(volume^3) / 0.5 attenuation steps.
-constexpr float KATANA_VOLUME_CUBIC_SCALE = 120.0f;
-constexpr uint8_t KATANA_VOLUME_FULL_ATTENUATION = 255;
-
-// The control logic ignores writes for this long after a reset.
-constexpr uint32_t RESET_SETTLE_DELAY_MS = 10;
-
-const LogString *filter_shape_to_str(FilterShape shape) {
-  switch (shape) {
-    case FILTER_SHAPE_LINEAR_PHASE_FAST:
-      return LOG_STR("linear_phase_fast");
-    case FILTER_SHAPE_LINEAR_PHASE_SLOW:
-      return LOG_STR("linear_phase_slow");
-    case FILTER_SHAPE_MIN_PHASE_FAST:
-      return LOG_STR("minimum_phase_fast");
-    case FILTER_SHAPE_MIN_PHASE_SLOW:
-      return LOG_STR("minimum_phase_slow");
-    case FILTER_SHAPE_APODIZING:
-      return LOG_STR("apodizing");
-    case FILTER_SHAPE_HYBRID:
-      return LOG_STR("hybrid");
-    default:
-      return LOG_STR("brick_wall");
-  }
-}
-
-const LogString *deemphasis_to_str(DeemphasisMode mode) {
-  switch (mode) {
-    case DEEMPHASIS_32KHZ:
-      return LOG_STR("32khz");
-    case DEEMPHASIS_44_1KHZ:
-      return LOG_STR("44_1khz");
-    case DEEMPHASIS_48KHZ:
-      return LOG_STR("48khz");
-    default:
-      return LOG_STR("bypass");
-  }
-}
-
-}  // namespace
-
-void ES9038Q2MKatana::setup() {
-  uint8_t chip_id = 0;
-  if (!this->read_byte(KATANA_REG_CHIP_ID, &chip_id)) {
-    this->mark_failed(LOG_STR(ESP_LOG_MSG_COMM_FAIL));
-    return;
-  }
-  if (chip_id != KATANA_CHIP_ID) {
-    ESP_LOGE(TAG, "Unexpected chip ID 0x%02X", chip_id);
-    this->mark_failed(LOG_STR("Unexpected chip ID"));
-    return;
-  }
-  if (!this->write_byte(KATANA_REG_RESET, 0x01)) {
-    this->mark_failed(LOG_STR(ESP_LOG_MSG_COMM_FAIL));
-    return;
-  }
-  delay(RESET_SETTLE_DELAY_MS);
-
-  // MUTE_STREAM is the gate the Linux driver closes between streams; ESPHome has no such
-  // notion, so it stays open and mute is only ever driven through MUTE.
-  if (!this->write_byte(KATANA_REG_FORMAT, this->format_) || !this->write_byte(KATANA_REG_COMMAND, 0x00) ||
-      !this->write_byte(KATANA_REG_DSP_PROGRAM, this->filter_shape_) ||
-      !this->write_byte(KATANA_REG_DEEMPHASIS, this->deemphasis_mode_) ||
-      !this->write_byte(KATANA_REG_DOP, this->dop_enabled_ ? 1 : 0) || !this->write_volume_() ||
-      !this->write_byte(KATANA_REG_MUTE, this->is_muted_ ? 1 : 0) || !this->write_byte(KATANA_REG_MUTE_STREAM, 0x00)) {
-    this->mark_failed(LOG_STR("Failed to configure the control logic"));
-  }
-}
-
-void ES9038Q2MKatana::dump_config() {
-  ESP_LOGCONFIG(TAG,
-                "ES9038Q2M Katana:\n"
-                "  Filter shape: %s\n"
-                "  De-emphasis: %s\n"
-                "  Format register: 0x%02X\n"
-                "  DoP: %s",
-                LOG_STR_ARG(filter_shape_to_str(this->filter_shape_)),
-                LOG_STR_ARG(deemphasis_to_str(this->deemphasis_mode_)), this->format_, ONOFF(this->dop_enabled_));
-  LOG_I2C_DEVICE(this);
-  if (this->is_failed())
-    return;
-#if ESPHOME_LOG_LEVEL >= ESPHOME_LOG_LEVEL_VERBOSE
-  for (uint8_t reg = KATANA_REG_CHIP_ID; reg <= KATANA_REG_MUTE_STREAM; reg++) {
-    uint8_t value = 0;
-    if (this->read_byte(reg, &value)) {
-      ESP_LOGV(TAG, "  Register 0x%02X: 0x%02X", reg, value);
-    } else {
-      ESP_LOGV(TAG, "  Register 0x%02X: read failed", reg);
-    }
-  }
-#endif
-}
-
-// Both channel registers follow ESPHome's single master volume.
-bool ES9038Q2MKatana::write_volume_() {
-  return this->write_byte(KATANA_REG_VOLUME_1, this->volume_reg_) &&
-         this->write_byte(KATANA_REG_VOLUME_2, this->volume_reg_);
-}
-
-// Records the outcome of a runtime write; the cached state only changes on success.
-bool ES9038Q2MKatana::check_write_(bool ok) {
-  if (ok) {
-    this->status_clear_warning();
-  } else {
-    this->status_set_warning(LOG_STR(ESP_LOG_MSG_COMM_FAIL));
-  }
-  return ok;
-}
-
-bool ES9038Q2MKatana::set_volume(float volume) {
-  if (this->is_failed())
-    return false;
-  volume = clamp(volume, 0.0f, 1.0f);
-  const uint8_t previous = this->volume_reg_;
-  float attenuation = KATANA_VOLUME_FULL_ATTENUATION;
-  if (volume >= KATANA_VOLUME_MIDPOINT) {
-    attenuation = KATANA_VOLUME_MIDPOINT_STEPS * (1.0f - volume) / (1.0f - KATANA_VOLUME_MIDPOINT);
-  } else if (volume > 0.0f) {
-    attenuation = KATANA_VOLUME_MIDPOINT_STEPS - KATANA_VOLUME_CUBIC_SCALE * log10f(volume / KATANA_VOLUME_MIDPOINT);
-  }
-  this->volume_reg_ =
-      static_cast<uint8_t>(lroundf(clamp(attenuation, 0.0f, static_cast<float>(KATANA_VOLUME_FULL_ATTENUATION))));
-  if (this->check_write_(this->write_volume_()))
-    return true;
-  this->volume_reg_ = previous;
-  return false;
-}
-
-float ES9038Q2MKatana::volume() {
-  if (this->volume_reg_ == KATANA_VOLUME_FULL_ATTENUATION)
-    return 0.0f;
-  if (this->volume_reg_ <= KATANA_VOLUME_MIDPOINT_STEPS)
-    return 1.0f - this->volume_reg_ * (1.0f - KATANA_VOLUME_MIDPOINT) / KATANA_VOLUME_MIDPOINT_STEPS;
-  return KATANA_VOLUME_MIDPOINT *
-         powf(10.0f, (KATANA_VOLUME_MIDPOINT_STEPS - this->volume_reg_) / KATANA_VOLUME_CUBIC_SCALE);
-}
-
-bool ES9038Q2MKatana::set_mute_state_(bool mute_state) {
-  if (this->is_failed())
-    return false;
-  if (!this->check_write_(this->write_byte(KATANA_REG_MUTE, mute_state ? 1 : 0)))
-    return false;
-  this->is_muted_ = mute_state;
-  return true;
-}
-
-}  // namespace esphome::es9038q2m_katana

esphome/components/es9038q2m_katana/es9038q2m_katana.h

@@ -1,62 +0,0 @@
-#pragma once
-
-#include "esphome/components/audio_dac/audio_dac.h"
-#include "esphome/components/i2c/i2c.h"
-#include "esphome/core/component.h"
-#include "esphome/core/helpers.h"
-
-namespace esphome::es9038q2m_katana {
-
-// DSP program numbers of the Katana control interface; there is no program 5.
-enum FilterShape : uint8_t {
-  FILTER_SHAPE_LINEAR_PHASE_FAST = 0,
-  FILTER_SHAPE_LINEAR_PHASE_SLOW = 1,
-  FILTER_SHAPE_MIN_PHASE_FAST = 2,
-  FILTER_SHAPE_MIN_PHASE_SLOW = 3,
-  FILTER_SHAPE_APODIZING = 4,
-  FILTER_SHAPE_HYBRID = 6,
-  FILTER_SHAPE_BRICK_WALL = 7,
-};
-
-enum DeemphasisMode : uint8_t {
-  DEEMPHASIS_BYPASS = 0,
-  DEEMPHASIS_32KHZ = 1,
-  DEEMPHASIS_44_1KHZ = 2,
-  DEEMPHASIS_48KHZ = 3,
-};
-
-// Boards that expose an ES9038Q2M through the Allo Katana control logic at I2C address 0x30.
-// Ported from the Linux driver sound/soc/bcm/allo-katana-codec.c; the DAC's own registers
-// are never written, the control logic applies the configuration itself.
-class ES9038Q2MKatana : public audio_dac::AudioDac, public Component, public i2c::I2CDevice {
- public:
-  void setup() override;
-  void dump_config() override;
-
-  // Cubic below 50%, then 0.5 dB per 1% above, meeting at -25 dB.
-  // Zero selects full attenuation (-127.5 dB).
-  bool set_volume(float volume) override;
-  float volume() override;
-  bool set_mute_off() override { return this->set_mute_state_(false); }
-  bool set_mute_on() override { return this->set_mute_state_(true); }
-  bool is_muted() override { return this->is_muted_; }
-
-  void set_filter_shape(FilterShape shape) { this->filter_shape_ = shape; }
-  void set_format(uint8_t format) { this->format_ = format; }
-  void set_deemphasis_mode(DeemphasisMode mode) { this->deemphasis_mode_ = mode; }
-  void set_dop_enabled(bool enabled) { this->dop_enabled_ = enabled; }
-
- protected:
-  bool set_mute_state_(bool mute_state);
-  bool write_volume_();
-  bool check_write_(bool ok);
-
-  FilterShape filter_shape_{FILTER_SHAPE_APODIZING};
-  DeemphasisMode deemphasis_mode_{DEEMPHASIS_BYPASS};
-  uint8_t format_{0};
-  // Attenuation in 0.5 dB steps: 0 is loudest, 255 quietest. Starts 20 dB down.
-  uint8_t volume_reg_{0x28};
-  bool dop_enabled_{false};
-};
-
-}  // namespace esphome::es9038q2m_katana

esphome/components/esp32/__init__.py

@@ -2920,7 +2920,6 @@ async def _finalize_arduino_aware_flags():
     if not arduino_linked:
         cg.add_build_flag("-Wl,--wrap=esp_panic_handler")
         cg.add_define("USE_ESP32_CRASH_HANDLER")
-        cg.add_define("USE_CRASH_HANDLER")
     elif not CORE.using_arduino:
         cg.add_build_flag("-DUSE_ARDUINO")
 

esphome/components/esp32/crash_handler.cpp

@@ -161,7 +161,7 @@ static bool s_crash_data_valid = false;  // NOLINT(cppcoreguidelines-avoid-non-c
 
 namespace esphome::esp32 {
 
-ESPHOME_LOG_TAG(TAG, CRASH_LOG_TAG);
+ESPHOME_LOG_TAG(TAG, "esp32.crash");
 
 // RAM copy of the build timestamp. The generated constant lives in flash,
 // which the panic handler must not read (cache may be disabled during
@@ -175,8 +175,7 @@ static uint32_t s_current_build_time = static_cast<uint32_t>(ESPHOME_BUILD_TIME)
 
 // Validate the NOINIT record. Runs on every has_data() call; re-running is
 // harmless and the magic is left alone so the record survives an OTA
-// rollback reboot, crash_handler_clear() drops it once a log client has it
-// (logger::log_crash_to_client(), for the API and MQTT).
+// rollback reboot, crash_handler_clear() drops it once an API client has it.
 static void read_crash_data() {
   if (s_raw_crash_data.magic == CRASH_MAGIC && s_raw_crash_data.version == CRASH_DATA_VERSION) {
     s_crash_data_valid = true;

esphome/components/esp32/crash_handler.h

@@ -4,9 +4,6 @@
 
 namespace esphome::esp32 {
 
-/// The tag the crash record is logged under, so a client can check the level in force for it
-inline constexpr const char *CRASH_LOG_TAG = "esp32.crash";
-
 /// Log crash data if a crash was detected on previous boot.
 void crash_handler_log();
 

esphome/components/esp32/preferences.cpp

@@ -131,7 +131,6 @@ bool ESP32PreferenceBackend::load(uint8_t *data, size_t len) {
 void ESP32Preferences::open() {
   // Runs from app_main() before the logger is initialized; any logging here
   // must be deferred. See s_open_err and make_preference() below.
-  // Components that need NVS check nvs_handle instead of initializing it again.
   nvs_flash_init();
   esp_err_t err = nvs_open("esphome", NVS_READWRITE, &this->nvs_handle);
   if (err == 0)

esphome/components/esp32_ble/ble.cpp

@@ -5,7 +5,6 @@
 #include "esphome/core/application.h"
 #include "esphome/core/helpers.h"
 #include "esphome/core/log.h"
-#include "esphome/core/preferences.h"
 
 #ifndef CONFIG_BT_CONTROLLER_DISABLED
 #include <esp_bt.h>
@@ -29,6 +28,7 @@ extern "C" {
 #include <freertos/FreeRTOS.h>
 #include <freertos/FreeRTOSConfig.h>
 #include <freertos/task.h>
+#include <nvs_flash.h>
 
 #ifdef USE_ARDUINO
 // Prevent Arduino from releasing BT memory at startup (esp32-hal-misc.c).
@@ -77,9 +77,8 @@ static constexpr uint32_t HOSTED_BT_WDT_TIMEOUT_MS = 60000;
 
 void ESP32BLE::setup() {
   global_ble = this;
-  // Preferences opens NVS in app_main(); a zero handle means it could not be opened, even after an erase
-  if (global_preferences->nvs_handle == 0) {
-    ESP_LOGE(TAG, "NVS unavailable");
+  if (!ble_pre_setup_()) {
+    ESP_LOGE(TAG, "BLE could not be prepared for configuration");
     this->mark_failed();
     return;
   }
@@ -186,6 +185,15 @@ void ESP32BLE::advertising_remove_service_uuid(ESPBTUUID uuid) {
 }
 #endif
 
+bool ESP32BLE::ble_pre_setup_() {
+  esp_err_t err = nvs_flash_init();
+  if (err != ESP_OK) {
+    ESP_LOGE(TAG, "nvs_flash_init failed: %d", err);
+    return false;
+  }
+  return true;
+}
+
 #ifdef USE_ESP32_BLE_ADVERTISING
 void ESP32BLE::advertising_init_() {
   if (this->advertising_ != nullptr)

esphome/components/esp32_ble/ble.h

@@ -185,6 +185,7 @@ class ESP32BLE final : public Component {
     }
     this->ble_events_.get_and_reset_dropped_count();
   }
+  bool ble_pre_setup_();
 #ifdef USE_ESP32_BLE_ADVERTISING
   void advertising_init_();
 #endif

esphome/components/esp32_ble_beacon/esp32_ble_beacon.cpp

@@ -10,6 +10,7 @@
 #include <esp_gap_ble_api.h>
 #include <freertos/FreeRTOS.h>
 #include <freertos/task.h>
+#include <nvs_flash.h>
 #include <cstring>
 
 #include "esphome/core/hal.h"

esphome/components/esp32_ble_client/ble_client_base.cpp

@@ -300,7 +300,7 @@ void BLEClientBase::log_warning_(const char *message) {
 
 esp_err_t BLEClientBase::update_conn_params_(uint16_t min_interval, uint16_t max_interval, uint16_t latency,
                                              uint16_t timeout, const char *param_type) {
-  esp_ble_conn_update_params_t conn_params = {};
+  esp_ble_conn_update_params_t conn_params = {{0}};
   memcpy(conn_params.bda, this->remote_bda_, sizeof(esp_bd_addr_t));
   conn_params.min_int = min_interval;
   conn_params.max_int = max_interval;

esphome/components/esp32_ble_server/ble_server.cpp

@@ -7,6 +7,7 @@
 
 #ifdef USE_ESP32
 
+#include <nvs_flash.h>
 #include <freertos/FreeRTOSConfig.h>
 #include <esp_bt_main.h>
 #ifndef CONFIG_BT_CONTROLLER_DISABLED

esphome/components/esp32_ble_tracker/esp32_ble_tracker.cpp

@@ -16,6 +16,7 @@
 #include <freertos/FreeRTOS.h>
 #include <freertos/FreeRTOSConfig.h>
 #include <freertos/task.h>
+#include <nvs_flash.h>
 #include <cinttypes>
 
 #ifdef USE_OTA

esphome/components/esp32_can/canbus.py

@@ -47,7 +47,6 @@ CanMode = esp32_can_ns.enum("CanMode")
 CAN_MODES = {
     "NORMAL": CanMode.CAN_MODE_NORMAL,
     "LISTENONLY": CanMode.CAN_MODE_LISTEN_ONLY,
-    "NO_ACK": CanMode.CAN_MODE_NO_ACK,
 }
 
 # Currently the driver only supports a subset of the bit rates defined in canbus

esphome/components/esp32_can/esp32_can.cpp

@@ -79,13 +79,10 @@ bool ESP32Can::setup_internal() {
   }
 
   // Select TWAI mode based on configuration
-  twai_mode_t twai_mode = TWAI_MODE_NORMAL;
+  twai_mode_t twai_mode = (this->mode_ == CAN_MODE_LISTEN_ONLY) ? TWAI_MODE_LISTEN_ONLY : TWAI_MODE_NORMAL;
+
   if (this->mode_ == CAN_MODE_LISTEN_ONLY) {
-    twai_mode = TWAI_MODE_LISTEN_ONLY;
     ESP_LOGI(TAG, "CAN bus configured in LISTEN_ONLY mode (passive, no ACKs)");
-  } else if (this->mode_ == CAN_MODE_NO_ACK) {
-    twai_mode = TWAI_MODE_NO_ACK;
-    ESP_LOGI(TAG, "CAN bus configured in NO_ACK mode (transmit without requiring ACK)");
   }
 
   twai_general_config_t g_config =

esphome/components/esp32_can/esp32_can.h

@@ -12,7 +12,6 @@ namespace esphome::esp32_can {
 enum CanMode : uint8_t {
   CAN_MODE_NORMAL = 0,
   CAN_MODE_LISTEN_ONLY = 1,
-  CAN_MODE_NO_ACK = 2,
 };
 
 class ESP32Can final : public canbus::Canbus {

esphome/components/esp32_hosted/esp_now_hosted.cpp

@@ -42,7 +42,6 @@ extern "C" {
 }
 
 #include "esp_now_hosted_rpc.h"
-#include "esphome/core/log.h"
 
 namespace {
 
@@ -53,8 +52,6 @@ ESPHOME_LOG_TAG(TAG, "esp_now_hosted");
 // single esp-hosted RPC RX thread. Serializing requests keeps the shared
 // response slot race-free; a sequence number stops a late/stale response from
 // being mistaken for ours.
-// NOLINTBEGIN(cppcoreguidelines-avoid-non-const-global-variables): the shim is
-// C-ABI state shared between the main loop and the esp-hosted RX thread.
 SemaphoreHandle_t g_req_mutex = nullptr;
 SemaphoreHandle_t g_resp_sem = nullptr;  // given when the matching RESP lands
 bool g_setup_done = false;               // set only after setup fully succeeds
@@ -88,7 +85,6 @@ constexpr size_t ESP_NOW_HOSTED_MAX_PEERS = 20;
 uint8_t g_peer_cache[ESP_NOW_HOSTED_MAX_PEERS][6];
 size_t g_peer_count = 0;
 portMUX_TYPE g_peer_lock = portMUX_INITIALIZER_UNLOCKED;
-// NOLINTEND(cppcoreguidelines-avoid-non-const-global-variables)
 
 // Caller must hold g_peer_lock.
 int peer_cache_find_locked(const uint8_t *mac) {
@@ -235,14 +231,12 @@ esp_err_t ensure_setup() {
     g_resp_sem = xSemaphoreCreateBinary();
   if (g_req_mutex == nullptr || g_resp_sem == nullptr)
     return ESP_ERR_NO_MEM;
-  esp_err_t err = esp_hosted_register_custom_callback(ESP_NOW_HOSTED_MSG_RESP, on_resp, nullptr);
-  if (err != ESP_OK)
+  esp_err_t err;
+  if ((err = esp_hosted_register_custom_callback(ESP_NOW_HOSTED_MSG_RESP, on_resp, nullptr)) != ESP_OK)
     return err;
-  err = esp_hosted_register_custom_callback(ESP_NOW_HOSTED_MSG_RECV, on_recv, nullptr);
-  if (err != ESP_OK)
+  if ((err = esp_hosted_register_custom_callback(ESP_NOW_HOSTED_MSG_RECV, on_recv, nullptr)) != ESP_OK)
     return err;
-  err = esp_hosted_register_custom_callback(ESP_NOW_HOSTED_MSG_SEND, on_send, nullptr);
-  if (err != ESP_OK)
+  if ((err = esp_hosted_register_custom_callback(ESP_NOW_HOSTED_MSG_SEND, on_send, nullptr)) != ESP_OK)
     return err;
   g_setup_done = true;
   return ESP_OK;
@@ -428,11 +422,10 @@ esp_err_t esp_now_send(const uint8_t *peer_addr, const uint8_t *data, size_t len
   uint8_t hdr[sizeof(esp_now_hosted_send_req_t)];
   auto *s = reinterpret_cast<esp_now_hosted_send_req_t *>(hdr);
   s->has_addr = peer_addr != nullptr ? 1 : 0;
-  if (peer_addr != nullptr) {
+  if (peer_addr != nullptr)
     memcpy(s->peer_addr, peer_addr, 6);
-  } else {
+  else
     memset(s->peer_addr, 0, 6);
-  }
   s->data_len = static_cast<uint16_t>(len);
   // Fire-and-forget (wait=false): native esp_now_send returns once the frame is
   // queued, with the real TX result delivered later through the send callback.

esphome/components/esp8266/__init__.py

@@ -53,14 +53,10 @@ from .const import (
     KEY_SERIAL1_REQUIRED,
     KEY_SERIAL_REQUIRED,
     KEY_WAVEFORM_REQUIRED,
-    PREFERENCES_RTC_EBOOT_WORDS,
-    PREFERENCES_RTC_NORMAL_WORDS,
     THROW_STUBS_HEADER,
-    check_preferences_fit,
     enable_serial,
     enable_serial1,
     esp8266_ns,
-    preferences_flash_words,
 )
 from .gpio import PinInitialState, add_pin_initial_states_array
 
@@ -420,7 +416,6 @@ async def to_code(config: ConfigType) -> None:
     cg.add_define("ESPHOME_VARIANT", "ESP8266")
     cg.add_define(ThreadModel.SINGLE)
     cg.add_define("USE_ESP8266_CRASH_HANDLER")
-    cg.add_define("USE_CRASH_HANDLER")
 
     enable_scanf_float = config.get(CONF_ENABLE_SCANF_FLOAT)
     if enable_scanf_float is None and lambdas_use_scanf_float(CORE.config):
@@ -472,12 +467,6 @@ async def to_code(config: ConfigType) -> None:
     # Other projects like Tasmota & ESPEasy also use this
     cg.add_build_flag("-DPIO_FRAMEWORK_ARDUINO_LWIP2_HIGHER_BANDWIDTH_LOW_FLASH")
 
-    cg.add_define("ESP8266_PREFERENCES_RTC_NORMAL_WORDS", PREFERENCES_RTC_NORMAL_WORDS)
-    cg.add_define("ESP8266_PREFERENCES_RTC_EBOOT_WORDS", PREFERENCES_RTC_EBOOT_WORDS)
-    cg.add_define(
-        "ESP8266_PREFERENCES_FLASH_WORDS",
-        preferences_flash_words(config[CONF_RESTORE_FROM_FLASH]),
-    )
     if config[CONF_RESTORE_FROM_FLASH]:
         cg.add_define("USE_ESP8266_PREFERENCES_FLASH")
 
@@ -539,7 +528,6 @@ async def to_code(config: ConfigType) -> None:
     CORE.add_job(add_pin_initial_states_array)
     CORE.add_job(finalize_waveform_config)
     CORE.add_job(finalize_serial_config)
-    CORE.add_job(check_preferences_fit)
 
 
 @coroutine_with_priority(CoroPriority.WORKAROUNDS)

esphome/components/esp8266/const.py

@@ -1,13 +1,9 @@
-import logging
-
 import esphome.codegen as cg
 
 # Re-exported from the shared definition; here it indexes the BOARDS
 # metadata dicts, whose entries in boards.py spell the literal.
 from esphome.const import KEY_FLASH_SIZE  # noqa: F401  # pylint: disable=unused-import
-from esphome.core import CORE, CoroPriority, EsphomeError, coroutine_with_priority
-
-_LOGGER = logging.getLogger(__name__)
+from esphome.core import CORE
 
 KEY_ESP8266 = "esp8266"
 KEY_BOARD = "board"
@@ -28,87 +24,6 @@ KEY_LDSCRIPT = "ldscript"
 # Crash-decode tools, resolved once per run by __init__
 KEY_DECODE_TOOLS = "decode_tools"
 
-# Saved-settings space in 4-byte words; preferences.cpp gets these as defines. A value cannot span the two
-# RTC regions, and the flash store is smaller when only explicit flash preferences use it.
-PREFERENCES_RTC_NORMAL_WORDS = 78
-PREFERENCES_RTC_EBOOT_WORDS = 32
-PREFERENCES_RTC_WORDS = PREFERENCES_RTC_NORMAL_WORDS + PREFERENCES_RTC_EBOOT_WORDS
-PREFERENCES_FLASH_WORDS = 128
-PREFERENCES_FLASH_WORDS_WITHOUT_RESTORE = 64
-KEY_PREFERENCES = "preferences"
-
-
-def preferences_flash_words(restore_from_flash: bool) -> int:
-    """Size of the flash store for this configuration."""
-    return (
-        PREFERENCES_FLASH_WORDS
-        if restore_from_flash
-        else PREFERENCES_FLASH_WORDS_WITHOUT_RESTORE
-    )
-
-
-def preference_words(value_bytes: int) -> int:
-    """Words a saved value takes, checksum word included (rtc_pref_bytes_to_words plus one)."""
-    return (value_bytes + 3) // 4 + 1
-
-
-def reserve_preferences(
-    count: int, value_bytes: int, in_flash: bool | None = None
-) -> None:
-    """Record saved values a component creates; check_preferences_fit() adds them all up.
-
-    in_flash is the value's own storage, as passed to make_preference(); None is the two-argument
-    form, which follows restore_from_flash.
-    """
-    if in_flash is None:
-        in_flash = CORE.config[KEY_ESP8266][CONF_RESTORE_FROM_FLASH]
-    reservations = CORE.data.setdefault(KEY_ESP8266, {}).setdefault(KEY_PREFERENCES, [])
-    reservations.extend([(preference_words(value_bytes), in_flash)] * count)
-
-
-def _rtc_values_can_split(values: list[int]) -> bool:
-    """Whether some order fills the two RTC regions without a value spanning them."""
-    total = sum(values)
-    if total <= PREFERENCES_RTC_NORMAL_WORDS:
-        return True
-    # Bit i of reachable is set when some subset of the values sums to i
-    reachable = 1
-    for words in values:
-        reachable |= reachable << words
-    lowest = max(0, total - PREFERENCES_RTC_EBOOT_WORDS)
-    highest = min(total, PREFERENCES_RTC_NORMAL_WORDS)
-    return any(reachable >> normal & 1 for normal in range(lowest, highest + 1))
-
-
-@coroutine_with_priority(CoroPriority.FINAL)
-async def check_preferences_fit() -> None:
-    """Fail the build when the reserved saved values cannot fit the space preferences.cpp has."""
-    flash_store = preferences_flash_words(
-        CORE.config[KEY_ESP8266][CONF_RESTORE_FROM_FLASH]
-    )
-    reservations = CORE.data[KEY_ESP8266].get(KEY_PREFERENCES, [])
-    flash_words = sum(w for w, in_flash in reservations if in_flash)
-    rtc_values = [w for w, in_flash in reservations if not in_flash]
-    if flash_words > flash_store:
-        raise EsphomeError(
-            f"Saved values need {flash_words} words but the ESP8266 flash store has {flash_store}; "
-            "use fewer or smaller saved values"
-        )
-    if not _rtc_values_can_split(rtc_values):
-        raise EsphomeError(
-            f"Saved values need {sum(rtc_values)} words but ESP8266 RTC memory has {PREFERENCES_RTC_WORDS} in "
-            f"regions of {PREFERENCES_RTC_NORMAL_WORDS} and {PREFERENCES_RTC_EBOOT_WORDS} that a value cannot "
-            "span; use fewer or smaller saved values, or store them in flash"
-        )
-    if sum(rtc_values) > PREFERENCES_RTC_NORMAL_WORDS:
-        _LOGGER.warning(
-            "Saved values reserve %d of %d words of ESP8266 RTC memory; the fit depends on setup order, and "
-            "saved settings that do not reserve are not counted",
-            sum(rtc_values),
-            PREFERENCES_RTC_WORDS,
-        )
-
-
 # esp8266 namespace is already defined by arduino, manually prefix esphome
 esp8266_ns = cg.global_ns.namespace("esphome").namespace("esp8266")
 

esphome/components/esp8266/crash_handler.cpp

@@ -4,7 +4,6 @@
 #ifdef USE_ESP8266_CRASH_HANDLER
 
 #include "crash_handler.h"
-#include "rtc_layout.h"
 #include "esphome/core/log.h"
 
 #include <cinttypes>
@@ -47,8 +46,11 @@ static inline bool IRAM_ATTR is_code_addr(uint32_t val) {
 // Recover the actual code address from a windowed-ABI return address on the stack.
 static inline uint32_t IRAM_ATTR recover_code_addr(uint32_t val) { return (val & XTENSA_ADDR_MASK) | XTENSA_CODE_BASE; }
 
-// Crash data lives in the last esphome::esp8266::RTC_CRASH_WORDS of user RTC memory (rtc_layout.h).
+// RTC user memory layout for crash backtrace data.
+// User-accessible RTC memory: blocks 64-191 (each block = 4 bytes).
+// We use blocks 174-191 (last 18 blocks, 72 bytes) to minimize conflicts.
 // Store 16 raw candidates, filter to real return addresses at log time.
+static constexpr uint8_t RTC_CRASH_BASE = 174;
 static constexpr size_t MAX_BACKTRACE = 16;
 
 // Magic word packs sentinel, version, and count into one uint32_t:
@@ -76,7 +78,7 @@ struct RtcCrashData {
   uint32_t backtrace[MAX_BACKTRACE];
   uint32_t epc1;  // Fault PC, used to filter duplicates
 };
-static_assert(sizeof(RtcCrashData) == esphome::esp8266::RTC_CRASH_WORDS * 4, "RtcCrashData must fill its RTC words");
+static_assert(sizeof(RtcCrashData) == 72, "RtcCrashData must fit in 18 RTC blocks");
 
 namespace esphome::esp8266 {
 
@@ -127,7 +129,7 @@ static const LogString *get_reset_reason(uint32_t reason) {
 // Returns the number of valid backtrace entries (0 if no data found).
 static uint8_t read_rtc_backtrace(uint32_t *backtrace, size_t max_entries) {
   RtcCrashData rtc_data;
-  if (!system_rtc_mem_read(esphome::esp8266::RTC_CRASH_BASE, &rtc_data, sizeof(rtc_data)))
+  if (!system_rtc_mem_read(RTC_CRASH_BASE, &rtc_data, sizeof(rtc_data)))
     return 0;
   uint32_t magic = rtc_data.magic;
   if ((magic & CRASH_SENTINEL_MASK) != CRASH_SENTINEL || (magic & CRASH_VERSION_MASK) != CRASH_VERSION)
@@ -231,7 +233,7 @@ extern "C" void IRAM_ATTR custom_crash_callback(struct rst_info *rst_info, uint3
   data.epc1 = epc1;
   data.magic = CRASH_SENTINEL | CRASH_VERSION | count;
 
-  system_rtc_mem_write(esphome::esp8266::RTC_CRASH_BASE, &data, sizeof(data));
+  system_rtc_mem_write(RTC_CRASH_BASE, &data, sizeof(data));
 }
 
 #endif  // USE_ESP8266_CRASH_HANDLER

esphome/components/esp8266/preferences.cpp

@@ -6,7 +6,6 @@ extern "C" {
 }
 
 #include "preferences.h"
-#include "rtc_layout.h"
 #include "esphome/core/helpers.h"
 #include "esphome/core/log.h"
 #include "esphome/core/preferences_rtc.h"
@@ -18,26 +17,31 @@ namespace esphome::esp8266 {
 ESPHOME_LOG_TAG(TAG, "preferences");
 
 static constexpr uint32_t ESP_RTC_USER_MEM_START = 0x60001200;
-static constexpr uint32_t ESP_RTC_USER_MEM_SIZE_WORDS = RTC_USER_MEM_WORDS;
+static constexpr uint32_t ESP_RTC_USER_MEM_SIZE_WORDS = 128;
 static constexpr uint32_t ESP_RTC_USER_MEM_SIZE_BYTES = ESP_RTC_USER_MEM_SIZE_WORDS * 4;
 
-// RTC memory layout (sizes come from const.py through codegen):
+// RTC memory layout:
 // - Eboot region:  RTC words 0-31   (reserved, mapped from preference offset 78-109)
 // - Normal region: RTC words 32-109 (mapped from preference offset 0-77)
 // - Crash handler: RTC words 110-127 (reserved for crash_handler.cpp backtrace data)
-static constexpr uint32_t RTC_EBOOT_REGION_WORDS = ESP8266_PREFERENCES_RTC_EBOOT_WORDS;
-static constexpr uint32_t RTC_NORMAL_REGION_WORDS = ESP8266_PREFERENCES_RTC_NORMAL_WORDS;
+static constexpr uint32_t RTC_EBOOT_REGION_WORDS = 32;   // Words 0-31 reserved for eboot
+static constexpr uint32_t RTC_NORMAL_REGION_WORDS = 78;  // Words 32-109 for normal prefs
 static constexpr uint32_t PREF_TOTAL_WORDS = RTC_EBOOT_REGION_WORDS + RTC_NORMAL_REGION_WORDS;  // 110
-static_assert(PREF_TOTAL_WORDS <= RTC_CRASH_BASE - RTC_SYSTEM_USER_BASE,
-              "preference regions overlap the crash handler's RTC words");
 
 // Maximum preference size in words (limited by uint8_t length_words field)
 static constexpr uint32_t MAX_PREFERENCE_WORDS = 255;
 
 #define ESP_RTC_USER_MEM ((uint32_t *) ESP_RTC_USER_MEM_START)
 
-// Smaller without restore_from_flash, when only explicit flash preferences live here
-static constexpr uint32_t ESP8266_FLASH_STORAGE_SIZE = ESP8266_PREFERENCES_FLASH_WORDS;
+// Flash storage size depends on esp8266 -> restore_from_flash YAML option (default: false).
+// When enabled (USE_ESP8266_PREFERENCES_FLASH), all preferences default to flash and need
+// 128 words (512 bytes). When disabled, only explicit flash prefs use this storage so
+// 64 words (256 bytes) suffices since most preferences go to RTC memory instead.
+#ifdef USE_ESP8266_PREFERENCES_FLASH
+static constexpr uint32_t ESP8266_FLASH_STORAGE_SIZE = 128;
+#else
+static constexpr uint32_t ESP8266_FLASH_STORAGE_SIZE = 64;
+#endif
 
 static uint32_t
     s_flash_storage[ESP8266_FLASH_STORAGE_SIZE];  // NOLINT(cppcoreguidelines-avoid-non-const-global-variables)
@@ -56,7 +60,7 @@ static inline bool esp_rtc_user_mem_write(uint32_t index, uint32_t value) {
   if (index >= ESP_RTC_USER_MEM_SIZE_WORDS) {
     return false;
   }
-  if (index < RTC_EBOOT_REGION_WORDS && s_prevent_write) {
+  if (index < 32 && s_prevent_write) {
     return false;
   }
 
@@ -119,7 +123,7 @@ static bool load_from_rtc(size_t offset, uint32_t *data, size_t len) {
 
 // Maximum buffer for any single preference - bounded by storage sizes.
 // Flash prefs: bounded by ESP8266_FLASH_STORAGE_SIZE (128 or 64 words).
-// RTC prefs: bounded by RTC_NORMAL_REGION_WORDS (78) - a single pref can't span both RTC regions.
+// RTC prefs: bounded by RTC_NORMAL_REGION_WORDS (96) - a single pref can't span both RTC regions.
 static constexpr size_t PREF_MAX_BUFFER_WORDS =
     ESP8266_FLASH_STORAGE_SIZE > RTC_NORMAL_REGION_WORDS ? ESP8266_FLASH_STORAGE_SIZE : RTC_NORMAL_REGION_WORDS;
 
@@ -176,8 +180,8 @@ ESPPreferenceObject ESP8266Preferences::make_preference(size_t length, uint32_t
   } else {
     uint32_t start = this->current_offset;
     bool in_normal = start < RTC_NORMAL_REGION_WORDS;
-    // Normal: offset 0-77 maps to RTC offset 32-109
-    // Eboot: offset 78-109 maps to RTC offset 0-31
+    // Normal: offset 0-95 maps to RTC offset 32-127
+    // Eboot: offset 96-127 maps to RTC offset 0-31
     if (in_normal && start + total_words > RTC_NORMAL_REGION_WORDS) {
       // start is in normal but end is not -> switch to Eboot
       this->current_offset = start = RTC_NORMAL_REGION_WORDS;

esphome/components/esp8266/rtc_layout.h

@@ -1,18 +0,0 @@
-#pragma once
-
-#ifdef USE_ESP8266
-
-#include <cstdint>
-
-namespace esphome::esp8266 {
-
-// User RTC memory is system blocks 64-191, one 4-byte word each. preferences.cpp owns the first
-// words, crash_handler.cpp the last; const.py hands preferences.cpp its region sizes.
-static constexpr uint32_t RTC_SYSTEM_USER_BASE = 64;
-static constexpr uint32_t RTC_USER_MEM_WORDS = 128;
-static constexpr uint32_t RTC_CRASH_WORDS = 18;
-static constexpr uint32_t RTC_CRASH_BASE = RTC_SYSTEM_USER_BASE + RTC_USER_MEM_WORDS - RTC_CRASH_WORDS;
-
-}  // namespace esphome::esp8266
-
-#endif  // USE_ESP8266

esphome/components/fusb302b/__init__.py

@@ -1,40 +0,0 @@
-from esphome import pins
-import esphome.codegen as cg
-from esphome.components import i2c
-import esphome.config_validation as cv
-from esphome.const import CONF_ID, CONF_INTERRUPT_PIN
-from esphome.types import ConfigType
-
-CODEOWNERS = ["@remcom"]
-DEPENDENCIES = ["i2c"]
-DOMAIN = "fusb302b"
-
-CONF_REQUEST_VOLTAGE = "request_voltage"
-
-fusb302b_ns = cg.esphome_ns.namespace("fusb302b")
-FUSB302B = fusb302b_ns.class_("FUSB302B", cg.Component, i2c.I2CDevice)
-
-# USB PD fixed supply voltages are 5, 9, 12, 15 and 20 V; the highest one that does not exceed the
-# requested voltage is chosen.
-validate_voltage = cv.int_range(min=5, max=20)
-
-CONFIG_SCHEMA = cv.All(
-    cv.Schema(
-        {
-            cv.GenerateID(): cv.declare_id(FUSB302B),
-            cv.Required(CONF_INTERRUPT_PIN): pins.internal_gpio_input_pullup_pin_schema,
-            cv.Required(CONF_REQUEST_VOLTAGE): validate_voltage,
-        }
-    )
-    .extend(cv.COMPONENT_SCHEMA)
-    .extend(i2c.i2c_device_schema(0x22)),
-    cv.only_on_esp32,
-)
-
-
-async def to_code(config: ConfigType) -> None:
-    interrupt_pin = await cg.gpio_pin_expression(config[CONF_INTERRUPT_PIN])
-    var = cg.new_Pvariable(config[CONF_ID], interrupt_pin)
-    await cg.register_component(var, config)
-    await i2c.register_i2c_device(var, config)
-    cg.add(var.set_request_voltage(config[CONF_REQUEST_VOLTAGE]))

esphome/components/fusb302b/fusb302b.cpp

@@ -1,415 +0,0 @@
-#include "fusb302b.h"
-
-#ifdef USE_ESP32
-
-#include "esphome/core/log.h"
-
-#include "fusb302b_registers.h"
-
-namespace esphome::fusb302b {
-
-ESPHOME_LOG_TAG(TAG, "fusb302b");
-
-// Task notification bits
-static constexpr uint32_t NOTIFY_IRQ = 1 << 0;
-static constexpr uint32_t NOTIFY_STOP = 1 << 1;
-
-static constexpr uint32_t TASK_STACK_SIZE = 4096;
-static constexpr UBaseType_t TASK_PRIORITY = 18;
-
-static constexpr uint32_t STARTUP_DELAY_MS = 2000;
-static constexpr uint32_t CC_SETTLE_MS = 5;
-static constexpr uint32_t CC_POLL_INTERVAL_MS = 500;
-static constexpr uint32_t PD_POLL_INTERVAL_MS = 100;
-// Safety net in case an interrupt edge is missed while attached and idle
-static constexpr uint32_t IDLE_POLL_INTERVAL_MS = 1000;
-// Time to wait for the source to send its capabilities on its own after attach
-static constexpr uint32_t SOURCE_CAP_WAIT_MS = 5000;
-// Time to wait after each GET_SOURCE_CAP / soft reset before the next recovery step
-static constexpr uint32_t SOURCE_CAP_RETRY_MS = 2500;
-// Upper bound on back-to-back interrupt handling while INT_N stays asserted
-static constexpr uint8_t MAX_IRQ_ROUNDS = 8;
-// BC_LVL is read this many extra times to confirm a stable measurement
-static constexpr uint8_t CC_STABLE_READS = 5;
-static constexpr uint8_t CC_LEVEL_UNSTABLE = 0xFF;
-
-void IRAM_ATTR FUSB302B::gpio_intr(FUSB302B *arg) {
-  TaskHandle_t handle = arg->task_.get_handle();
-  if (handle == nullptr)
-    return;
-  BaseType_t woken = pdFALSE;
-  xTaskNotifyFromISR(handle, NOTIFY_IRQ, eSetBits, &woken);
-  portYIELD_FROM_ISR(woken);
-}
-
-void FUSB302B::task_func(void *arg) { static_cast<FUSB302B *>(arg)->run_task_(); }
-
-void FUSB302B::setup() {
-  uint8_t device_id = 0;
-  if (!this->read_byte(FUSB_DEVICE_ID, &device_id)) {
-    this->mark_failed(LOG_STR(ESP_LOG_MSG_COMM_FAIL));
-    return;
-  }
-  const uint8_t version = device_id & FUSB_DEVICE_ID_VERSION_MASK;
-  if (version != FUSB_DEVICE_ID_VERSION_A && version != FUSB_DEVICE_ID_VERSION_B) {
-    ESP_LOGE(TAG, "Unknown device ID 0x%02X", device_id);
-    this->mark_failed();
-    return;
-  }
-  ESP_LOGD(TAG, "Device ID 0x%02X (product %u, revision %u)", device_id, (device_id >> 2) & 0x3, device_id & 0x3);
-  if (!this->init_chip_()) {
-    this->mark_failed(LOG_STR("Initialization failed"));
-    return;
-  }
-
-  this->interrupt_pin_->setup();
-  // The task must exist before the interrupt is attached, since the ISR notifies it
-  if (!this->task_.create(FUSB302B::task_func, "fusb302b", TASK_STACK_SIZE, this, TASK_PRIORITY, false)) {
-    this->mark_failed(LOG_STR("Failed to create task"));
-    return;
-  }
-  this->interrupt_pin_->attach_interrupt(&FUSB302B::gpio_intr, this, gpio::INTERRUPT_FALLING_EDGE);
-}
-
-void FUSB302B::dump_config() {
-  ESP_LOGCONFIG(TAG,
-                "FUSB302B:\n"
-                "  Request Voltage: %u V",
-                this->get_request_voltage());
-  LOG_I2C_DEVICE(this);
-  LOG_PIN("  Interrupt Pin: ", this->interrupt_pin_);
-}
-
-void FUSB302B::on_shutdown() {
-  this->interrupt_pin_->detach_interrupt();
-  // The task parks itself instead of being deleted, so it can never be stopped in the middle of an I2C transfer
-  if (this->task_.is_created())
-    xTaskNotify(this->task_.get_handle(), NOTIFY_STOP, eSetBits);
-}
-
-void FUSB302B::run_task_() {
-  // Give the source time to settle after power-up before the first CC measurement
-  vTaskDelay(pdMS_TO_TICKS(STARTUP_DELAY_MS));
-
-  while (true) {
-    uint32_t wait_ms = CC_POLL_INTERVAL_MS;
-    if (this->attached_) {
-      const bool busy = this->waiting_for_source_caps_ || this->retry_request_pending_ || this->check_ams_();
-      wait_ms = busy ? PD_POLL_INTERVAL_MS : IDLE_POLL_INTERVAL_MS;
-    }
-    uint32_t bits = 0;
-    xTaskNotifyWait(0, UINT32_MAX, &bits, pdMS_TO_TICKS(wait_ms));
-
-    if (bits & NOTIFY_STOP) {
-      while (true)
-        vTaskSuspend(nullptr);
-    }
-
-    // INT_N is held low until the interrupt registers are read, so a new event that arrives while it is
-    // already low has no falling edge: keep servicing while the pin stays asserted.
-    if (bits & NOTIFY_IRQ)
-      this->handle_interrupt_();
-    for (uint8_t i = 0; i < MAX_IRQ_ROUNDS && !this->interrupt_pin_->digital_read(); i++)
-      this->handle_interrupt_();
-
-    if (!this->attached_) {
-      this->try_attach_();
-      continue;
-    }
-    this->check_transition_timeout_();
-    this->check_request_retry_();
-    this->check_source_caps_();
-  }
-}
-
-bool FUSB302B::init_chip_() {
-  // Software reset restores all registers to their defaults
-  if (!this->write_byte(FUSB_RESET, FUSB_RESET_SW_RES))
-    return false;
-  if (!this->reset_pd_())
-    return false;
-
-  // Unmask the interrupts used for PD messaging and VBUS changes
-  if (!this->write_byte(FUSB_MASK1, FUSB_MASK1_DEFAULT) || !this->write_byte(FUSB_MASKA, 0) ||
-      !this->write_byte(FUSB_MASKB, 0))
-    return false;
-
-  // Let the chip retransmit unacknowledged messages up to 3 times
-  uint8_t control3 = 0;
-  if (!this->read_byte(FUSB_CONTROL3, &control3))
-    return false;
-  control3 =
-      (control3 & ~FUSB_CONTROL3_N_RETRIES_MASK) | (3 << FUSB_CONTROL3_N_RETRIES_SHIFT) | FUSB_CONTROL3_AUTO_RETRY;
-  if (!this->write_byte(FUSB_CONTROL3, control3))
-    return false;
-
-  if (!this->write_byte(FUSB_POWER, FUSB_POWER_ALL))
-    return false;
-  return this->reset_pd_();
-}
-
-bool FUSB302B::reset_pd_() {
-  this->reset_protocol_();
-  // Writing CONTROL0 as a whole byte also clears INT_MASK, which is what enables the INT_N pin
-  return this->write_byte(FUSB_CONTROL0, FUSB_CONTROL0_TX_FLUSH) &&
-         this->write_byte(FUSB_CONTROL1, FUSB_CONTROL1_RX_FLUSH) && this->write_byte(FUSB_RESET, FUSB_RESET_PD_RESET);
-}
-
-bool FUSB302B::enable_auto_crc_() {
-  uint8_t switches1 = 0;
-  return this->read_byte(FUSB_SWITCHES1, &switches1) &&
-         this->write_byte(FUSB_SWITCHES1, switches1 | FUSB_SWITCHES1_AUTO_CRC);
-}
-
-void FUSB302B::handle_interrupt_() {
-  // STATUS0A, STATUS1A, INTERRUPTA, INTERRUPTB, STATUS0, STATUS1, INTERRUPT; reading clears the interrupts
-  uint8_t regs[7];
-  if (this->read_register(FUSB_STATUS0A, regs, sizeof(regs)) != i2c::ERROR_OK) {
-    this->enter_error_();
-    return;
-  }
-  const uint8_t interrupta = regs[2];
-  const uint8_t status0 = regs[4];
-  uint8_t status1 = regs[5];
-  const uint8_t interrupt = regs[6];
-
-  if ((interrupt & FUSB_INTERRUPT_I_VBUSOK) && !(status0 & FUSB_STATUS0_VBUSOK)) {
-    if (this->attached_)
-      this->detach_();
-    return;
-  }
-  if (interrupta & FUSB_INTERRUPTA_I_HARDRST) {
-    if (this->attached_)
-      this->handle_hard_reset_();
-    return;
-  }
-  if (interrupta & FUSB_INTERRUPTA_I_SOFTRST) {
-    ESP_LOGV(TAG, "Soft reset received");
-  }
-  if ((interrupta & FUSB_INTERRUPTA_I_RETRYFAIL) && this->attached_)
-    this->handle_transmit_failed_();
-
-  if (!this->attached_)
-    return;
-  PdMsg msg;
-  while (!(status1 & FUSB_STATUS1_RX_EMPTY)) {
-    bool is_sop = false;
-    if (!this->read_message_(msg, is_sop)) {
-      ESP_LOGW(TAG, "Reading message failed");
-      // A partial read leaves the FIFO misaligned
-      this->write_byte(FUSB_CONTROL1, FUSB_CONTROL1_RX_FLUSH);
-      return;
-    }
-    // Only SOP packets are addressed to a sink; SOP'/SOP'' are for cable plugs
-    if (is_sop)
-      this->handle_message_(msg);
-    if (!this->read_byte(FUSB_STATUS1, &status1))
-      return;
-  }
-}
-
-bool FUSB302B::read_message_(PdMsg &msg, bool &is_sop) {
-  uint8_t token = 0;
-  uint8_t header[2];
-  if (!this->read_byte(FUSB_FIFOS, &token) || this->read_register(FUSB_FIFOS, header, 2) != i2c::ERROR_OK)
-    return false;
-  msg.set_header(encode_uint16(header[1], header[0]));
-
-  // Data objects, followed by the CRC32 that the chip already checked
-  uint8_t buf[PD_MAX_NUM_DATA_OBJECTS * 4 + 4];
-  if (this->read_register(FUSB_FIFOS, buf, msg.num_of_obj * 4 + 4) != i2c::ERROR_OK)
-    return false;
-  for (uint8_t i = 0; i < msg.num_of_obj; i++) {
-    const uint8_t *obj = &buf[i * 4];
-    msg.data_objects[i] = encode_uint32(obj[3], obj[2], obj[1], obj[0]);
-  }
-  is_sop = (token & FUSB_FIFO_RX_TOKEN_BITS) == FUSB_FIFO_RX_SOP;
-  return true;
-}
-
-bool FUSB302B::send_message(const PdMsg &msg) {
-  // Register address, then the TX tokens; written in one transfer without the copy write_register() makes
-  uint8_t buf[1 + 4 + 1 + 2 + PD_MAX_NUM_DATA_OBJECTS * 4 + 4];
-  size_t len = 0;
-  const uint16_t header = msg.get_coded_header();
-
-  buf[len++] = FUSB_FIFOS;
-  buf[len++] = FUSB_TX_TOKEN_SYNC1;
-  buf[len++] = FUSB_TX_TOKEN_SYNC1;
-  buf[len++] = FUSB_TX_TOKEN_SYNC1;
-  buf[len++] = FUSB_TX_TOKEN_SYNC2;
-  buf[len++] = FUSB_TX_TOKEN_PACKSYM | (msg.num_of_obj * 4 + 2);
-  buf[len++] = header & 0xFF;
-  buf[len++] = header >> 8;
-  for (uint8_t i = 0; i < msg.num_of_obj; i++) {
-    const uint32_t obj = msg.data_objects[i];
-    buf[len++] = obj & 0xFF;
-    buf[len++] = (obj >> 8) & 0xFF;
-    buf[len++] = (obj >> 16) & 0xFF;
-    buf[len++] = obj >> 24;
-  }
-  buf[len++] = FUSB_TX_TOKEN_JAM_CRC;
-  buf[len++] = FUSB_TX_TOKEN_EOP;
-  buf[len++] = FUSB_TX_TOKEN_TXOFF;
-  buf[len++] = FUSB_TX_TOKEN_TXON;
-
-  i2c::ErrorCode err = this->write(buf, len);
-  if (err != i2c::ERROR_OK) {
-    ESP_LOGW(TAG, "Sending message type %u failed (error %d)", msg.type, static_cast<int>(err));
-    return false;
-  }
-  return true;
-}
-
-bool FUSB302B::measure_cc_(uint8_t meas_switch, uint8_t &level) {
-  if (!this->write_byte(FUSB_SWITCHES0, FUSB_SWITCHES0_PDWN_1 | FUSB_SWITCHES0_PDWN_2 | meas_switch))
-    return false;
-  vTaskDelay(pdMS_TO_TICKS(CC_SETTLE_MS));
-  uint8_t status0 = 0;
-  if (!this->read_byte(FUSB_STATUS0, &status0))
-    return false;
-  level = status0 & FUSB_STATUS0_BC_LVL;
-  for (uint8_t i = 0; i < CC_STABLE_READS; i++) {
-    if (!this->read_byte(FUSB_STATUS0, &status0))
-      return false;
-    if ((status0 & FUSB_STATUS0_BC_LVL) != level) {
-      level = CC_LEVEL_UNSTABLE;
-      return true;
-    }
-  }
-  return true;
-}
-
-void FUSB302B::try_attach_() {
-  if (this->state_ == PdState::PD_STATE_ERROR) {
-    if (!this->init_chip_())
-      return;
-    ESP_LOGI(TAG, "Communication restored");
-    this->set_state_(PdState::PD_STATE_DISCONNECTED);
-  }
-
-  uint8_t status0 = 0;
-  if (!this->write_byte(FUSB_POWER, FUSB_POWER_ALL) || !this->read_byte(FUSB_STATUS0, &status0)) {
-    this->enter_error_();
-    return;
-  }
-  // A source may present its CC pull-up before VBUS is on; detach is only detected when VBUS drops
-  if (!(status0 & FUSB_STATUS0_VBUSOK)) {
-    this->cc_ambiguous_logged_ = false;
-    return;
-  }
-
-  uint8_t cc1 = 0;
-  uint8_t cc2 = 0;
-  if (!this->write_byte(FUSB_SWITCHES1, FUSB_SWITCHES1_SPECREV_REV2) ||
-      !this->write_byte(FUSB_MEASURE, FUSB_MEASURE_MDAC_CC) || !this->measure_cc_(FUSB_SWITCHES0_MEAS_CC1, cc1) ||
-      !this->measure_cc_(FUSB_SWITCHES0_MEAS_CC2, cc2)) {
-    this->enter_error_();
-    return;
-  }
-  // Exactly one CC line carries the source pull-up; the other one is open
-  uint8_t meas_switch;
-  uint8_t tx_switch;
-  if (cc1 != CC_LEVEL_UNSTABLE && cc1 > 0 && cc2 == 0) {
-    meas_switch = FUSB_SWITCHES0_MEAS_CC1;
-    tx_switch = FUSB_SWITCHES1_TXCC1;
-  } else if (cc2 != CC_LEVEL_UNSTABLE && cc2 > 0 && cc1 == 0) {
-    meas_switch = FUSB_SWITCHES0_MEAS_CC2;
-    tx_switch = FUSB_SWITCHES1_TXCC2;
-  } else {
-    if (!this->cc_ambiguous_logged_) {
-      ESP_LOGD(TAG, "VBUS present but no single CC line with a source pull-up (CC1 %u, CC2 %u)", cc1, cc2);
-      this->cc_ambiguous_logged_ = true;
-    }
-    return;
-  }
-
-  if (!this->write_byte(FUSB_SWITCHES0, FUSB_SWITCHES0_PDWN_1 | FUSB_SWITCHES0_PDWN_2 | meas_switch) ||
-      !this->write_byte(FUSB_SWITCHES1, tx_switch | FUSB_SWITCHES1_SPECREV_REV2) || !this->enable_auto_crc_() ||
-      !this->reset_pd_()) {
-    this->enter_error_();
-    return;
-  }
-  ESP_LOGD(TAG, "Attached on CC%u", meas_switch == FUSB_SWITCHES0_MEAS_CC1 ? 1 : 2);
-  this->attached_ = true;
-  this->cc_ambiguous_logged_ = false;
-  this->start_source_cap_wait_(SourceCapStep::SOURCE_CAP_STEP_WAIT);
-  this->set_state_and_contract_(PdState::PD_STATE_DEFAULT_CONTRACT, DEFAULT_CONTRACT);
-}
-
-void FUSB302B::detach_() {
-  ESP_LOGD(TAG, "Detached (VBUS lost)");
-  this->attached_ = false;
-  this->waiting_for_source_caps_ = false;
-  this->reset_pd_();
-  this->clear_contract_();
-  this->set_state_(PdState::PD_STATE_DISCONNECTED);
-}
-
-void FUSB302B::handle_hard_reset_() {
-  ESP_LOGD(TAG, "Hard reset received");
-  // The source returns to Type-C default power and sends its capabilities again
-  // Also flushes the RX FIFO, so the caller has nothing left to read
-  if (!this->reset_pd_()) {
-    this->enter_error_();
-    return;
-  }
-  this->set_state_and_contract_(PdState::PD_STATE_DEFAULT_CONTRACT, DEFAULT_CONTRACT);
-  this->start_source_cap_wait_(SourceCapStep::SOURCE_CAP_STEP_WAIT);
-}
-
-void FUSB302B::enter_error_() {
-  if (this->state_ == PdState::PD_STATE_ERROR)
-    return;
-  ESP_LOGW(TAG, "Communication with the chip failed");
-  this->attached_ = false;
-  this->waiting_for_source_caps_ = false;
-  this->clear_contract_();
-  this->set_state_(PdState::PD_STATE_ERROR);
-}
-
-void FUSB302B::send_soft_reset_() {
-  this->reset_pd_();
-  this->send_message(this->make_control_msg_(PD_CNTRL_SOFT_RESET));
-  // The source answers a soft reset with new source capabilities
-  this->start_source_cap_wait_(SourceCapStep::SOURCE_CAP_STEP_SOFT_RESET_SENT);
-}
-
-void FUSB302B::start_source_cap_wait_(SourceCapStep step) {
-  this->waiting_for_source_caps_ = true;
-  this->source_cap_step_ = step;
-  this->source_cap_step_start_ = millis();
-}
-
-void FUSB302B::check_source_caps_() {
-  if (!this->waiting_for_source_caps_ || this->check_ams_())
-    return;
-  const uint32_t elapsed = millis() - this->source_cap_step_start_;
-  switch (this->source_cap_step_) {
-    case SourceCapStep::SOURCE_CAP_STEP_WAIT:
-      if (elapsed < SOURCE_CAP_WAIT_MS)
-        return;
-      ESP_LOGD(TAG, "No source capabilities received, requesting them");
-      this->send_message(this->make_control_msg_(PD_CNTRL_GET_SOURCE_CAP));
-      this->source_cap_step_ = SourceCapStep::SOURCE_CAP_STEP_GET_SENT;
-      break;
-    case SourceCapStep::SOURCE_CAP_STEP_GET_SENT:
-      if (elapsed < SOURCE_CAP_RETRY_MS)
-        return;
-      ESP_LOGD(TAG, "No source capabilities received, sending soft reset");
-      this->send_soft_reset_();
-      return;
-    case SourceCapStep::SOURCE_CAP_STEP_SOFT_RESET_SENT:
-      if (elapsed < SOURCE_CAP_RETRY_MS)
-        return;
-      ESP_LOGW(TAG, "PD negotiation failed, staying at 5 V");
-      this->waiting_for_source_caps_ = false;
-      this->set_state_(PdState::PD_STATE_PD_TIMEOUT);
-      return;
-  }
-  this->source_cap_step_start_ = millis();
-}
-
-}  // namespace esphome::fusb302b
-
-#endif  // USE_ESP32

esphome/components/fusb302b/fusb302b.h

@@ -1,74 +0,0 @@
-#pragma once
-
-#ifdef USE_ESP32
-
-#include "esphome/components/i2c/i2c.h"
-#include "esphome/core/component.h"
-#include "esphome/core/defines.h"
-#include "esphome/core/hal.h"
-#include "esphome/core/helpers.h"
-#include "esphome/core/static_task.h"
-
-#include "pd.h"
-
-namespace esphome::fusb302b {
-
-/// FUSB302B USB Type-C / Power Delivery sink controller.
-///
-/// A dedicated task owns all I2C traffic to the chip so that PD replies meet the protocol timing
-/// even while the main loop is busy.
-class FUSB302B : public PowerDelivery, public Component, public i2c::I2CDevice {
- public:
-  explicit FUSB302B(InternalGPIOPin *interrupt_pin) : interrupt_pin_(interrupt_pin) {}
-
-  void setup() override;
-  void dump_config() override;
-  void on_shutdown() override;
-  float get_setup_priority() const override { return setup_priority::HARDWARE; }
-
- protected:
-  enum class SourceCapStep : uint8_t {
-    SOURCE_CAP_STEP_WAIT,
-    SOURCE_CAP_STEP_GET_SENT,
-    SOURCE_CAP_STEP_SOFT_RESET_SENT,
-  };
-
-  static void gpio_intr(FUSB302B *arg);
-  static void task_func(void *arg);
-
-  bool send_message(const PdMsg &msg) override;
-  void on_state_changed() override {}
-  void on_soft_reset_received() override { this->start_source_cap_wait_(SourceCapStep::SOURCE_CAP_STEP_WAIT); }
-  void on_source_caps_received() override { this->waiting_for_source_caps_ = false; }
-  void on_transition_timeout() override { this->send_soft_reset_(); }
-
-  // PHY task only
-  [[noreturn]] void run_task_();
-  bool init_chip_();
-  bool reset_pd_();
-  bool enable_auto_crc_();
-  void handle_interrupt_();
-  bool read_message_(PdMsg &msg, bool &is_sop);
-  void try_attach_();
-  bool measure_cc_(uint8_t meas_switch, uint8_t &level);
-  void detach_();
-  void handle_hard_reset_();
-  void start_source_cap_wait_(SourceCapStep step);
-  void send_soft_reset_();
-  void check_source_caps_();
-  void enter_error_();
-
-  InternalGPIOPin *interrupt_pin_;
-  StaticTask task_;
-
-  // PHY task only
-  uint32_t source_cap_step_start_{0};
-  SourceCapStep source_cap_step_{SourceCapStep::SOURCE_CAP_STEP_WAIT};
-  bool attached_{false};
-  bool waiting_for_source_caps_{false};
-  bool cc_ambiguous_logged_{false};
-};
-
-}  // namespace esphome::fusb302b
-
-#endif  // USE_ESP32

esphome/components/fusb302b/fusb302b_registers.h

@@ -1,94 +0,0 @@
-#pragma once
-
-#include <cstdint>
-
-namespace esphome::fusb302b {
-
-// Register addresses
-static constexpr uint8_t FUSB_DEVICE_ID = 0x01;
-static constexpr uint8_t FUSB_SWITCHES0 = 0x02;
-static constexpr uint8_t FUSB_SWITCHES1 = 0x03;
-static constexpr uint8_t FUSB_MEASURE = 0x04;
-static constexpr uint8_t FUSB_CONTROL0 = 0x06;
-static constexpr uint8_t FUSB_CONTROL1 = 0x07;
-static constexpr uint8_t FUSB_CONTROL3 = 0x09;
-static constexpr uint8_t FUSB_MASK1 = 0x0A;
-static constexpr uint8_t FUSB_POWER = 0x0B;
-static constexpr uint8_t FUSB_RESET = 0x0C;
-static constexpr uint8_t FUSB_MASKA = 0x0E;
-static constexpr uint8_t FUSB_MASKB = 0x0F;
-static constexpr uint8_t FUSB_STATUS0A = 0x3C;
-static constexpr uint8_t FUSB_STATUS0 = 0x40;
-static constexpr uint8_t FUSB_STATUS1 = 0x41;
-static constexpr uint8_t FUSB_FIFOS = 0x43;
-
-// DEVICE_ID: version in bits 7:4, product variant (I2C address 0x22-0x25) in bits 3:2, silicon revision in bits 1:0
-static constexpr uint8_t FUSB_DEVICE_ID_VERSION_MASK = 0xF0;
-static constexpr uint8_t FUSB_DEVICE_ID_VERSION_A = 0x80;
-static constexpr uint8_t FUSB_DEVICE_ID_VERSION_B = 0x90;
-
-// SWITCHES0 bits
-static constexpr uint8_t FUSB_SWITCHES0_MEAS_CC2 = 1 << 3;
-static constexpr uint8_t FUSB_SWITCHES0_MEAS_CC1 = 1 << 2;
-static constexpr uint8_t FUSB_SWITCHES0_PDWN_2 = 1 << 1;
-static constexpr uint8_t FUSB_SWITCHES0_PDWN_1 = 1 << 0;
-
-// SWITCHES1 bits
-static constexpr uint8_t FUSB_SWITCHES1_SPECREV_REV2 = 0x01 << 5;
-static constexpr uint8_t FUSB_SWITCHES1_AUTO_CRC = 1 << 2;
-static constexpr uint8_t FUSB_SWITCHES1_TXCC2 = 1 << 1;
-static constexpr uint8_t FUSB_SWITCHES1_TXCC1 = 1 << 0;
-
-// MEASURE value used for CC detection
-static constexpr uint8_t FUSB_MEASURE_MDAC_CC = 49;
-
-// CONTROL0 bits
-static constexpr uint8_t FUSB_CONTROL0_TX_FLUSH = 1 << 6;
-
-// CONTROL1 bits
-static constexpr uint8_t FUSB_CONTROL1_RX_FLUSH = 1 << 2;
-
-// CONTROL3 bits
-static constexpr uint8_t FUSB_CONTROL3_N_RETRIES_SHIFT = 1;
-static constexpr uint8_t FUSB_CONTROL3_N_RETRIES_MASK = 0x3 << FUSB_CONTROL3_N_RETRIES_SHIFT;
-static constexpr uint8_t FUSB_CONTROL3_AUTO_RETRY = 1 << 0;
-
-// MASK1: mask the ACTIVITY, CRC_CHK and BC_LVL interrupts
-static constexpr uint8_t FUSB_MASK1_DEFAULT = 0x51;
-
-// POWER bits
-static constexpr uint8_t FUSB_POWER_ALL = 0x0F;
-
-// RESET bits
-static constexpr uint8_t FUSB_RESET_PD_RESET = 1 << 1;
-static constexpr uint8_t FUSB_RESET_SW_RES = 1 << 0;
-
-// INTERRUPTA bits
-static constexpr uint8_t FUSB_INTERRUPTA_I_RETRYFAIL = 1 << 4;
-static constexpr uint8_t FUSB_INTERRUPTA_I_SOFTRST = 1 << 1;
-static constexpr uint8_t FUSB_INTERRUPTA_I_HARDRST = 1 << 0;
-
-// INTERRUPT bits
-static constexpr uint8_t FUSB_INTERRUPT_I_VBUSOK = 1 << 7;
-
-// STATUS0 bits
-static constexpr uint8_t FUSB_STATUS0_VBUSOK = 1 << 7;
-static constexpr uint8_t FUSB_STATUS0_BC_LVL = 0x03;
-
-// STATUS1 bits
-static constexpr uint8_t FUSB_STATUS1_RX_EMPTY = 1 << 5;
-
-// RX FIFO token
-static constexpr uint8_t FUSB_FIFO_RX_TOKEN_BITS = 0xE0;
-static constexpr uint8_t FUSB_FIFO_RX_SOP = 0xE0;
-
-// TX FIFO tokens
-static constexpr uint8_t FUSB_TX_TOKEN_TXON = 0xA1;
-static constexpr uint8_t FUSB_TX_TOKEN_SYNC1 = 0x12;
-static constexpr uint8_t FUSB_TX_TOKEN_SYNC2 = 0x13;
-static constexpr uint8_t FUSB_TX_TOKEN_PACKSYM = 0x80;
-static constexpr uint8_t FUSB_TX_TOKEN_JAM_CRC = 0xFF;
-static constexpr uint8_t FUSB_TX_TOKEN_EOP = 0x14;
-static constexpr uint8_t FUSB_TX_TOKEN_TXOFF = 0xFE;
-
-}  // namespace esphome::fusb302b

esphome/components/fusb302b/pd.cpp

@@ -1,330 +0,0 @@
-#include "pd.h"
-
-#include <cstring>
-
-#include "esphome/core/hal.h"
-#include "esphome/core/log.h"
-
-namespace esphome::fusb302b {
-
-ESPHOME_LOG_TAG(TAG, "fusb302b.pd");
-
-static constexpr uint32_t AMS_TIMEOUT_MS = 2000;
-// tSinkRequest: delay before repeating a request that the source answered with Wait
-static constexpr uint32_t SINK_REQUEST_MS = 100;
-static constexpr uint8_t MAX_WAIT_RETRIES = 10;
-
-// USB PD 6.4.1.3.1 Sink Fixed Supply Power Data Object flags; only the first (5 V) object carries them
-static constexpr uint32_t SINK_PDO_HIGHER_CAPABILITY = 1u << 28;
-static constexpr uint32_t SINK_PDO_USB_COMMS_CAPABLE = 1u << 26;
-// Operational current advertised for every sink object: 3 A (300 x 10 mA)
-static constexpr uint16_t SINK_PDO_CURRENT = 300;
-
-// USB PD 6.4.1.2.3 Source Fixed Supply Power Data Object; other PDO types only report their type
-static PdContract parse_pdo(uint32_t pdo) {
-  PdContract info{};
-  info.type = static_cast<PdPdoType>(pdo >> 30);
-  if (info.type == PD_PDO_TYPE_FIXED_SUPPLY) {
-    info.max_v = (pdo >> 10) & 0x3FF;
-    info.max_i = pdo & 0x3FF;
-  }
-  return info;
-}
-
-// USB PD 6.4.1.3.1 Sink Fixed Supply Power Data Object; voltage in 50 mV units, current in 10 mA units
-static constexpr uint32_t sink_fixed_pdo(uint16_t voltage, uint16_t current) {
-  return (static_cast<uint32_t>(PD_PDO_TYPE_FIXED_SUPPLY) << 30) | (static_cast<uint32_t>(voltage & 0x3FF) << 10) |
-         (current & 0x3FF);
-}
-
-void PdMsg::set_header(uint16_t header) {
-  this->type = header & 0x1F;
-  this->spec_rev = static_cast<PdSpecRevision>((header >> 6) & 0x3);
-  this->id = (header >> 9) & 0x7;
-  this->num_of_obj = (header >> 12) & 0x7;
-  this->extended = (header >> 15) & 0x1;
-}
-
-uint16_t PdMsg::get_coded_header() const {
-  // Data role UFP (bit 5 = 0), power role sink (bit 8 = 0)
-  return static_cast<uint16_t>(this->type & 0x1F) | (static_cast<uint16_t>(this->spec_rev) << 6) |
-         (static_cast<uint16_t>(this->id & 0x7) << 9) | (static_cast<uint16_t>(this->num_of_obj & 0x7) << 12) |
-         (static_cast<uint16_t>(this->extended) << 15);
-}
-
-PdMsg PowerDelivery::make_control_msg_(PdControlMsgType type) const {
-  PdMsg msg;
-  msg.type = type;
-  msg.id = this->msg_counter_ % 8;
-  return msg;
-}
-
-PdMsg PowerDelivery::make_data_msg_(PdDataMsgType type, const uint32_t *objects, uint8_t len) const {
-  PdMsg msg;
-  msg.type = type;
-  msg.id = this->msg_counter_ % 8;
-  msg.num_of_obj = len;
-  memcpy(msg.data_objects, objects, len * sizeof(uint32_t));
-  return msg;
-}
-
-void PowerDelivery::reset_protocol_() {
-  this->last_received_msg_id_ = 255;
-  this->msg_counter_ = 0;
-  this->active_ams_ = false;
-  this->ps_rdy_expected_ = false;
-  this->retry_request_pending_ = false;
-  this->wait_retries_ = 0;
-}
-
-void PowerDelivery::set_state_(PdState state) {
-  if (this->state_.exchange(state) != state)
-    this->on_state_changed();
-}
-
-void PowerDelivery::set_contract_(const PdContract &contract) {
-  this->accepted_contract_ = contract;
-  const uint32_t packed = PackedContract::from(contract).value;
-  if (this->contract_.exchange(packed) != packed)
-    this->on_state_changed();
-}
-
-void PowerDelivery::clear_contract_() {
-  this->accepted_contract_ = {};
-  if (this->contract_.exchange(0) != 0)
-    this->on_state_changed();
-}
-
-void PowerDelivery::set_state_and_contract_(PdState state, const PdContract &contract) {
-  this->accepted_contract_ = contract;
-  const uint32_t packed = PackedContract::from(contract).value;
-  // The contract is stored first, so a reader that sees the new state also sees the new contract
-  const bool contract_changed = this->contract_.exchange(packed) != packed;
-  const bool state_changed = this->state_.exchange(state) != state;
-  if (contract_changed || state_changed)
-    this->on_state_changed();
-}
-
-void PowerDelivery::set_ams_(bool active) {
-  this->active_ams_ = active;
-  // A new sequence has no accepted request yet, and an ended one can no longer complete
-  this->ps_rdy_expected_ = false;
-  if (active)
-    this->ams_start_ = millis();
-}
-
-bool PowerDelivery::check_ams_() {
-  if (this->active_ams_ && millis() - this->ams_start_ > AMS_TIMEOUT_MS)
-    this->set_ams_(false);
-  return this->active_ams_;
-}
-
-void PowerDelivery::check_request_retry_() {
-  if (!this->retry_request_pending_ || millis() - this->wait_received_ms_ < SINK_REQUEST_MS)
-    return;
-  if (this->send_request_()) {
-    this->retry_request_pending_ = false;
-  } else if (this->wait_retries_ < MAX_WAIT_RETRIES) {
-    // Try again after another tSinkRequest; failed attempts count against the same limit as Wait replies
-    this->wait_retries_++;
-    this->wait_received_ms_ = millis();
-  } else {
-    ESP_LOGW(TAG, "Giving up repeating the request");
-    this->retry_request_pending_ = false;
-    this->request_failed_();
-  }
-}
-
-bool PowerDelivery::send_request_() {
-  this->set_ams_(true);
-  if (this->send_message(this->make_data_msg_(PD_DATA_REQUEST, &this->last_rdo_, 1)))
-    return true;
-  ESP_LOGW(TAG, "Sending the request failed");
-  this->set_ams_(false);
-  return false;
-}
-
-void PowerDelivery::request_failed_() {
-  // A contract already in place stays valid. Without one, report that negotiation is over at default power.
-  if (this->state_ == PdState::PD_STATE_DEFAULT_CONTRACT)
-    this->set_state_(PdState::PD_STATE_PD_TIMEOUT);
-}
-
-void PowerDelivery::check_transition_timeout_() {
-  // The AMS that sent the request only ends on PS_RDY, so an ended AMS while in transition means a timeout
-  if (this->state_ != PdState::PD_STATE_TRANSITION || this->check_ams_())
-    return;
-  ESP_LOGW(TAG, "Source did not report the new supply ready, falling back to default power");
-  this->set_state_and_contract_(PdState::PD_STATE_DEFAULT_CONTRACT, DEFAULT_CONTRACT);
-  this->on_transition_timeout();
-}
-
-void PowerDelivery::handle_transmit_failed_() {
-  // USB PD 6.12.2.2: the counter also moves on after a failed transmission. The source may have received the
-  // message and only its GoodCRC was lost, so reusing the MessageID would make it drop the next one as a repeat.
-  ESP_LOGD(TAG, "Message %u not acknowledged", this->msg_counter_ % 8);
-  this->msg_counter_++;
-}
-
-void PowerDelivery::handle_message_(const PdMsg &msg) {
-  if (msg.num_of_obj == 0 && msg.type == PD_CNTRL_GOODCRC) {
-    // A GoodCRC carries the MessageID it acknowledges; a duplicate or stray one must not advance the counter
-    if (msg.id != this->msg_counter_ % 8) {
-      ESP_LOGD(TAG, "Ignoring GoodCRC for MessageID %u, expected %u", msg.id, this->msg_counter_ % 8);
-      return;
-    }
-    // Our last message was received, so the next one gets a new MessageID
-    this->msg_counter_++;
-    return;
-  }
-  // Soft_Reset always has MessageID 0, so it must not be dropped as a retransmission of the last message
-  if (msg.num_of_obj == 0 && msg.type == PD_CNTRL_SOFT_RESET) {
-    this->handle_soft_reset_(msg);
-    return;
-  }
-  // Retransmissions repeat the MessageID of a message that was already handled
-  if (msg.id == this->last_received_msg_id_)
-    return;
-  this->last_received_msg_id_ = msg.id;
-
-  if (msg.num_of_obj == 0) {
-    this->handle_control_message_(msg);
-  } else {
-    this->handle_data_message_(msg);
-  }
-}
-
-void PowerDelivery::handle_data_message_(const PdMsg &msg) {
-  if (msg.extended || msg.type != PD_DATA_SOURCE_CAP) {
-    // BIST and Vendor_Defined messages must not be answered with Reject, so unsupported data messages are ignored
-    ESP_LOGV(TAG, "Ignoring data message type %u%s", msg.type,
-             msg.extended ? LOG_STR_LITERAL(" (extended)") : LOG_STR_LITERAL(""));
-    return;
-  }
-  this->on_source_caps_received();
-  this->respond_to_source_caps_(msg);
-}
-
-void PowerDelivery::handle_control_message_(const PdMsg &msg) {
-  switch (msg.type) {
-    case PD_CNTRL_ACCEPT:
-      if (!this->check_ams_()) {
-        ESP_LOGD(TAG, "Ignoring Accept outside a request");
-        break;
-      }
-      this->ps_rdy_expected_ = true;
-      if (this->requested_contract_ != this->accepted_contract_)
-        this->set_state_and_contract_(PdState::PD_STATE_TRANSITION, this->requested_contract_);
-      break;
-    case PD_CNTRL_PS_RDY:
-      // check_ams_() first, so a PS_RDY that arrives after the sequence timed out is ignored too
-      if (!this->check_ams_() || !this->ps_rdy_expected_) {
-        ESP_LOGD(TAG, "Ignoring PS_RDY without an accepted request");
-        break;
-      }
-      this->set_ams_(false);
-      this->set_state_(PdState::PD_STATE_EXPLICIT_CONTRACT);
-      break;
-    case PD_CNTRL_REJECT:
-      if (!this->check_ams_()) {
-        ESP_LOGD(TAG, "Ignoring Reject outside a request");
-        break;
-      }
-      ESP_LOGW(TAG, "Source rejected the request");
-      this->set_ams_(false);
-      this->request_failed_();
-      break;
-    case PD_CNTRL_WAIT:
-      if (!this->check_ams_()) {
-        ESP_LOGD(TAG, "Ignoring Wait outside a request");
-        break;
-      }
-      this->set_ams_(false);
-      if (this->wait_retries_ < MAX_WAIT_RETRIES) {
-        ESP_LOGD(TAG, "Source asked to wait, repeating the request");
-        this->wait_retries_++;
-        this->retry_request_pending_ = true;
-        this->wait_received_ms_ = millis();
-      } else {
-        ESP_LOGW(TAG, "Source kept answering Wait, giving up");
-        this->request_failed_();
-      }
-      break;
-    case PD_CNTRL_PING:
-    case PD_CNTRL_NOT_SUPPORTED:
-      break;
-    case PD_CNTRL_GET_SINK_CAP: {
-      // 5 V first, then the requested voltage. Higher Capability tells the source that 5 V is not enough for
-      // full operation.
-      const uint16_t request_v = this->request_voltage_ * 20;  // 50 mV units
-      uint32_t pdos[2];
-      uint8_t count = 0;
-      pdos[count++] = sink_fixed_pdo(100, SINK_PDO_CURRENT) | SINK_PDO_USB_COMMS_CAPABLE |
-                      (request_v > 100 ? SINK_PDO_HIGHER_CAPABILITY : 0);
-      if (request_v > 100)
-        pdos[count++] = sink_fixed_pdo(request_v, SINK_PDO_CURRENT);
-      this->send_message(this->make_data_msg_(PD_DATA_SINK_CAP, pdos, count));
-      break;
-    }
-    default:
-      // Messages are sent as PD 2.0, which has no Not_Supported message
-      this->send_message(this->make_control_msg_(PD_CNTRL_REJECT));
-      break;
-  }
-}
-
-void PowerDelivery::handle_soft_reset_(const PdMsg &msg) {
-  this->reset_protocol_();
-  this->last_received_msg_id_ = msg.id;
-  // If this fails the source escalates to a hard reset. The hook still runs, so the PHY starts waiting for source
-  // capabilities and recovers on its own if neither follows.
-  if (!this->send_message(this->make_control_msg_(PD_CNTRL_ACCEPT))) {
-    ESP_LOGW(TAG, "Accepting the soft reset failed");
-  }
-  // A soft reset keeps the power level, but the outcome of a transition in progress is unknown
-  if (this->state_ == PdState::PD_STATE_TRANSITION)
-    this->set_state_and_contract_(PdState::PD_STATE_DEFAULT_CONTRACT, DEFAULT_CONTRACT);
-  this->on_soft_reset_received();
-}
-
-void PowerDelivery::respond_to_source_caps_(const PdMsg &msg) {
-  // Pick the highest fixed supply PDO that does not exceed the requested voltage.
-  // The first PDO is always the 5 V fixed supply.
-  const uint16_t request_v = this->request_voltage_ * 20;  // 50 mV units
-  PdContract selected{};
-  uint8_t position = 0;  // 1-based object position, 0 = none
-  for (uint8_t idx = 0; idx < msg.num_of_obj; idx++) {
-    PdContract info = parse_pdo(msg.data_objects[idx]);
-    if (info.type != PD_PDO_TYPE_FIXED_SUPPLY)
-      continue;
-    if (position == 0 || (info.max_v <= request_v && info.max_v > selected.max_v)) {
-      selected = info;
-      position = idx + 1;
-    }
-  }
-
-  // USB PD 6.4.2 Request Data Object: no USB suspend (bit 24), USB communications capable (bit 25)
-  uint32_t rdo = (1u << 24) | (1u << 25);
-  if (position == 0) {
-    ESP_LOGW(TAG, "No usable PDO in source capabilities, requesting 5 V");
-    // Object 1 (5 V fixed supply), 300 mA maximum, 100 mA operating current
-    selected = PdContract{PD_PDO_TYPE_FIXED_SUPPLY, 100, 30};
-    position = 1;
-    rdo |= (30u << 0) | (10u << 10);
-  } else {
-    // Request the full current the source offers
-    const uint32_t current = selected.max_i;
-    rdo |= (current << 0) | (current << 10);
-  }
-  rdo |= static_cast<uint32_t>(position) << 28;
-  ESP_LOGD(TAG, "Requesting PDO %u: %.2f V", position, selected.max_v * 0.05f);
-  this->requested_contract_ = selected;
-  this->last_rdo_ = rdo;
-  this->retry_request_pending_ = false;
-  this->wait_retries_ = 0;
-  // A repeat would come too late: the source resets if it gets no Request within tSenderResponse (24-30 ms)
-  if (!this->send_request_())
-    this->request_failed_();
-}
-
-}  // namespace esphome::fusb302b

esphome/components/fusb302b/pd.h

@@ -1,179 +0,0 @@
-#pragma once
-
-#include <algorithm>
-#include <atomic>
-#include <cstddef>
-#include <cstdint>
-
-namespace esphome::fusb302b {
-
-static constexpr uint8_t PD_MAX_NUM_DATA_OBJECTS = 7;
-// Standard Power Range fixed supplies, which are the only ones this sink negotiates
-static constexpr uint8_t MIN_REQUEST_VOLTAGE = 5;
-static constexpr uint8_t MAX_REQUEST_VOLTAGE = 20;
-
-enum PdSpecRevision : uint8_t {
-  PD_SPEC_REV_1 = 0,
-  PD_SPEC_REV_2 = 1,
-  PD_SPEC_REV_3 = 2,
-};
-
-enum PdDataMsgType : uint8_t {
-  PD_DATA_SOURCE_CAP = 0x01,
-  PD_DATA_REQUEST = 0x02,
-  PD_DATA_SINK_CAP = 0x04,
-};
-
-enum PdControlMsgType : uint8_t {
-  PD_CNTRL_GOODCRC = 0x01,
-  PD_CNTRL_ACCEPT = 0x03,
-  PD_CNTRL_REJECT = 0x04,
-  PD_CNTRL_PING = 0x05,
-  PD_CNTRL_PS_RDY = 0x06,
-  PD_CNTRL_GET_SOURCE_CAP = 0x07,
-  PD_CNTRL_GET_SINK_CAP = 0x08,
-  PD_CNTRL_WAIT = 0x0C,
-  PD_CNTRL_SOFT_RESET = 0x0D,
-  PD_CNTRL_NOT_SUPPORTED = 0x10,
-};
-
-enum PdPdoType : uint8_t {
-  PD_PDO_TYPE_FIXED_SUPPLY = 0,
-  PD_PDO_TYPE_BATTERY = 1,
-  PD_PDO_TYPE_VARIABLE_SUPPLY = 2,
-  PD_PDO_TYPE_AUGMENTED = 3,
-};
-
-enum class PdState : uint8_t {
-  PD_STATE_DISCONNECTED,
-  /// Negotiation is over without a PD contract (no capabilities, or the request was not accepted); the source
-  /// supplies Type-C default power.
-  PD_STATE_PD_TIMEOUT,
-  PD_STATE_DEFAULT_CONTRACT,
-  PD_STATE_TRANSITION,
-  PD_STATE_EXPLICIT_CONTRACT,
-  PD_STATE_ERROR,
-};
-
-/// Returns true for the states in which a source is attached and supplying power.
-inline bool is_connected_state(PdState state) {
-  return state == PdState::PD_STATE_DEFAULT_CONTRACT || state == PdState::PD_STATE_TRANSITION ||
-         state == PdState::PD_STATE_EXPLICIT_CONTRACT || state == PdState::PD_STATE_PD_TIMEOUT;
-}
-
-struct PdContract {
-  PdPdoType type{PD_PDO_TYPE_FIXED_SUPPLY};
-  uint16_t max_v{0};  // 50 mV units
-  uint16_t max_i{0};  // 10 mA units
-
-  bool operator==(const PdContract &other) const {
-    return this->max_v == other.max_v && this->max_i == other.max_i && this->type == other.type;
-  }
-  bool operator!=(const PdContract &other) const { return !(*this == other); }
-};
-
-// Type-C default power: 5 V (100 x 50 mV) at 500 mA (50 x 10 mA)
-static constexpr PdContract DEFAULT_CONTRACT{PD_PDO_TYPE_FIXED_SUPPLY, 100, 50};
-
-/// A contract packed into one word so it can be shared between tasks as an atomic.
-/// 0 means there is no contract (nothing attached).
-struct PackedContract {
-  uint32_t value{0};
-
-  static PackedContract from(const PdContract &contract) {
-    return {(static_cast<uint32_t>(contract.max_v) << 16) | contract.max_i};
-  }
-  bool is_set() const { return this->value != 0; }
-  float voltage() const { return (this->value >> 16) * 0.05f; }
-  float current() const { return (this->value & 0xFFFF) * 0.01f; }
-};
-
-struct PdMsg {
-  uint8_t type{0};
-  PdSpecRevision spec_rev{PD_SPEC_REV_2};
-  uint8_t id{0};
-  uint8_t num_of_obj{0};
-  bool extended{false};
-  uint32_t data_objects[PD_MAX_NUM_DATA_OBJECTS]{};
-
-  void set_header(uint16_t header);
-  uint16_t get_coded_header() const;
-};
-
-/// USB-PD sink protocol logic, independent of the PHY chip.
-/// Everything except the getters and set_request_voltage() runs in the PHY task, which must also call
-/// check_transition_timeout_() and check_request_retry_() regularly; the protocol has no timers of its own.
-class PowerDelivery {
- public:
-  void set_request_voltage(uint8_t voltage) {
-    this->request_voltage_ = std::clamp(voltage, MIN_REQUEST_VOLTAGE, MAX_REQUEST_VOLTAGE);
-  }
-  uint8_t get_request_voltage() const { return this->request_voltage_; }
-
-  PdState get_state() const { return this->state_; }
-  bool is_connected() const { return is_connected_state(this->state_); }
-
- protected:
-  /// Returns false when the message could not be handed to the chip; the PHY logs the failure.
-  virtual bool send_message(const PdMsg &msg) = 0;
-  /// Called after state_ or contract_ changed, to let the main loop publish it.
-  virtual void on_state_changed() = 0;
-  /// Called after the source soft reset the protocol; it sends new source capabilities next.
-  virtual void on_soft_reset_received() = 0;
-  /// Called when source capabilities arrive, before the request for them is sent.
-  virtual void on_source_caps_received() = 0;
-  /// Called after an accepted request was not followed by PS_RDY in time and the state fell back to default power;
-  /// the PHY sends a soft reset so the source offers its capabilities again.
-  virtual void on_transition_timeout() = 0;
-
-  void handle_message_(const PdMsg &msg);
-  /// Called by the PHY when the chip gave up on a message after its retries without receiving a GoodCRC.
-  void handle_transmit_failed_();
-  void reset_protocol_();
-  void set_state_(PdState state);
-  void set_contract_(const PdContract &contract);
-  void clear_contract_();
-  /// Stores both before calling on_state_changed() once, so the main loop never sees the new state with the old
-  /// contract.
-  void set_state_and_contract_(PdState state, const PdContract &contract);
-  void set_ams_(bool active);
-  /// Returns true while an atomic message sequence is in progress; ends it after a timeout.
-  bool check_ams_();
-  /// Falls back to default power when the source accepted a request but did not report the new supply ready in time.
-  void check_transition_timeout_();
-  /// Sends the last request again once tSinkRequest has passed after the source answered Wait.
-  void check_request_retry_();
-
-  PdMsg make_control_msg_(PdControlMsgType type) const;
-  PdMsg make_data_msg_(PdDataMsgType type, const uint32_t *objects, uint8_t len) const;
-
-  // Shared with the main loop
-  std::atomic<PdState> state_{PdState::PD_STATE_DISCONNECTED};
-  std::atomic<uint32_t> contract_{0};
-  std::atomic<uint8_t> request_voltage_{5};
-
-  // PHY task only
-  uint32_t ams_start_{0};
-  uint32_t wait_received_ms_{0};
-  bool retry_request_pending_{false};
-
- private:
-  void handle_data_message_(const PdMsg &msg);
-  void handle_control_message_(const PdMsg &msg);
-  void handle_soft_reset_(const PdMsg &msg);
-  void respond_to_source_caps_(const PdMsg &msg);
-  bool send_request_();
-  void request_failed_();
-
-  PdContract requested_contract_{};
-  PdContract accepted_contract_{};
-  uint32_t last_rdo_{0};
-  bool active_ams_{false};
-  // Set by Accept; PS_RDY is only valid after the source accepted the request of the current sequence
-  bool ps_rdy_expected_{false};
-  uint8_t last_received_msg_id_{255};
-  uint8_t msg_counter_{0};
-  uint8_t wait_retries_{0};
-};
-
-}  // namespace esphome::fusb302b

esphome/components/haier/hon_climate.cpp

@@ -2,8 +2,6 @@
 #include <string>
 #include "esphome/components/climate/climate.h"
 #include "esphome/components/uart/uart.h"
-#include "esphome/core/application.h"
-#include "esphome/core/hal.h"
 #include "esphome/core/helpers.h"
 #include "esphome/core/progmem.h"
 #include "hon_climate.h"
@@ -14,26 +12,6 @@ using namespace esphome::uart;
 
 namespace esphome::haier {
 
-static bool vertical_axis_is_auto(climate::ClimateSwingMode swing_mode) {
-  return (swing_mode == climate::CLIMATE_SWING_VERTICAL) || (swing_mode == climate::CLIMATE_SWING_BOTH);
-}
-
-static bool horizontal_axis_is_auto(climate::ClimateSwingMode swing_mode) {
-  return (swing_mode == climate::CLIMATE_SWING_HORIZONTAL) || (swing_mode == climate::CLIMATE_SWING_BOTH);
-}
-
-static bool is_auto(hon_protocol::VerticalSwingMode mode) {
-  return (mode == hon_protocol::VerticalSwingMode::AUTO) || (mode == hon_protocol::VerticalSwingMode::AUTO_SPECIAL);
-}
-
-static bool is_auto(hon_protocol::HorizontalSwingMode mode) { return mode == hon_protocol::HorizontalSwingMode::AUTO; }
-
-// A position the user just set wins over the appliance's echo of the old one for this long
-constexpr uint32_t AIRFLOW_SELECT_DEBOUNCE_MS = 10000;
-static bool in_debounce(uint32_t set_time, uint32_t now) {
-  return set_time != 0 && now - set_time < AIRFLOW_SELECT_DEBOUNCE_MS;
-}
-
 ESPHOME_LOG_TAG(TAG, "haier.climate");
 constexpr size_t SIGNAL_LEVEL_UPDATE_INTERVAL_MS = 10000;
 constexpr int PROTOCOL_OUTDOOR_TEMPERATURE_OFFSET = -64;
@@ -111,60 +89,21 @@ bool HonClimate::get_quiet_mode_state() const {
 }
 
 esphome::optional<hon_protocol::VerticalSwingMode> HonClimate::get_vertical_airflow() const {
-  if (!this->current_vertical_swing_.has_value()) {
-    return this->current_vertical_swing_;
-  }
-  // While the appliance swings, or right after the user chose a position, report the chosen position
-  if (is_auto(this->current_vertical_swing_.value()) ||
-      in_debounce(this->vertical_direction_set_time_, App.get_loop_component_start_time())) {
-    return this->settings_.last_vertiacal_swing;
-  }
   return this->current_vertical_swing_;
-}
+};
 
 void HonClimate::set_vertical_airflow(hon_protocol::VerticalSwingMode direction) {
-  if (is_auto(direction)) {
-    ESP_LOGW(TAG, "Vertical AUTO mode is not allowed for airflow position selector");
-    return;
-  }
-  if (this->settings_.last_vertiacal_swing != direction) {
-    this->settings_.last_vertiacal_swing = direction;
-    this->hon_rtc_.save(&this->settings_);
-  }
   this->pending_vertical_direction_ = direction;
   this->force_send_control_ = true;
-  this->vertical_direction_set_time_ = App.get_loop_component_start_time();
-#ifdef USE_SELECT
-  this->publish_airflow_selects_();
-#endif
 }
 
 esphome::optional<hon_protocol::HorizontalSwingMode> HonClimate::get_horizontal_airflow() const {
-  if (!this->current_horizontal_swing_.has_value()) {
-    return this->current_horizontal_swing_;
-  }
-  if (is_auto(this->current_horizontal_swing_.value()) ||
-      in_debounce(this->horizontal_direction_set_time_, App.get_loop_component_start_time())) {
-    return this->settings_.last_horizontal_swing;
-  }
   return this->current_horizontal_swing_;
 }
 
 void HonClimate::set_horizontal_airflow(hon_protocol::HorizontalSwingMode direction) {
-  if (is_auto(direction)) {
-    ESP_LOGW(TAG, "Horizontal AUTO mode is not allowed for airflow position selector");
-    return;
-  }
-  if (this->settings_.last_horizontal_swing != direction) {
-    this->settings_.last_horizontal_swing = direction;
-    this->hon_rtc_.save(&this->settings_);
-  }
   this->pending_horizontal_direction_ = direction;
   this->force_send_control_ = true;
-  this->horizontal_direction_set_time_ = App.get_loop_component_start_time();
-#ifdef USE_SELECT
-  this->publish_airflow_selects_();
-#endif
 }
 
 const char *HonClimate::get_cleaning_status_text() const {
@@ -594,18 +533,6 @@ void HonClimate::initialization() {
   } else {
     this->settings_ = {hon_protocol::VerticalSwingMode::CENTER, hon_protocol::HorizontalSwingMode::CENTER, true, false};
   }
-  bool settings_fixed = false;
-  if (is_auto(this->settings_.last_vertiacal_swing)) {
-    this->settings_.last_vertiacal_swing = hon_protocol::VerticalSwingMode::CENTER;
-    settings_fixed = true;
-  }
-  if (is_auto(this->settings_.last_horizontal_swing)) {
-    this->settings_.last_horizontal_swing = hon_protocol::HorizontalSwingMode::CENTER;
-    settings_fixed = true;
-  }
-  if (settings_fixed) {
-    this->hon_rtc_.save(&this->settings_);
-  }
   this->current_vertical_swing_ = this->settings_.last_vertiacal_swing;
   this->current_horizontal_swing_ = this->settings_.last_horizontal_swing;
   this->quiet_mode_state_ = this->settings_.quiet_mode_state ? SwitchState::SWITCH_ON : SwitchState::SWITCH_OFF;
@@ -741,21 +668,12 @@ haier_protocol::HaierMessage HonClimate::get_control_message() {
       }
     }
   }
-  const ClimateSwingMode target_swing_mode = this->current_hvac_settings_.swing_mode.value_or(this->swing_mode);
   if (this->pending_vertical_direction_.has_value()) {
-    if (!vertical_axis_is_auto(target_swing_mode)) {
-      out_data->vertical_swing_mode = (uint8_t) this->pending_vertical_direction_.value();
-    } else {
-      ESP_LOGD(TAG, "Vertical swing is on; the position is kept for when it is turned off");
-    }
+    out_data->vertical_swing_mode = (uint8_t) this->pending_vertical_direction_.value();
     this->pending_vertical_direction_.reset();
   }
   if (this->pending_horizontal_direction_.has_value()) {
-    if (!horizontal_axis_is_auto(target_swing_mode)) {
-      out_data->horizontal_swing_mode = (uint8_t) this->pending_horizontal_direction_.value();
-    } else {
-      ESP_LOGD(TAG, "Horizontal swing is on; the position is kept for when it is turned off");
-    }
+    out_data->horizontal_swing_mode = (uint8_t) this->pending_horizontal_direction_.value();
     this->pending_horizontal_direction_.reset();
   }
   {
@@ -922,41 +840,6 @@ void HonClimate::set_quiet_mode_switch(switch_::Switch *sw) {
 }
 #endif  // USE_SWITCH
 
-#ifdef USE_SELECT
-template<typename Mode, size_t N>
-static void publish_airflow_index(select::Select *sel, const std::array<Mode, N> &order, Mode mode) {
-  if (sel == nullptr) {
-    return;
-  }
-  // Saved settings never hold AUTO after initialization(); any other value outside the table shows as Center
-  size_t index = N;
-  size_t center = 0;
-  for (size_t i = 0; i < N; i++) {
-    const Mode entry = airflow_order_at(order, i);
-    if (entry == mode) {
-      index = i;
-    } else if (entry == Mode::CENTER) {
-      center = i;
-    }
-  }
-  if (index == N) {
-    index = center;
-  }
-  const auto active = sel->active_index();
-  if (active.has_value() && *active == index) {
-    return;
-  }
-  sel->publish_state(index);
-}
-
-void HonClimate::publish_airflow_selects_() {
-  publish_airflow_index(this->vertical_airflow_select_, VERTICAL_SWING_MODES_ORDER,
-                        this->settings_.last_vertiacal_swing);
-  publish_airflow_index(this->horizontal_airflow_select_, HORIZONTAL_SWING_MODES_ORDER,
-                        this->settings_.last_horizontal_swing);
-}
-#endif  // USE_SELECT
-
 haier_protocol::HandlerError HonClimate::process_status_message_(const uint8_t *packet_buffer, uint8_t size) {
   size_t expected_size =
       2 + this->status_message_header_size_ + this->real_control_packet_size_ + this->real_sensors_packet_size_;
@@ -1191,25 +1074,16 @@ haier_protocol::HandlerError HonClimate::process_status_message_(const uint8_t *
     // Saving last known non auto mode for vertical and horizontal swing
     this->current_vertical_swing_ = (hon_protocol::VerticalSwingMode) packet.control.vertical_swing_mode;
     this->current_horizontal_swing_ = (hon_protocol::HorizontalSwingMode) packet.control.horizontal_swing_mode;
-    const uint32_t now_ms = App.get_loop_component_start_time();
-    bool save_vertical = !in_debounce(this->vertical_direction_set_time_, now_ms) &&
-                         !is_auto(this->current_vertical_swing_.value()) &&
-                         (this->current_vertical_swing_.value() != this->settings_.last_vertiacal_swing);
-    bool save_horizontal = !in_debounce(this->horizontal_direction_set_time_, now_ms) &&
-                           !is_auto(this->current_horizontal_swing_.value()) &&
-                           (this->current_horizontal_swing_.value() != this->settings_.last_horizontal_swing);
-    if (save_vertical || save_horizontal) {
-      if (save_vertical) {
-        this->settings_.last_vertiacal_swing = this->current_vertical_swing_.value();
-      }
-      if (save_horizontal) {
-        this->settings_.last_horizontal_swing = this->current_horizontal_swing_.value();
-      }
+    bool save_settings = ((this->current_vertical_swing_.value() != hon_protocol::VerticalSwingMode::AUTO) &&
+                          (this->current_vertical_swing_.value() != hon_protocol::VerticalSwingMode::AUTO_SPECIAL) &&
+                          (this->current_vertical_swing_.value() != this->settings_.last_vertiacal_swing)) ||
+                         ((this->current_horizontal_swing_.value() != hon_protocol::HorizontalSwingMode::AUTO) &&
+                          (this->current_horizontal_swing_.value() != this->settings_.last_horizontal_swing));
+    if (save_settings) {
+      this->settings_.last_vertiacal_swing = this->current_vertical_swing_.value();
+      this->settings_.last_horizontal_swing = this->current_horizontal_swing_.value();
       this->hon_rtc_.save(&this->settings_);
     }
-#ifdef USE_SELECT
-    this->publish_airflow_selects_();
-#endif
     should_publish = should_publish || (old_swing_mode != this->swing_mode);
   }
   this->last_valid_status_timestamp_ = std::chrono::steady_clock::now();
@@ -1385,10 +1259,8 @@ void HonClimate::fill_control_messages_queue_() {
                                               (uint8_t) hon_protocol::DataParameters::SET_POINT,
                                           buffer, 2);
   }
-  ClimateSwingMode target_swing_mode = this->swing_mode;
   // Vertical swing mode
   if (climate_control.swing_mode.has_value()) {
-    target_swing_mode = climate_control.swing_mode.value();
     uint8_t vertical_swing_buf[] = {0x00, (uint8_t) hon_protocol::VerticalSwingMode::AUTO};
     uint8_t horizontal_swing_buf[] = {0x00, (uint8_t) hon_protocol::HorizontalSwingMode::AUTO};
     switch (climate_control.swing_mode.value()) {
@@ -1414,32 +1286,6 @@ void HonClimate::fill_control_messages_queue_() {
                                               (uint8_t) hon_protocol::DataParameters::VERTICAL_SWING_MODE,
                                           vertical_swing_buf, 2);
   }
-  // A swing change above already sent both axes from settings_.last_*, which set_*_airflow() updated
-  const bool swing_sent = climate_control.swing_mode.has_value();
-  if (this->pending_vertical_direction_.has_value()) {
-    if (vertical_axis_is_auto(target_swing_mode)) {
-      ESP_LOGD(TAG, "Vertical swing is on; the position is kept for when it is turned off");
-    } else if (!swing_sent) {
-      uint8_t vertical_swing_buf[] = {0x00, (uint8_t) this->pending_vertical_direction_.value()};
-      this->control_messages_queue_.emplace(haier_protocol::FrameType::CONTROL,
-                                            (uint16_t) hon_protocol::SubcommandsControl::SET_SINGLE_PARAMETER +
-                                                (uint8_t) hon_protocol::DataParameters::VERTICAL_SWING_MODE,
-                                            vertical_swing_buf, 2);
-    }
-    this->pending_vertical_direction_.reset();
-  }
-  if (this->pending_horizontal_direction_.has_value()) {
-    if (horizontal_axis_is_auto(target_swing_mode)) {
-      ESP_LOGD(TAG, "Horizontal swing is on; the position is kept for when it is turned off");
-    } else if (!swing_sent) {
-      uint8_t horizontal_swing_buf[] = {0x00, (uint8_t) this->pending_horizontal_direction_.value()};
-      this->control_messages_queue_.emplace(haier_protocol::FrameType::CONTROL,
-                                            (uint16_t) hon_protocol::SubcommandsControl::SET_SINGLE_PARAMETER +
-                                                (uint8_t) hon_protocol::DataParameters::HORIZONTAL_SWING_MODE,
-                                            horizontal_swing_buf, 2);
-    }
-    this->pending_horizontal_direction_.reset();
-  }
   // Fan mode
   if (climate_control.fan_mode.has_value()) {
     switch (climate_control.fan_mode.value()) {

esphome/components/haier/hon_climate.h

@@ -1,6 +1,5 @@
 #pragma once
 
-#include <array>
 #include <chrono>
 #include <queue>
 #ifdef USE_SENSOR
@@ -15,36 +14,12 @@
 #ifdef USE_SWITCH
 #include "esphome/components/switch/switch.h"
 #endif
-#ifdef USE_SELECT
-#include "esphome/components/select/select.h"
-#endif
 #include "esphome/core/automation.h"
-#include "esphome/core/hal.h"
 #include "haier_base.h"
 #include "hon_packet.h"
 
 namespace esphome::haier {
 
-#ifdef USE_SELECT
-// Positions in the order the select platform lists them; in flash on ESP8266, so read with airflow_order_at()
-inline constexpr std::array<hon_protocol::VerticalSwingMode, 7> VERTICAL_SWING_MODES_ORDER PROGMEM{
-    hon_protocol::VerticalSwingMode::HEALTH_UP,   hon_protocol::VerticalSwingMode::MAX_UP,
-    hon_protocol::VerticalSwingMode::UP,          hon_protocol::VerticalSwingMode::CENTER,
-    hon_protocol::VerticalSwingMode::DOWN,        hon_protocol::VerticalSwingMode::MAX_DOWN,
-    hon_protocol::VerticalSwingMode::HEALTH_DOWN,
-};
-inline constexpr std::array<hon_protocol::HorizontalSwingMode, 5> HORIZONTAL_SWING_MODES_ORDER PROGMEM{
-    hon_protocol::HorizontalSwingMode::MAX_LEFT,  hon_protocol::HorizontalSwingMode::LEFT,
-    hon_protocol::HorizontalSwingMode::CENTER,    hon_protocol::HorizontalSwingMode::RIGHT,
-    hon_protocol::HorizontalSwingMode::MAX_RIGHT,
-};
-
-template<typename Mode, size_t N> Mode airflow_order_at(const std::array<Mode, N> &order, size_t index) {
-  static_assert(sizeof(Mode) == 1);
-  return static_cast<Mode>(progmem_read_byte(reinterpret_cast<const uint8_t *>(order.data() + index)));
-}
-#endif
-
 enum class CleaningState : uint8_t {
   NO_CLEANING = 0,
   SELF_CLEAN = 1,
@@ -125,16 +100,6 @@ class HonClimate final : public HaierClimateBase {
  protected:
   switch_::Switch *beeper_switch_{nullptr};
   switch_::Switch *quiet_mode_switch_{nullptr};
-#endif
-#ifdef USE_SELECT
- public:
-  void set_vertical_airflow_select(select::Select *sel) { this->vertical_airflow_select_ = sel; }
-  void set_horizontal_airflow_select(select::Select *sel) { this->horizontal_airflow_select_ = sel; }
-
- protected:
-  void publish_airflow_selects_();
-  select::Select *vertical_airflow_select_{nullptr};
-  select::Select *horizontal_airflow_select_{nullptr};
 #endif
  public:
   HonClimate();
@@ -230,9 +195,6 @@ class HonClimate final : public HaierClimateBase {
   uint8_t big_data_counter_{0};
   esphome::optional<hon_protocol::VerticalSwingMode> current_vertical_swing_{};
   esphome::optional<hon_protocol::HorizontalSwingMode> current_horizontal_swing_{};
-  // millis() of the last user-set position per axis, 0 when none
-  uint32_t vertical_direction_set_time_{0};
-  uint32_t horizontal_direction_set_time_{0};
   HonSettings settings_{};
   ESPPreferenceObject hon_rtc_;
   SwitchState quiet_mode_state_{SwitchState::SWITCH_OFF};

esphome/components/haier/select/__init__.py

@@ -1,67 +0,0 @@
-import esphome.codegen as cg
-from esphome.components import select
-import esphome.config_validation as cv
-from esphome.const import ENTITY_CATEGORY_CONFIG
-from esphome.types import ConfigType
-
-from ..climate import (
-    CONF_HAIER_ID,
-    CONF_HORIZONTAL_AIRFLOW,
-    CONF_VERTICAL_AIRFLOW,
-    HonClimate,
-    haier_ns,
-)
-
-CODEOWNERS = ["@paveldn"]
-VerticalAirflowSelect = haier_ns.class_("VerticalAirflowSelect", select.Select)
-HorizontalAirflowSelect = haier_ns.class_("HorizontalAirflowSelect", select.Select)
-
-# Same order as VERTICAL_SWING_MODES_ORDER and HORIZONTAL_SWING_MODES_ORDER in hon_climate.h
-AIRFLOW_VERTICAL_DIRECTION_OPTIONS = [
-    "Health Up",
-    "Max Up",
-    "Up",
-    "Center",
-    "Down",
-    "Max Down",
-    "Health Down",
-]
-
-AIRFLOW_HORIZONTAL_DIRECTION_OPTIONS = [
-    "Max Left",
-    "Left",
-    "Center",
-    "Right",
-    "Max Right",
-]
-
-CONFIG_SCHEMA = cv.Schema(
-    {
-        cv.GenerateID(CONF_HAIER_ID): cv.use_id(HonClimate),
-        cv.Optional(CONF_VERTICAL_AIRFLOW): select.select_schema(
-            VerticalAirflowSelect,
-            icon="mdi:arrow-expand-vertical",
-            entity_category=ENTITY_CATEGORY_CONFIG,
-        ),
-        cv.Optional(CONF_HORIZONTAL_AIRFLOW): select.select_schema(
-            HorizontalAirflowSelect,
-            icon="mdi:arrow-expand-horizontal",
-            entity_category=ENTITY_CATEGORY_CONFIG,
-        ),
-    }
-)
-
-
-async def to_code(config: ConfigType) -> None:
-    hub = await cg.get_variable(config[CONF_HAIER_ID])
-    selects = select.sub_selects(config, parent=hub)
-    await selects(
-        CONF_VERTICAL_AIRFLOW,
-        hub.set_vertical_airflow_select,
-        options=AIRFLOW_VERTICAL_DIRECTION_OPTIONS,
-    )
-    await selects(
-        CONF_HORIZONTAL_AIRFLOW,
-        hub.set_horizontal_airflow_select,
-        options=AIRFLOW_HORIZONTAL_DIRECTION_OPTIONS,
-    )

esphome/components/haier/select/horizontal_airflow.h

@@ -1,15 +0,0 @@
-#pragma once
-
-#include "esphome/components/select/select.h"
-#include "../hon_climate.h"
-
-namespace esphome::haier {
-
-class HorizontalAirflowSelect : public select::Select, public Parented<HonClimate> {
- protected:
-  void control(size_t index) override {
-    this->parent_->set_horizontal_airflow(airflow_order_at(HORIZONTAL_SWING_MODES_ORDER, index));
-  }
-};
-
-}  // namespace esphome::haier

esphome/components/haier/select/vertical_airflow.h

@@ -1,15 +0,0 @@
-#pragma once
-
-#include "esphome/components/select/select.h"
-#include "../hon_climate.h"
-
-namespace esphome::haier {
-
-class VerticalAirflowSelect : public select::Select, public Parented<HonClimate> {
- protected:
-  void control(size_t index) override {
-    this->parent_->set_vertical_airflow(airflow_order_at(VERTICAL_SWING_MODES_ORDER, index));
-  }
-};
-
-}  // namespace esphome::haier

esphome/components/heatpumpir/climate.py

@@ -126,8 +126,8 @@ CONFIG_SCHEMA = cv.All(
 
 
 async def to_code(config: ConfigType) -> None:
-    tag = heatpumpir_ns.ProtocolTag.template(config[CONF_PROTOCOL])
-    var = await climate_ir.new_climate_ir(config, tag())
+    var = await climate_ir.new_climate_ir(config)
+    cg.add(var.set_protocol(config[CONF_PROTOCOL]))
     cg.add(var.set_horizontal_default(config[CONF_HORIZONTAL_DEFAULT]))
     cg.add(var.set_vertical_default(config[CONF_VERTICAL_DEFAULT]))
     cg.add(var.set_max_temperature(config[CONF_MAX_TEMPERATURE]))

esphome/components/heatpumpir/heatpumpir.cpp

@@ -5,6 +5,7 @@
 #if defined(USE_ARDUINO) || defined(USE_ESP32)
 
 #include <cmath>
+#include <map>
 #include <IRSender.h>
 #include <HeatpumpIRFactory.h>
 #include "esphome/components/remote_base/remote_base.h"
@@ -44,76 +45,71 @@ class IRSenderESPHome : public IRSender {
 
 ESPHOME_LOG_TAG(TAG, "heatpumpir.climate");
 
-template<Protocol P> struct ProtocolClass;
-
-template<Protocol P> HeatpumpIR *create_heatpump_ir() {
-  return new typename ProtocolClass<P>::type();  // NOLINT
-}
-
-// Codegen calls only the configured protocols, so the linker drops the other classes
-#define HEATPUMPIR_PROTOCOL(protocol, cls) \
-  template<> struct ProtocolClass<protocol> { using type = cls; }; \
-  template HeatpumpIR *create_heatpump_ir<protocol>();
-
-HEATPUMPIR_PROTOCOL(PROTOCOL_AUX, AUXHeatpumpIR)
-HEATPUMPIR_PROTOCOL(PROTOCOL_BALLU, BalluHeatpumpIR)
-HEATPUMPIR_PROTOCOL(PROTOCOL_CARRIER_MCA, CarrierMCAHeatpumpIR)
-HEATPUMPIR_PROTOCOL(PROTOCOL_CARRIER_NQV, CarrierNQVHeatpumpIR)
-HEATPUMPIR_PROTOCOL(PROTOCOL_DAIKIN_ARC417, DaikinHeatpumpARC417IR)
-HEATPUMPIR_PROTOCOL(PROTOCOL_DAIKIN_ARC480, DaikinHeatpumpARC480A14IR)
-HEATPUMPIR_PROTOCOL(PROTOCOL_DAIKIN, DaikinHeatpumpIR)
-HEATPUMPIR_PROTOCOL(PROTOCOL_ELECTROLUXYAL, ElectroluxYALHeatpumpIR)
-HEATPUMPIR_PROTOCOL(PROTOCOL_FUEGO, FuegoHeatpumpIR)
-HEATPUMPIR_PROTOCOL(PROTOCOL_FUJITSU_AWYZ, FujitsuHeatpumpIR)
-HEATPUMPIR_PROTOCOL(PROTOCOL_GREE, GreeGenericHeatpumpIR)
-HEATPUMPIR_PROTOCOL(PROTOCOL_GREEYAA, GreeYAAHeatpumpIR)
-HEATPUMPIR_PROTOCOL(PROTOCOL_GREEYAN, GreeYANHeatpumpIR)
-HEATPUMPIR_PROTOCOL(PROTOCOL_GREEYAC, GreeYACHeatpumpIR)
-HEATPUMPIR_PROTOCOL(PROTOCOL_GREEYT, GreeYTHeatpumpIR)
-HEATPUMPIR_PROTOCOL(PROTOCOL_GREEYAP, GreeYAPHeatpumpIR)
-HEATPUMPIR_PROTOCOL(PROTOCOL_HISENSE_AUD, HisenseHeatpumpIR)
-HEATPUMPIR_PROTOCOL(PROTOCOL_HITACHI, HitachiHeatpumpIR)
-HEATPUMPIR_PROTOCOL(PROTOCOL_HYUNDAI, HyundaiHeatpumpIR)
-HEATPUMPIR_PROTOCOL(PROTOCOL_IVT, IVTHeatpumpIR)
-HEATPUMPIR_PROTOCOL(PROTOCOL_MIDEA, MideaHeatpumpIR)
-HEATPUMPIR_PROTOCOL(PROTOCOL_MITSUBISHI_FA, MitsubishiFAHeatpumpIR)
-HEATPUMPIR_PROTOCOL(PROTOCOL_MITSUBISHI_FD, MitsubishiFDHeatpumpIR)
-HEATPUMPIR_PROTOCOL(PROTOCOL_MITSUBISHI_FE, MitsubishiFEHeatpumpIR)
-HEATPUMPIR_PROTOCOL(PROTOCOL_MITSUBISHI_HEAVY_FDTC, MitsubishiHeavyFDTCHeatpumpIR)
-HEATPUMPIR_PROTOCOL(PROTOCOL_MITSUBISHI_HEAVY_ZJ, MitsubishiHeavyZJHeatpumpIR)
-HEATPUMPIR_PROTOCOL(PROTOCOL_MITSUBISHI_HEAVY_ZM, MitsubishiHeavyZMHeatpumpIR)
-HEATPUMPIR_PROTOCOL(PROTOCOL_MITSUBISHI_HEAVY_ZMP, MitsubishiHeavyZMPHeatpumpIR)
-HEATPUMPIR_PROTOCOL(PROTOCOL_MITSUBISHI_KJ, MitsubishiKJHeatpumpIR)
-HEATPUMPIR_PROTOCOL(PROTOCOL_MITSUBISHI_MSC, MitsubishiMSCHeatpumpIR)
-HEATPUMPIR_PROTOCOL(PROTOCOL_MITSUBISHI_MSY, MitsubishiMSYHeatpumpIR)
-HEATPUMPIR_PROTOCOL(PROTOCOL_MITSUBISHI_SEZ, MitsubishiSEZKDXXHeatpumpIR)
-HEATPUMPIR_PROTOCOL(PROTOCOL_PANASONIC_CKP, PanasonicCKPHeatpumpIR)
-HEATPUMPIR_PROTOCOL(PROTOCOL_PANASONIC_DKE, PanasonicDKEHeatpumpIR)
-HEATPUMPIR_PROTOCOL(PROTOCOL_PANASONIC_EKE, PanasonicEKEHeatpumpIR)
-HEATPUMPIR_PROTOCOL(PROTOCOL_PANASONIC_JKE, PanasonicJKEHeatpumpIR)
-HEATPUMPIR_PROTOCOL(PROTOCOL_PANASONIC_LKE, PanasonicLKEHeatpumpIR)
-HEATPUMPIR_PROTOCOL(PROTOCOL_PANASONIC_NKE, PanasonicNKEHeatpumpIR)
-HEATPUMPIR_PROTOCOL(PROTOCOL_SAMSUNG_AQV, SamsungAQVHeatpumpIR)
-HEATPUMPIR_PROTOCOL(PROTOCOL_SAMSUNG_FJM, SamsungFJMHeatpumpIR)
-HEATPUMPIR_PROTOCOL(PROTOCOL_SHARP, SharpHeatpumpIR)
-HEATPUMPIR_PROTOCOL(PROTOCOL_TOSHIBA_DAISEIKAI, ToshibaDaiseikaiHeatpumpIR)
-HEATPUMPIR_PROTOCOL(PROTOCOL_TOSHIBA, ToshibaHeatpumpIR)
-HEATPUMPIR_PROTOCOL(PROTOCOL_ZHLT01, ZHLT01HeatpumpIR)
-HEATPUMPIR_PROTOCOL(PROTOCOL_NIBE, NibeHeatpumpIR)
-HEATPUMPIR_PROTOCOL(PROTOCOL_QLIMA_1, Qlima1HeatpumpIR)
-HEATPUMPIR_PROTOCOL(PROTOCOL_QLIMA_2, Qlima2HeatpumpIR)
-HEATPUMPIR_PROTOCOL(PROTOCOL_SAMSUNG_AQV12MSAN, SamsungAQV12MSANHeatpumpIR)
-HEATPUMPIR_PROTOCOL(PROTOCOL_ZHJG01, ZHJG01HeatpumpIR)
-HEATPUMPIR_PROTOCOL(PROTOCOL_AIRWAY, AIRWAYHeatpumpIR)
-HEATPUMPIR_PROTOCOL(PROTOCOL_BGH_AUD, BGHHeatpumpIR)
-HEATPUMPIR_PROTOCOL(PROTOCOL_PANASONIC_ALTDKE, PanasonicAltDKEHeatpumpIR)
-HEATPUMPIR_PROTOCOL(PROTOCOL_PHILCO_PHS32, PhilcoPHS32HeatpumpIR)
-HEATPUMPIR_PROTOCOL(PROTOCOL_VAILLANTVAI8, VaillantHeatpumpIR)
-HEATPUMPIR_PROTOCOL(PROTOCOL_R51M, R51MHeatpumpIR)
-
-#undef HEATPUMPIR_PROTOCOL
+const std::map<Protocol, std::function<HeatpumpIR *()>> PROTOCOL_CONSTRUCTOR_MAP = {
+    {PROTOCOL_AUX, []() { return new AUXHeatpumpIR(); }},                                    // NOLINT
+    {PROTOCOL_BALLU, []() { return new BalluHeatpumpIR(); }},                                // NOLINT
+    {PROTOCOL_CARRIER_MCA, []() { return new CarrierMCAHeatpumpIR(); }},                     // NOLINT
+    {PROTOCOL_CARRIER_NQV, []() { return new CarrierNQVHeatpumpIR(); }},                     // NOLINT
+    {PROTOCOL_DAIKIN_ARC417, []() { return new DaikinHeatpumpARC417IR(); }},                 // NOLINT
+    {PROTOCOL_DAIKIN_ARC480, []() { return new DaikinHeatpumpARC480A14IR(); }},              // NOLINT
+    {PROTOCOL_DAIKIN, []() { return new DaikinHeatpumpIR(); }},                              // NOLINT
+    {PROTOCOL_ELECTROLUXYAL, []() { return new ElectroluxYALHeatpumpIR(); }},                // NOLINT
+    {PROTOCOL_FUEGO, []() { return new FuegoHeatpumpIR(); }},                                // NOLINT
+    {PROTOCOL_FUJITSU_AWYZ, []() { return new FujitsuHeatpumpIR(); }},                       // NOLINT
+    {PROTOCOL_GREE, []() { return new GreeGenericHeatpumpIR(); }},                           // NOLINT
+    {PROTOCOL_GREEYAA, []() { return new GreeYAAHeatpumpIR(); }},                            // NOLINT
+    {PROTOCOL_GREEYAN, []() { return new GreeYANHeatpumpIR(); }},                            // NOLINT
+    {PROTOCOL_GREEYAC, []() { return new GreeYACHeatpumpIR(); }},                            // NOLINT
+    {PROTOCOL_GREEYT, []() { return new GreeYTHeatpumpIR(); }},                              // NOLINT
+    {PROTOCOL_GREEYAP, []() { return new GreeYAPHeatpumpIR(); }},                            // NOLINT
+    {PROTOCOL_HISENSE_AUD, []() { return new HisenseHeatpumpIR(); }},                        // NOLINT
+    {PROTOCOL_HITACHI, []() { return new HitachiHeatpumpIR(); }},                            // NOLINT
+    {PROTOCOL_HYUNDAI, []() { return new HyundaiHeatpumpIR(); }},                            // NOLINT
+    {PROTOCOL_IVT, []() { return new IVTHeatpumpIR(); }},                                    // NOLINT
+    {PROTOCOL_MIDEA, []() { return new MideaHeatpumpIR(); }},                                // NOLINT
+    {PROTOCOL_MITSUBISHI_FA, []() { return new MitsubishiFAHeatpumpIR(); }},                 // NOLINT
+    {PROTOCOL_MITSUBISHI_FD, []() { return new MitsubishiFDHeatpumpIR(); }},                 // NOLINT
+    {PROTOCOL_MITSUBISHI_FE, []() { return new MitsubishiFEHeatpumpIR(); }},                 // NOLINT
+    {PROTOCOL_MITSUBISHI_HEAVY_FDTC, []() { return new MitsubishiHeavyFDTCHeatpumpIR(); }},  // NOLINT
+    {PROTOCOL_MITSUBISHI_HEAVY_ZJ, []() { return new MitsubishiHeavyZJHeatpumpIR(); }},      // NOLINT
+    {PROTOCOL_MITSUBISHI_HEAVY_ZM, []() { return new MitsubishiHeavyZMHeatpumpIR(); }},      // NOLINT
+    {PROTOCOL_MITSUBISHI_HEAVY_ZMP, []() { return new MitsubishiHeavyZMPHeatpumpIR(); }},    // NOLINT
+    {PROTOCOL_MITSUBISHI_KJ, []() { return new MitsubishiKJHeatpumpIR(); }},                 // NOLINT
+    {PROTOCOL_MITSUBISHI_MSC, []() { return new MitsubishiMSCHeatpumpIR(); }},               // NOLINT
+    {PROTOCOL_MITSUBISHI_MSY, []() { return new MitsubishiMSYHeatpumpIR(); }},               // NOLINT
+    {PROTOCOL_MITSUBISHI_SEZ, []() { return new MitsubishiSEZKDXXHeatpumpIR(); }},           // NOLINT
+    {PROTOCOL_PANASONIC_CKP, []() { return new PanasonicCKPHeatpumpIR(); }},                 // NOLINT
+    {PROTOCOL_PANASONIC_DKE, []() { return new PanasonicDKEHeatpumpIR(); }},                 // NOLINT
+    {PROTOCOL_PANASONIC_EKE, []() { return new PanasonicEKEHeatpumpIR(); }},                 // NOLINT
+    {PROTOCOL_PANASONIC_JKE, []() { return new PanasonicJKEHeatpumpIR(); }},                 // NOLINT
+    {PROTOCOL_PANASONIC_LKE, []() { return new PanasonicLKEHeatpumpIR(); }},                 // NOLINT
+    {PROTOCOL_PANASONIC_NKE, []() { return new PanasonicNKEHeatpumpIR(); }},                 // NOLINT
+    {PROTOCOL_SAMSUNG_AQV, []() { return new SamsungAQVHeatpumpIR(); }},                     // NOLINT
+    {PROTOCOL_SAMSUNG_FJM, []() { return new SamsungFJMHeatpumpIR(); }},                     // NOLINT
+    {PROTOCOL_SHARP, []() { return new SharpHeatpumpIR(); }},                                // NOLINT
+    {PROTOCOL_TOSHIBA_DAISEIKAI, []() { return new ToshibaDaiseikaiHeatpumpIR(); }},         // NOLINT
+    {PROTOCOL_TOSHIBA, []() { return new ToshibaHeatpumpIR(); }},                            // NOLINT
+    {PROTOCOL_ZHLT01, []() { return new ZHLT01HeatpumpIR(); }},                              // NOLINT
+    {PROTOCOL_NIBE, []() { return new NibeHeatpumpIR(); }},                                  // NOLINT
+    {PROTOCOL_QLIMA_1, []() { return new Qlima1HeatpumpIR(); }},                             // NOLINT
+    {PROTOCOL_QLIMA_2, []() { return new Qlima2HeatpumpIR(); }},                             // NOLINT
+    {PROTOCOL_SAMSUNG_AQV12MSAN, []() { return new SamsungAQV12MSANHeatpumpIR(); }},         // NOLINT
+    {PROTOCOL_ZHJG01, []() { return new ZHJG01HeatpumpIR(); }},                              // NOLINT
+    {PROTOCOL_AIRWAY, []() { return new AIRWAYHeatpumpIR(); }},                              // NOLINT
+    {PROTOCOL_BGH_AUD, []() { return new BGHHeatpumpIR(); }},                                // NOLINT
+    {PROTOCOL_PANASONIC_ALTDKE, []() { return new PanasonicAltDKEHeatpumpIR(); }},           // NOLINT
+    {PROTOCOL_PHILCO_PHS32, []() { return new PhilcoPHS32HeatpumpIR(); }},                   // NOLINT
+    {PROTOCOL_VAILLANTVAI8, []() { return new VaillantHeatpumpIR(); }},                      // NOLINT
+    {PROTOCOL_R51M, []() { return new R51MHeatpumpIR(); }},                                  // NOLINT
+};
 
 void HeatpumpIRClimate::setup() {
+  auto protocol_constructor = PROTOCOL_CONSTRUCTOR_MAP.find(protocol_);
+  if (protocol_constructor == PROTOCOL_CONSTRUCTOR_MAP.end()) {
+    ESP_LOGE(TAG, "Invalid protocol");
+    return;
+  }
+  this->heatpump_ir_ = protocol_constructor->second();
   climate_ir::ClimateIR::setup();
   if (this->sensor_) {
     this->sensor_->add_on_state_callback([this](float state) {

esphome/components/heatpumpir/heatpumpir.h

@@ -89,21 +89,25 @@ enum VerticalDirection {
   VERTICAL_DIRECTION_DOWN = 5,
 };
 
-/// Creates the HeatpumpIR library class for a protocol; instantiated in heatpumpir.cpp.
-template<Protocol P> HeatpumpIR *create_heatpump_ir();
-
-/// Selects the protocol at compile time so the enum and the library object always match.
-template<Protocol P> struct ProtocolTag {};
-
 // Temperature
 const float TEMP_MIN = 0;    // Celsius
 const float TEMP_MAX = 100;  // Celsius
 
 class HeatpumpIRClimate final : public climate_ir::ClimateIR {
  public:
-  template<Protocol P>
-  explicit HeatpumpIRClimate(ProtocolTag<P> /*tag*/) : HeatpumpIRClimate(P, create_heatpump_ir<P>()) {}
+  HeatpumpIRClimate()
+      : climate_ir::ClimateIR(TEMP_MIN, TEMP_MAX, 1.0f, true, true,
+                              {climate::CLIMATE_FAN_LOW, climate::CLIMATE_FAN_MEDIUM, climate::CLIMATE_FAN_HIGH,
+                               climate::CLIMATE_FAN_AUTO},
+                              {climate::CLIMATE_SWING_OFF, climate::CLIMATE_SWING_HORIZONTAL,
+                               climate::CLIMATE_SWING_VERTICAL, climate::CLIMATE_SWING_BOTH}) {}
   void setup() override;
+  void set_protocol(Protocol protocol) {
+    this->protocol_ = protocol;
+    if (this->has_fan_byte_presets_()) {
+      this->presets_ = {climate::CLIMATE_PRESET_NONE, climate::CLIMATE_PRESET_ECO, climate::CLIMATE_PRESET_BOOST};
+    }
+  }
   void set_horizontal_default(HorizontalDirection horizontal_direction) {
     this->default_horizontal_direction_ = horizontal_direction;
   }
@@ -115,18 +119,6 @@ class HeatpumpIRClimate final : public climate_ir::ClimateIR {
   void set_min_temperature(float temperature) { this->min_temperature_ = temperature; }
 
  protected:
-  HeatpumpIRClimate(Protocol protocol, HeatpumpIR *heatpump_ir)
-      : climate_ir::ClimateIR(TEMP_MIN, TEMP_MAX, 1.0f, true, true,
-                              {climate::CLIMATE_FAN_LOW, climate::CLIMATE_FAN_MEDIUM, climate::CLIMATE_FAN_HIGH,
-                               climate::CLIMATE_FAN_AUTO},
-                              {climate::CLIMATE_SWING_OFF, climate::CLIMATE_SWING_HORIZONTAL,
-                               climate::CLIMATE_SWING_VERTICAL, climate::CLIMATE_SWING_BOTH}),
-        heatpump_ir_(heatpump_ir),
-        protocol_(protocol) {
-    if (this->has_fan_byte_presets_()) {
-      this->presets_ = {climate::CLIMATE_PRESET_NONE, climate::CLIMATE_PRESET_ECO, climate::CLIMATE_PRESET_BOOST};
-    }
-  }
   HeatpumpIR *heatpump_ir_;
   void control(const climate::ClimateCall &call) override;
   /// Transmit via IR the state of this climate controller.

esphome/components/homeassistant/button/homeassistant_button.cpp

@@ -5,7 +5,6 @@
 #include "esphome/components/api/api_pb2.h"
 #include "esphome/components/api/api_server.h"
 #include "esphome/core/log.h"
-#include "esphome/core/progmem.h"
 #include "esphome/core/string_ref.h"
 
 namespace esphome::homeassistant {
@@ -32,21 +31,22 @@ void HomeassistantButton::press_action() {
   }
 #endif
 
-  // In flash on the ESP8266 and encoded from there
-  static const char SERVICE_BUTTON[] PROGMEM = "button.press";
-  static const char SERVICE_INPUT_BUTTON[] PROGMEM = "input_button.press";
-  static const char ENTITY_ID_KEY[] PROGMEM = "entity_id";
+  static constexpr auto SERVICE_BUTTON = StringRef::from_lit("button.press");
+  static constexpr auto SERVICE_INPUT_BUTTON = StringRef::from_lit("input_button.press");
+  static constexpr auto ENTITY_ID_KEY = StringRef::from_lit("entity_id");
+  static constexpr char INPUT_PREFIX[] = "input_";
 
   api::HomeassistantActionRequest resp;
-  // An input helper entity id starts with the "input_" its action name starts with
-  const bool input_helper = ESPHOME_strncmp_P(this->entity_id_, SERVICE_INPUT_BUTTON, sizeof("input_") - 1) == 0;
-  resp.service =
-      input_helper ? ProgmemStringRef::from_lit(SERVICE_INPUT_BUTTON) : ProgmemStringRef::from_lit(SERVICE_BUTTON);
+  if (strncmp(this->entity_id_, INPUT_PREFIX, sizeof(INPUT_PREFIX) - 1) == 0) {
+    resp.service = SERVICE_INPUT_BUTTON;
+  } else {
+    resp.service = SERVICE_BUTTON;
+  }
 
   resp.data.init(1);
   auto &entity_id_kv = resp.data.emplace_back();
-  entity_id_kv.key = ProgmemStringRef::from_lit(ENTITY_ID_KEY);
-  entity_id_kv.value = ProgmemStringRef(StringRef(this->entity_id_));
+  entity_id_kv.key = ENTITY_ID_KEY;
+  entity_id_kv.value = StringRef(this->entity_id_);
 
   api::global_api_server->send_homeassistant_action(resp);
 }

esphome/components/homeassistant/number/homeassistant_number.cpp

@@ -5,7 +5,6 @@
 #include "esphome/components/api/api_pb2.h"
 #include "esphome/components/api/api_server.h"
 #include "esphome/core/log.h"
-#include "esphome/core/progmem.h"
 #include "esphome/core/string_ref.h"
 
 namespace esphome::homeassistant {
@@ -90,29 +89,31 @@ void HomeassistantNumber::control(float value) {
 
   this->publish_state(value);
 
-  // In flash on the ESP8266 and encoded from there
-  static const char NUMBER_SERVICE_NAME[] PROGMEM = "number.set_value";
-  static const char INPUT_NUMBER_SERVICE_NAME[] PROGMEM = "input_number.set_value";
-  static const char ENTITY_ID_KEY[] PROGMEM = "entity_id";
-  static const char VALUE_KEY[] PROGMEM = "value";
+  static constexpr auto NUMBER_SERVICE_NAME = StringRef::from_lit("number.set_value");
+  static constexpr auto INPUT_NUMBER_SERVICE_NAME = StringRef::from_lit("input_number.set_value");
+  static constexpr char INPUT_PREFIX[] = "input_";
+  static constexpr auto ENTITY_ID_KEY = StringRef::from_lit("entity_id");
+  static constexpr auto VALUE_KEY = StringRef::from_lit("value");
 
   api::HomeassistantActionRequest resp;
-  // An input helper entity id starts with the "input_" its action name starts with
-  const bool input_helper = ESPHOME_strncmp_P(this->entity_id_, INPUT_NUMBER_SERVICE_NAME, sizeof("input_") - 1) == 0;
-  resp.service = input_helper ? ProgmemStringRef::from_lit(INPUT_NUMBER_SERVICE_NAME)
-                              : ProgmemStringRef::from_lit(NUMBER_SERVICE_NAME);
+  // input_number entities have their own set_value action
+  if (strncmp(this->entity_id_, INPUT_PREFIX, sizeof(INPUT_PREFIX) - 1) == 0) {
+    resp.service = INPUT_NUMBER_SERVICE_NAME;
+  } else {
+    resp.service = NUMBER_SERVICE_NAME;
+  }
 
   resp.data.init(2);
   auto &entity_id = resp.data.emplace_back();
-  entity_id.key = ProgmemStringRef::from_lit(ENTITY_ID_KEY);
-  entity_id.value = ProgmemStringRef(StringRef(this->entity_id_));
+  entity_id.key = ENTITY_ID_KEY;
+  entity_id.value = StringRef(this->entity_id_);
 
   auto &entity_value = resp.data.emplace_back();
-  entity_value.key = ProgmemStringRef::from_lit(VALUE_KEY);
+  entity_value.key = VALUE_KEY;
   // Stack buffer - no heap allocation; %g produces shortest representation
   char value_buf[16];
   buf_append_printf(value_buf, sizeof(value_buf), 0, "%g", value);
-  entity_value.value = ProgmemStringRef(StringRef(value_buf));
+  entity_value.value = StringRef(value_buf);
 
   api::global_api_server->send_homeassistant_action(resp);
 }

esphome/components/homeassistant/select/homeassistant_select.cpp

@@ -6,7 +6,6 @@
 #include "esphome/components/api/api_server.h"
 #include "esphome/core/helpers.h"
 #include "esphome/core/log.h"
-#include "esphome/core/progmem.h"
 #include "esphome/core/string_ref.h"
 
 namespace esphome::homeassistant {
@@ -238,26 +237,27 @@ void HomeassistantSelect::control(size_t index) {
   }
 #endif
 
-  // In flash on the ESP8266 and encoded from there
-  static const char SERVICE_SELECT[] PROGMEM = "select.select_option";
-  static const char SERVICE_INPUT_SELECT[] PROGMEM = "input_select.select_option";
-  static const char ENTITY_ID_KEY[] PROGMEM = "entity_id";
-  static const char OPTION_KEY[] PROGMEM = "option";
+  static constexpr auto SERVICE_SELECT = StringRef::from_lit("select.select_option");
+  static constexpr auto SERVICE_INPUT_SELECT = StringRef::from_lit("input_select.select_option");
+  static constexpr auto ENTITY_ID_KEY = StringRef::from_lit("entity_id");
+  static constexpr auto OPTION_KEY = StringRef::from_lit("option");
+  static constexpr char INPUT_PREFIX[] = "input_";
 
   api::HomeassistantActionRequest resp;
-  // An input helper entity id starts with the "input_" its action name starts with
-  const bool input_helper = ESPHOME_strncmp_P(this->entity_id_, SERVICE_INPUT_SELECT, sizeof("input_") - 1) == 0;
-  resp.service =
-      input_helper ? ProgmemStringRef::from_lit(SERVICE_INPUT_SELECT) : ProgmemStringRef::from_lit(SERVICE_SELECT);
+  if (strncmp(this->entity_id_, INPUT_PREFIX, sizeof(INPUT_PREFIX) - 1) == 0) {
+    resp.service = SERVICE_INPUT_SELECT;
+  } else {
+    resp.service = SERVICE_SELECT;
+  }
 
   resp.data.init(2);
   auto &entity_id = resp.data.emplace_back();
-  entity_id.key = ProgmemStringRef::from_lit(ENTITY_ID_KEY);
-  entity_id.value = ProgmemStringRef(StringRef(this->entity_id_));
+  entity_id.key = ENTITY_ID_KEY;
+  entity_id.value = StringRef(this->entity_id_);
 
   auto &option = resp.data.emplace_back();
-  option.key = ProgmemStringRef::from_lit(OPTION_KEY);
-  option.value = ProgmemStringRef(StringRef(this->option_at(index)));
+  option.key = OPTION_KEY;
+  option.value = StringRef(this->option_at(index));
 
   api::global_api_server->send_homeassistant_action(resp);
 }

esphome/components/homeassistant/switch/homeassistant_switch.cpp

@@ -1,7 +1,6 @@
 #include "homeassistant_switch.h"
 #include "esphome/components/api/api_server.h"
 #include "esphome/core/log.h"
-#include "esphome/core/progmem.h"
 #include "esphome/core/string_ref.h"
 
 namespace esphome::homeassistant {
@@ -48,18 +47,21 @@ void HomeassistantSwitch::write_state(bool state) {
   }
 #endif
 
-  // In flash on the ESP8266 and encoded from there
-  static const char SERVICE_ON[] PROGMEM = "homeassistant.turn_on";
-  static const char SERVICE_OFF[] PROGMEM = "homeassistant.turn_off";
-  static const char ENTITY_ID_KEY[] PROGMEM = "entity_id";
+  static constexpr auto SERVICE_ON = StringRef::from_lit("homeassistant.turn_on");
+  static constexpr auto SERVICE_OFF = StringRef::from_lit("homeassistant.turn_off");
+  static constexpr auto ENTITY_ID_KEY = StringRef::from_lit("entity_id");
 
   api::HomeassistantActionRequest resp;
-  resp.service = state ? ProgmemStringRef::from_lit(SERVICE_ON) : ProgmemStringRef::from_lit(SERVICE_OFF);
+  if (state) {
+    resp.service = SERVICE_ON;
+  } else {
+    resp.service = SERVICE_OFF;
+  }
 
   resp.data.init(1);
   auto &entity_id_kv = resp.data.emplace_back();
-  entity_id_kv.key = ProgmemStringRef::from_lit(ENTITY_ID_KEY);
-  entity_id_kv.value = ProgmemStringRef(StringRef(this->entity_id_));
+  entity_id_kv.key = ENTITY_ID_KEY;
+  entity_id_kv.value = StringRef(this->entity_id_);
 
   api::global_api_server->send_homeassistant_action(resp);
 }

esphome/components/homeassistant/text/homeassistant_text.cpp

@@ -6,7 +6,6 @@
 #include "esphome/components/api/api_server.h"
 #include "esphome/core/helpers.h"
 #include "esphome/core/log.h"
-#include "esphome/core/progmem.h"
 #include "esphome/core/string_ref.h"
 
 namespace esphome::homeassistant {
@@ -87,26 +86,27 @@ void HomeassistantText::control(const std::string &value) {
   }
 #endif
 
-  // In flash on the ESP8266 and encoded from there
-  static const char SERVICE_TEXT[] PROGMEM = "text.set_value";
-  static const char SERVICE_INPUT_TEXT[] PROGMEM = "input_text.set_value";
-  static const char ENTITY_ID_KEY[] PROGMEM = "entity_id";
-  static const char VALUE_KEY[] PROGMEM = "value";
+  static constexpr auto SERVICE_TEXT = StringRef::from_lit("text.set_value");
+  static constexpr auto SERVICE_INPUT_TEXT = StringRef::from_lit("input_text.set_value");
+  static constexpr auto ENTITY_ID_KEY = StringRef::from_lit("entity_id");
+  static constexpr auto VALUE_KEY = StringRef::from_lit("value");
+  static constexpr char INPUT_PREFIX[] = "input_";
 
   api::HomeassistantActionRequest resp;
-  // An input helper entity id starts with the "input_" its action name starts with
-  const bool input_helper = ESPHOME_strncmp_P(this->entity_id_, SERVICE_INPUT_TEXT, sizeof("input_") - 1) == 0;
-  resp.service =
-      input_helper ? ProgmemStringRef::from_lit(SERVICE_INPUT_TEXT) : ProgmemStringRef::from_lit(SERVICE_TEXT);
+  if (strncmp(this->entity_id_, INPUT_PREFIX, sizeof(INPUT_PREFIX) - 1) == 0) {
+    resp.service = SERVICE_INPUT_TEXT;
+  } else {
+    resp.service = SERVICE_TEXT;
+  }
 
   resp.data.init(2);
   auto &entity_id_kv = resp.data.emplace_back();
-  entity_id_kv.key = ProgmemStringRef::from_lit(ENTITY_ID_KEY);
-  entity_id_kv.value = ProgmemStringRef(StringRef(this->entity_id_));
+  entity_id_kv.key = ENTITY_ID_KEY;
+  entity_id_kv.value = StringRef(this->entity_id_);
 
   auto &value_kv = resp.data.emplace_back();
-  value_kv.key = ProgmemStringRef::from_lit(VALUE_KEY);
-  value_kv.value = ProgmemStringRef(value.data(), value.size());
+  value_kv.key = VALUE_KEY;
+  value_kv.value = StringRef(value.data(), value.size());
 
   api::global_api_server->send_homeassistant_action(resp);
 }

esphome/components/host/core.cpp

@@ -59,8 +59,8 @@ namespace esphome::host {
 char **get_argv() { return s_argv; }
 
 const std::string &get_exe_path() {
-  static const std::string EMPTY;
-  return s_exe_path != nullptr ? *s_exe_path : EMPTY;
+  static const std::string empty;
+  return s_exe_path != nullptr ? *s_exe_path : empty;
 }
 
 void arm_reexec(const std::string &path) {

esphome/components/host/hal.cpp

@@ -5,7 +5,7 @@
 #include "esphome/core/log.h"
 #include "core.h"
 
-#include <ctime>
+#include <time.h>
 #include <unistd.h>
 #include <cerrno>
 #include <cstdlib>

esphome/components/host/helpers.cpp

@@ -39,8 +39,8 @@ bool Mutex::try_lock() { return static_cast<std::mutex *>(handle_)->try_lock();
 void Mutex::unlock() { static_cast<std::mutex *>(handle_)->unlock(); }
 
 void get_mac_address_raw(uint8_t *mac) {  // NOLINT(readability-non-const-parameter)
-  static constexpr uint8_t HOST_MAC_ADDRESS[MAC_ADDRESS_SIZE] = USE_ESPHOME_HOST_MAC_ADDRESS;
-  memcpy(mac, HOST_MAC_ADDRESS, sizeof(HOST_MAC_ADDRESS));
+  static const uint8_t esphome_host_mac_address[MAC_ADDRESS_SIZE] = USE_ESPHOME_HOST_MAC_ADDRESS;
+  memcpy(mac, esphome_host_mac_address, sizeof(esphome_host_mac_address));
 }
 
 }  // namespace esphome

esphome/components/host/preferences.cpp

@@ -2,7 +2,6 @@
 
 #include <filesystem>
 #include <fstream>
-#include <utility>
 #include "preferences.h"
 #include "esphome/core/application.h"
 #include "esphome/core/log.h"
@@ -46,10 +45,11 @@ void HostPreferences::setup_() {
         break;
       if (fread(&len, sizeof(len), 1, fp) != 1)
         break;
-      std::vector<uint8_t> data(len);
-      if (fread(data.data(), sizeof(uint8_t), len, fp) != len)
+      uint8_t data[len];
+      if (fread(data, sizeof(uint8_t), len, fp) != len)
         break;
-      this->data_[key] = std::move(data);
+      std::vector vec(data, data + len);
+      this->data_[key] = vec;
     }
     fclose(fp);
   }

esphome/components/http_request/http_request_host.cpp

@@ -53,7 +53,7 @@ std::shared_ptr<HttpContainer> HttpRequestHost::perform(const char *url, const c
   for (const auto &[name, value] : request_headers) {
     h_headers.emplace(name, value);
   }
-  httplib::Client client(scheme_host);
+  httplib::Client client(scheme_host.c_str());
   if (!client.is_valid()) {
     ESP_LOGE(TAG, "HTTP Request failed; Invalid URL: %s", url);
     return nullptr;
@@ -114,7 +114,7 @@ std::shared_ptr<HttpContainer> HttpRequestHost::perform(const char *url, const c
   }
 
   container->content_length = container->response_body_.size();
-  for (const auto &header : response.headers) {
+  for (auto header : response.headers) {
     ESP_LOGD(TAG, "Header: %s: %s", header.first.c_str(), header.second.c_str());
     auto lower_name = str_lower_case(header.first);  // NOLINT
     if (should_collect_header(lower_case_collect_headers, lower_name)) {

esphome/components/i2s_audio/speaker/__init__.py

@@ -1,7 +1,6 @@
 from esphome import pins
 import esphome.codegen as cg
 from esphome.components import audio, esp32, speaker
-from esphome.components.microphone import DOMAIN as MICROPHONE_DOMAIN
 from esphome.config_helpers import filter_source_files_from_defines
 import esphome.config_validation as cv
 from esphome.const import (
@@ -15,11 +14,9 @@ from esphome.const import (
     CONF_SAMPLE_RATE,
     CONF_TIMEOUT,
 )
-import esphome.final_validate as fv
 from esphome.types import ConfigType
 
 from .. import (
-    CONF_I2S_AUDIO_ID,
     CONF_I2S_DOUT_PIN,
     CONF_I2S_MODE,
     CONF_LEFT,
@@ -47,7 +44,6 @@ I2SAudioSpeaker = i2s_audio_ns.class_("I2SAudioSpeaker", I2SAudioSpeakerBase)
 
 CONF_DAC_TYPE = "dac_type"
 CONF_I2S_COMM_FMT = "i2s_comm_fmt"
-CONF_KEEP_ALIVE = "keep_alive"
 CONF_SPDIF_MODE = "spdif_mode"
 
 I2SAudioSpeakerBase = i2s_audio_ns.class_(
@@ -177,7 +173,6 @@ BASE_SCHEMA = (
                 cv.positive_time_period_milliseconds,
                 cv.one_of(CONF_NEVER, lower=True),
             ),
-            cv.Optional(CONF_KEEP_ALIVE, default=False): cv.boolean,
         }
     )
     .extend(cv.COMPONENT_SCHEMA)
@@ -240,23 +235,6 @@ def _final_validate(config: ConfigType) -> None:
             raise cv.Invalid("SPDIF mode requires 'i2s_comm_fmt: stand_i2s'")
         if config[CONF_MCLK_MULTIPLE] != 256:
             raise cv.Invalid("SPDIF mode requires 'mclk_multiple: 256'")
-        if config[CONF_KEEP_ALIVE]:
-            raise cv.Invalid("SPDIF mode does not support 'keep_alive'")
-
-    if config[CONF_KEEP_ALIVE]:
-        # A kept channel holds the port between sessions, so nothing else may share the bus
-        bus = config[CONF_I2S_AUDIO_ID]
-        full_config = fv.full_config.get()
-        on_bus = sum(
-            1
-            for domain in (speaker.DOMAIN, MICROPHONE_DOMAIN)
-            for entry in full_config.get(domain, [])
-            if entry.get(CONF_I2S_AUDIO_ID) == bus
-        )
-        if on_bus > 1:
-            raise cv.Invalid(
-                "'keep_alive' needs its own I2S bus; another speaker or microphone shares this one"
-            )
 
 
 FINAL_VALIDATE_SCHEMA = _final_validate
@@ -284,8 +262,6 @@ async def to_code(config: ConfigType) -> None:
     if config[CONF_TIMEOUT] != CONF_NEVER:
         cg.add(var.set_timeout(config[CONF_TIMEOUT]))
     cg.add(var.set_buffer_duration(config[CONF_BUFFER_DURATION]))
-    if config[CONF_KEEP_ALIVE]:
-        cg.add(var.set_keep_alive(True))
 
 
 # The SPDIF encoder and speaker are fully #ifdef'd on USE_I2S_AUDIO_SPDIF_MODE,

esphome/components/i2s_audio/speaker/i2s_audio_speaker.cpp

@@ -56,9 +56,8 @@ void I2SAudioSpeakerBase::dump_config() {
   ESP_LOGCONFIG(TAG,
                 "Speaker:\n"
                 "  Pin: %d\n"
-                "  Buffer duration: %" PRIu32 "\n"
-                "  Keep alive: %s",
-                static_cast<int8_t>(this->dout_pin_), this->buffer_duration_ms_, YESNO(this->keep_alive_));
+                "  Buffer duration: %" PRIu32,
+                static_cast<int8_t>(this->dout_pin_), this->buffer_duration_ms_);
   if (this->timeout_.has_value()) {
     ESP_LOGCONFIG(TAG, "  Timeout: %" PRIu32 " ms", this->timeout_.value());
   }
@@ -106,13 +105,7 @@ void I2SAudioSpeakerBase::loop() {
     vTaskDelete(this->speaker_task_handle_);
     this->speaker_task_handle_ = nullptr;
 
-    // The task raises this bit before it exits, possibly a loop pass before TASK_STOPPED is seen, so read it
-    // live here; a channel the task could not bring up is rebuilt next time rather than kept
-    const bool task_failed = xEventGroupGetBits(this->event_group_) & SpeakerEventGroupBits::ERR_ESP_NO_MEM;
-    if (task_failed) {
-      ESP_LOGE(TAG, "Speaker task setup failed (allocation, preload, or channel enable)");
-    }
-    this->stop_i2s_driver_(this->keep_alive_ && !task_failed);
+    this->stop_i2s_driver_();
     // ALL_BITS includes COMMAND_START. Take the bits from the clear itself, not from the snapshot at
     // the top of loop(): the audio source's task can raise a start at any point above, including
     // during stop_i2s_driver_(), and nothing would ever re-issue it.
@@ -128,6 +121,11 @@ void I2SAudioSpeakerBase::loop() {
     this->state_ = speaker::STATE_STOPPED;
   }
 
+  if (event_group_bits & SpeakerEventGroupBits::ERR_ESP_NO_MEM) {
+    ESP_LOGE(TAG, "Speaker task setup failed (allocation, preload, or channel enable)");
+    xEventGroupClearBits(this->event_group_, SpeakerEventGroupBits::ERR_ESP_NO_MEM);
+  }
+
   // Handle the speaker's state
   switch (this->state_) {
     case speaker::STATE_STARTING:
@@ -135,8 +133,8 @@ void I2SAudioSpeakerBase::loop() {
         break;
       }
 
-      // Still winding down from a previous run
-      if (this->speaker_task_handle_ != nullptr) {
+      // Still starting up or winding down from a previous run
+      if ((this->tx_handle_ != nullptr) || (this->speaker_task_handle_ != nullptr)) {
         break;
       }
 
@@ -156,7 +154,7 @@ void I2SAudioSpeakerBase::loop() {
       if (this->speaker_task_handle_ == nullptr) {
         ESP_LOGE(TAG, "Task failed to start, retrying in 1 second");
         this->status_momentary_error(1000);
-        this->stop_i2s_driver_(false);  // Stops the driver to return the lock; will be reloaded in next attempt
+        this->stop_i2s_driver_();  // Stops the driver to return the lock; will be reloaded in next attempt
       }
       break;
     case speaker::STATE_RUNNING:   // Intentional fallthrough
@@ -272,25 +270,31 @@ esp_err_t I2SAudioSpeakerBase::init_i2s_channel_(const i2s_chan_config_t &chan_c
   err = i2s_channel_init_std_mode(this->tx_handle_, &std_cfg);
   if (err != ESP_OK) {
     ESP_LOGE(TAG, "Failed to initialize I2S channel");
-    this->delete_channel_();
+    i2s_del_channel(this->tx_handle_);
+    this->tx_handle_ = nullptr;
     this->parent_->unlock();
     return err;
   }
 
-  // Both queues are drained by the speaker task before it preloads, whether the channel is new or kept
   if (this->i2s_event_queue_ == nullptr) {
     this->i2s_event_queue_ = xQueueCreate(event_queue_size, sizeof(int64_t));
+  } else {
+    // Reset queue to clear any stale events from previous task
+    xQueueReset(this->i2s_event_queue_);
   }
 
   // Lockstep records queue. One record per in-flight DMA buffer; sized to match the I2S event queue
   // so a fully-saturated DMA pipeline cannot overflow either side before drain.
   if (this->write_records_queue_ == nullptr) {
     this->write_records_queue_ = xQueueCreate(event_queue_size, sizeof(uint32_t));
+  } else {
+    xQueueReset(this->write_records_queue_);
   }
 
   if (this->i2s_event_queue_ == nullptr || this->write_records_queue_ == nullptr) {
     ESP_LOGE(TAG, "Failed to allocate I2S event queue(s)");
-    this->delete_channel_();
+    i2s_del_channel(this->tx_handle_);
+    this->tx_handle_ = nullptr;
     this->parent_->unlock();
     return ESP_ERR_NO_MEM;
   }
@@ -298,30 +302,22 @@ esp_err_t I2SAudioSpeakerBase::init_i2s_channel_(const i2s_chan_config_t &chan_c
   return ESP_OK;
 }
 
-void I2SAudioSpeakerBase::stop_i2s_driver_(bool keep_channel) {
+void I2SAudioSpeakerBase::stop_i2s_driver_() {
   if (this->tx_handle_ != nullptr) {
     i2s_channel_disable(this->tx_handle_);
-    // A kept channel lets the next start skip i2s_new_channel and i2s_channel_init_std_mode, whose GPIO and
-    // clock reconfiguration is the audible pop
-    if (!keep_channel) {
-      this->delete_channel_();
-    }
+    i2s_del_channel(this->tx_handle_);
+    this->tx_handle_ = nullptr;
+
+    // i2s_del_channel() leaves dout wired to this port's data-out signal in the GPIO matrix: it only
+    // clears an internal reservation mask, never the esp_rom_gpio_connect_out_signal() routing that
+    // setup installed. If another speaker reuses this port (shared bus), its audio still reaches our
+    // dout. Detach the pin and drive it low so a stale output stops driving downstream hardware: a
+    // SPDIF optical transmitter would otherwise stay lit, and an analog DAC would emit noise.
+    this->park_dout_pin_();
   }
   this->parent_->unlock();
 }
 
-void I2SAudioSpeakerBase::delete_channel_() {
-  i2s_del_channel(this->tx_handle_);
-  this->tx_handle_ = nullptr;
-
-  // i2s_del_channel() leaves dout wired to this port's data-out signal in the GPIO matrix: it only
-  // clears an internal reservation mask, never the esp_rom_gpio_connect_out_signal() routing that
-  // setup installed. If another speaker reuses this port (shared bus), its audio still reaches our
-  // dout. Detach the pin and drive it low so a stale output stops driving downstream hardware: a
-  // SPDIF optical transmitter would otherwise stay lit, and an analog DAC would emit noise.
-  this->park_dout_pin_();
-}
-
 bool IRAM_ATTR I2SAudioSpeakerBase::i2s_on_sent_cb(i2s_chan_handle_t handle, i2s_event_data_t *event, void *user_ctx) {
   int64_t now = esp_timer_get_time();
 

esphome/components/i2s_audio/speaker/i2s_audio_speaker.h

@@ -54,7 +54,6 @@ class I2SAudioSpeakerBase : public I2SAudioOut, public speaker::Speaker, public
 
   void set_buffer_duration(uint32_t buffer_duration_ms) { this->buffer_duration_ms_ = buffer_duration_ms; }
   void set_timeout(uint32_t ms) { this->timeout_ = ms; }
-  void set_keep_alive(bool keep_alive) { this->keep_alive_ = keep_alive; }
   void set_dout_pin(uint8_t pin) { this->dout_pin_ = (gpio_num_t) pin; }
 
   /// @brief Get the I2S TX channel handle
@@ -127,15 +126,12 @@ class I2SAudioSpeakerBase : public I2SAudioOut, public speaker::Speaker, public
   esp_err_t init_i2s_channel_(const i2s_chan_config_t &chan_cfg, const i2s_std_config_t &std_cfg,
                               size_t event_queue_size);
 
-  /// @brief Stops the I2S driver and unlocks the I2S port; keep_channel leaves the disabled channel allocated
-  void stop_i2s_driver_(bool keep_channel);
+  /// @brief Stops the I2S driver and unlocks the I2S port
+  void stop_i2s_driver_();
 
   /// @brief Detaches dout from the I2S signal and drives it low
   void park_dout_pin_();
 
-  /// @brief Deletes the I2S channel and parks dout; the caller holds the bus lock
-  void delete_channel_();
-
   /// @brief Called in loop() when the task has stopped. Override for mode-specific cleanup.
   virtual void on_task_stopped() {}
 
@@ -181,7 +177,6 @@ class I2SAudioSpeakerBase : public I2SAudioOut, public speaker::Speaker, public
   optional<uint32_t> timeout_;
 
   bool pause_state_{false};
-  bool keep_alive_{false};
 
   // Smooths software gain changes. The main loop posts targets, the speaker task processes;
   // GainRamp's mailbox makes that safe. The main loop is the only poster.

esphome/components/i2s_audio/speaker/i2s_audio_speaker_standard.cpp

@@ -75,9 +75,6 @@ void I2SAudioSpeaker::dump_config() {
 
 void I2SAudioSpeaker::run_speaker_task() {
   xEventGroupSetBits(this->event_group_, SpeakerEventGroupBits::TASK_STARTING);
-  // Stale records from the previous run would pair with the wrong DMA events
-  xQueueReset(this->i2s_event_queue_);
-  xQueueReset(this->write_records_queue_);
 
   const uint32_t dma_buffers_duration_ms = DMA_BUFFER_DURATION_MS * DMA_BUFFERS_COUNT;
   // Ensure ring buffer duration is at least the duration of all DMA buffers
@@ -392,6 +389,8 @@ void I2SAudioSpeaker::run_speaker_task() {
 }
 
 esp_err_t I2SAudioSpeaker::start_i2s_driver(audio::AudioStreamInfo &audio_stream_info) {
+  this->current_stream_info_ = audio_stream_info;
+
   if ((this->i2s_role_ & I2S_ROLE_SLAVE) && (this->sample_rate_ != audio_stream_info.get_sample_rate())) {  // NOLINT
     // Can't reconfigure I2S bus, so the sample rate must match the configured value
     ESP_LOGE(TAG, "Incompatible stream settings");
@@ -429,16 +428,6 @@ esp_err_t I2SAudioSpeaker::start_i2s_driver(audio::AudioStreamInfo &audio_stream
     return ESP_ERR_INVALID_STATE;
   }
 
-  // Reuse a kept channel while the stream format matches
-  if (this->tx_handle_ != nullptr) {
-    if (this->current_stream_info_ == audio_stream_info) {
-      return ESP_OK;
-    }
-    this->delete_channel_();
-  }
-
-  this->current_stream_info_ = audio_stream_info;
-
   // The DMA buffers hold output-format (post-narrowing) samples, so size them from the output stream info.
   uint32_t dma_buffer_length = dma_buffer_frames(this->output_stream_info_);
 

esphome/components/it8951/display.py

@@ -37,6 +37,7 @@ from esphome.const import (
     CONF_WIDTH,
 )
 from esphome.cpp_generator import RawExpression
+from esphome.final_validate import full_config
 from esphome.types import ConfigType
 
 AUTO_LOAD = ["split_buffer"]
@@ -347,8 +348,11 @@ def _final_validate(config: ConfigType) -> None:
         config
     )
 
+    global_config = full_config.get()
+    from esphome.components.lvgl import DOMAIN as LVGL_DOMAIN
+
     if CONF_LAMBDA not in config and CONF_PAGES not in config:
-        if display.has_external_writer(config[CONF_ID]):
+        if LVGL_DOMAIN in global_config:
             if CONF_UPDATE_INTERVAL not in config:
                 config[CONF_UPDATE_INTERVAL] = update_interval("never")
         else:

esphome/components/ld2450/__init__.py

@@ -1,7 +1,6 @@
 from esphome import automation
 import esphome.codegen as cg
 from esphome.components import uart
-from esphome.config_helpers import filter_source_files_from_defines
 import esphome.config_validation as cv
 from esphome.const import CONF_ID, CONF_ON_DATA, CONF_THROTTLE
 from esphome.types import ConfigType
@@ -17,8 +16,6 @@ LD2450Component = ld2450_ns.class_("LD2450Component", cg.Component, uart.UARTDev
 
 
 CONF_LD2450_ID = "ld2450_id"
-CONF_POLYGON_ZONE_ID = "polygon_zone_id"
-CONF_POLYGON_ZONES = "polygon_zones"
 
 CONFIG_SCHEMA = cv.All(
     cv.Schema(
@@ -53,14 +50,6 @@ _CALLBACK_AUTOMATIONS = (
     automation.CallbackAutomation(CONF_ON_DATA, "add_on_data_callback"),
 )
 
-# Polygon zone sources build only when zones are configured
-FILTER_SOURCE_FILES = filter_source_files_from_defines(
-    {
-        "polygon.cpp": "LD2450_POLYGON_ZONE_COUNT",
-        "polygon_zone.cpp": "LD2450_POLYGON_ZONE_COUNT",
-    }
-)
-
 
 async def to_code(config: ConfigType) -> None:
     var = cg.new_Pvariable(config[CONF_ID])

esphome/components/ld2450/binary_sensor.py

@@ -2,7 +2,6 @@ import esphome.codegen as cg
 from esphome.components import binary_sensor
 import esphome.config_validation as cv
 from esphome.const import (
-    CONF_FILTERS,
     CONF_HAS_MOVING_TARGET,
     CONF_HAS_STILL_TARGET,
     CONF_HAS_TARGET,
@@ -12,14 +11,7 @@ from esphome.const import (
 )
 from esphome.types import ConfigType
 
-from . import (  # noqa: F401  pylint: disable=unused-import
-    CONF_LD2450_ID,
-    CONF_POLYGON_ZONE_ID,
-    CONF_POLYGON_ZONES,
-    FILTER_SOURCE_FILES,
-    LD2450Component,
-)
-from .text import PolygonZone
+from . import CONF_LD2450_ID, LD2450Component
 
 DEPENDENCIES = ["ld2450"]
 
@@ -27,18 +19,6 @@ ICON_MEDITATION = "mdi:meditation"
 ICON_SHIELD_ACCOUNT = "mdi:shield-account"
 ICON_TARGET_ACCOUNT = "mdi:target-account"
 
-
-def _reject_filters(config: ConfigType) -> ConfigType:
-    # Clearing a polygon makes presence unknown without going through filters, so they would get out of step
-    if CONF_FILTERS in config:
-        raise cv.Invalid(
-            "Polygon zone presence binary sensors can't have filters; use the ld2450 number platform's "
-            "'presence_timeout' to keep presence on after targets leave",
-            path=[CONF_FILTERS],
-        )
-    return config
-
-
 CONFIG_SCHEMA = {
     cv.GenerateID(CONF_ID): cv.declare_id(cg.EntityBase),
     cv.GenerateID(CONF_LD2450_ID): cv.use_id(LD2450Component),
@@ -57,16 +37,6 @@ CONFIG_SCHEMA = {
         filters=[{"settle": cv.TimePeriod(milliseconds=1000)}],
         icon=ICON_MEDITATION,
     ),
-    cv.Optional(CONF_POLYGON_ZONES): cv.ensure_list(
-        binary_sensor.binary_sensor_schema(
-            device_class=DEVICE_CLASS_OCCUPANCY,
-        ).extend(
-            {
-                cv.Required(CONF_POLYGON_ZONE_ID): cv.use_id(PolygonZone),
-            }
-        ),
-        _reject_filters,
-    ),
 }
 
 
@@ -76,7 +46,3 @@ async def to_code(config: ConfigType) -> None:
     await binary_sensors(CONF_HAS_TARGET, hub.set_target_binary_sensor)
     await binary_sensors(CONF_HAS_MOVING_TARGET, hub.set_moving_target_binary_sensor)
     await binary_sensors(CONF_HAS_STILL_TARGET, hub.set_still_target_binary_sensor)
-    for presence_conf in config.get(CONF_POLYGON_ZONES, []):
-        presence = await binary_sensor.new_binary_sensor(presence_conf)
-        zone = await cg.get_variable(presence_conf[CONF_POLYGON_ZONE_ID])
-        cg.add(zone.set_presence_binary_sensor(presence))

esphome/components/ld2450/ld2450.cpp

@@ -179,11 +179,6 @@ void LD2450Component::setup() {
     this->pref_ = this->presence_timeout_number_->make_entity_preference<float>();
     this->set_presence_timeout();
   }
-#endif
-#ifdef LD2450_POLYGON_ZONE_COUNT
-  for (PolygonZone *zone : this->polygon_zones_) {
-    zone->setup();
-  }
 #endif
   this->restart_and_read_all_info();
 }
@@ -270,12 +265,6 @@ void LD2450Component::dump_config() {
   LOG_BUTTON("  ", "FactoryReset", this->factory_reset_button_);
   LOG_BUTTON("  ", "Restart", this->restart_button_);
 #endif
-#ifdef LD2450_POLYGON_ZONE_COUNT
-  ESP_LOGCONFIG(TAG, "Polygon Zones:");
-  for (PolygonZone *zone : this->polygon_zones_) {
-    zone->dump_config();
-  }
-#endif
 }
 
 void LD2450Component::loop() {
@@ -476,15 +465,15 @@ void LD2450Component::handle_periodic_data_() {
 #if defined(USE_BINARY_SENSOR) || defined(USE_SENSOR) || defined(USE_TEXT_SENSOR)
   // Loop thru targets
   for (index = 0; index < MAX_TARGETS; index++) {
+#ifdef USE_SENSOR
     // X
     start = TARGET_X + index * 8;
     is_moving = false;
-    // tx and ty are used for further calculations, so always need to be populated
+    // tx is used for further calculations, so always needs to be populated
     tx = ld2450::decode_coordinate(this->buffer_data_[start], this->buffer_data_[start + 1]);
     // Y
     start = TARGET_Y + index * 8;
     ty = ld2450::decode_coordinate(this->buffer_data_[start], this->buffer_data_[start + 1]);
-#ifdef USE_SENSOR
     // RESOLUTION
     start = TARGET_RESOLUTION + index * 8;
     res = (this->buffer_data_[start + 1] << 8) | this->buffer_data_[start];
@@ -553,23 +542,6 @@ void LD2450Component::handle_periodic_data_() {
   still_target_count = target_count - moving_target_count;
 #endif
 
-#ifdef LD2450_POLYGON_ZONE_COUNT
-  const uint32_t now = App.get_loop_component_start_time();
-  for (PolygonZone *zone : this->polygon_zones_) {
-    if (!zone->has_polygon())
-      continue;
-    bool target_inside = false;
-    for (const Target &target : this->target_info_) {
-      // Untracked targets are stored as (0, 0)
-      if ((target.x != 0 || target.y != 0) && zone->contains(target.x, target.y)) {
-        target_inside = true;
-        break;
-      }
-    }
-    zone->update(target_inside, now, this->get_timeout_status_(zone->get_last_inside_ms()));
-  }
-#endif
-
 #ifdef USE_SENSOR
   // Loop thru zones
   uint8_t zone_still_targets = 0;
@@ -630,7 +602,7 @@ void LD2450Component::handle_periodic_data_() {
     }
   }
 #endif
-#ifdef USE_BINARY_SENSOR
+#ifdef USE_SENSOR
   // For presence timeout check
   if (target_count > 0) {
     this->presence_millis_ = App.get_loop_component_start_time();

esphome/components/ld2450/ld2450.h

@@ -24,10 +24,6 @@
 #include "esphome/components/binary_sensor/binary_sensor.h"
 #endif
 
-#ifdef LD2450_POLYGON_ZONE_COUNT
-#include "polygon_zone.h"
-#endif
-
 #include "esphome/components/ld24xx/ld24xx.h"
 #include "esphome/components/uart/uart.h"
 #include "esphome/core/helpers.h"
@@ -141,9 +137,6 @@ class LD2450Component : public Component, public uart::UARTDevice {
   void set_zone_target_count_sensor(uint8_t zone, sensor::Sensor *s);
   void set_zone_still_target_count_sensor(uint8_t zone, sensor::Sensor *s);
   void set_zone_moving_target_count_sensor(uint8_t zone, sensor::Sensor *s);
-#endif
-#ifdef LD2450_POLYGON_ZONE_COUNT
-  void register_polygon_zone(PolygonZone *zone) { this->polygon_zones_.push_back(zone); }
 #endif
   void reset_radar_zone();
   void set_radar_zone(int32_t zone_type, int32_t zone1_x1, int32_t zone1_y1, int32_t zone1_x2, int32_t zone1_y2,
@@ -174,7 +167,7 @@ class LD2450Component : public Component, public uart::UARTDevice {
   uint32_t presence_millis_ = 0;
   uint32_t still_presence_millis_ = 0;
   uint32_t moving_presence_millis_ = 0;
-  uint32_t timeout_ = DEFAULT_PRESENCE_TIMEOUT * 1000;  // presence_timeout, in ms
+  uint32_t timeout_ = 5;
   uint8_t buffer_data_[MAX_LINE_LENGTH];
   uint8_t mac_address_[MAC_ADDRESS_SIZE] = {0, 0, 0, 0, 0, 0};
   uint8_t version_[6] = {0, 0, 0, 0, 0, 0};
@@ -207,10 +200,6 @@ class LD2450Component : public Component, public uart::UARTDevice {
   std::array<text_sensor::TextSensor *, MAX_TARGETS> direction_text_sensors_{};
 #endif
 
-#ifdef LD2450_POLYGON_ZONE_COUNT
-  StaticVector<PolygonZone *, LD2450_POLYGON_ZONE_COUNT> polygon_zones_;
-#endif
-
   LazyCallbackManager<void()> data_callback_;
 };
 

esphome/components/ld2450/polygon.cpp

@@ -1,123 +0,0 @@
-#include "polygon.h"
-
-#include "esphome/core/helpers.h"
-
-#include <cstdio>
-
-namespace esphome::ld2450 {
-
-namespace {
-
-class Scanner {
- public:
-  Scanner(const char *str, size_t len) : pos_(str), end_(str + len) {}
-
-  bool at_end() const { return this->pos_ == this->end_; }
-
-  void skip_spaces() {
-    while (this->pos_ != this->end_ && *this->pos_ == ' ')
-      this->pos_++;
-  }
-
-  bool consume(char c) {
-    this->skip_spaces();
-    if (this->pos_ != this->end_ && *this->pos_ == c) {
-      this->pos_++;
-      return true;
-    }
-    return false;
-  }
-
-  /// Read an integer in [min, max]; returns false if there is none or it is out of range.
-  bool read_int(int16_t min, int16_t max, int16_t &out) {
-    bool negative = this->consume('-');
-    int32_t value = 0;
-    uint8_t digits = 0;
-    while (this->pos_ != this->end_ && *this->pos_ >= '0' && *this->pos_ <= '9') {
-      // Six digits is already beyond any valid coordinate; stop before value can overflow
-      if (++digits > 6)
-        return false;
-      value = value * 10 + (*this->pos_ - '0');
-      this->pos_++;
-    }
-    if (digits == 0)
-      return false;
-    if (negative)
-      value = -value;
-    if (value < min || value > max)
-      return false;
-    out = static_cast<int16_t>(value);
-    return true;
-  }
-
- protected:
-  const char *pos_;
-  const char *end_;
-};
-
-}  // namespace
-
-bool Polygon::is_valid() const {
-  if (this->count == 0)
-    return true;
-  if (this->count < MIN_POLYGON_POINTS || this->count > MAX_POLYGON_POINTS)
-    return false;
-  for (uint8_t i = 0; i < this->count; i++) {
-    const Point &p = this->points[i];
-    if (p.x < POLYGON_MIN_X || p.x > POLYGON_MAX_X || p.y < POLYGON_MIN_Y || p.y > POLYGON_MAX_Y)
-      return false;
-  }
-  return true;
-}
-
-bool Polygon::contains(int16_t x, int16_t y) const {
-  bool inside = false;
-  for (uint8_t i = 0, j = this->count - 1; i < this->count; j = i++) {
-    const Point &a = this->points[i];
-    const Point &b = this->points[j];
-    if ((a.y > y) == (b.y > y))
-      continue;
-    // Does the edge a-b cross the ray going from (x, y) towards +x? Compare
-    // x - a.x < (y - a.y) * (b.x - a.x) / (b.y - a.y) without division; values fit in 32 bits.
-    const int32_t dy = static_cast<int32_t>(b.y) - a.y;
-    const int32_t lhs = (static_cast<int32_t>(x) - a.x) * dy;
-    const int32_t rhs = (static_cast<int32_t>(y) - a.y) * (static_cast<int32_t>(b.x) - a.x);
-    if (dy > 0 ? lhs < rhs : lhs > rhs)
-      inside = !inside;
-  }
-  return inside;
-}
-
-bool Polygon::parse(const char *str, size_t len) {
-  Polygon result;
-  Scanner scanner(str, len);
-  scanner.skip_spaces();
-  while (!scanner.at_end()) {
-    if (result.count == MAX_POLYGON_POINTS)
-      return false;
-    Point &p = result.points[result.count];
-    if (!scanner.read_int(POLYGON_MIN_X, POLYGON_MAX_X, p.x) || !scanner.consume(',') ||
-        !scanner.read_int(POLYGON_MIN_Y, POLYGON_MAX_Y, p.y))
-      return false;
-    result.count++;
-    bool separator = scanner.consume(';');
-    scanner.skip_spaces();
-    if (!separator && !scanner.at_end())
-      return false;
-  }
-  if (!result.is_valid())
-    return false;
-  *this = result;
-  return true;
-}
-
-void Polygon::format(char *buf) const {
-  size_t pos = 0;
-  buf[0] = '\0';
-  for (uint8_t i = 0; i < this->count; i++) {
-    pos = buf_append_printf(buf, POLYGON_STR_SIZE, pos, "%s%d,%d", i == 0 ? "" : ";", this->points[i].x,
-                            this->points[i].y);
-  }
-}
-
-}  // namespace esphome::ld2450

esphome/components/ld2450/polygon.h

@@ -1,53 +0,0 @@
-#pragma once
-
-#include <array>
-#include <cstddef>
-#include <cstdint>
-
-namespace esphome::ld2450 {
-
-static constexpr uint8_t MIN_POLYGON_POINTS = 3;
-// The most points whose text always fits Home Assistant's 255-character limit: 23 x "-4860,7560" + 22 x ';' = 252
-static constexpr uint8_t MAX_POLYGON_POINTS = 23;
-// Coordinate limits of the radar detection area, in mm
-static constexpr int16_t POLYGON_MIN_X = -4860;
-static constexpr int16_t POLYGON_MAX_X = 4860;
-static constexpr int16_t POLYGON_MIN_Y = 0;
-static constexpr int16_t POLYGON_MAX_Y = 7560;
-// Longest point is "-4860,7560;" (11 characters), plus the null terminator
-static constexpr size_t POLYGON_STR_SIZE = MAX_POLYGON_POINTS * 11 + 1;
-
-struct Point {
-  int16_t x;
-  int16_t y;
-};
-
-/// A polygon in radar coordinates. Trivially copyable so it can be saved to preferences as-is.
-struct Polygon {
-  std::array<Point, MAX_POLYGON_POINTS> points{};
-  uint8_t count{0};
-
-  /// True when the polygon has no points, which disables the zone.
-  bool empty() const { return this->count == 0; }
-
-  /// True when the polygon is empty, or has a valid number of points that are all inside the radar area.
-  bool is_valid() const;
-
-  /// Return whether the point is inside the polygon (even-odd rule). Always false for an empty polygon.
-  bool contains(int16_t x, int16_t y) const;
-
-  /** Parse "x,y;x,y;..." (mm) into this polygon.
-   *
-   * Spaces around numbers and a trailing ';' are allowed. An empty or all-space string gives an empty polygon.
-   * @return false if the text is invalid; the polygon is then left unchanged.
-   */
-  bool parse(const char *str, size_t len);
-
-  /// Write the polygon as "x,y;x,y;..." into buf, which must hold at least POLYGON_STR_SIZE bytes.
-  void format(char *buf) const;
-};
-
-// text.py counts on this size
-static_assert(sizeof(Polygon) == 94, "Polygon layout changed; update POLYGON_SAVED_BYTES in text.py");
-
-}  // namespace esphome::ld2450

esphome/components/ld2450/polygon_zone.cpp

@@ -1,60 +0,0 @@
-#include "polygon_zone.h"
-#ifdef LD2450_POLYGON_ZONE_COUNT
-
-#include "esphome/core/log.h"
-
-namespace esphome::ld2450 {
-
-ESPHOME_LOG_TAG(TAG, "ld2450.polygon_zone");
-
-void PolygonZone::setup() {
-  // Bump the version when Polygon's layout changes
-  this->pref_ = this->make_entity_preference<Polygon>(1);
-  Polygon saved;
-  if (this->pref_.load(&saved)) {
-    if (saved.is_valid()) {
-      this->polygon_ = saved;
-    } else {
-      ESP_LOGW(TAG, "'%s': saved polygon is invalid; zone disabled", this->get_name().c_str());
-    }
-  }
-  // Presence stays unknown until the first radar frame
-  this->publish_polygon_();
-}
-
-void PolygonZone::dump_config() {
-  char polygon_s[POLYGON_STR_SIZE];
-  this->polygon_.format(polygon_s);
-  LOG_TEXT("  ", "PolygonZone", this);
-  ESP_LOGCONFIG(TAG, "    Polygon: '%s'", polygon_s);
-  LOG_BINARY_SENSOR("    ", "Presence", this->presence_);
-}
-
-void PolygonZone::control(const std::string &value) {
-  Polygon polygon;
-  if (!polygon.parse(value.c_str(), value.size())) {
-    ESP_LOGW(TAG, "'%s': invalid polygon '%s'; expected 'x,y;x,y;...' with %u to %u points", this->get_name().c_str(),
-             value.c_str(), MIN_POLYGON_POINTS, MAX_POLYGON_POINTS);
-  } else if (!this->pref_.save(&polygon)) {
-    // On ESP8266, the space for saved settings is small and can run out with several zones
-    ESP_LOGW(TAG, "'%s': could not save the polygon; keeping the previous one", this->get_name().c_str());
-  } else {
-    this->polygon_ = polygon;
-    // A target seen inside the previous polygon must not keep the new one on
-    this->last_inside_ms_ = 0;
-    if (this->polygon_.empty())
-      this->presence_->invalidate_state();
-  }
-  // On error this publishes the previous polygon again, so the frontend shows the value in use
-  this->publish_polygon_();
-}
-
-void PolygonZone::publish_polygon_() {
-  char polygon_s[POLYGON_STR_SIZE];
-  this->polygon_.format(polygon_s);
-  this->publish_state(polygon_s);
-}
-
-}  // namespace esphome::ld2450
-
-#endif  // LD2450_POLYGON_ZONE_COUNT

esphome/components/ld2450/polygon_zone.h

@@ -1,63 +0,0 @@
-#pragma once
-
-#include "esphome/core/defines.h"
-#ifdef LD2450_POLYGON_ZONE_COUNT
-
-#include "esphome/components/binary_sensor/binary_sensor.h"
-#include "esphome/components/text/text.h"
-#include "esphome/core/preferences.h"
-#include "polygon.h"
-
-namespace esphome::ld2450 {
-
-/** A zone with any polygon shape. The text state holds the polygon, so it can be edited and read back from HA.
- *
- * The polygon is in the radar's raw coordinates (mm), and targets are checked against it as decoded from each
- * radar frame, before any sensor filter. Filters on the target X/Y sensors change only what they publish, so a
- * filter that changes their values (multiply, offset, lambda, ...) puts them in a different frame from the polygon.
- *
- * Like the hub's has_target binary sensors, presence stays on until presence_timeout has passed since a target was
- * last inside the zone.
- */
-class PolygonZone : public text::Text {
- public:
-  /// Config validation guarantees every zone gets exactly one presence binary sensor.
-  void set_presence_binary_sensor(binary_sensor::BinarySensor *presence) { this->presence_ = presence; }
-
-  /// Load the saved polygon and publish it. Called from the hub's setup().
-  void setup();
-  void dump_config();
-  /** Publish presence for one radar frame. A zone without a polygon keeps presence unknown.
-   *
-   * @param target_inside whether any target is inside the zone in this frame.
-   * @param now the frame's time, in ms.
-   * @param timed_out whether presence_timeout has passed since get_last_inside_ms().
-   */
-  void update(bool target_inside, uint32_t now, bool timed_out) {
-    if (this->polygon_.empty())
-      return;
-    if (target_inside) {
-      this->last_inside_ms_ = now;
-      this->presence_->publish_state(true);
-    } else if (timed_out) {
-      this->presence_->publish_state(false);
-    }
-  }
-  /// When a target was last inside the zone, in ms; 0 if never since the polygon was set.
-  uint32_t get_last_inside_ms() const { return this->last_inside_ms_; }
-  bool contains(int16_t x, int16_t y) const { return this->polygon_.contains(x, y); }
-  bool has_polygon() const { return !this->polygon_.empty(); }
-
- protected:
-  void control(const std::string &value) override;
-  void publish_polygon_();
-
-  binary_sensor::BinarySensor *presence_{nullptr};
-  Polygon polygon_;
-  ESPPreferenceObject pref_;
-  uint32_t last_inside_ms_{0};
-};
-
-}  // namespace esphome::ld2450
-
-#endif  // LD2450_POLYGON_ZONE_COUNT

esphome/components/ld2450/sensor.py

@@ -17,7 +17,7 @@ from esphome.const import (
 )
 from esphome.types import ConfigType
 
-from . import CONF_LD2450_ID, FILTER_SOURCE_FILES, LD2450Component  # noqa: F401  pylint: disable=unused-import
+from . import CONF_LD2450_ID, LD2450Component
 
 DEPENDENCIES = ["ld2450"]
 

esphome/components/ld2450/text.py

@@ -1,120 +0,0 @@
-from esphome import preferences
-import esphome.codegen as cg
-from esphome.components import text
-import esphome.config_validation as cv
-from esphome.const import CONF_ID, CONF_PLATFORM, ENTITY_CATEGORY_CONFIG
-import esphome.final_validate as fv
-from esphome.types import ConfigType
-
-from . import (  # noqa: F401  pylint: disable=unused-import
-    CONF_LD2450_ID,
-    CONF_POLYGON_ZONE_ID,
-    CONF_POLYGON_ZONES,
-    DOMAIN,
-    FILTER_SOURCE_FILES,
-    LD2450Component,
-    ld2450_ns,
-)
-
-DEPENDENCIES = ["ld2450"]
-
-ICON_VECTOR_POLYGON = "mdi:vector-polygon"
-
-# Must match MIN_POLYGON_POINTS and MAX_POLYGON_POINTS in polygon.h
-MIN_POLYGON_POINTS = 3
-MAX_POLYGON_POINTS = 23
-# Matches what Polygon::parse() accepts, apart from coordinate ranges, which only the device checks:
-# empty, or MIN_POLYGON_POINTS to MAX_POLYGON_POINTS "x,y" points separated by ';'. HA validates input with it.
-# No character classes: the HA frontend compiles it with the JS "v" flag, HA core with Python re.
-POLYGON_PATTERN = (
-    r"^ *$|^ *-?\d{1,4} *, *\d{1,4} *"
-    rf"(; *-?\d{{1,4}} *, *\d{{1,4}} *){{{MIN_POLYGON_POINTS - 1},{MAX_POLYGON_POINTS - 1}}};? *$"
-)
-# Home Assistant's limit for a state; the longest polygon the device publishes is 252 characters
-POLYGON_MAX_LENGTH = 255
-
-# sizeof(Polygon), pinned by a static_assert in polygon.h
-POLYGON_SAVED_BYTES = 94
-
-PolygonZone = ld2450_ns.class_("PolygonZone", text.Text)
-
-_request_polygon_zone_slot = cg.slot_counter("LD2450_POLYGON_ZONE_COUNT")
-
-
-def _require_manual_id(config: ConfigType) -> ConfigType:
-    if not config[CONF_ID].is_manual:
-        raise cv.Invalid(
-            f"'{CONF_ID}' is required, so the zone's presence binary sensor can refer to it",
-            path=[CONF_ID],
-        )
-    return config
-
-
-CONFIG_SCHEMA = cv.Schema(
-    {
-        cv.GenerateID(CONF_LD2450_ID): cv.use_id(LD2450Component),
-        # Polygons are in raw radar mm, checked before sensor filters (polygon_zone.h)
-        cv.Required(CONF_POLYGON_ZONES): cv.ensure_list(
-            text.text_schema(
-                PolygonZone,
-                entity_category=ENTITY_CATEGORY_CONFIG,
-                icon=ICON_VECTOR_POLYGON,
-                mode="TEXT",
-            ),
-            _require_manual_id,
-        ),
-    }
-)
-
-
-def _final_validate(config: ConfigType) -> None:
-    """Each polygon zone must have exactly one presence binary sensor, on the same LD2450."""
-    full_config = fv.full_config.get()
-    # Polygon zone id -> the LD2450 id of each presence binary sensor that uses it
-    references: dict[str, list[str]] = {}
-    for binary_sensor_conf in full_config.get("binary_sensor", []):
-        if binary_sensor_conf.get(CONF_PLATFORM) != "ld2450":
-            continue
-        hub_id = binary_sensor_conf[CONF_LD2450_ID].id
-        for presence_conf in binary_sensor_conf.get(CONF_POLYGON_ZONES, []):
-            zone_id = presence_conf[CONF_POLYGON_ZONE_ID].id
-            references.setdefault(zone_id, []).append(hub_id)
-
-    zone_hub_id = config[CONF_LD2450_ID].id
-    for index, zone_conf in enumerate(config[CONF_POLYGON_ZONES]):
-        zone_id = zone_conf[CONF_ID].id
-        hub_ids = references.get(zone_id, [])
-        if len(hub_ids) != 1:
-            problem = (
-                "has no presence binary sensor"
-                if not hub_ids
-                else "is used by more than one presence binary sensor"
-            )
-            raise cv.Invalid(
-                f"Polygon zone '{zone_id}' {problem}; each zone needs exactly one, under "
-                f"'binary_sensor: - platform: ld2450' -> '{CONF_POLYGON_ZONES}'",
-                path=[CONF_POLYGON_ZONES, index],
-            )
-        if hub_ids[0] != zone_hub_id:
-            raise cv.Invalid(
-                f"Polygon zone '{zone_id}' belongs to LD2450 '{zone_hub_id}', but its presence "
-                f"binary sensor is under LD2450 '{hub_ids[0]}'; use the same '{CONF_LD2450_ID}'",
-                path=[CONF_POLYGON_ZONES, index],
-            )
-
-
-FINAL_VALIDATE_SCHEMA = _final_validate
-
-
-async def to_code(config: ConfigType) -> None:
-    hub = await cg.get_variable(config[CONF_LD2450_ID])
-    # Each zone saves its polygon; the ESP8266 checks that every component's saved values fit
-    preferences.reserve_preferences(
-        len(config[CONF_POLYGON_ZONES]), POLYGON_SAVED_BYTES
-    )
-    for zone_conf in config[CONF_POLYGON_ZONES]:
-        zone = await text.new_text(
-            zone_conf, max_length=POLYGON_MAX_LENGTH, pattern=POLYGON_PATTERN
-        )
-        _request_polygon_zone_slot(str(hub))
-        cg.add(hub.register_polygon_zone(zone))

esphome/components/ld2450/text_sensor.py

@@ -14,7 +14,7 @@ from esphome.const import (
 )
 from esphome.types import ConfigType
 
-from . import CONF_LD2450_ID, FILTER_SOURCE_FILES, LD2450Component  # noqa: F401  pylint: disable=unused-import
+from . import CONF_LD2450_ID, LD2450Component
 
 DEPENDENCIES = ["ld2450"]
 

esphome/components/ln882h_ble/ln882h_ble.cpp

@@ -246,7 +246,7 @@ static void ble_scan_callback(void *param) {
   memcpy(slot->data, info->data, slot->data_len);
 
   s_ble->push_scan_report(slot);
-}  // NOLINT(clang-analyzer-unix.Malloc) the slot is a pool entry handed to push_scan_report(), not a leak
+}
 
 BLEScanReport *LN882HBLE::allocate_scan_report() {
   BLEScanReport *slot = this->report_pool_.allocate();
@@ -287,7 +287,6 @@ void LN882HBLE::enable() {
     return;
   this->state_ = BLEComponentState::ENABLING;
 
-  // NOLINTNEXTLINE(performance-no-int-to-ptr) - MMIO register at a fixed address
   *reinterpret_cast<volatile uint32_t *>(BLE_COEX_PTI_REG_ADDR) = BLE_COEX_PTI_ENABLE_ALL;
   soc_module_clk_gate_enable(CLK_G_BLE);
 

esphome/components/logger/logger.cpp

@@ -142,8 +142,6 @@ void Logger::log_vprintf_(uint8_t level, const char *tag, int line, const __Flas
 }
 #endif  // USE_ESP8266
 
-uint8_t Logger::get_log_level(const char *tag) { return this->level_for(tag); }
-
 inline uint8_t Logger::level_for(const char *tag) {
 #ifdef USE_LOGGER_RUNTIME_TAG_LEVELS
   // Skip the lookup when no per-tag levels are set

esphome/components/logger/logger.h

@@ -178,8 +178,6 @@ class Logger final : public Component {
   void set_log_level(const char *tag, uint8_t log_level);
 #endif
   uint8_t get_log_level() { return this->current_level_; }
-  /// The level in force for a tag: its own when one is set, else the default
-  uint8_t get_log_level(const char *tag);
 
   // ========== INTERNAL METHODS ==========
   // (In most use cases you won't need these)
@@ -513,14 +511,6 @@ class LoggerMessageTrigger final : public Trigger<uint8_t, const char *, const c
 #endif
 };
 
-#ifdef USE_CRASH_HANDLER
-/// Whether a crash record from before this boot is waiting to be reported
-bool crash_log_pending();
-/// Log the previous crash for a client that just subscribed to the logs. On the ESP32 the record
-/// is kept until a client has seen it, so this call also clears it there.
-void log_crash_to_client();
-#endif
-
 }  // namespace esphome::logger
 
 // Platform-specific inline implementations of write_msg_()

esphome/components/logger/logger_esp32.cpp

@@ -162,16 +162,5 @@ const LogString *Logger::get_uart_selection_() {
   }
 }
 
-#ifdef USE_CRASH_HANDLER
-bool crash_log_pending() { return esp32::crash_handler_has_data(); }
-void log_crash_to_client() {
-  // A level that drops the lines would throw the record away unseen; keep it for a client that can see it
-  if (global_logger->get_log_level(esp32::CRASH_LOG_TAG) < ESPHOME_LOG_LEVEL_ERROR)
-    return;
-  esp32::crash_handler_log();
-  esp32::crash_handler_clear();
-}
-#endif
-
 }  // namespace esphome::logger
 #endif

esphome/components/logger/logger_esp8266.cpp

@@ -48,11 +48,6 @@ const LogString *Logger::get_uart_selection_() {
 #endif
 }
 
-#ifdef USE_CRASH_HANDLER
-bool crash_log_pending() { return esp8266::crash_handler_has_data(); }
-void log_crash_to_client() { esp8266::crash_handler_log(); }
-#endif
-
 }  // namespace esphome::logger
 
 #if !defined(USE_ESP8266_LOGGER_SERIAL) && !defined(USE_ESP8266_LOGGER_SERIAL1)

esphome/components/logger/logger_rp2.cpp

@@ -49,10 +49,5 @@ const LogString *Logger::get_uart_selection_() {
   }
 }
 
-#ifdef USE_CRASH_HANDLER
-bool crash_log_pending() { return rp2::crash_handler_has_data(); }
-void log_crash_to_client() { rp2::crash_handler_log(); }
-#endif
-
 }  // namespace esphome::logger
 #endif  // USE_RP2

esphome/components/lvgl/__init__.py

@@ -335,16 +335,6 @@ def final_validation(config_list):
                 widget_type.final_validate(name, conf, widget_conf, path[1:])
 
 
-def lv_conf_path_flag(lv_conf_h_file: Path) -> str:
-    """The ``-DLV_CONF_PATH`` build flag, decoded identically by the shell
-    lexers (PlatformIO, host, ESP8266) and the quoted CMake arguments
-    (ESP-IDF, Zephyr) the build flags pass through."""
-    # forward slashes for Windows, then escape what shlex or a quoted CMake
-    # argument would not pass through literally
-    path = re.sub(r"[^\w/.:+=,-]", r"\\\g<0>", Path(lv_conf_h_file).as_posix())
-    return f'-DLV_CONF_PATH=\\"{path}\\"'
-
-
 async def to_code(configs):
     config_0 = configs[0]
     # Global configuration
@@ -573,7 +563,9 @@ async def to_code(configs):
     if write_file_if_changed(lv_conf_h_file, generate_lv_conf_h()):
         clean_build(clear_pio_cache=False)
     cg.add_build_flag("-DLV_CONF_H=1")
-    cg.add_build_flag(lv_conf_path_flag(lv_conf_h_file))
+    # handle windows paths in a way that doesn't break the generated C++
+    lv_conf_h_path = Path(lv_conf_h_file).as_posix()
+    cg.add_build_flag(f'-DLV_CONF_PATH=\\"{lv_conf_h_path}\\"')
     cg.add_build_flag("-DLV_KCONFIG_IGNORE")
 
     for prop in df.get_remapped_uses():

esphome/components/micro_wake_word/__init__.py

@@ -13,7 +13,6 @@ from esphome.components.http_request import validate_url
 import esphome.config_validation as cv
 from esphome.const import (
     CONF_FILE,
-    CONF_FRAMEWORK,
     CONF_ID,
     CONF_INTERNAL,
     CONF_MICROPHONE,
@@ -27,12 +26,10 @@ from esphome.const import (
     CONF_TYPE,
     CONF_URL,
     CONF_USERNAME,
-    PLATFORM_ESP32,
     TYPE_GIT,
     TYPE_LOCAL,
 )
 from esphome.core import CORE, HexInt
-import esphome.final_validate as fv
 from esphome.types import ConfigType
 
 _LOGGER = logging.getLogger(__name__)
@@ -44,8 +41,6 @@ DEPENDENCIES = ["microphone"]
 DOMAIN = "micro_wake_word"
 
 
-CONF_TASK_CORE = "task_core"
-
 CONF_FEATURE_STEP_SIZE = "feature_step_size"
 CONF_MODELS = "models"
 CONF_ON_WAKE_WORD_DETECTED = "on_wake_word_detected"
@@ -412,27 +407,6 @@ def _download_http_models(config: ConfigType) -> ConfigType:
     return config
 
 
-def _validate_task_core(config: ConfigType) -> ConfigType:
-    if config[CONF_TASK_CORE] != 1:
-        return config
-    esp32.only_on_variant(
-        supported=[
-            esp32.VARIANT_ESP32,
-            esp32.VARIANT_ESP32S3,
-            esp32.VARIANT_ESP32P4,
-            esp32.VARIANT_ESP32H4,
-            esp32.VARIANT_ESP32S31,
-        ],
-        msg_prefix="micro_wake_word task_core: 1",
-    )(config)
-    sdkconfig = fv.full_config.get()[PLATFORM_ESP32][CONF_FRAMEWORK][
-        esp32.CONF_SDKCONFIG_OPTIONS
-    ]
-    if sdkconfig.get("CONFIG_FREERTOS_UNICORE") == "y":
-        raise cv.Invalid("task_core: 1 requires FreeRTOS dual-core mode")
-    return config
-
-
 CONFIG_SCHEMA = cv.All(
     cv.Schema(
         {
@@ -453,7 +427,6 @@ CONFIG_SCHEMA = cv.All(
             ),
             cv.Optional(CONF_VAD): _maybe_empty_vad_schema,
             cv.Optional(CONF_STOP_AFTER_DETECTION, default=True): cv.boolean,
-            cv.Optional(CONF_TASK_CORE, default=-1): cv.int_range(min=-1, max=1),
             cv.Optional(CONF_PREFER_INTERNAL_RAM, default=False): cv.boolean,
             cv.Optional(CONF_TASK_STACK_IN_PSRAM): psram.validate_task_stack_in_psram,
             cv.Optional(CONF_MODEL): cv.invalid(
@@ -536,7 +509,6 @@ FINAL_VALIDATE_SCHEMA = cv.All(
         },
         extra=cv.ALLOW_EXTRA,
     ),
-    _validate_task_core,
     _feature_step_size_validate,
 )
 
@@ -549,12 +521,6 @@ async def to_code(config):
     cg.add(var.set_microphone_source(mic_source))
 
     cg.add_define("USE_MICRO_WAKE_WORD")
-    cg.add_define(
-        "MICRO_WAKE_WORD_TASK_CORE",
-        cg.RawExpression("tskNO_AFFINITY")
-        if config[CONF_TASK_CORE] == -1
-        else config[CONF_TASK_CORE],
-    )
     if config[CONF_PREFER_INTERNAL_RAM]:
         cg.add_define("USE_MICRO_WAKE_WORD_INTERNAL_RAM")
     ota.request_ota_state_listeners()

esphome/components/micro_wake_word/micro_wake_word.cpp

@@ -17,10 +17,6 @@
 
 namespace esphome::micro_wake_word {
 
-// Config validation checks the YAML, this checks the build: a unicore sdkconfig reached any other way
-static_assert(MICRO_WAKE_WORD_TASK_CORE == tskNO_AFFINITY || MICRO_WAKE_WORD_TASK_CORE < portNUM_PROCESSORS,
-              "micro_wake_word task_core is not a core of this build");
-
 ESPHOME_LOG_TAG(TAG, "micro_wake_word");
 
 static const ssize_t DETECTION_QUEUE_LENGTH = 5;
@@ -88,12 +84,6 @@ static const LogString *micro_wake_word_state_to_string(State state) {
 
 void MicroWakeWord::dump_config() {
   ESP_LOGCONFIG(TAG, "microWakeWord:");
-  // tskNO_AFFINITY is a cast expression, so this cannot be a preprocessor test; the compiler folds it
-  if (MICRO_WAKE_WORD_TASK_CORE == tskNO_AFFINITY) {
-    ESP_LOGCONFIG(TAG, "  Inference task core: any");
-  } else {
-    ESP_LOGCONFIG(TAG, "  Inference task core: %d", MICRO_WAKE_WORD_TASK_CORE);
-  }
   ESP_LOGCONFIG(TAG, "  models:");
   for (auto &model : this->wake_word_models_) {
     model->log_model_config();
@@ -487,8 +477,7 @@ void MicroWakeWord::loop() {
         }
 
         if (!this->inference_task_.create(MicroWakeWord::inference_task, "mww", INFERENCE_TASK_STACK_SIZE,
-                                          (void *) this, INFERENCE_TASK_PRIORITY, this->task_stack_in_psram_,
-                                          MICRO_WAKE_WORD_TASK_CORE)) {
+                                          (void *) this, INFERENCE_TASK_PRIORITY, this->task_stack_in_psram_)) {
           FrontendFreeStateContents(&this->frontend_state_);  // Deallocate frontend state
           this->status_momentary_error(1000);
         }

esphome/components/microphone/microphone_source.cpp

@@ -1,20 +1,9 @@
 #include "microphone_source.h"
 
-#include <array>
-
-#include <gain.h>         // esp-audio-libs
-#include <pcm_convert.h>  // esp-audio-libs
-
 namespace esphome::microphone {
 
-// Builds the exact LinearGain for an integer factor without the float dB conversion: the factor is
-// mantissa / 2^31 * 2^exponent, with the exponent set to the factor's bit width.
-static esp_audio_libs::gain::LinearGain factor_to_linear_gain(uint32_t factor) {
-  esp_audio_libs::gain::LinearGain gain;
-  gain.exponent = 32 - __builtin_clz(factor);
-  gain.mantissa_q31 = static_cast<int32_t>(factor << (31 - gain.exponent));
-  return gain;
-}
+static const int32_t Q25_MAX_VALUE = (1 << 25) - 1;
+static const int32_t Q25_MIN_VALUE = ~Q25_MAX_VALUE;
 
 audio::AudioStreamInfo MicrophoneSource::get_audio_stream_info() {
   return audio::AudioStreamInfo(this->bits_per_sample_, this->channels_.count(),
@@ -37,26 +26,50 @@ void MicrophoneSource::stop() {
 }
 
 void MicrophoneSource::process_audio_(const std::vector<uint8_t> &data, std::vector<uint8_t> &filtered_data) {
-  const audio::AudioStreamInfo source_info = this->mic_->get_audio_stream_info();
-  const uint32_t total_frames = source_info.bytes_to_frames(data.size());
-  const uint8_t target_bytes_per_sample = (this->bits_per_sample_ + 7) / 8;
+  // - Bit depth conversions are obtained by truncating bits or padding with zeros - no dithering is applied.
+  // - In the comments, Qxx refers to a fixed point number with xx bits of precision for representing fractional values.
+  //   For example, audio with a bit depth of 16 can store a sample in a int16, which can be considered a Q15 number.
+  // - All samples are converted to Q25 before applying the gain factor - this results in a small precision loss for
+  //   data with 32 bits per sample. Since the maximum gain factor is 64 = (1<<6), this ensures that applying the gain
+  //   will never overflow a 32 bit signed integer. This still retains more bit depth than what is audibly noticeable.
+  // - Loops for reading/writing data buffers are unrolled, assuming little endian, for a small performance increase.
 
-  // Enabled channels in ascending order, which is their order in each output frame
-  std::array<uint8_t, 8> channel_map;
-  uint8_t target_channels = 0;
-  for (size_t channel = 0; channel < this->channels_.size(); ++channel) {
-    if (this->channels_.test(channel)) {
-      channel_map[target_channels++] = static_cast<uint8_t>(channel);
+  const size_t source_bytes_per_sample = this->mic_->get_audio_stream_info().samples_to_bytes(1);
+  const uint32_t source_channels = this->mic_->get_audio_stream_info().get_channels();
+
+  const size_t source_bytes_per_frame = this->mic_->get_audio_stream_info().frames_to_bytes(1);
+
+  const uint32_t total_frames = this->mic_->get_audio_stream_info().bytes_to_frames(data.size());
+  const size_t target_bytes_per_sample = (this->bits_per_sample_ + 7) / 8;
+  const size_t target_bytes_per_frame = target_bytes_per_sample * this->channels_.count();
+
+  filtered_data.resize(target_bytes_per_frame * total_frames);
+
+  uint8_t *current_data = filtered_data.data();
+
+  for (uint32_t frame_index = 0; frame_index < total_frames; ++frame_index) {
+    for (uint32_t channel_index = 0; channel_index < source_channels; ++channel_index) {
+      if (this->channels_.test(channel_index)) {
+        // Channel's current sample is included in the target mask. Convert bits per sample, if necessary.
+
+        const uint32_t sample_index = frame_index * source_bytes_per_frame + channel_index * source_bytes_per_sample;
+
+        int32_t sample = audio::unpack_audio_sample_to_q31(&data[sample_index], source_bytes_per_sample);  // Q31
+        sample >>= 6;                                                                                      // Q31 -> Q25
+
+        // Apply gain using multiplication
+        sample *= this->gain_factor_;  // Q25
+
+        // Clamp ``sample`` in case gain multiplication overflows 25 bits
+        sample = clamp<int32_t>(sample, Q25_MIN_VALUE, Q25_MAX_VALUE);  // Q25
+
+        sample *= (1 << 6);  // Q25 -> Q31
+
+        audio::pack_q31_as_audio_sample(sample, current_data, target_bytes_per_sample);
+        current_data = current_data + target_bytes_per_sample;
+      }
     }
   }
-
-  filtered_data.resize(static_cast<size_t>(total_frames) * target_bytes_per_sample * target_channels);
-
-  // Applies the gain at full precision before narrowing; samples saturate at full scale, and narrowing rounds
-  esp_audio_libs::pcm_convert::copy_frames_with_gain(data.data(), filtered_data.data(), source_info.samples_to_bytes(1),
-                                                     source_info.get_channels(), target_bytes_per_sample,
-                                                     channel_map.data(), target_channels,
-                                                     factor_to_linear_gain(this->gain_factor_), total_frames);
 }
 
 }  // namespace esphome::microphone