github/esphome
2
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2026-07-10 17:05:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

Rename has_loop_override to HasLoopOverride for clang-tidy naming

Browse Source
This commit is contained in:
J. Nick Koston
2026-03-02 08:09:59 -10:00
parent 5ed3be7b97
commit b8e7870115
2 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
esphome/core/application.h
+4 -4
View File
@@ -120,9 +120,9 @@ namespace esphome {
/// SFINAE helper: resolves to true when &T::loop compiles and differs from &Component::loop.
/// Falls back to true when &T::loop is ambiguous (e.g. multiple inheritance with separate loop() methods).
template<typename T, typename = void> struct has_loop_override : std::true_type {};
template<typename T, typename = void> struct HasLoopOverride : std::true_type {};
template<typename T>
struct has_loop_override<T, std::void_t<decltype(&T::loop)>>
struct HasLoopOverride<T, std::void_t<decltype(&T::loop)>>
: std::bool_constant<!std::is_same_v<decltype(&T::loop), decltype(&Component::loop)>> {};
// Teardown timeout constant (in milliseconds)
@@ -551,9 +551,9 @@ class Application {
#endif
/// Register a component, detecting loop() override at compile time.
/// Uses has_loop_override<T> which handles ambiguous &T::loop from multiple inheritance.
/// Uses HasLoopOverride<T> which handles ambiguous &T::loop from multiple inheritance.
template<typename T> void register_component_(T *comp) {
this->register_component_impl_(comp, has_loop_override<T>::value);
this->register_component_impl_(comp, HasLoopOverride<T>::value);
}
void register_component_impl_(Component *comp, bool has_loop);
esphome/core/config.py
+2 -2
View File
@@ -517,10 +517,10 @@ async def _add_looping_components() -> None:
return
# Build constexpr sum for the exact count, deduplicating by type
# Uses has_loop_override<T> which handles ambiguous &T::loop from multiple inheritance
# Uses HasLoopOverride<T> which handles ambiguous &T::loop from multiple inheritance
type_counts = Counter(entries)
terms = [
f"({count} * has_loop_override<{cpp_type}>::value)"
f"({count} * HasLoopOverride<{cpp_type}>::value)"
for cpp_type, count in type_counts.items()
]
constexpr_expr = " + \\\n ".join(terms)