From b8e78701152a484ac12ebbf0b2aed9e1d6089bd5 Mon Sep 17 00:00:00 2001 From: "J. Nick Koston" Date: Mon, 2 Mar 2026 08:09:59 -1000 Subject: [PATCH] Rename has_loop_override to HasLoopOverride for clang-tidy naming --- esphome/core/application.h | 8 ++++---- esphome/core/config.py | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/esphome/core/application.h b/esphome/core/application.h index b8c8f1370a..70b88ca3d2 100644 --- a/esphome/core/application.h +++ b/esphome/core/application.h @@ -120,9 +120,9 @@ namespace esphome { /// SFINAE helper: resolves to true when &T::loop compiles and differs from &Component::loop. /// Falls back to true when &T::loop is ambiguous (e.g. multiple inheritance with separate loop() methods). -template struct has_loop_override : std::true_type {}; +template struct HasLoopOverride : std::true_type {}; template -struct has_loop_override> +struct HasLoopOverride> : std::bool_constant> {}; // Teardown timeout constant (in milliseconds) @@ -551,9 +551,9 @@ class Application { #endif /// Register a component, detecting loop() override at compile time. - /// Uses has_loop_override which handles ambiguous &T::loop from multiple inheritance. + /// Uses HasLoopOverride which handles ambiguous &T::loop from multiple inheritance. template void register_component_(T *comp) { - this->register_component_impl_(comp, has_loop_override::value); + this->register_component_impl_(comp, HasLoopOverride::value); } void register_component_impl_(Component *comp, bool has_loop); diff --git a/esphome/core/config.py b/esphome/core/config.py index 18d3648cb8..9411949bb9 100644 --- a/esphome/core/config.py +++ b/esphome/core/config.py @@ -517,10 +517,10 @@ async def _add_looping_components() -> None: return # Build constexpr sum for the exact count, deduplicating by type - # Uses has_loop_override which handles ambiguous &T::loop from multiple inheritance + # Uses HasLoopOverride which handles ambiguous &T::loop from multiple inheritance type_counts = Counter(entries) terms = [ - f"({count} * has_loop_override<{cpp_type}>::value)" + f"({count} * HasLoopOverride<{cpp_type}>::value)" for cpp_type, count in type_counts.items() ] constexpr_expr = " + \\\n ".join(terms)