github/esphome
2
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2026-09-15 17:18:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

[core] Limit play_complex override to StatelessLambdaAction only

Browse Source 
LambdaAction and ContinuationAction overrides caused flash bloat
by replacing shared base class play_complex instantiations with
per-class copies. StatelessLambdaAction is the most common
automation action and its no-args variant is only 24 bytes.
This commit is contained in:
J. Nick Koston
2026-03-20 18:52:12 -10:00
parent 884db8060a
commit aacc7e54d2
1 changed files with 0 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files
esphome/core/base_automation.h
-14
View File
@@ -217,13 +217,6 @@ template<typename... Ts> class LambdaAction : public Action<Ts...> {
public:
explicit LambdaAction(std::function<void(Ts...)> &&f) : f_(std::move(f)) {}
// Override play_complex to call play() non-virtually (qualified call),
// eliminating one virtual dispatch frame from the call stack.
void play_complex(const Ts &...x) override {
this->num_running_++;
LambdaAction::play(x...);
this->play_next_(x...);
}
void play(const Ts &...x) override { this->f_(x...); }
protected:
@@ -257,13 +250,6 @@ template<typename... Ts> class ContinuationAction : public Action<Ts...> {
public:
explicit ContinuationAction(Action<Ts...> *parent) : parent_(parent) {}
// Override play_complex to call play() non-virtually (qualified call),
// eliminating one virtual dispatch frame from the call stack.
void play_complex(const Ts &...x) override {
this->num_running_++;
ContinuationAction::play(x...);
this->play_next_(x...);
}
void play(const Ts &...x) override { this->parent_->play_next_(x...); }
protected: