github/terraform-provider-unifi
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Apply suggestions from code review

Browse Source
This commit is contained in:
Paul Tyng
2021-08-10 10:16:10 -04:00
parent 4c36a8af1b
commit a3094fb13c
3 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
go.sum
View File

@@ -518,7 +518,6 @@ golang.org/x/sys v0.0.0-20210320140829-1e4c9ba3b0c4/go.mod h1:h1NjWce9XRLGQEsW7w
golang.org/x/sys v0.0.0-20210324051608-47abb6519492/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
golang.org/x/sys v0.0.0-20210502180810-71e4cd670f79 h1:RX8C8PRZc2hTIod4ds8ij+/4RQX3AqhYj3uOHmyaz4E=
golang.org/x/sys v0.0.0-20210502180810-71e4cd670f79/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
golang.org/x/term v0.0.0-20201126162022-7de9c90e9dd1 h1:v+OssWQX+hTHEmOBgwxdZxK4zHq3yOs8F9J7mk0PY8E=
golang.org/x/term v0.0.0-20201126162022-7de9c90e9dd1/go.mod h1:bj7SfCRtBDWHUb9snDiAeCFNEtKQo2Wmx5Cou7ajbmo=
golang.org/x/text v0.0.0-20170915032832-14c0d48ead0c/go.mod h1:NqM8EUOU14njkJ3fqMW+pc6Ldnwhi/IjpwHt7yyuwOQ=
golang.org/x/text v0.3.0/go.mod h1:NqM8EUOU14njkJ3fqMW+pc6Ldnwhi/IjpwHt7yyuwOQ=

2
internal/provider/data_ap_group.go
View File

@@ -47,7 +47,7 @@ func dataAPGroupRead(ctx context.Context, d *schema.ResourceData, meta interface
site = c.site
}
groups, err := c.c.ListAPGroup(context.TODO(), site)
groups, err := c.c.ListAPGroup(ctx, site)
if err != nil {
return diag.FromErr(err)
}

6
internal/provider/resource_network.go
View File

@@ -319,7 +319,7 @@ func resourceNetworkGetResourceData(d *schema.ResourceData) (*unifi.Network, err
func resourceNetworkSetResourceData(resp *unifi.Network, d *schema.ResourceData, site string) diag.Diagnostics {
wanType := ""
var wanDNS []string
wanDNS := []string{}
wanIP := ""
wanNetmask := ""
wanGateway := ""
@@ -358,7 +358,7 @@ func resourceNetworkSetResourceData(resp *unifi.Network, d *schema.ResourceData,
dhcpLease = 86400
}
var dhcpDNS []string
dhcpDNS := []string{}
if resp.DHCPDDNSEnabled {
for _, dns := range []string{
resp.DHCPDDNS1,
@@ -508,7 +508,7 @@ func getNetworkIDByName(ctx context.Context, client unifiClient, networkName, si
}
idMatchingName := ""
var allNames []string
allNames := []string{}
for _, network := range networks {
allNames = append(allNames, network.Name)
if network.Name != networkName {