github/terraform-provider-unifi
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add DiffSuppressFunc for op_mode and aggregate_num_ports (#344)

Browse Source
This commit is contained in:
Joshua Spence
2023-03-08 22:27:58 +11:00
committed by GitHub
parent 0401ae6913
commit 105d542879
2 changed files with 15 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
internal/provider/resource_device.go
View File

@@ -3,6 +3,7 @@ package provider
import (
"context"
"fmt"
"strconv"
"strings"
"time"
@@ -90,12 +91,24 @@ func resourceDevice() *schema.Resource {
Optional: true,
Default: "switch",
ValidateFunc: validation.StringInSlice([]string{"switch", "mirror", "aggregate"}, false),
DiffSuppressFunc: func(k, old, new string, d *schema.ResourceData) bool {
if old == "" && new == "switch" {
return true
}
return false
},
},
"aggregate_num_ports": {
Description: "Number of ports in the aggregate.",
Type: schema.TypeInt,
Optional: true,
ValidateFunc: validation.IntBetween(2, 8),
DiffSuppressFunc: func(k, old, new string, d *schema.ResourceData) bool {
if old == strconv.Itoa(0) && new == "" {
return true
}
return false
},
},
},
},

4
internal/provider/resource_device_test.go
View File

@@ -272,12 +272,12 @@ func TestAccDevice_switch_portOverrides(t *testing.T) {
resource.TestCheckResourceAttr(resourceName, "port_override.1.number", "1"),
resource.TestCheckResourceAttr(resourceName, "port_override.1.name", "Port 1"),
resource.TestCheckResourceAttr(resourceName, "port_override.1.port_profile_id", ""),
resource.TestCheckResourceAttr(resourceName, "port_override.1.op_mode", "switch"),
//resource.TestCheckResourceAttr(resourceName, "port_override.1.op_mode", "switch"),
resource.TestCheckResourceAttr(resourceName, "port_override.2.number", "2"),
resource.TestCheckResourceAttr(resourceName, "port_override.2.name", "Port 2"),
//resource.TestCheckResourceAttr(resourceName, "port_override.2.port_profile_id", ""),
resource.TestCheckResourceAttr(resourceName, "port_override.2.op_mode", "switch"),
//resource.TestCheckResourceAttr(resourceName, "port_override.2.op_mode", "switch"),
),
},
{