mirror of
https://github.com/esphome/esphome.git
synced 2026-09-14 00:28:39 +00:00
J. Nick Koston
f75d6ab88d
Two doc-drift fixes flagged by copilot review: 1. esphome_fast_select_set_ota_listener_sock() header comment claimed passing NULL 'clears the filter' so wake fires on every RCVPLUS. The actual code stores NULL and the conn == s_ota_listener_conn check never matches, so NULL means 'no wakes' not 'all wakes'. Rewrite to describe the actual semantics (install a listener to enable filtered wakes; NULL disables OTA wakes entirely). 2. ESPHomeOTAComponent::loop() docstring still claimed false wakes from unrelated monitored sockets are expected. Post-filter that's no longer true on fast-select (filtered to OTA listener netconn) or raw TCP (per-pcb accept_fn_). Rewrite to describe the current behavior: loop() runs ~once per real incoming OTA connection, with the idle self-disable retained as a safety net for the few narrow cases where a wake can land with no pending work (queued-during-session, filter not yet installed, host select fallback).
