mirror of
https://github.com/esphome/esphome.git
synced 2026-09-17 18:18:43 +00:00
J. Nick Koston
5a9e55707b
Two bugs fixed from Copilot review: 1. Dangling pointer on copy: deprecated setters stored data in an OwnedCustomModes struct on ClimateTraits. If the traits object was copied (when NRVO doesn't apply), the copy's pointer dangled. Fix: deprecated setters now heap-allocate (intentional leak, same pattern as Climate entity). Pointer survives any copy. Remove the OwnedCustomModes wrapper entirely. 2. find_custom_fan_mode_ / find_custom_preset_ only searched the Climate-owned vectors, breaking external components using the deprecated traits setters. Fix: fall back to get_traits() when the entity vector is null.
