[factory_reset] Use a user provided default constructor for FactoryResetSwitch

2026-10-26 16:02:13 +00:00 · 2026-09-12 05:35:39 -05:00
2 changed files with 5 additions and 5 deletions
@@ -8,6 +8,9 @@ namespace esphome::factory_reset {

 class FactoryResetSwitch final : public switch_::Switch, public Component {
 public:
+  // User provided, not "= default": `new(p) FactoryResetSwitch()` would zero-fill .bss that is already zero.
+  FactoryResetSwitch() {}
+
  void dump_config() override;
 #ifdef USE_OPENTHREAD
  static void factory_reset_callback();
@@ -15,9 +15,6 @@ namespace esphome::http_request {

 class HttpRequestUpdate final : public update::UpdateEntity, public PollingComponent, public ota::OTAStateListener {
 public:
-  // User provided, not "= default": `new(p) HttpRequestUpdate()` would zero-fill .bss that is already zero.
-  HttpRequestUpdate() {}
-
  void setup() override;
  void update() override;

@@ -34,8 +31,8 @@ class HttpRequestUpdate final : public update::UpdateEntity, public PollingCompo
  void on_ota_state(ota::OTAState state, float progress, uint8_t error) override;

 protected:
-  HttpRequestComponent *request_parent_{nullptr};
-  OtaHttpRequestComponent *ota_parent_{nullptr};
+  HttpRequestComponent *request_parent_;
+  OtaHttpRequestComponent *ota_parent_;
  std::string source_url_;

  static void update_task(void *params);