github/esphome
2
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2026-09-11 15:27:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

Address review: notify/pairing breadcrumbs, aborted fan-out trace

Browse Source 
- on_notify_state and on_pairing_result are handled on the neutral
  client: a failed registration or pairing logs instead of vanishing
  into the default no-op on a frozen surface
- A node tearing the link down during the connect fan-out leaves a
  warning, since on_disconnect then fires with no preceding on_connect
This commit is contained in:
J. Nick Koston
2026-08-09 12:59:24 -05:00
parent 5572bf77dd
commit fb64b18047
2 changed files with 22 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
esphome/components/ble_client/ble_client_gatt.cpp
+20 -2
View File
@@ -159,8 +159,9 @@ void BLEClient::on_service_discovery_done(int error) {
for (auto *node : this->nodes_) {
node->on_connected(table);
if (this->state_ != State::CONNECTED) {
// A node tore the link down mid-fan-out; the normal release below is
// skipped (release is idempotent).
// A node tore the link down mid-fan-out: on_disconnect fires with no
// preceding on_connect, so leave a trace of why.
ESP_LOGW(TAG, "[%s] A node aborted the connection during setup", this->address_str_);
this->backend_->release_services();
return;
}
@@ -199,6 +200,23 @@ void BLEClient::on_notify_data(uint16_t handle, const uint8_t *data, uint16_t le
}
}
void BLEClient::on_notify_state(uint16_t handle, bool enabled, int error) {
// Breadcrumb only until the first notify node lands; a dropped failure
// here would otherwise be silent on a frozen surface.
if (error != 0) {
ESP_LOGW(TAG, "[%s] Notify %s on handle 0x%04x failed, status=%d", this->address_str_,
enabled ? "enable" : "disable", handle, error);
}
}
void BLEClient::on_pairing_result(int status) {
if (status != 0) {
ESP_LOGW(TAG, "[%s] Pairing failed, status=%d", this->address_str_, status);
} else {
ESP_LOGI(TAG, "[%s] Paired", this->address_str_);
}
}
void BLEClient::dump_config() {
ESP_LOGCONFIG(TAG,
"BLE Client:\n"
esphome/components/ble_client/ble_client_gatt.h
+2
View File
@@ -121,6 +121,8 @@ class BLEClient : public Component,
void on_read_result(uint16_t handle, const uint8_t *data, uint16_t len, int error) override;
void on_write_result(uint16_t handle, int error) override;
void on_notify_data(uint16_t handle, const uint8_t *data, uint16_t len) override;
void on_notify_state(uint16_t handle, bool enabled, int error) override;
void on_pairing_result(int status) override;
protected:
enum class State : uint8_t { IDLE, CONNECTING, DISCOVERING, CONNECTED };