github/esphome
2
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2026-09-14 08:38:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

[wifi] Fix infinite roaming when best-signal AP is crashed/broken

Browse Source
This commit is contained in:
J. Nick Koston
2026-01-07 16:16:47 -10:00
parent d0843d504e
commit fb4d50150a
1 changed files with 9 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
esphome/components/wifi/wifi_component.cpp
+9 -2
View File
@@ -1308,7 +1308,11 @@ void WiFiComponent::check_connecting_finished(uint32_t now) {
// Only reset attempts if this wasn't a roaming-triggered connection
// (CONNECTING = roam attempt, RECONNECTING = failed roam, reconnecting)
// This prevents ping-pong between APs when a roam target is unreachable
if (this->roaming_state_ == RoamingState::IDLE) {
if (this->roaming_state_ == RoamingState::CONNECTING) {
ESP_LOGD(TAG, "Roam successful");
} else if (this->roaming_state_ == RoamingState::RECONNECTING) {
ESP_LOGD(TAG, "Reconnected after failed roam (attempt %u/%u)", this->roaming_attempts_, ROAMING_MAX_ATTEMPTS);
} else {
this->roaming_attempts_ = 0;
}
this->roaming_state_ = RoamingState::IDLE;
@@ -1741,6 +1745,7 @@ void WiFiComponent::retry_connect() {
// (preserves roaming_attempts_ so we stop roaming after ROAMING_MAX_ATTEMPTS failures)
// Otherwise reset all roaming state
if (this->roaming_state_ == RoamingState::CONNECTING) {
ESP_LOGD(TAG, "Roam failed, reconnecting (attempt %u/%u)", this->roaming_attempts_, ROAMING_MAX_ATTEMPTS);
this->roaming_state_ = RoamingState::RECONNECTING;
// Keep roaming_attempts_ - will prevent further roaming after max failures
} else if (this->roaming_state_ != RoamingState::RECONNECTING) {
@@ -2021,8 +2026,10 @@ void WiFiComponent::check_roaming_(uint32_t now) {
// Guard: skip scan if signal is already good (no meaningful improvement possible)
int8_t rssi = this->wifi_rssi();
if (rssi > ROAMING_GOOD_RSSI)
if (rssi > ROAMING_GOOD_RSSI) {
ESP_LOGV(TAG, "Roam check skipped, signal good (%d dBm)", rssi);
return;
}
ESP_LOGD(TAG, "Roam scan (%d dBm)", rssi);
this->roaming_state_ = RoamingState::SCANNING;