github/esphome
2
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2026-09-24 05:24:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

[esp32] Drop IRAM_ATTR from the Log V2 esp_log_format override

Browse Source
This commit is contained in:
J. Nick Koston
2026-07-01 20:17:07 -05:00
parent e8e5f6366d
commit f843cc81c6
1 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
esphome/core/log.cpp
+6 -3
View File
@@ -140,9 +140,12 @@ static void __attribute__((noinline)) esp_log_format_direct_(esp_log_msg_t *mess
extern "C" {
// Override esp_log_format from liblog.a to prevent V2's 3-call vprintf
// fragmentation. IRAM_ATTR to match esp_log_va's IRAM placement and avoid
// an IRAM->flash cache miss on every ESP-IDF log call.
void IRAM_ATTR esp_log_format(esp_log_msg_t *message) {
// fragmentation. Deliberately NOT IRAM_ATTR: every caller that must work with
// flash cache disabled (ESP_DRAM_LOGx, ESP_EARLY_LOGx) bypasses esp_log()
// entirely under CONFIG_LOG_API_CONSTRAINED_ENV_SAFE=n, and both paths below
// immediately call flash-resident code anyway, so IRAM placement would only
// spend the IRAM this change exists to save.
void esp_log_format(esp_log_msg_t *message) {
extern vprintf_like_t esp_log_vprint_func;
extern int vprintf(const char *, __gnuc_va_list); // NOLINT
if (esp_log_vprint_func == &vprintf || message->config.opts.constrained_env) [[unlikely]] {