[tmp117] Code clean-up (#15260)

This commit is contained in:
Keith Burzinski
2026-03-27 17:59:26 -05:00
committed by GitHub
parent 76d75850a3
commit f6c63c62e4
2 changed files with 9 additions and 14 deletions
+7 -10
View File
@@ -4,8 +4,7 @@
#include "tmp117.h"
#include "esphome/core/log.h"
namespace esphome {
namespace tmp117 {
namespace esphome::tmp117 {
static const char *const TAG = "tmp117";
@@ -18,11 +17,10 @@ void TMP117Component::update() {
if ((uint16_t) data != 0x8000) {
float temperature = data * 0.0078125f;
ESP_LOGD(TAG, "Got temperature=%.2f°C", temperature);
this->publish_state(temperature);
this->status_clear_warning();
} else {
ESP_LOGD(TAG, "TMP117 not ready");
ESP_LOGD(TAG, "Not ready");
}
}
void TMP117Component::setup() {
@@ -38,7 +36,7 @@ void TMP117Component::setup() {
}
}
void TMP117Component::dump_config() {
ESP_LOGD(TAG, "TMP117:");
ESP_LOGCONFIG(TAG, "TMP117:");
LOG_I2C_DEVICE(this);
if (this->is_failed()) {
ESP_LOGE(TAG, ESP_LOG_MSG_COMM_FAIL);
@@ -48,7 +46,7 @@ void TMP117Component::dump_config() {
bool TMP117Component::read_data_(int16_t *data) {
if (!this->read_byte_16(0, (uint16_t *) data)) {
ESP_LOGW(TAG, "Updating TMP117 failed!");
ESP_LOGW(TAG, "Updating failed");
return false;
}
return true;
@@ -56,7 +54,7 @@ bool TMP117Component::read_data_(int16_t *data) {
bool TMP117Component::read_config_(uint16_t *config) {
if (!this->read_byte_16(1, (uint16_t *) config)) {
ESP_LOGW(TAG, "Reading TMP117 config failed!");
ESP_LOGW(TAG, "Reading config failed");
return false;
}
return true;
@@ -64,11 +62,10 @@ bool TMP117Component::read_config_(uint16_t *config) {
bool TMP117Component::write_config_(uint16_t config) {
if (!this->write_byte_16(1, config)) {
ESP_LOGE(TAG, "Writing TMP117 config failed!");
ESP_LOGE(TAG, "Writing config failed");
return false;
}
return true;
}
} // namespace tmp117
} // namespace esphome
} // namespace esphome::tmp117
+2 -4
View File
@@ -4,8 +4,7 @@
#include "esphome/components/sensor/sensor.h"
#include "esphome/components/i2c/i2c.h"
namespace esphome {
namespace tmp117 {
namespace esphome::tmp117 {
class TMP117Component : public PollingComponent, public i2c::I2CDevice, public sensor::Sensor {
public:
@@ -22,5 +21,4 @@ class TMP117Component : public PollingComponent, public i2c::I2CDevice, public s
uint16_t config_;
};
} // namespace tmp117
} // namespace esphome
} // namespace esphome::tmp117