Inline init_log_buffer_ into constructor

This commit is contained in:
J. Nick Koston
2026-03-21 17:00:26 -10:00
parent b0e6f57bc2
commit e32565b36a
2 changed files with 4 additions and 11 deletions
+4 -10
View File
@@ -165,18 +165,12 @@ Logger::Logger(uint32_t baud_rate) : baud_rate_(baud_rate) {
this->main_thread_ = pthread_self();
#endif
#ifdef USE_ESPHOME_TASK_LOG_BUFFER
this->init_log_buffer_(task_log_buffer_size);
#endif
}
#ifdef USE_ESPHOME_TASK_LOG_BUFFER
void Logger::init_log_buffer_(size_t total_buffer_size) {
// NOLINTNEXTLINE(cppcoreguidelines-owning-memory) - allocated once, never freed
this->log_buffer_ = new logger::TaskLogBuffer(total_buffer_size);
// Note: we don't call disable_loop_when_buffer_empty_() here because this is called
// from the constructor before the component is registered with App. The loop will
// self-disable on its first iteration when it finds no messages to process.
}
this->log_buffer_ = new logger::TaskLogBuffer(task_log_buffer_size);
// Note: we don't disable loop here because the component isn't registered with App yet.
// The loop self-disables on its first iteration when it finds no messages to process.
#endif
}
#if defined(USE_ESPHOME_TASK_LOG_BUFFER) || (defined(USE_ZEPHYR) && defined(USE_LOGGER_UART_SELECTION_USB_CDC))
void Logger::loop() {
-1
View File
@@ -354,7 +354,6 @@ class Logger final : public Component {
std::vector<LoggerLevelListener *> level_listeners_; // Log level change listeners
#endif
#ifdef USE_ESPHOME_TASK_LOG_BUFFER
void init_log_buffer_(size_t total_buffer_size);
logger::TaskLogBuffer *log_buffer_{nullptr}; // Allocated once, never freed
#endif