github/esphome
2
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2026-09-11 15:27:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

[sx1509] Only clear interrupt source when interrupt actually fired

Browse Source
This commit is contained in:
J. Nick Koston
2026-04-09 16:57:18 -10:00
parent 867df4225a
commit dce6d5ab0c
2 changed files with 12 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
esphome/components/sx1509/sx1509.cpp
+11 -5
View File
@@ -41,7 +41,10 @@ void SX1509Component::setup() {
}
}
void IRAM_ATTR SX1509Component::gpio_intr(SX1509Component *arg) { arg->enable_loop_soon_any_context(); }
void IRAM_ATTR SX1509Component::gpio_intr(SX1509Component *arg) {
arg->interrupt_pending_ = true;
arg->enable_loop_soon_any_context();
}
void SX1509Component::dump_config() {
ESP_LOGCONFIG(TAG, "SX1509:");
LOG_PIN(" Interrupt Pin: ", this->interrupt_pin_);
@@ -52,16 +55,19 @@ void SX1509Component::dump_config() {
}
void SX1509Component::loop() {
if (this->interrupt_pin_ != nullptr) {
if (this->interrupt_pending_) {
this->interrupt_pending_ = false;
// Clear interrupt source before resetting cache to avoid losing
// pin changes that occur between cache reset and interrupt clear
uint16_t interrupt_source = 0;
this->read_byte_16(REG_INTERRUPT_SOURCE_B, &interrupt_source);
this->reset_pin_cache_();
if (!this->has_keypad_) {
this->disable_loop();
}
return;
}
this->reset_pin_cache_();
if (this->interrupt_pin_ != nullptr && !this->has_keypad_) {
this->disable_loop();
}
if (this->has_keypad_) {
if (millis() - this->last_loop_timestamp_ < min_loop_period_)
esphome/components/sx1509/sx1509.h
+1
View File
@@ -89,6 +89,7 @@ class SX1509Component : public Component,
std::vector<SX1509KeyTrigger *> key_triggers_;
InternalGPIOPin *interrupt_pin_{nullptr};
volatile bool interrupt_pending_{false};
uint32_t last_loop_timestamp_ = 0;
const uint32_t min_loop_period_ = 15; // ms