github/esphome
2
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2026-09-20 19:48:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove dead call_loop override check from has_overridden_loop()

Browse Source 
Since call_loop() is no longer virtual, the pointer-to-member
comparison can never detect an override. Remove the dead code.
This commit is contained in:
J. Nick Koston
2026-02-18 22:41:17 -06:00
parent 37d196643c
commit db8618e5fe
1 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
esphome/core/component.cpp
+2 -4
View File
@@ -492,16 +492,14 @@ void Component::set_setup_priority(float priority) {
bool Component::has_overridden_loop() const {
#if defined(USE_HOST) || defined(CLANG_TIDY)
bool loop_overridden = true;
bool call_loop_overridden = true;
return true;
#else
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wpmf-conversions"
bool loop_overridden = (void *) (this->*(&Component::loop)) != (void *) (&Component::loop);
bool call_loop_overridden = (void *) (this->*(&Component::call_loop)) != (void *) (&Component::call_loop);
#pragma GCC diagnostic pop
return loop_overridden;
#endif
return loop_overridden || call_loop_overridden;
}
PollingComponent::PollingComponent(uint32_t update_interval) : update_interval_(update_interval) {}