github/esphome
2
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2026-08-27 00:18:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

[esp32_hosted] Mark esp_now shim recv/send callback pointers volatile

Browse Source 
They are written from the main loop and read from the esp-hosted RX thread;
volatile matches the treatment of the g_resp_* globals and makes the
cross-thread visibility intent explicit (per review).
This commit is contained in:
Jesse Hills
2026-07-21 11:57:49 +12:00
parent 8155209689
commit cbb3c8f087
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
esphome/components/esp32_hosted/esp_now_hosted.cpp
+6 -2
View File
@@ -61,8 +61,12 @@ volatile int32_t g_resp_status = 0;
uint8_t g_resp_ret[16];
volatile uint16_t g_resp_ret_len = 0;
esp_now_recv_cb_t g_recv_cb = nullptr;
esp_now_send_cb_t g_send_cb = nullptr;
// Written from the main loop (register/unregister/deinit), read from the
// esp-hosted RX thread (on_recv/on_send). volatile for the same reason the
// g_resp_* globals are: force the RX thread to observe an updated pointer
// (e.g. a nulling by esp_now_deinit) rather than a cached one.
volatile esp_now_recv_cb_t g_recv_cb = nullptr;
volatile esp_now_send_cb_t g_send_cb = nullptr;
// ── CustomRpc event handlers (run on the esp-hosted RPC RX thread) ──────────
// Keep them short and non-blocking. In particular they MUST NOT call back into