github/esphome
2
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2026-09-04 03:56:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

Address review feedback

Browse Source 
- Actually filter bot reviews (not just comment about it)
- Use core.setFailed() instead of silently swallowing errors
- Remove unused getEffectiveOwners import from detectors.js
This commit is contained in:
J. Nick Koston
2026-03-02 15:52:04 -10:00
parent 55fc563c69
commit ca600a45a2
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.github/scripts/auto-label-pr/detectors.js
+1 -1
View File
@@ -7,7 +7,7 @@ const {
hasDashboardChanges,
hasGitHubActionsChanges,
} = require('../detect-tags');
const { fetchCodeowners, getEffectiveOwners } = require('../codeowners');
const { fetchCodeowners } = require('../codeowners');
// Strategy: Merge branch detection
async function detectMergeBranch(context) {
.github/workflows/codeowner-approved-label.yml
+2 -2
View File
@@ -105,7 +105,7 @@ jobs:
const latestReviewByUser = new Map();
for (const review of reviews) {
// Skip bot reviews and comment-only reviews
if (!review.user || review.state === 'COMMENTED') continue;
if (!review.user || review.user.type === 'Bot' || review.state === 'COMMENTED') continue;
latestReviewByUser.set(review.user.login, review);
}
@@ -156,6 +156,6 @@ jobs:
}
} catch (error) {
console.log('Failed to process codeowner approval label:', error.message);
console.error(error);
core.setFailed(`Failed to process codeowner approval label: ${error.message}`);
}