github/esphome
2
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2026-09-03 19:46:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

[mdns] Revert defines.h USE_MDNS_EVENT_DRIVEN_POLLING / USE_MDNS_WIFI_LISTENER adds

Browse Source 
Copilot flagged that defining these unconditionally in defines.h breaks static
analysis on platforms that don't meet the derivation's platform+listener guard:
USE_MDNS_WIFI_LISTENER enables 'public wifi::WiFiIPStateListener' inheritance in
the class declaration, but wifi_component.h is only #include'd inside the
mdns_component.h derivation block. On analysis envs where the derivation guard
is false (non-ESP8266/RP2040, or missing listener feature flags), the inherit
fires without the header in scope, causing 'use of undeclared identifier' and
related errors.

Letting the derivation in mdns_component.h be the sole source of truth keeps the
define and its corresponding include atomically linked.
This commit is contained in:
J. Nick Koston
2026-04-23 20:55:22 -05:00
parent fad9210cb9
commit c74931aecb
1 changed files with 0 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
esphome/core/defines.h
-2
View File
@@ -111,8 +111,6 @@
#define MDNS_SERVICE_COUNT 3
#define USE_MDNS_DYNAMIC_TXT
#define MDNS_DYNAMIC_TXT_COUNT 2
#define USE_MDNS_EVENT_DRIVEN_POLLING
#define USE_MDNS_WIFI_LISTENER
#define MICRONOVA_LISTENER_COUNT 1
#define USE_MICRONOVA_WRITER
#define SERIAL_PROXY_COUNT 2