github/esphome
2
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2026-08-30 17:46:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

[voice_assistant] Prepend the model URL prefix in place

Browse Source 
clang-tidy's performance-inefficient-string-concatenation flags building
the absolute URL with operator+, which allocates a temporary for the
prefix and another for the result. Insert the prefix instead.
This commit is contained in:
Kevin Ahrendt
2026-08-10 08:11:47 -04:00
parent aedc5f2f28
commit b26f6e79e1
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
esphome/components/voice_assistant/voice_assistant.cpp
+2 -1
View File
@@ -1481,7 +1481,8 @@ void VoiceAssistant::model_load_task(void *params) {
if (!model_url.starts_with("http://") && !model_url.starts_with("https://")) {
size_t slash_pos = cached_ww.url.find_last_of('/');
if (slash_pos != std::string::npos) {
model_url = cached_ww.url.substr(0, slash_pos + 1) + model_url;
// Prepend in place: building the prefix separately would allocate two temporary strings.
model_url.insert(0, cached_ww.url, 0, slash_pos + 1);
}
}
ESP_LOGD(TAG, "Resolved model URL for %s: %s", id.c_str(), model_url.c_str());