github/esphome
2
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2026-09-20 11:38:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

bot concerns

Browse Source
This commit is contained in:
J. Nick Koston
2026-01-15 18:17:42 -10:00
parent 2db4e15452
commit 9bdefc98b1
1 changed files with 16 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
esphome/core/helpers.h
+16 -6
View File
@@ -143,19 +143,29 @@ template<size_t InlineSize = 8> class SmallInlineBuffer {
delete[] this->heap_;
}
// Move constructor - memcpy is safe because union is zero-initialized
// Move constructor
SmallInlineBuffer(SmallInlineBuffer &&other) noexcept : len_(other.len_) {
memcpy(this->inline_, other.inline_, InlineSize);
other.len_ = 0; // Mark as empty so other's destructor is no-op
if (other.is_inline_()) {
memcpy(this->inline_, other.inline_, this->len_);
} else {
this->heap_ = other.heap_;
other.heap_ = nullptr;
}
other.len_ = 0;
}
// Move assignment - memcpy is safe because union is zero-initialized
// Move assignment
SmallInlineBuffer &operator=(SmallInlineBuffer &&other) noexcept {
if (this != &other) {
if (!this->is_inline_())
delete[] this->heap_;
this->len_ = other.len_;
memcpy(this->inline_, other.inline_, InlineSize);
if (other.is_inline_()) {
memcpy(this->inline_, other.inline_, this->len_);
} else {
this->heap_ = other.heap_;
other.heap_ = nullptr;
}
other.len_ = 0;
}
return *this;
@@ -188,7 +198,7 @@ template<size_t InlineSize = 8> class SmallInlineBuffer {
size_t len_{0};
union {
uint8_t inline_[InlineSize]{}; // Zero-init for safe memcpy in move ops
uint8_t inline_[InlineSize]{}; // Zero-init ensures clean initial state
uint8_t *heap_;
};
};