github/esphome
2
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2026-09-18 02:28:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

[speaker] Make media player volume and mute independent (#19307)

Browse Source
This commit is contained in:
Kevin Ahrendt
2026-09-14 18:59:05 -04:00
committed by GitHub
parent 0af1f22e77
commit 8d61b35cdc
1 changed files with 5 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
esphome/components/speaker/media_player/speaker_media_player.cpp
+5 -9
View File
@@ -595,8 +595,11 @@ void SpeakerMediaPlayer::set_mute_state_(bool mute_state) {
}
void SpeakerMediaPlayer::set_volume_(float volume, bool publish) {
// Remap the volume to fit with in the configured limits
float bounded_volume = remap<float, float>(volume, 0.0f, 1.0f, this->volume_min_, this->volume_max_);
// Remap the volume to fit within the configured limits. An effectively zero volume is passed through as zero so
// the speaker silences it, otherwise volume_min would make it audible.
float bounded_volume = (volume < SILENT_VOLUME_THRESHOLD)
? 0.0f
: remap<float, float>(volume, 0.0f, 1.0f, this->volume_min_, this->volume_max_);
if (this->media_speaker_ != nullptr) {
this->media_speaker_->set_volume(bounded_volume);
@@ -611,13 +614,6 @@ void SpeakerMediaPlayer::set_volume_(float volume, bool publish) {
this->save_volume_restore_state_();
}
// Turn on the mute state if the volume is effectively zero, off otherwise
if (volume < speaker::SILENT_VOLUME_THRESHOLD) {
this->set_mute_state_(true);
} else {
this->set_mute_state_(false);
}
this->defer([this, volume]() { this->volume_trigger_.trigger(volume); });
}