github/esphome
2
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2026-08-31 01:56:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

Address review: pin the neutral arm's rejection of esp32-only keys

Browse Source 
The schema split's accept side was tested; the reject side was not - a
key leaking from the legacy arm into the neutral schema would have
passed silently.
This commit is contained in:
J. Nick Koston
2026-08-09 19:12:52 -05:00
parent 87b7076cd1
commit 830854d661
1 changed files with 11 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/component_tests/ble_client/test_validation.py
+11
View File
@@ -109,3 +109,14 @@ def test_legacy_node_choke_point_rejects_other_platforms() -> None:
# Through the public schema too, so removing the cv.All wiring fails here.
with pytest.raises(cv.Invalid, match="not been migrated"):
ble_client.BLE_CLIENT_SCHEMA({})
def test_neutral_arm_rejects_esp32_only_keys() -> None:
# Pins the schema split's rejection side: the legacy-only keys must not
# leak into the neutral arm.
from esphome.components import ble_client
CORE.data.setdefault(KEY_CORE, {})[KEY_TARGET_PLATFORM] = PLATFORM_RP2
for key in ("name", "on_passkey_request", "on_passkey_notification"):
with pytest.raises(cv.Invalid):
ble_client.CONFIG_SCHEMA({"mac_address": "AA:BB:CC:DD:EE:FF", key: "x"})