github/esphome
2
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2026-09-11 15:27:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

[core] Convert a null StringRef to an empty JSON string and pin null against null

Browse Source
This commit is contained in:
J. Nick Koston
2026-09-08 03:44:24 +02:00
parent a7bf937001
commit 82d399400e
2 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
esphome/core/string_ref.h
+1 -1
View File
@@ -263,7 +263,7 @@ inline double stod(const StringRef &str, size_t *pos = nullptr) {
#ifdef USE_JSON
// NOLINTNEXTLINE(readability-identifier-naming)
inline void convertToJson(const StringRef &src, JsonVariant dst) { dst.set(src.c_str()); }
inline void convertToJson(const StringRef &src, JsonVariant dst) { dst.set(src.empty() ? "" : src.c_str()); }
#endif // USE_JSON
} // namespace esphome
tests/components/core/test_string_ref.cpp
+8
View File
@@ -94,4 +94,12 @@ TEST(StringRefNullEmpty, ComparesAgainstText) {
EXPECT_TRUE(text.starts_with(null_empty));
}
TEST(StringRefNullEmpty, TwoNullViewsAreEqual) {
const StringRef a{nullptr, 0};
const StringRef b{nullptr, 0};
EXPECT_TRUE(a == b);
EXPECT_EQ(a.compare(b), 0);
EXPECT_TRUE(a.starts_with(b));
}
} // namespace esphome::core::testing