github/esphome
2
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2026-09-04 03:56:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix clang-tidy naming violations in lwip_raw_tcp_impl

Browse Source 
- Rename internal_write/internal_output to internal_write_/internal_output_
  (protected methods require trailing underscore)
- Fix getpeername/getsockname parameter name mismatch between .h and .cpp
This commit is contained in:
J. Nick Koston
2026-02-28 22:56:48 -10:00
parent 39bbdbbfce
commit 7e119b1cbd
2 changed files with 10 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
esphome/components/socket/lwip_raw_tcp_impl.cpp
+6 -6
View File
@@ -441,7 +441,7 @@ ssize_t LWIPRawImpl::readv(const struct iovec *iov, int iovcnt) {
return ret;
}
ssize_t LWIPRawImpl::internal_write(const void *buf, size_t len) {
ssize_t LWIPRawImpl::internal_write_(const void *buf, size_t len) {
if (this->pcb_ == nullptr) {
errno = ECONNRESET;
return -1;
@@ -473,7 +473,7 @@ ssize_t LWIPRawImpl::internal_write(const void *buf, size_t len) {
return to_send;
}
int LWIPRawImpl::internal_output() {
int LWIPRawImpl::internal_output_() {
LWIP_LOG("tcp_output(%p)", this->pcb_);
err_t err = tcp_output(this->pcb_);
if (err == ERR_ABRT) {
@@ -489,7 +489,7 @@ int LWIPRawImpl::internal_output() {
}
ssize_t LWIPRawImpl::write(const void *buf, size_t len) {
ssize_t written = this->internal_write(buf, len);
ssize_t written = this->internal_write_(buf, len);
if (written == -1)
return -1;
if (written == 0) {
@@ -497,7 +497,7 @@ ssize_t LWIPRawImpl::write(const void *buf, size_t len) {
return 0;
}
if (this->nodelay_) {
int err = this->internal_output();
int err = this->internal_output_();
if (err == -1)
return -1;
}
@@ -507,7 +507,7 @@ ssize_t LWIPRawImpl::write(const void *buf, size_t len) {
ssize_t LWIPRawImpl::writev(const struct iovec *iov, int iovcnt) {
ssize_t written = 0;
for (int i = 0; i < iovcnt; i++) {
ssize_t err = this->internal_write(reinterpret_cast<uint8_t *>(iov[i].iov_base), iov[i].iov_len);
ssize_t err = this->internal_write_(reinterpret_cast<uint8_t *>(iov[i].iov_base), iov[i].iov_len);
if (err == -1) {
if (written != 0) {
// if we already read some don't return an error
@@ -524,7 +524,7 @@ ssize_t LWIPRawImpl::writev(const struct iovec *iov, int iovcnt) {
return 0;
}
if (this->nodelay_) {
int err = this->internal_output();
int err = this->internal_output_();
if (err == -1)
return -1;
}
esphome/components/socket/lwip_raw_tcp_impl.h
+4 -4
View File
@@ -35,8 +35,8 @@ class LWIPRawCommon {
int close();
int shutdown(int how);
int getpeername(struct sockaddr *addr, socklen_t *addrlen);
int getsockname(struct sockaddr *addr, socklen_t *addrlen);
int getpeername(struct sockaddr *name, socklen_t *addrlen);
int getsockname(struct sockaddr *name, socklen_t *addrlen);
/// Format peer address into a fixed-size buffer (no heap allocation)
size_t getpeername_to(std::span<char, SOCKADDR_STR_LEN> buf);
@@ -112,8 +112,8 @@ class LWIPRawImpl : public LWIPRawCommon {
static err_t s_recv_fn(void *arg, struct tcp_pcb *pcb, struct pbuf *pb, err_t err);
protected:
ssize_t internal_write(const void *buf, size_t len);
int internal_output();
ssize_t internal_write_(const void *buf, size_t len);
int internal_output_();
pbuf *rx_buf_ = nullptr;
size_t rx_buf_offset_ = 0;