github/esphome
2
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2026-09-18 02:28:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

[speaker_source] Don't remap a requested volume of zero (#19063)

Browse Source 
Co-authored-by: rexmoriarty <181678468+rexmoriarty@users.noreply.github.com>
Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
Co-authored-by: Kevin Ahrendt <kevin.ahrendt@openhomefoundation.org>
This commit is contained in:
rexmoriarty
2026-09-14 18:11:25 -04:00
committed by GitHub
co-authored by rexmoriarty Claude Opus 5 Kevin Ahrendt
parent 2472838e13
commit 7a25ca0741
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
esphome/components/speaker_source/speaker_source_media_player.cpp
+5 -2
View File
@@ -809,8 +809,11 @@ void SpeakerSourceMediaPlayer::set_mute_state_(bool mute_state, bool publish) {
}
void SpeakerSourceMediaPlayer::set_volume_(float volume, bool publish) {
// Remap the volume to fit within the configured limits
float bounded_volume = remap<float, float>(volume, 0.0f, 1.0f, this->volume_min_, this->volume_max_);
// Remap the volume to fit within the configured limits. An effectively zero volume is passed through as zero so
// the speaker silences it, otherwise volume_min would make it audible.
float bounded_volume = (volume < speaker::SILENT_VOLUME_THRESHOLD)
? 0.0f
: remap<float, float>(volume, 0.0f, 1.0f, this->volume_min_, this->volume_max_);
for (auto &ps : this->pipelines_) {
if (ps.is_configured()) {