github/esphome
2
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2026-09-11 23:37:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

[logger] Use only compiled log level for verbose warning

Browse Source 
The compiled ESPHOME_LOG_LEVEL is what matters - all log calls up
to that level are in the binary and will format/block UART regardless
of runtime initial_level.
This commit is contained in:
J. Nick Koston
2026-03-26 08:30:00 -10:00
parent 8677dafae8
commit 76c93b882d
1 changed files with 7 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files
esphome/components/logger/logger.cpp
+7 -15
View File
@@ -245,23 +245,15 @@ void Logger::dump_config() {
dump_crash_();
#endif
// Warn users that VERBOSE/VERY_VERBOSE logging impacts performance.
// The compiled log level (ESPHOME_LOG_LEVEL) is what matters here — even if
// initial_level is set lower at runtime, log messages at the compiled level
// are still formatted (vsnprintf) and written to UART which is blocking.
// Only the compiled log level matters — all log calls up to this level
// are in the binary and will be formatted (vsnprintf) and block UART.
#if ESPHOME_LOG_LEVEL >= ESPHOME_LOG_LEVEL_VERY_VERBOSE
if (this->current_level_ >= ESPHOME_LOG_LEVEL_VERY_VERBOSE) {
ESP_LOGW(TAG, "VERY_VERBOSE logging is active. This will significantly impact device performance and may cause "
"connection instability. This level is intended for short-term debugging only. "
"Set the log level to DEBUG or lower for long-term use.");
} else if (this->current_level_ >= ESPHOME_LOG_LEVEL_VERBOSE) {
ESP_LOGI(TAG, "VERBOSE logging is active. This will impact device performance and is intended for short-term "
"debugging only. Set the log level to DEBUG or lower for long-term use.");
}
ESP_LOGW(TAG, "VERY_VERBOSE logging is active. This will significantly impact device performance and may cause "
"connection instability. This level is intended for short-term debugging only. "
"Set the log level to DEBUG or lower for long-term use.");
#elif ESPHOME_LOG_LEVEL >= ESPHOME_LOG_LEVEL_VERBOSE
if (this->current_level_ >= ESPHOME_LOG_LEVEL_VERBOSE) {
ESP_LOGI(TAG, "VERBOSE logging is active. This will impact device performance and is intended for short-term "
"debugging only. Set the log level to DEBUG or lower for long-term use.");
}
ESP_LOGI(TAG, "VERBOSE logging is active. This will impact device performance and is intended for short-term "
"debugging only. Set the log level to DEBUG or lower for long-term use.");
#endif
}