github/esphome
2
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2026-07-10 08:55:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

[light] Use raw byte compare for uniformity scan to keep apply() hot path inlinable

Browse Source
This commit is contained in:
J. Nick Koston
2026-04-13 14:31:42 -10:00
parent 4e8f98e767
commit 6edadaa33b
1 changed files with 12 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
esphome/components/light/addressable_light.cpp
+12 -3
View File
@@ -65,12 +65,21 @@ void AddressableLightTransformer::start() {
// at low values (e.g. gamma 2.8 pre-gamma values <27 round to stored 0, freezing progress).
this->uniform_start_color_.reset();
if (this->light_.size() > 0) {
Color first = this->light_[0].get();
// Compare raw (post-gamma) bytes across LEDs for uniformity. This avoids N calls to the
// gamma-uncorrecting get_red/green/blue/white accessors, which would otherwise discourage
// the compiler from inlining them inside the apply() fallback path.
auto first = this->light_[0];
uint8_t r_raw = first.get_red_raw();
uint8_t g_raw = first.get_green_raw();
uint8_t b_raw = first.get_blue_raw();
uint8_t w_raw = first.get_white_raw();
for (int32_t i = 1; i < this->light_.size(); i++) {
if (this->light_[i].get() != first)
auto view = this->light_[i];
if (view.get_red_raw() != r_raw || view.get_green_raw() != g_raw || view.get_blue_raw() != b_raw ||
view.get_white_raw() != w_raw)
return;
}
this->uniform_start_color_ = first;
this->uniform_start_color_ = first.get();
}
}