github/esphome
2
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2026-09-30 00:10:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

[voice_assistant] Read the enabled preference without allocating a backend

Browse Source 
make_preference allocates a backend that ESPPreferenceObject never frees, and
restore_runtime_models_ runs for every advertised model on every configuration
request Home Assistant sends. Use load_from_key for the read instead.
This commit is contained in:
Kevin Ahrendt
2026-08-10 08:11:47 -04:00
parent 2c3867dbdb
commit 68aa3b87aa
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
esphome/components/voice_assistant/voice_assistant.cpp
+5 -3
View File
@@ -1290,10 +1290,12 @@ void VoiceAssistant::restore_runtime_models_() {
continue;
}
// Only re-download models the user had enabled before the reboot.
auto pref = global_preferences->make_preference<bool>(fnv1_hash(cached_ww.id));
// Only re-download models the user had enabled before the reboot. Read the key directly: make_preference
// allocates a backend that is never freed, and this runs for every advertised model on every request.
bool enabled = false;
if (pref.load(&enabled) && enabled) {
if (global_preferences->load_from_key(fnv1_hash(cached_ww.id), reinterpret_cast<uint8_t *>(&enabled),
sizeof(enabled)) &&
enabled) {
ESP_LOGD(TAG, "Restoring runtime model %s", cached_ww.id.c_str());
this->model_download_queue_.push_back(cached_ww);
this->pending_active_wake_words_.push_back(cached_ww.id);