github/esphome
2
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2026-07-10 17:05:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

[light] Drop redundant is_standard_layout asserts (offsetof no longer used)

Browse Source 
Since validate_() now accesses unit_fields_[] directly via the union
alias, there's no offsetof arithmetic to guard. The FieldFlags bit
layout assert is all that's needed.
This commit is contained in:
J. Nick Koston
2026-04-13 16:57:58 -10:00
parent 58885c2090
commit 674fb1d3f6
1 changed files with 1 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
esphome/components/light/light_call.cpp
+1 -5
View File
@@ -1,5 +1,4 @@
#include <cinttypes>
#include <type_traits>
#include "light_call.h"
#include "light_state.h"
@@ -281,10 +280,7 @@ LightColorValues LightCall::validate_() {
if (this->has_state())
v.set_state(this->state_);
// FieldFlags bits 0-7 must match unit_fields_ array indices; the union in
// both structs guarantees brightness_..warm_white_ alias unit_fields_[0..7].
static_assert(std::is_standard_layout_v<LightCall>, "LightCall must be standard-layout");
static_assert(std::is_standard_layout_v<LightColorValues>, "LightColorValues must be standard-layout");
// FieldFlags bits 0-7 must match unit_fields_ array indices.
static_assert(FLAG_HAS_BRIGHTNESS == 1u << 0 && FLAG_HAS_COLOR_BRIGHTNESS == 1u << 1 && FLAG_HAS_RED == 1u << 2 &&
FLAG_HAS_GREEN == 1u << 3 && FLAG_HAS_BLUE == 1u << 4 && FLAG_HAS_WHITE == 1u << 5 &&
FLAG_HAS_COLD_WHITE == 1u << 6 && FLAG_HAS_WARM_WHITE == 1u << 7,