github/esphome
2
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2026-07-10 17:05:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

[core] Document mtime check's package-edit limitation as YAGNI

Browse Source
This commit is contained in:
J. Nick Koston
2026-05-12 17:58:09 -05:00
parent 0c3682124d
commit 622c0b35a7
1 changed files with 8 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
esphome/compiled_config.py
+8
View File
@@ -53,6 +53,14 @@ def load_compiled_config(conf_path: Path) -> ConfigType | None:
Returns None (caller falls back to read_config) when the cache is
missing, older than the source YAML, unparseable, or the sidecar
is incomplete.
Known limitation: the mtime check only stats the top-level YAML.
A package / !include / !secret edit that changes a CLI-side key
(e.g. wifi.use_address pinned to a manual IP) without re-touching
the main YAML or recompiling would keep the stale address in the
cache. Realistic workflows recompile when anything material
changes, so this is YAGNI -- revisit if someone actually trips
over it.
"""
cache_path = compiled_config_path(conf_path.name)
if not _cache_is_fresh(cache_path, conf_path):