Clarify pre-extraction failure messages

This commit is contained in:
J. Nick Koston
2026-08-27 19:30:29 -05:00
parent 083c35bccd
commit 5da2cca3e7
2 changed files with 9 additions and 6 deletions
+3 -5
View File
@@ -825,11 +825,9 @@ def _preinstall_idf_tool_archives(
stream_output=True,
)
if not success:
# Detail already streamed to the terminal by the script
_LOGGER.warning(
"ESP-IDF tool pre-extraction failed; the installer will "
"extract sequentially"
)
# Detail already streamed to the terminal by the script; a
# surviving torn dir prints its own guidance there
_LOGGER.warning("ESP-IDF tool pre-extraction failed; see above")
except Exception as e: # noqa: BLE001 # pylint: disable=broad-exception-caught
_LOGGER.warning("ESP-IDF tool pre-extraction failed: %s", failure_reason(e))
_LOGGER.debug("Pre-extraction failure detail", exc_info=True)
+6 -1
View File
@@ -63,7 +63,12 @@ def install_one(tool: object, name: str, version: str) -> bool | None:
except FileNotFoundError: # pragma: no cover # failed before mkdir
pass
except OSError as cleanup_err:
print(f"could not remove {dest}: {cleanup_err}", file=sys.stderr)
print(
f"could not remove {dest}: {cleanup_err}; the installer may "
"trust the partial tool dir, delete it manually if the build "
"fails",
file=sys.stderr,
)
return None
return False
return True