github/esphome
2
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2026-09-18 18:48:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

[api] Call write_raw_slow_ directly from cold paths to save flash

Browse Source 
write_frame_ (handshake) and bad indicator response are cold paths
that don't benefit from the inlined write_raw_ fast path. Calling
write_raw_slow_ directly avoids expanding the inline fast path code
at these call sites, saving ~70 bytes per site.
This commit is contained in:
J. Nick Koston
2026-03-29 11:10:56 -10:00
parent ce9bc3aaa1
commit 5a8e54301f
2 changed files with 9 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
esphome/components/api/api_frame_helper_noise.cpp
+3 -2
View File
@@ -539,16 +539,17 @@ APIError APINoiseFrameHelper::write_frame_(const uint8_t *data, uint16_t len) {
header[1] = (uint8_t) (len >> 8);
header[2] = (uint8_t) len;
// Handshake-only path — use slow path directly to avoid inlining write_raw_ fast path
struct iovec iov[2];
iov[0].iov_base = header;
iov[0].iov_len = 3;
if (len == 0) {
return this->write_raw_(iov, 1, 3); // Just header
return this->write_raw_slow_(iov, 1, 3, -1);
}
iov[1].iov_base = const_cast<uint8_t *>(data);
iov[1].iov_len = len;
return this->write_raw_(iov, 2, 3 + len); // Header + data
return this->write_raw_slow_(iov, 2, 3 + len, -1);
}
/** Initiate the data structures for the handshake.
esphome/components/api/api_frame_helper_plaintext.cpp
+6 -2
View File
@@ -219,11 +219,15 @@ APIError APIPlaintextFrameHelper::read_packet(ReadPacketBuffer *buffer) {
"Bad indicator byte";
char msg[INDICATOR_MSG_SIZE];
memcpy_P(msg, MSG_PROGMEM, INDICATOR_MSG_SIZE);
this->write_raw_(msg, INDICATOR_MSG_SIZE);
// Error path — use slow path directly to avoid inlining write_raw_ fast path
struct iovec iov = {msg, INDICATOR_MSG_SIZE};
this->write_raw_slow_(&iov, 1, INDICATOR_MSG_SIZE, -1);
#else
static const char MSG[] = "\x00"
"Bad indicator byte";
this->write_raw_(MSG, INDICATOR_MSG_SIZE);
// Error path — use slow path directly to avoid inlining write_raw_ fast path
struct iovec iov = {const_cast<char *>(MSG), INDICATOR_MSG_SIZE};
this->write_raw_slow_(&iov, 1, INDICATOR_MSG_SIZE, -1);
#endif
}
return aerr;