github/esphome
2
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2026-09-16 01:28:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

[binary_sensor] Access flags_ directly in set_new_state to reduce flash

Browse Source
This commit is contained in:
J. Nick Koston
2026-03-22 16:17:35 -10:00
parent e28c9d191c
commit 5854fa1d82
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
esphome/core/entity_base.h
+3 -3
View File
@@ -343,8 +343,8 @@ template<typename T> class StatefulEntityBase : public EntityBase {
* Returns true if the state actually changed, false if it was the same.
*/
virtual bool set_new_state(const optional<T> &new_state) {
// Compare without constructing optional — avoid unnecessary codegen
bool had_state = this->has_state();
// Access flags_ directly to avoid virtual/function call overhead in this hot path
bool had_state = this->flags_.has_state;
if (new_state.has_value()) {
if (had_state && this->get_state() == new_state.value())
return false; // same value, no change
@@ -354,7 +354,7 @@ template<typename T> class StatefulEntityBase : public EntityBase {
// State changed — capture old state, then update storage before firing callbacks
// so callback code can inspect the entity's current state via get_state()/has_state()
optional<T> old_state = had_state ? optional<T>(this->get_state()) : nullopt;
this->set_has_state(new_state.has_value());
this->flags_.has_state = new_state.has_value();
if (new_state.has_value()) {
this->set_state_value_(new_state.value());
}