github/esphome
2
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2026-09-08 05:56:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

[i2s_audio] Keep a start request that arrives while the speaker task stops (#19027)

Browse Source 
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
This commit is contained in:
mipa87
2026-09-08 12:10:55 +12:00
committed by GitHub
co-authored by Claude pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
parent 89a56298c2
commit 50ca381198
1 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
esphome/components/i2s_audio/speaker/i2s_audio_speaker.cpp
+8 -1
View File
@@ -91,7 +91,14 @@ void I2SAudioSpeakerBase::loop() {
this->speaker_task_handle_ = nullptr;
this->stop_i2s_driver_();
xEventGroupClearBits(this->event_group_, SpeakerEventGroupBits::ALL_BITS);
// ALL_BITS includes COMMAND_START. Take the bits from the clear itself, not from the snapshot at
// the top of loop(): the audio source's task can raise a start at any point above, including
// during stop_i2s_driver_(), and nothing would ever re-issue it.
const EventBits_t bits_before_clear = xEventGroupClearBits(this->event_group_, SpeakerEventGroupBits::ALL_BITS);
if (bits_before_clear & SpeakerEventGroupBits::COMMAND_START) {
ESP_LOGD(TAG, "Start requested while stopping; keeping the request");
xEventGroupSetBits(this->event_group_, SpeakerEventGroupBits::COMMAND_START);
}
this->status_clear_error();
this->on_task_stopped();