github/esphome
2
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2026-08-26 16:10:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

[core] Fix false-positive readability-non-const-parameter in string_ref.h (#18758)

Browse Source
This commit is contained in:
Frédéric Metrich
2026-08-25 10:36:00 -05:00
committed by GitHub
parent b579751bdf
commit 4eba9ee41a
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
esphome/core/string_ref.h
+4 -2
View File
@@ -239,7 +239,9 @@ template<typename R, typename F> inline R parse_number(const StringRef &str, siz
}
// NOLINTEND(google-runtime-int)
} // namespace internal
// NOLINTBEGIN(readability-identifier-naming,google-runtime-int)
// readability-non-const-parameter: `pos` is written through by internal::parse_number, one call
// frame away; the check only inspects these bodies, so it wrongly proposes `const size_t *`.
// NOLINTBEGIN(readability-identifier-naming,google-runtime-int,readability-non-const-parameter)
inline int stoi(const StringRef &str, size_t *pos = nullptr, int base = 10) {
return static_cast<int>(internal::parse_number<long>(str, pos, base, std::strtol));
}
@@ -252,7 +254,7 @@ inline float stof(const StringRef &str, size_t *pos = nullptr) {
inline double stod(const StringRef &str, size_t *pos = nullptr) {
return internal::parse_number<double>(str, pos, std::strtod);
}
// NOLINTEND(readability-identifier-naming,google-runtime-int)
// NOLINTEND(readability-identifier-naming,google-runtime-int,readability-non-const-parameter)
#ifdef USE_JSON
// NOLINTNEXTLINE(readability-identifier-naming)