github/esphome
2
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2026-09-04 03:56:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

copilot found a bug, its not new though

Browse Source
This commit is contained in:
J. Nick Koston
2026-01-16 13:26:56 -10:00
parent 7d6b95f535
commit 4d26eeaf75
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
esphome/components/tx20/tx20.cpp
+4 -2
View File
@@ -48,8 +48,10 @@ void Tx20Component::decode_and_publish_() {
std::array<bool, MAX_BUFFER_SIZE> bit_buffer{};
size_t bit_pos = 0;
bool current_bit = true;
// Cap at MAX_BUFFER_SIZE to prevent out-of-bounds access (buffer_index can exceed MAX_BUFFER_SIZE in ISR)
const int max_buffer_index = std::min(static_cast<int>(this->store_.buffer_index), static_cast<int>(MAX_BUFFER_SIZE));
for (int i = 1; i <= this->store_.buffer_index; i++) {
for (int i = 1; i <= max_buffer_index; i++) {
uint8_t repeat = this->store_.buffer[i] / TX20_BIT_TIME;
// ignore segments at the end that were too short
for (uint8_t j = 0; j < repeat && bit_pos < MAX_BUFFER_SIZE; j++) {
@@ -109,7 +111,7 @@ void Tx20Component::decode_and_publish_() {
// Build debug strings from completed data
char debug_buf[320]; // buffer values: max 42 entries * 7 chars each
size_t debug_pos = 0;
for (int i = 1; i <= this->store_.buffer_index; i++) {
for (int i = 1; i <= max_buffer_index; i++) {
debug_pos = buf_append_printf(debug_buf, sizeof(debug_buf), debug_pos, "%u, ", this->store_.buffer[i]);
}
if (bits_before_padding < MAX_BUFFER_SIZE) {