github/esphome
2
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2026-09-18 18:48:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

[core] Optimize Component::is_ready() with bitmask check

Browse Source 
Replace three separate equality comparisons with a single bitmask
shift-and-test. This compiles to fully branchless code and halves
the function size on Xtensa (38 → 19 bytes, 14 → 7 instructions).
This commit is contained in:
J. Nick Koston
2026-03-19 22:14:13 -10:00
parent 02ada93ea5
commit 453cbbe81c
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
esphome/core/component.cpp
+4 -3
View File
@@ -378,9 +378,10 @@ void Component::set_retry(uint32_t initial_wait_time, uint8_t max_attempts, std:
#pragma GCC diagnostic pop
}
bool Component::is_ready() const {
return (this->component_state_ & COMPONENT_STATE_MASK) == COMPONENT_STATE_LOOP ||
(this->component_state_ & COMPONENT_STATE_MASK) == COMPONENT_STATE_LOOP_DONE ||
(this->component_state_ & COMPONENT_STATE_MASK) == COMPONENT_STATE_SETUP;
// Bitmask check: valid states are SETUP(1), LOOP(2), LOOP_DONE(4)
// (1 << state) & 0b10110 checks membership in one instruction
return ((1u << (this->component_state_ & COMPONENT_STATE_MASK)) &
((1u << COMPONENT_STATE_SETUP) | (1u << COMPONENT_STATE_LOOP) | (1u << COMPONENT_STATE_LOOP_DONE))) != 0;
}
bool Component::can_proceed() { return true; }
bool Component::set_status_flag_(uint8_t flag) {