github/esphome
2
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2026-09-18 18:48:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

[scheduler] Remove redundant Defer_UniqueID, keep anonymous + same-ID

Browse Source 
UniqueID benchmark was unrealistic — unique IDs still ran
cancel_item_locked_ scanning all containers for matches that never
exist. Replace with just two meaningful defer variants:
- Defer: anonymous (nullptr name, skips cancel entirely)
- Defer_SameID: fixed ID (cancel-and-replace coalescing pattern)
This commit is contained in:
J. Nick Koston
2026-04-02 11:51:52 -10:00
parent ed14694e46
commit 4535b82483
1 changed files with 0 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/benchmarks/core/bench_scheduler.cpp
-27
View File
@@ -203,33 +203,6 @@ static void Scheduler_Defer_SameID(benchmark::State &state) {
}
BENCHMARK(Scheduler_Defer_SameID);
// --- Scheduler: defer with unique IDs (no cancel path) ---
static void Scheduler_Defer_UniqueID(benchmark::State &state) {
Scheduler scheduler;
Component dummy_component;
// Measures defer with unique numeric IDs — cancel_item_locked_ runs but
// never finds a match, measuring the scan overhead on an empty search.
static constexpr int kBatchSize = 3;
static_assert(kInnerIterations % kBatchSize == 0, "kInnerIterations must be divisible by kBatchSize");
warm_pool(scheduler, &dummy_component, kBatchSize, 0);
for (auto _ : state) {
uint32_t now = millis();
uint32_t id = 0;
for (int i = 0; i < kInnerIterations; i++) {
scheduler.set_timeout(&dummy_component, id++, 0, []() {});
if ((i + 1) % kBatchSize == 0) {
scheduler.call(++now);
}
}
scheduler.call(++now);
benchmark::DoNotOptimize(scheduler);
}
state.SetItemsProcessed(state.iterations() * kInnerIterations);
}
BENCHMARK(Scheduler_Defer_UniqueID);
// --- Scheduler: set_timeout with batch size exceeding pool (cliff test) ---
static void Scheduler_SetTimeout_ExceedPool(benchmark::State &state) {