github/esphome
2
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2026-09-11 15:27:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

Tighten shared_yaml marker validation to exactly one literal arg

Browse Source
This commit is contained in:
J. Nick Koston
2026-09-03 23:05:38 +02:00
parent 28ab280c7b
commit 44cea5c0ed
1 changed files with 10 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/integration/conftest.py
+10 -4
View File
@@ -310,10 +310,16 @@ def _shared_yaml_name(request: pytest.FixtureRequest) -> str | None:
marker = request.node.get_closest_marker("shared_yaml")
if marker is None:
return None
# \w+ keeps the name safe as a build dir component and discoverable by CI
# test selection (script/helpers.py)
if not marker.args or not re.fullmatch(r"\w+", str(marker.args[0])):
raise ValueError("shared_yaml marker requires a \\w+ fixture name literal")
# Exactly one \w+ positional arg: the name doubles as a build dir
# component, and CI test selection (script/helpers.py) parses the same shape
if (
len(marker.args) != 1
or marker.kwargs
or not re.fullmatch(r"\w+", str(marker.args[0]))
):
raise ValueError(
"shared_yaml marker requires exactly one \\w+ fixture name literal"
)
return marker.args[0]