Address review: only log hard errors, fix try_drain doc comments

- Move HELPER_LOG after errno check so transient WOULD_BLOCK doesn't
  spam very-verbose logs during normal backpressure
- Fix try_drain() docstring: -1 can be EWOULDBLOCK or hard error
  (caller distinguishes via errno), 0 means no progress (not would-block)
This commit is contained in:
J. Nick Koston
2026-03-16 13:01:42 -10:00
parent 1450d1e487
commit 3ac6eb0f5a
3 changed files with 10 additions and 6 deletions
+6 -4
View File
@@ -102,9 +102,10 @@ const LogString *api_error_to_logstr(APIError err) {
APIError APIFrameHelper::drain_overflow_and_handle_errors_() {
if (this->overflow_buf_.try_drain(this->socket_.get()) == -1) {
HELPER_LOG("Socket write failed with errno %d", errno);
if (this->check_socket_write_err_(errno) != APIError::WOULD_BLOCK)
if (this->check_socket_write_err_(errno) != APIError::WOULD_BLOCK) {
HELPER_LOG("Socket write failed with errno %d", errno);
return APIError::SOCKET_WRITE_FAILED;
}
}
return APIError::OK;
}
@@ -134,9 +135,10 @@ APIError APIFrameHelper::write_raw_(const struct iovec *iov, int iovcnt, uint16_
(iovcnt == 1) ? this->socket_->write(iov[0].iov_base, iov[0].iov_len) : this->socket_->writev(iov, iovcnt);
if (sent == -1) [[unlikely]] {
HELPER_LOG("Socket write failed with errno %d", errno);
if (this->check_socket_write_err_(errno) != APIError::WOULD_BLOCK)
if (this->check_socket_write_err_(errno) != APIError::WOULD_BLOCK) {
HELPER_LOG("Socket write failed with errno %d", errno);
return APIError::SOCKET_WRITE_FAILED;
}
} else if (static_cast<uint16_t>(sent) >= total_write_len) [[likely]] {
return APIError::OK;
} else {
@@ -18,7 +18,8 @@ ssize_t APIOverflowBuffer::try_drain(socket::Socket *socket) {
ssize_t sent = socket->write(front->current_data(), front->remaining());
if (sent <= 0) {
// -1 = error (caller checks errno), 0 = would block
// -1 = error (caller checks errno for EWOULDBLOCK vs hard error)
// 0 = nothing sent (treat as no progress)
return sent;
}
+2 -1
View File
@@ -52,7 +52,8 @@ class APIOverflowBuffer {
uint8_t count() const { return this->count_; }
/// Try to drain queued data to the socket.
/// Returns bytes-written >= 0 on success/partial, -1 on hard error (errno set).
/// Returns bytes-written > 0 on success/partial, 0 if all drained,
/// -1 on error (caller must check errno to distinguish EWOULDBLOCK from hard errors).
/// Frees entries as they are fully sent.
ssize_t try_drain(socket::Socket *socket);