github/esphome
2
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2026-09-01 02:26:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

[api] Restructure write_raw_ for single tail call to slow path

Browse Source
This commit is contained in:
J. Nick Koston
2026-03-29 10:47:07 -10:00
parent ea7dc663f6
commit 348d5f583a
1 changed files with 6 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
esphome/components/api/api_frame_helper.h
+6 -8
View File
@@ -193,27 +193,25 @@ class APIFrameHelper {
// Write a single contiguous buffer to the socket (inlined fast path)
inline APIError ESPHOME_ALWAYS_INLINE write_raw_(const void *data, uint16_t len) {
// Fast path: no overflow backlog and full write succeeds
ssize_t sent = -1;
if (this->overflow_buf_.empty()) [[likely]] {
ssize_t sent = this->socket_->write(data, len);
sent = this->socket_->write(data, len);
if (sent == static_cast<ssize_t>(len)) [[likely]]
return APIError::OK;
// Slow path: wrap in iovec and handle error/overflow
struct iovec iov = {const_cast<void *>(data), len};
return this->write_raw_slow_(&iov, 1, len, sent);
}
struct iovec iov = {const_cast<void *>(data), len};
return this->write_raw_slow_(&iov, 1, len, -1);
return this->write_raw_slow_(&iov, 1, len, sent);
}
// Write multiple iovec buffers to the socket (inlined fast path)
inline APIError ESPHOME_ALWAYS_INLINE write_raw_(const struct iovec *iov, int iovcnt, uint16_t total_write_len) {
// Fast path: no overflow backlog and full writev succeeds
ssize_t sent = -1;
if (this->overflow_buf_.empty()) [[likely]] {
ssize_t sent = this->socket_->writev(iov, iovcnt);
sent = this->socket_->writev(iov, iovcnt);
if (sent == static_cast<ssize_t>(total_write_len)) [[likely]]
return APIError::OK;
return this->write_raw_slow_(iov, iovcnt, total_write_len, sent);
}
return this->write_raw_slow_(iov, iovcnt, total_write_len, -1);
return this->write_raw_slow_(iov, iovcnt, total_write_len, sent);
}
// Slow path (out-of-line): handle partial writes, errors, overflow buffering
APIError write_raw_slow_(const struct iovec *iov, int iovcnt, uint16_t total_write_len, ssize_t sent);