github/esphome
2
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2026-08-27 00:18:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

Address review: an empty service table with nodes logs a warning

Browse Source 
A service-less device or a failed materialization both leave the nodes
unable to resolve; the client no longer sits inert without a trace.
This commit is contained in:
J. Nick Koston
2026-08-09 14:20:31 -05:00
parent c98dd74e11
commit 1d0a87daa8
1 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
esphome/components/ble_client/ble_client_gatt.cpp
+5
View File
@@ -159,6 +159,11 @@ void BLEClient::on_service_discovery_done(int error) {
// Materialize only when a node will read it: a client with no nodes
// would pay the build/free cycle on every (re)connect for nothing.
auto table = this->backend_->get_service_table();
if (table.service_count == 0) {
// A service-less device or a failed materialization: either way the
// nodes cannot resolve, so say so instead of sitting inert.
ESP_LOGW(TAG, "[%s] Service table is empty; nodes will not resolve", this->address_str_);
}
for (auto *node : this->nodes_) {
node->on_connected(table);
if (this->state_ != State::CONNECTED) {