github/esphome
2
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2026-09-15 17:18:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove redundant body_start variable in inline encode

Browse Source
This commit is contained in:
J. Nick Koston
2026-04-08 23:25:12 -10:00
parent 14a4a2c618
commit 1ac2a73267
2 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
esphome/components/api/api_pb2.cpp
+1 -2
View File
@@ -2334,7 +2334,6 @@ uint8_t *BluetoothLERawAdvertisementsResponse::encode(ProtoWriteBuffer &buffer P
auto &sub_msg = this->advertisements[i];
ProtoEncode::write_raw_byte(pos PROTO_ENCODE_DEBUG_ARG, 10);
uint8_t *len_pos = pos++;
uint8_t *body_start = pos;
ProtoEncode::write_raw_byte(pos PROTO_ENCODE_DEBUG_ARG, 8);
ProtoEncode::encode_varint_raw_64(pos PROTO_ENCODE_DEBUG_ARG, sub_msg.address);
ProtoEncode::write_raw_byte(pos PROTO_ENCODE_DEBUG_ARG, 16);
@@ -2346,7 +2345,7 @@ uint8_t *BluetoothLERawAdvertisementsResponse::encode(ProtoWriteBuffer &buffer P
ProtoEncode::write_raw_byte(pos PROTO_ENCODE_DEBUG_ARG, 34);
ProtoEncode::write_raw_byte(pos PROTO_ENCODE_DEBUG_ARG, static_cast<uint8_t>(sub_msg.data_len));
ProtoEncode::encode_raw(pos PROTO_ENCODE_DEBUG_ARG, sub_msg.data, sub_msg.data_len);
*len_pos = static_cast<uint8_t>(pos - body_start);
*len_pos = static_cast<uint8_t>(pos - len_pos - 1);
}
return pos;
}
script/api_protobuf/api_protobuf.py
+1 -2
View File
@@ -1596,7 +1596,6 @@ def _generate_inline_encode_block(
lines.append(f"auto &sub_msg = {element};")
lines.append(f"ProtoEncode::write_raw_byte(pos, {tag});")
lines.append("uint8_t *len_pos = pos++;")
lines.append("uint8_t *body_start = pos;")
# Generate inline field encoding for each sub-message field
for field in sub_desc.field:
@@ -1608,7 +1607,7 @@ def _generate_inline_encode_block(
encode_line = encode_line.replace("this->", "sub_msg.")
lines.extend(encode_line.split("\n"))
lines.append("*len_pos = static_cast<uint8_t>(pos - body_start);")
lines.append("*len_pos = static_cast<uint8_t>(pos - len_pos - 1);")
return "\n".join(lines)