github/esphome
2
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2026-09-13 00:07:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

close dangling pointer risk

Browse Source
This commit is contained in:
J. Nick Koston
2026-04-29 12:52:29 -05:00
parent e55b7b54cb
commit 185fa7e302
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
esphome/components/ota/ota_backend_esp_idf.cpp
+5 -2
View File
@@ -372,9 +372,12 @@ OTAResponseTypes IDFOTABackend::update_partition_table() {
ESP_LOGE(TAG, "esp_ota_end failed (err=0x%X) ", err);
return OTA_RESPONSE_ERROR_PARTITION_TABLE_UPDATE;
}
esp_partition_deregister_external(this->partition_table_part_);
this->partition_table_part_ = nullptr;
// esp_partition_unload_all() invalidates every cached partition entry, including the externally
// registered `partition_table_part_`, so the explicit deregister call is redundant. Do the
// unload first, then null the member pointer so it never dangles past invalidation; if abort()
// were ever to observe an in-between state, it would see a non-null but freed pointer and crash.
esp_partition_unload_all();
this->partition_table_part_ = nullptr;
// Write otadata to set the new boot partition
const esp_partition_info_t *new_part =